René's URL Explorer Experiment


Title: wasi: accept wasm i32 pointers with high bit set by guybedford · Pull Request #66636 · nodejs/node · GitHub

Open Graph Title: wasi: accept wasm i32 pointers with high bit set by guybedford · Pull Request #66636 · nodejs/node

X Title: wasi: accept wasm i32 pointers with high bit set by guybedford · Pull Request #66636 · nodejs/node

Description: Fixes: #62671 Refs: #62822 Wasm i32 arguments with the high bit set are passed to JS as negative Int32 numbers, so all WASI functions taking uint32_t pointers rejected them with EINVAL. This was hit by Rspack with WASI modules using >2GB of linear memory. This takes the general approach suggested in #62822: CheckType now accepts either Uint32 or Int32, and ConvertType reinterprets a negative Int32 as uint32_t, so every WASI function is fixed rather than just clock_time_get. The fast API path already received raw uint32_t and was unaffected. The test calls clock_time_get and args_sizes_get with pointer 0x80000000 against a 1-page memory and asserts EOVERFLOW rather than EINVAL, so no large memory allocation is needed.

Open Graph Description: Fixes: #62671 Refs: #62822 Wasm i32 arguments with the high bit set are passed to JS as negative Int32 numbers, so all WASI functions taking uint32_t pointers rejected them with EINVAL. This was hi...

X Description: Fixes: #62671 Refs: #62822 Wasm i32 arguments with the high bit set are passed to JS as negative Int32 numbers, so all WASI functions taking uint32_t pointers rejected them with EINVAL. This was hi...

Opengraph URL: https://github.com/nodejs/node/pull/66636

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.112.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1f826898-9c40-7bdf-1acc-e5134e3149c1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC246:19B3CF:18E049:1F9200:6B033B4A
html-safe-nonceb099fb3b8f5e03f230be141ac599237819dacffa88631655f543e3e5503b199d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjQ2OjE5QjNDRjoxOEUwNDk6MUY5MjAwOjZCMDMzQjRBIiwidmlzaXRvcl9pZCI6Ijg3NTY4MjA4ODI0MzA4MzU1MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd39c41db091d34de1e5a63bfb6a09188f38ffe79b978e76e3db56da3b7b21df7
hovercard-subject-tagpull_request:4808798645
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/66636/files
twitter:imagehttps://avatars.githubusercontent.com/u/598730?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/598730?s=400&v=4
og:image:altFixes: #62671 Refs: #62822 Wasm i32 arguments with the high bit set are passed to JS as negative Int32 numbers, so all WASI functions taking uint32_t pointers rejected them with EINVAL. This was hi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66636/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66636%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66636%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66636/files
Reloadhttps://github.com/nodejs/node/pull/66636/files
Reloadhttps://github.com/nodejs/node/pull/66636/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
guybedford:wasi-int32-ptrhttps://github.com/guybedford/node/tree/wasi-int32-ptr
Conversation 4 https://github.com/nodejs/node/pull/66636
Commits 1 https://github.com/nodejs/node/pull/66636/commits
Checks 53 https://github.com/nodejs/node/pull/66636/checks
Files changed https://github.com/nodejs/node/pull/66636/files
Please reload this pagehttps://github.com/nodejs/node/pull/66636/files
wasi: accept wasm i32 pointers with high bit set https://github.com/nodejs/node/pull/66636/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/66636/files
64a715b wasi: accept wasm i32 pointers with high bit set guybedford Oct 10, 2026 https://github.com/nodejs/node/pull/66636/commits/64a715bd469b65112205567b71fa8603f38533fb
Clear filters https://github.com/nodejs/node/pull/66636/files
Please reload this pagehttps://github.com/nodejs/node/pull/66636/files
Please reload this pagehttps://github.com/nodejs/node/pull/66636/files
node_wasi.cc https://github.com/nodejs/node/pull/66636/files#diff-a3e5de85d02189b913d8c51d1b92c2091bf35debe9b25b04af9e2bf313fce2cb
wasi-high-bit-ptr.wasm https://github.com/nodejs/node/pull/66636/files#diff-fa2a18ef03d48987db198d132f6f3a8fb571be9319c2a098e911c14846b4d7ed
wasi-high-bit-ptr.wat https://github.com/nodejs/node/pull/66636/files#diff-6427167c6efd9336c030e89f87c2d4da7522f103ed969ee02f52da47bc166669
test-wasi-high-bit-ptr.js https://github.com/nodejs/node/pull/66636/files#diff-0704fa1043c9b921db8324a6f256b2416bb8742ec1616d6e2744a141c531a528
src/node_wasi.cchttps://github.com/nodejs/node/pull/66636/files#diff-a3e5de85d02189b913d8c51d1b92c2091bf35debe9b25b04af9e2bf313fce2cb
View file https://github.com/guybedford/node/blob/64a715bd469b65112205567b71fa8603f38533fb/src/node_wasi.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66636/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66636/files#diff-a3e5de85d02189b913d8c51d1b92c2091bf35debe9b25b04af9e2bf313fce2cb
https://github.com/nodejs/node/pull/66636/files#diff-a3e5de85d02189b913d8c51d1b92c2091bf35debe9b25b04af9e2bf313fce2cb
https://github.com/nodejs/node/pull/66636/files#diff-a3e5de85d02189b913d8c51d1b92c2091bf35debe9b25b04af9e2bf313fce2cb
https://github.com/nodejs/node/pull/66636/files#diff-a3e5de85d02189b913d8c51d1b92c2091bf35debe9b25b04af9e2bf313fce2cb
test/fixtures/wasi-high-bit-ptr.wasmhttps://github.com/nodejs/node/pull/66636/files#diff-fa2a18ef03d48987db198d132f6f3a8fb571be9319c2a098e911c14846b4d7ed
View file https://github.com/guybedford/node/blob/64a715bd469b65112205567b71fa8603f38533fb/test/fixtures/wasi-high-bit-ptr.wasm
Open in desktop https://desktop.github.com
test/fixtures/wasi-high-bit-ptr.wathttps://github.com/nodejs/node/pull/66636/files#diff-6427167c6efd9336c030e89f87c2d4da7522f103ed969ee02f52da47bc166669
View file https://github.com/guybedford/node/blob/64a715bd469b65112205567b71fa8603f38533fb/test/fixtures/wasi-high-bit-ptr.wat
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66636/{{ revealButtonHref }}
test/wasi/test-wasi-high-bit-ptr.jshttps://github.com/nodejs/node/pull/66636/files#diff-0704fa1043c9b921db8324a6f256b2416bb8742ec1616d6e2744a141c531a528
View file https://github.com/guybedford/node/blob/64a715bd469b65112205567b71fa8603f38533fb/test/wasi/test-wasi-high-bit-ptr.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66636/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/66636/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.