René's URL Explorer Experiment


Title: fs: fix mkdtempDisposable with Buffer paths by gengjiawen · Pull Request #66594 · nodejs/node · GitHub

Open Graph Title: fs: fix mkdtempDisposable with Buffer paths by gengjiawen · Pull Request #66594 · nodejs/node

X Title: fs: fix mkdtempDisposable with Buffer paths by gengjiawen · Pull Request #66594 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: fs.mkdtempDisposableSync() and fsPromises.mkdtempDisposable() resolve the path of the new directory with path.resolve(), so that remove() still works after process.chdir(). path.resolve() only acce...

X Description: fs.mkdtempDisposableSync() and fsPromises.mkdtempDisposable() resolve the path of the new directory with path.resolve(), so that remove() still works after process.chdir(). path.resolve() only acce...

Opengraph URL: https://github.com/nodejs/node/pull/66594

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dcd3305b-7f74-6476-0a06-e98b83ca7c4b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id969A:1085A1:1AF9A0:22E282:6AED160F
html-safe-nonce4e9a6688f7fa3a1f0b90064aead2d2ee11c1443eb1c10479aa959d9059acde24
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjlBOjEwODVBMToxQUY5QTA6MjJFMjgyOjZBRUQxNjBGIiwidmlzaXRvcl9pZCI6IjIwOTk2Njk3NTQ1NzI1MTA3MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0b445394489bb129e8d00e9ffadec3da8d6c2f6b5777301631e0e381f867103c
hovercard-subject-tagpull_request:4783035422
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66594/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8174c8873710b7c438aa5e1f1b8476b77f2ac3705335c33ce7ec0c09cda397a0/nodejs/node/pull/66594
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8174c8873710b7c438aa5e1f1b8476b77f2ac3705335c33ce7ec0c09cda397a0/nodejs/node/pull/66594
og:image:altfs.mkdtempDisposableSync() and fsPromises.mkdtempDisposable() resolve the path of the new directory with path.resolve(), so that remove() still works after process.chdir(). path.resolve() only acce...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegengjiawen
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66594#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66594
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66594
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66594
Reloadhttps://github.com/nodejs/node/pull/66594
Reloadhttps://github.com/nodejs/node/pull/66594
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
gengjiawenhttps://github.com/gengjiawen
nodejs:mainhttps://github.com/nodejs/node/tree/main
gengjiawen:fs-mkdtemp-disposable-bufferhttps://github.com/gengjiawen/node/tree/fs-mkdtemp-disposable-buffer
Conversationhttps://github.com/nodejs/node/pull/66594
Commits1 (1)https://github.com/nodejs/node/pull/66594/commits
Checkshttps://github.com/nodejs/node/pull/66594/checks
Files changedhttps://github.com/nodejs/node/pull/66594/files
fs: fix mkdtempDisposable with Buffer pathshttps://github.com/nodejs/node/pull/66594#top
gengjiawenhttps://github.com/gengjiawen
nodejs:mainhttps://github.com/nodejs/node/tree/main
gengjiawen:fs-mkdtemp-disposable-bufferhttps://github.com/gengjiawen/node/tree/fs-mkdtemp-disposable-buffer
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Oct 8, 2026https://github.com/nodejs/node/pull/66594#issue-5757362905
#66593https://github.com/nodejs/node/issues/66593
#64397https://github.com/nodejs/node/pull/64397
Please reload this pagehttps://github.com/nodejs/node/pull/66594
https://github.com/gengjiawen
fs: fix mkdtempDisposable with Buffer pathshttps://github.com/nodejs/node/pull/66594/commits/f88356bf0aa9faadfdad7fd7baa6f7627743efe0
f88356bhttps://github.com/nodejs/node/pull/66594/commits/f88356bf0aa9faadfdad7fd7baa6f7627743efe0
nodejs#66593https://github.com/nodejs/node/issues/66593
nodejs#64397https://github.com/nodejs/node/pull/64397
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 8, 2026https://github.com/nodejs/node/pull/66594#event-32757409853
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 8, 2026https://github.com/nodejs/node/pull/66594#issuecomment-6056007499
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66594?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
6d5e309https://app.codecov.io/gh/nodejs/node/commit/6d5e30987117e072bb4638c0535946464a314b7e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
f88356bhttps://app.codecov.io/gh/nodejs/node/commit/f88356bf0aa9faadfdad7fd7baa6f7627743efe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66594?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/fs.jshttps://app.codecov.io/gh/nodejs/node/pull/66594?src=pr&el=tree&filepath=lib%2Ffs.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ZzLmpz
lib/internal/fs/promises.jshttps://app.codecov.io/gh/nodejs/node/pull/66594?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fpromises.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3Byb21pc2VzLmpz
lib/internal/fs/utils.jshttps://app.codecov.io/gh/nodejs/node/pull/66594?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Futils.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3V0aWxzLmpz
27 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66594/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66594
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
jasnellhttps://github.com/jasnell
panvahttps://github.com/panva
October 13, 2026 07:33https://github.com/nodejs/node/pull/66594#event-33111236469
https://github.com/panva
panvahttps://github.com/panva
October 13, 2026 07:36https://github.com/nodejs/node/pull/66594#event-33111435888
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
LiviaMedeiroshttps://github.com/LiviaMedeiros
Renegade334https://github.com/Renegade334
aduh95https://github.com/aduh95
anonrighttps://github.com/anonrig
lpincahttps://github.com/lpinca
mcollinahttps://github.com/mcollina
trivikrhttps://github.com/trivikr
October 15, 2026 12:27https://github.com/nodejs/node/pull/66594#event-33331955210
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66594
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/Renegade334
Renegade334 https://github.com/Renegade334
https://github.com/LiviaMedeiros
LiviaMedeiros https://github.com/LiviaMedeiros
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/trivikr
trivikr https://github.com/trivikr
Please reload this pagehttps://github.com/nodejs/node/pull/66594
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
fs.mkdtempDisposableSync() / fsPromises.mkdtempDisposable() throw and leak the directory when the path is a Buffer https://github.com/nodejs/node/issues/66593
Please reload this pagehttps://github.com/nodejs/node/pull/66594
https://github.com/gengjiawen
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.