René's URL Explorer Experiment


Title: buffer: validate end argument of indexOf methods by gengjiawen · Pull Request #66590 · nodejs/node · GitHub

Open Graph Title: buffer: validate end argument of indexOf methods by gengjiawen · Pull Request #66590 · nodejs/node

X Title: buffer: validate end argument of indexOf methods by gengjiawen · Pull Request #66590 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Buffer.prototype.indexOf(), lastIndexOf() and includes() pass any end that is neither a string nor undefined straight to the binding, which CHECKs that it is a number, so buf.indexOf('a', 0...

X Description: Buffer.prototype.indexOf(), lastIndexOf() and includes() pass any end that is neither a string nor undefined straight to the binding, which CHECKs that it is a number, so buf.indexOf('a&...

Opengraph URL: https://github.com/nodejs/node/pull/66590

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f45646b9-7756-0eca-00fe-8c47e558f1fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC504:204D3A:6F5546:96FBA2:6AED2A01
html-safe-nonce265397a65750963a3e842700c36f4a7d578daf27171839f2b98e2be72061e6bc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTA0OjIwNEQzQTo2RjU1NDY6OTZGQkEyOjZBRUQyQTAxIiwidmlzaXRvcl9pZCI6Ijc4NDM0NTQzNDg0NDI4MDY3ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb0df41a47faecb826e88a0ed71a505cd483cf4e4f6c669d4a1a981b682e44350
hovercard-subject-tagpull_request:4782825016
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66590/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b7e8c45bb0af58023456f8ba04198ef59bde157a03dc0f0ae72ebb59f2698a9f/nodejs/node/pull/66590
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b7e8c45bb0af58023456f8ba04198ef59bde157a03dc0f0ae72ebb59f2698a9f/nodejs/node/pull/66590
og:image:altBuffer.prototype.indexOf(), lastIndexOf() and includes() pass any end that is neither a string nor undefined straight to the binding, which CHECKs that it is a number, so buf.indexOf('a', 0...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegengjiawen
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66590#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66590
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66590
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66590
Reloadhttps://github.com/nodejs/node/pull/66590
Reloadhttps://github.com/nodejs/node/pull/66590
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
gengjiawenhttps://github.com/gengjiawen
nodejs:mainhttps://github.com/nodejs/node/tree/main
gengjiawen:buffer-indexof-validate-endhttps://github.com/gengjiawen/node/tree/buffer-indexof-validate-end
Conversationhttps://github.com/nodejs/node/pull/66590
Commits1 (1)https://github.com/nodejs/node/pull/66590/commits
Checkshttps://github.com/nodejs/node/pull/66590/checks
Files changedhttps://github.com/nodejs/node/pull/66590/files
buffer: validate end argument of indexOf methodshttps://github.com/nodejs/node/pull/66590#top
gengjiawenhttps://github.com/gengjiawen
nodejs:mainhttps://github.com/nodejs/node/tree/main
gengjiawen:buffer-indexof-validate-endhttps://github.com/gengjiawen/node/tree/buffer-indexof-validate-end
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Oct 8, 2026https://github.com/nodejs/node/pull/66590#issue-5757116113
#66589https://github.com/nodejs/node/issues/66589
#62390https://github.com/nodejs/node/pull/62390
Please reload this pagehttps://github.com/nodejs/node/pull/66590
https://github.com/gengjiawen
buffer: validate end argument of indexOf methodshttps://github.com/nodejs/node/pull/66590/commits/8a5c8ae34cb9780bda9c7a21613c005a3ee4c44b
8a5c8aehttps://github.com/nodejs/node/pull/66590/commits/8a5c8ae34cb9780bda9c7a21613c005a3ee4c44b
nodejs#66589https://github.com/nodejs/node/issues/66589
nodejs#62390https://github.com/nodejs/node/pull/62390
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 8, 2026https://github.com/nodejs/node/pull/66590#event-32755977437
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 8, 2026https://github.com/nodejs/node/pull/66590#issuecomment-6055690436
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66590?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
c3189d4https://app.codecov.io/gh/nodejs/node/commit/c3189d436e14202a764d59aa35526ef9c44d9f6b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
8a5c8aehttps://app.codecov.io/gh/nodejs/node/commit/8a5c8ae34cb9780bda9c7a21613c005a3ee4c44b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66590?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/buffer.jshttps://app.codecov.io/gh/nodejs/node/pull/66590?src=pr&el=tree&filepath=lib%2Fbuffer.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2J1ZmZlci5qcw==
28 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66590/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66590
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
jasnellhttps://github.com/jasnell
panvahttps://github.com/panva
ronaghttps://github.com/ronag
October 13, 2026 01:53https://github.com/nodejs/node/pull/66590#event-33094406428
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
addaleaxhttps://github.com/addaleax
aduh95https://github.com/aduh95
anonrighttps://github.com/anonrig
mcollinahttps://github.com/mcollina
October 22, 2026 03:25https://github.com/nodejs/node/pull/66590#event-33910958167
https://github.com/vedchaudhari
vedchaudharihttps://github.com/vedchaudhari
Oct 26, 2026 https://github.com/nodejs/node/pull/66590#ref-pullrequest-6033421047
buffer: stop clamping indexOf byteOffset to int32 #67009 https://github.com/nodejs/node/pull/67009
https://github.com/vedchaudhari
vedchaudharihttps://github.com/vedchaudhari
Nov 2, 2026 https://github.com/nodejs/node/pull/66590#ref-pullrequest-6055896051
buffer: prevent assertion crash in indexOf when encoding is non-numeric #67050 https://github.com/nodejs/node/pull/67050
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66590
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/panva
panva https://github.com/panva
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/addaleax
addaleax https://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/66590
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Buffer#indexOf()/lastIndexOf()/includes() abort the process when end is not a number https://github.com/nodejs/node/issues/66589
Please reload this pagehttps://github.com/nodejs/node/pull/66590
https://github.com/gengjiawen
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.