René's URL Explorer Experiment


Title: lib: set exit code on failed node:bench run() by RafaelGSS · Pull Request #66534 · nodejs/node · GitHub

Open Graph Title: lib: set exit code on failed node:bench run() by RafaelGSS · Pull Request #66534 · nodejs/node

X Title: lib: set exit code on failed node:bench run() by RafaelGSS · Pull Request #66534 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: I noticed the run() was exiting with exitCode 0 even when the benchmark fn fails

X Description: I noticed the run() was exiting with exitCode 0 even when the benchmark fn fails

Opengraph URL: https://github.com/nodejs/node/pull/66534

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:432c021f-5f02-afe1-f324-065f770bc09b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F7E:3E0336:26EB70:32A90F:6AED19C4
html-safe-noncee912134f4f8eda49026b70e28b043005771f221c8720ea11fb6a2fd1d7bec50f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjdFOjNFMDMzNjoyNkVCNzA6MzJBOTBGOjZBRUQxOUM0IiwidmlzaXRvcl9pZCI6IjUwNjY2NzAyNjY4NzE3ODE4MjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacaf0ad2ea41ac11f1d7b974eccbfba22e4f42eb844a6e33670da6c884b0363d4d
hovercard-subject-tagpull_request:4746570016
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66534/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6d9201db50bbb0428bf7b9ba8be9cb6911227b3176cc2abea202a4df2844c21f/nodejs/node/pull/66534
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6d9201db50bbb0428bf7b9ba8be9cb6911227b3176cc2abea202a4df2844c21f/nodejs/node/pull/66534
og:image:altI noticed the run() was exiting with exitCode 0 even when the benchmark fn fails
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRafaelGSS
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66534#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66534
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66534
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66534
Reloadhttps://github.com/nodejs/node/pull/66534
Reloadhttps://github.com/nodejs/node/pull/66534
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
RafaelGSShttps://github.com/RafaelGSS
nodejs:mainhttps://github.com/nodejs/node/tree/main
RafaelGSS:set-exit-code-on-failed-node-bench-runhttps://github.com/RafaelGSS/node/tree/set-exit-code-on-failed-node-bench-run
Conversationhttps://github.com/nodejs/node/pull/66534
Commits1 (1)https://github.com/nodejs/node/pull/66534/commits
Checkshttps://github.com/nodejs/node/pull/66534/checks
Files changedhttps://github.com/nodejs/node/pull/66534/files
lib: set exit code on failed node:bench run()https://github.com/nodejs/node/pull/66534#top
RafaelGSShttps://github.com/RafaelGSS
nodejs:mainhttps://github.com/nodejs/node/tree/main
RafaelGSS:set-exit-code-on-failed-node-bench-runhttps://github.com/RafaelGSS/node/tree/set-exit-code-on-failed-node-bench-run
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 5, 2026https://github.com/nodejs/node/pull/66534#issue-5713950412
Please reload this pagehttps://github.com/nodejs/node/pull/66534
Please reload this pagehttps://github.com/nodejs/node/pull/66534
https://github.com/RafaelGSS
lib: set exit code on failed node:bench run()https://github.com/nodejs/node/pull/66534/commits/640147224f7eebdfaee634770380be29d3742b4a
6401472https://github.com/nodejs/node/pull/66534/commits/640147224f7eebdfaee634770380be29d3742b4a
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
jasnellhttps://github.com/jasnell
October 5, 2026 14:38https://github.com/nodejs/node/pull/66534#event-32518051961
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
October 5, 2026 14:38https://github.com/nodejs/node/pull/66534#event-32518053272
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 5, 2026https://github.com/nodejs/node/pull/66534#event-32518119448
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 5, 2026 https://github.com/nodejs/node/pull/66534#pullrequestreview-5416297845
View reviewed changes https://github.com/nodejs/node/pull/66534/files/640147224f7eebdfaee634770380be29d3742b4a
https://github.com/atlowChemi
atlowChemihttps://github.com/atlowChemi
Oct 5, 2026 https://github.com/nodejs/node/pull/66534#pullrequestreview-5416451799
View reviewed changes https://github.com/nodejs/node/pull/66534/files/640147224f7eebdfaee634770380be29d3742b4a
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 5, 2026https://github.com/nodejs/node/pull/66534#issuecomment-5998930356
Please reload this pagehttps://github.com/nodejs/node/pull/66534
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66534?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
773bdd1https://app.codecov.io/gh/nodejs/node/commit/773bdd175d0bd10e339dc7099e5bd32056d7408b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
6401472https://app.codecov.io/gh/nodejs/node/commit/640147224f7eebdfaee634770380be29d3742b4a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66534?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/bench_runner/harness.jshttps://app.codecov.io/gh/nodejs/node/pull/66534?src=pr&el=tree&filepath=lib%2Finternal%2Fbench_runner%2Fharness.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2JlbmNoX3J1bm5lci9oYXJuZXNzLmpz
49 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66534/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66534
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 5, 2026https://github.com/nodejs/node/pull/66534#event-32541661719
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 5, 2026https://github.com/nodejs/node/pull/66534#event-32546596805
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 5, 2026https://github.com/nodejs/node/pull/66534#issuecomment-6003443717
https://ci.nodejs.org/job/node-test-pull-request/78190/https://ci.nodejs.org/job/node-test-pull-request/78190/
Please reload this pagehttps://github.com/nodejs/node/pull/66534
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 6, 2026https://github.com/nodejs/node/pull/66534#issuecomment-6010126001
https://ci.nodejs.org/job/node-test-pull-request/78198/https://ci.nodejs.org/job/node-test-pull-request/78198/
Please reload this pagehttps://github.com/nodejs/node/pull/66534
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 6, 2026https://github.com/nodejs/node/pull/66534#event-32586538797
https://github.com/bengl
benglhttps://github.com/bengl
Oct 6, 2026 https://github.com/nodejs/node/pull/66534#pullrequestreview-5430407116
View reviewed changes https://github.com/nodejs/node/pull/66534/files/640147224f7eebdfaee634770380be29d3742b4a
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Oct 6, 2026 https://github.com/nodejs/node/pull/66534#pullrequestreview-5433933914
View reviewed changes https://github.com/nodejs/node/pull/66534/files/640147224f7eebdfaee634770380be29d3742b4a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 7, 2026https://github.com/nodejs/node/pull/66534#event-32699659777
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 7, 2026https://github.com/nodejs/node/pull/66534#issuecomment-6040389162
commit-queue-failedhttps://github.com/nodejs/node/labels/commit-queue-failed
commit-queuehttps://github.com/nodejs/node/labels/commit-queue
View workflow runhttps://github.com/nodejs/node/actions/runs/37638693643
Please reload this pagehttps://github.com/nodejs/node/pull/66534
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 7, 2026https://github.com/nodejs/node/pull/66534#issuecomment-6044433774
cd18965https://github.com/nodejs/node/commit/cd18965041118eeac069a4f886385ad6c4956c5f
Please reload this pagehttps://github.com/nodejs/node/pull/66534
RafaelGSShttps://github.com/RafaelGSS
Oct 7, 2026 https://github.com/nodejs/node/pull/66534#ref-commit-cd18965
https://github.com/RafaelGSS
lib: set exit code on failed node:bench run()https://github.com/nodejs/node/commit/cd18965041118eeac069a4f886385ad6c4956c5f
cd18965https://github.com/nodejs/node/commit/cd18965041118eeac069a4f886385ad6c4956c5f
#66534https://github.com/nodejs/node/pull/66534
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 7, 2026https://github.com/nodejs/node/pull/66534#event-32716569883
richardlauhttps://github.com/richardlau
Oct 12, 2026 https://github.com/nodejs/node/pull/66534#ref-commit-05d0b14
https://github.com/RafaelGSS
https://github.com/richardlau
lib: set exit code on failed node:bench run()https://github.com/nodejs/node/commit/05d0b14438abd7805b0dc571b729dbd6180f850d
05d0b14https://github.com/nodejs/node/commit/05d0b14438abd7805b0dc571b729dbd6180f850d
#66534https://github.com/nodejs/node/pull/66534
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 12, 2026 https://github.com/nodejs/node/pull/66534#ref-pullrequest-5817131496
2026-10-14, Version 26.12.0 (Current) #66684 https://github.com/nodejs/node/pull/66684
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/66534#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
markhardinghttps://github.com/markharding
Nov 5, 2026 https://github.com/nodejs/node/pull/66534#ref-commit-609f23e
https://github.com/markharding
Update Node.js to v26 (#2168)https://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
609f23ehttps://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66534
https://github.com/bengl
bengl https://github.com/bengl
https://github.com/nodejs/node/pull/66534/files/640147224f7eebdfaee634770380be29d3742b4a
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/66534/files/640147224f7eebdfaee634770380be29d3742b4a
https://github.com/UlisesGascon
UlisesGascon https://github.com/UlisesGascon
https://github.com/nodejs/node/pull/66534/files/640147224f7eebdfaee634770380be29d3742b4a
https://github.com/atlowChemi
atlowChemi https://github.com/atlowChemi
https://github.com/nodejs/node/pull/66534/files/640147224f7eebdfaee634770380be29d3742b4a
Please reload this pagehttps://github.com/nodejs/node/pull/66534
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/66534
https://github.com/RafaelGSS
https://github.com/nodejs-github-bot
https://github.com/bengl
https://github.com/jasnell
https://github.com/UlisesGascon
https://github.com/atlowChemi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.