René's URL Explorer Experiment


Title: async-wrap: always call before and after hooks by AndreasMadsen · Pull Request #665 · nodejs/node · GitHub

Open Graph Title: async-wrap: always call before and after hooks by AndreasMadsen · Pull Request #665 · nodejs/node

X Title: async-wrap: always call before and after hooks by AndreasMadsen · Pull Request #665 · nodejs/node

Description: This patch allows the before and after hook to be called even if the kCallInitHook flag is 0. test/parallel/test-async-wrap-no-init-hook.js did not pass before. test/parallel/test-async-wrap-init-hook.js did pass before. I just added it for the sake of completeness. issue tracking: AndreasMadsen/trace#12

Open Graph Description: This patch allows the before and after hook to be called even if the kCallInitHook flag is 0. test/parallel/test-async-wrap-no-init-hook.js did not pass before. test/parallel/test-async-wrap-init-...

X Description: This patch allows the before and after hook to be called even if the kCallInitHook flag is 0. test/parallel/test-async-wrap-no-init-hook.js did not pass before. test/parallel/test-async-wrap-init-...

Opengraph URL: https://github.com/nodejs/node/pull/665

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4ba1ba60-59a9-cc09-d11d-45b6b6a63475
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA81E:3730CE:92BBC6:CE8671:6A4E7EA9
html-safe-nonce7c64df3282b3207bd3895511e65b65c84bb2758c0444777e9a2a3a4922e261c5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODFFOjM3MzBDRTo5MkJCQzY6Q0U4NjcxOjZBNEU3RUE5IiwidmlzaXRvcl9pZCI6IjMwNDQyMjQ5ODM4NDI1ODYyODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5268cf4850b074ec8fc2e18ea0fee8e932443755f7636e30437ccfa7a4286284
hovercard-subject-tagpull_request:28362347
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/665/files
twitter:imagehttps://avatars.githubusercontent.com/u/505333?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/505333?s=400&v=4
og:image:altThis patch allows the before and after hook to be called even if the kCallInitHook flag is 0. test/parallel/test-async-wrap-no-init-hook.js did not pass before. test/parallel/test-async-wrap-init-...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/665/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F665%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F665%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/665/files
Reloadhttps://github.com/nodejs/node/pull/665/files
Reloadhttps://github.com/nodejs/node/pull/665/files
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
AndreasMadsenhttps://github.com/AndreasMadsen
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
Conversation 25 https://github.com/nodejs/node/pull/665
Commits 4 https://github.com/nodejs/node/pull/665/commits
Checks 0 https://github.com/nodejs/node/pull/665/checks
Files changed 7 https://github.com/nodejs/node/pull/665/files
async-wrap: always call before and after hooks https://github.com/nodejs/node/pull/665/files#top
Show all changes 4 commits https://github.com/nodejs/node/pull/665/files
c3ee11e async-wrap: always call before and after hooks AndreasMadsen Jan 30, 2015 https://github.com/nodejs/node/pull/665/commits/c3ee11e875eaccc68c73aa975ab394a54e4a14de
af0fff2 async-wrap: expose enabled flag to JS AndreasMadsen Jan 30, 2015 https://github.com/nodejs/node/pull/665/commits/af0fff2293f6550b1161b7faa064ee5c56c2104b
b62788b async-wrap: use c++ style casting AndreasMadsen Jan 30, 2015 https://github.com/nodejs/node/pull/665/commits/b62788b0a30d8da52f459c4dba58ca9b7236e2b1
d44132c async-wrap: add enabled (disabled) test AndreasMadsen Jan 30, 2015 https://github.com/nodejs/node/pull/665/commits/d44132c7926d6927b3f4b28936351a39be2ca5ab
Clear filters https://github.com/nodejs/node/pull/665/files
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
async-wrap-inl.h https://github.com/nodejs/node/pull/665/files#diff-dfdba1b23bcf6a48bd1e580b38ef829c6a4e260458af5ef9308371c8326b8077
async-wrap.cc https://github.com/nodejs/node/pull/665/files#diff-eb96d4137061363ca88665d48df2f0f4fbd6d999ae156a0ef1caf6855e18d890
env-inl.h https://github.com/nodejs/node/pull/665/files#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4
env.h https://github.com/nodejs/node/pull/665/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
test-async-wrap-disabled.js https://github.com/nodejs/node/pull/665/files#diff-9f8a45285e02fe52a80855cce77400d2226589d24df47d6c6d2a73864ef73031
test-async-wrap-init-hook.js https://github.com/nodejs/node/pull/665/files#diff-eebfa0a9d171c5101686248a9c3a214b067fb8feb020c6d202a192cbc990ce20
test-async-wrap-no-init-hook.js https://github.com/nodejs/node/pull/665/files#diff-a7cc5d04bc3f13118db34d32118debc1119389817c7061d25dd866315b4670f0
src/async-wrap-inl.hhttps://github.com/nodejs/node/pull/665/files#diff-dfdba1b23bcf6a48bd1e580b38ef829c6a4e260458af5ef9308371c8326b8077
View file https://github.com/nodejs/node/blob/d44132c7926d6927b3f4b28936351a39be2ca5ab/src/async-wrap-inl.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/665/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/665/files#diff-dfdba1b23bcf6a48bd1e580b38ef829c6a4e260458af5ef9308371c8326b8077
https://github.com/nodejs/node/pull/665/files#diff-dfdba1b23bcf6a48bd1e580b38ef829c6a4e260458af5ef9308371c8326b8077
https://github.com/nodejs/node/pull/665/files#diff-dfdba1b23bcf6a48bd1e580b38ef829c6a4e260458af5ef9308371c8326b8077
src/async-wrap.cchttps://github.com/nodejs/node/pull/665/files#diff-eb96d4137061363ca88665d48df2f0f4fbd6d999ae156a0ef1caf6855e18d890
View file https://github.com/nodejs/node/blob/d44132c7926d6927b3f4b28936351a39be2ca5ab/src/async-wrap.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/665/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/665/files#diff-eb96d4137061363ca88665d48df2f0f4fbd6d999ae156a0ef1caf6855e18d890
trevnorrishttps://github.com/trevnorris
Jan 30, 2015https://github.com/nodejs/node/pull/665/files#r23870454
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
trevnorrishttps://github.com/trevnorris
Jan 30, 2015https://github.com/nodejs/node/pull/665/files#r23870548
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
AndreasMadsenhttps://github.com/AndreasMadsen
Jan 30, 2015https://github.com/nodejs/node/pull/665/files#r23871045
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
https://github.com/nodejs/node/pull/665/files#diff-eb96d4137061363ca88665d48df2f0f4fbd6d999ae156a0ef1caf6855e18d890
src/env-inl.hhttps://github.com/nodejs/node/pull/665/files#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4
View file https://github.com/nodejs/node/blob/d44132c7926d6927b3f4b28936351a39be2ca5ab/src/env-inl.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/665/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/665/files#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4
https://github.com/nodejs/node/pull/665/files#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4
https://github.com/nodejs/node/pull/665/files#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4
https://github.com/nodejs/node/pull/665/files#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4
src/env.hhttps://github.com/nodejs/node/pull/665/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
View file https://github.com/nodejs/node/blob/d44132c7926d6927b3f4b28936351a39be2ca5ab/src/env.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/665/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/665/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
https://github.com/nodejs/node/pull/665/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
trevnorrishttps://github.com/trevnorris
Mar 13, 2015https://github.com/nodejs/node/pull/665/files#r26408257
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
AndreasMadsenhttps://github.com/AndreasMadsen
Mar 13, 2015https://github.com/nodejs/node/pull/665/files#r26408890
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
trevnorrishttps://github.com/trevnorris
Mar 13, 2015https://github.com/nodejs/node/pull/665/files#r26413721
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
AndreasMadsenhttps://github.com/AndreasMadsen
Mar 13, 2015https://github.com/nodejs/node/pull/665/files#r26425961
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/iojs/io.js/blob/v1.x/src/async-wrap.cc#L39https://github.com/iojs/io.js/blob/v1.x/src/async-wrap.cc#L39
trace (L80)https://github.com/AndreasMadsen/trace/blob/master/trace.js#L80
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
AndreasMadsenhttps://github.com/AndreasMadsen
Mar 27, 2015https://github.com/nodejs/node/pull/665/files#r27312971
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
trevnorrishttps://github.com/trevnorris
Mar 27, 2015https://github.com/nodejs/node/pull/665/files#r27330645
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
AndreasMadsenhttps://github.com/AndreasMadsen
Mar 27, 2015https://github.com/nodejs/node/pull/665/files#r27331359
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
https://github.com/nodejs/node/pull/665/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
https://github.com/nodejs/node/pull/665/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
https://github.com/nodejs/node/pull/665/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
test/parallel/test-async-wrap-disabled.jshttps://github.com/nodejs/node/pull/665/files#diff-9f8a45285e02fe52a80855cce77400d2226589d24df47d6c6d2a73864ef73031
View file https://github.com/nodejs/node/blob/d44132c7926d6927b3f4b28936351a39be2ca5ab/test/parallel/test-async-wrap-disabled.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/665/{{ revealButtonHref }}
test/parallel/test-async-wrap-init-hook.jshttps://github.com/nodejs/node/pull/665/files#diff-eebfa0a9d171c5101686248a9c3a214b067fb8feb020c6d202a192cbc990ce20
View file https://github.com/nodejs/node/blob/d44132c7926d6927b3f4b28936351a39be2ca5ab/test/parallel/test-async-wrap-init-hook.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/665/{{ revealButtonHref }}
trevnorrishttps://github.com/trevnorris
Jan 30, 2015https://github.com/nodejs/node/pull/665/files#r23870363
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665/files
test/parallel/test-async-wrap-no-init-hook.jshttps://github.com/nodejs/node/pull/665/files#diff-a7cc5d04bc3f13118db34d32118debc1119389817c7061d25dd866315b4670f0
View file https://github.com/nodejs/node/blob/d44132c7926d6927b3f4b28936351a39be2ca5ab/test/parallel/test-async-wrap-no-init-hook.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/665/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.