René's URL Explorer Experiment


Title: async-wrap: always call before and after hooks by AndreasMadsen · Pull Request #665 · nodejs/node · GitHub

Open Graph Title: async-wrap: always call before and after hooks by AndreasMadsen · Pull Request #665 · nodejs/node

X Title: async-wrap: always call before and after hooks by AndreasMadsen · Pull Request #665 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This patch allows the before and after hook to be called even if the kCallInitHook flag is 0. test/parallel/test-async-wrap-no-init-hook.js did not pass before. test/parallel/test-async-wrap-init-...

X Description: This patch allows the before and after hook to be called even if the kCallInitHook flag is 0. test/parallel/test-async-wrap-no-init-hook.js did not pass before. test/parallel/test-async-wrap-init-...

Opengraph URL: https://github.com/nodejs/node/pull/665

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3261ac4e-cff6-fd18-3fcc-78322d5ba063
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD306:323A96:939734:D7E1F1:6A4E1A3C
html-safe-nonce074ea21409c7643d197aece440eee03e1535859771c2447ec0a75a88666736cc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzA2OjMyM0E5Njo5Mzk3MzQ6RDdFMUYxOjZBNEUxQTNDIiwidmlzaXRvcl9pZCI6IjI5NDc0NDc3Mzk4OTIyNDMwMDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfb31c38bd3d75019ea0391f97c9ecff939bb77babe8f16bd3288e7d6abf562c8
hovercard-subject-tagpull_request:28362347
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/665/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a9cf8a959b3e86811f28efd482d0cd50d8b79839752b73c679a21692b0a2a5e7/nodejs/node/pull/665
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a9cf8a959b3e86811f28efd482d0cd50d8b79839752b73c679a21692b0a2a5e7/nodejs/node/pull/665
og:image:altThis patch allows the before and after hook to be called even if the kCallInitHook flag is 0. test/parallel/test-async-wrap-no-init-hook.js did not pass before. test/parallel/test-async-wrap-init-...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndreasMadsen
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5fe497b4815fcce3df76c0e246faa739a82c3124
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/665#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F665
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F665
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/665
Reloadhttps://github.com/nodejs/node/pull/665
Reloadhttps://github.com/nodejs/node/pull/665
Please reload this pagehttps://github.com/nodejs/node/pull/665
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/665
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
AndreasMadsenhttps://github.com/AndreasMadsen
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
Conversationhttps://github.com/nodejs/node/pull/665
Commits4 (4)https://github.com/nodejs/node/pull/665/commits
Checkshttps://github.com/nodejs/node/pull/665/checks
Files changedhttps://github.com/nodejs/node/pull/665/files
async-wrap: always call before and after hookshttps://github.com/nodejs/node/pull/665#top
AndreasMadsenhttps://github.com/AndreasMadsen
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
https://github.com/AndreasMadsen
AndreasMadsenhttps://github.com/AndreasMadsen
Jan 30, 2015https://github.com/nodejs/node/pull/665#issue-56035549
AndreasMadsen/trace#12https://github.com/AndreasMadsen/trace/issues/12
Please reload this pagehttps://github.com/nodejs/node/pull/665
https://github.com/AndreasMadsen
async-wrap: always call before and after hookshttps://github.com/nodejs/node/pull/665/commits/c3ee11e875eaccc68c73aa975ab394a54e4a14de
c3ee11ehttps://github.com/nodejs/node/pull/665/commits/c3ee11e875eaccc68c73aa975ab394a54e4a14de
bnoordhuishttps://github.com/bnoordhuis
Jan 30, 2015 https://github.com/nodejs/node/pull/665#discussion-diff-23844008
View reviewed changes https://github.com/nodejs/node/pull/665/files/c3ee11e875eaccc68c73aa975ab394a54e4a14de#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
src/env.hhttps://github.com/nodejs/node/pull/665/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
bnoordhuishttps://github.com/bnoordhuis
Jan 30, 2015https://github.com/nodejs/node/pull/665#discussion_r23844008
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665
AndreasMadsenhttps://github.com/AndreasMadsen
Jan 30, 2015https://github.com/nodejs/node/pull/665#discussion_r23851231
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665
bnoordhuishttps://github.com/bnoordhuis
Jan 30, 2015https://github.com/nodejs/node/pull/665#discussion_r23851688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/665
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 30, 2015https://github.com/nodejs/node/pull/665#issuecomment-72206824
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/665
https://github.com/AndreasMadsen
async-wrap: expose enabled flag to JShttps://github.com/nodejs/node/pull/665/commits/af0fff2293f6550b1161b7faa064ee5c56c2104b
af0fff2https://github.com/nodejs/node/pull/665/commits/af0fff2293f6550b1161b7faa064ee5c56c2104b
trevnorrishttps://github.com/trevnorris
Jan 30, 2015 https://github.com/nodejs/node/pull/665#discussion-diff-23870199
View reviewed changes https://github.com/nodejs/node/pull/665/files/af0fff2293f6550b1161b7faa064ee5c56c2104b#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4
src/env-inl.hhttps://github.com/nodejs/node/pull/665/files#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4
trevnorrishttps://github.com/trevnorris
Jan 30, 2015https://github.com/nodejs/node/pull/665#discussion_r23870199
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 30, 2015https://github.com/nodejs/node/pull/665#issuecomment-72266353
@AndreasMadsenhttps://github.com/AndreasMadsen
Please reload this pagehttps://github.com/nodejs/node/pull/665
AndreasMadsenhttps://github.com/AndreasMadsen
January 30, 2015 21:58https://github.com/nodejs/node/pull/665#commits-pushed-b62788b
https://github.com/AndreasMadsen
async-wrap: use c++ style castinghttps://github.com/nodejs/node/pull/665/commits/b62788b0a30d8da52f459c4dba58ca9b7236e2b1
b62788bhttps://github.com/nodejs/node/pull/665/commits/b62788b0a30d8da52f459c4dba58ca9b7236e2b1
https://github.com/AndreasMadsen
async-wrap: add enabled (disabled) testhttps://github.com/nodejs/node/pull/665/commits/d44132c7926d6927b3f4b28936351a39be2ca5ab
d44132chttps://github.com/nodejs/node/pull/665/commits/d44132c7926d6927b3f4b28936351a39be2ca5ab
https://github.com/AndreasMadsen
AndreasMadsenhttps://github.com/AndreasMadsen
Jan 30, 2015https://github.com/nodejs/node/pull/665#issuecomment-72269770
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/665
https://github.com/AndreasMadsen
AndreasMadsenhttps://github.com/AndreasMadsen
Jan 30, 2015https://github.com/nodejs/node/pull/665#issuecomment-72270227
Please reload this pagehttps://github.com/nodejs/node/pull/665
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 30, 2015https://github.com/nodejs/node/pull/665#issuecomment-72278172
@AndreasMadsenhttps://github.com/AndreasMadsen
Please reload this pagehttps://github.com/nodejs/node/pull/665
https://github.com/AndreasMadsen
AndreasMadsenhttps://github.com/AndreasMadsen
Jan 30, 2015https://github.com/nodejs/node/pull/665#issuecomment-72284310
Please reload this pagehttps://github.com/nodejs/node/pull/665
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Feb 5, 2015https://github.com/nodejs/node/pull/665#event-230931169
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Mar 13, 2015https://github.com/nodejs/node/pull/665#issuecomment-79180899
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/665
trevnorrishttps://github.com/trevnorris
Mar 13, 2015 https://github.com/nodejs/node/pull/665#discussion-diff-26408257
View reviewed changes https://github.com/nodejs/node/pull/665/files/d44132c7926d6927b3f4b28936351a39be2ca5ab#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
src/env.hhttps://github.com/nodejs/node/pull/665/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
trevnorrishttps://github.com/trevnorris
Mar 13, 2015https://github.com/nodejs/node/pull/665#discussion_r26408257
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665
AndreasMadsenhttps://github.com/AndreasMadsen
Mar 13, 2015https://github.com/nodejs/node/pull/665#discussion_r26408890
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665
trevnorrishttps://github.com/trevnorris
Mar 13, 2015https://github.com/nodejs/node/pull/665#discussion_r26413721
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665
AndreasMadsenhttps://github.com/AndreasMadsen
Mar 13, 2015https://github.com/nodejs/node/pull/665#discussion_r26425961
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/iojs/io.js/blob/v1.x/src/async-wrap.cc#L39https://github.com/iojs/io.js/blob/v1.x/src/async-wrap.cc#L39
trace (L80)https://github.com/AndreasMadsen/trace/blob/master/trace.js#L80
Please reload this pagehttps://github.com/nodejs/node/pull/665
AndreasMadsenhttps://github.com/AndreasMadsen
Mar 27, 2015https://github.com/nodejs/node/pull/665#discussion_r27312971
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665
trevnorrishttps://github.com/trevnorris
Mar 27, 2015https://github.com/nodejs/node/pull/665#discussion_r27330645
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665
AndreasMadsenhttps://github.com/AndreasMadsen
Mar 27, 2015https://github.com/nodejs/node/pull/665#discussion_r27331359
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/665
https://github.com/AndreasMadsen
AndreasMadsenhttps://github.com/AndreasMadsen
Mar 13, 2015https://github.com/nodejs/node/pull/665#issuecomment-79199858
@trevnorrishttps://github.com/trevnorris
05f4dffhttps://github.com/nodejs/node/commit/05f4dff97519ada5d3149a16ca9e5a04df948a61
Please reload this pagehttps://github.com/nodejs/node/pull/665
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Apr 7, 2015https://github.com/nodejs/node/pull/665#event-274802472
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
land-on-master https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-master
Apr 17, 2015https://github.com/nodejs/node/pull/665#event-284308337
https://github.com/Qard
Qardhttps://github.com/Qard
Jun 25, 2015https://github.com/nodejs/node/pull/665#issuecomment-115050589
#1614https://github.com/nodejs/node/pull/1614
Please reload this pagehttps://github.com/nodejs/node/pull/665
https://github.com/Qard
Qardhttps://github.com/Qard
Jun 25, 2015https://github.com/nodejs/node/pull/665#event-339523997
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F665
https://github.com/trevnorris
trevnorris https://github.com/trevnorris
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/665
https://github.com/AndreasMadsen
https://github.com/bnoordhuis
https://github.com/trevnorris
https://github.com/Fishrock123
https://github.com/Qard
https://github.com/chrisdickinson
https://github.com/brendanashworth
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.