René's URL Explorer Experiment


Title: stream: apply additional fixes to iter streams by jasnell · Pull Request #66483 · nodejs/node · GitHub

Open Graph Title: stream: apply additional fixes to iter streams by jasnell · Pull Request #66483 · nodejs/node

X Title: stream: apply additional fixes to iter streams by jasnell · Pull Request #66483 · nodejs/node

Description: See each individual commit for it's own description.

Open Graph Description: See each individual commit for it's own description.

X Description: See each individual commit for it's own description.

Opengraph URL: https://github.com/nodejs/node/pull/66483

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:688a73a0-8045-e292-d769-37544a877ea0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE574:196DCB:70CD8E:9B6BC5:6AEDC6F0
html-safe-nonceb1b8a6f6857d14bd6cdb962679942cf9303312133a41f3c655e872435797dca8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTc0OjE5NkRDQjo3MENEOEU6OUI2QkM1OjZBRURDNkYwIiwidmlzaXRvcl9pZCI6IjY5MTQyOTQxNTQ1NTY5ODMwMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6ac52a60eaac94d40c6242f2e89f0809f6316f6467d74192bbd3c394c8e918fd
hovercard-subject-tagpull_request:4727611514
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649
twitter:imagehttps://avatars.githubusercontent.com/u/439929?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/439929?s=400&v=4
og:image:altSee each individual commit for it's own description.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec7d2f3ac4f4f560c56267b765892ba5b093e8a5fb2c0ed937edd8947746942e9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0cac2d0cb993b0ad48c49b076135ac558c742c30
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66483%2Fcommits%2F2947476bce074556077acfa074a8b229d4534649
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66483%2Fcommits%2F2947476bce074556077acfa074a8b229d4534649
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649
Reloadhttps://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649
Reloadhttps://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests663 (663)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
jasnellhttps://github.com/jasnell
nodejs:mainhttps://github.com/nodejs/node/tree/main
jasnell:stream-iter-fixeshttps://github.com/jasnell/node/tree/stream-iter-fixes
Conversation 6 https://github.com/nodejs/node/pull/66483
Commits 20 https://github.com/nodejs/node/pull/66483/commits
Checks 55 https://github.com/nodejs/node/pull/66483/checks
Files changed 29 https://github.com/nodejs/node/pull/66483/files
stream: apply additional fixes to iter streams https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#top
Show all changes 20 commits https://github.com/nodejs/node/pull/66483/files
ab994d6 fs: serialize FileHandle writer() async writes jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/ab994d64f53abb1bc9ef722ec7f52227aea429ba
2947476 fs: lock FileHandle on first read in pull() and pullSync() jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649
2d29ae0 stream: keep share buffer when all consumers detach jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/2d29ae03bb24c26ca8a751f0d04a6b0829904d3e
dafe05b stream: detach shareSync consumers on strict budget errors jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/dafe05b65c75cee00724deaf2083df1419331b37
1f110a3 stream: reject drop-newest backpressure in shareSync() jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/1f110a3e628f0d867b42ffd7df545eac5e681fad
5baabd6 stream: split oversized share batches under drop-oldest jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/5baabd614f4b4cbe248e1f75b5aba5514fe110e3
967e65f stream: guard shareSync() against re-entrant source reads jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/967e65ff1ac46b03afb017e9e61bb441133e7c4a
3b4331b stream: bound pre-batched async values in from() jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/3b4331b83e083ca77e11ad1f10c2ec8c1adffda3
36cd03b stream: do not hold back nested async data in from() jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/36cd03b8ac00ad3abf925c047e1deeba319912b0
a8b8a20 stream: honor stream/iter protocols on function objects jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/a8b8a209d62b27e6d2bd8aaca83a6fd647256200
0a7084b stream: align pull() abort handling with the spec jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/0a7084b4516c9095dd0721fa3c6e1e61bce39702
af4f699 stream: keep the original error when writer.fail() throws jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/af4f699c33ec3a918ef3ba8aa6e3d3138f17452c
d767f65 stream: reduce per-chunk overhead in stream/iter consumers jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/d767f652b08752207e2a90c6fd1c616723a753b0
d200500 stream: accept explicit stream/iter budgets below 16384 jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/d200500fecf34351fa6a8c9f70800c8b76bad6c0
518ef66 stream: reject closed fromWritable() writes with a TypeError jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/518ef66aa19ec337fbbaa2772ad6e3b91e698d83
c39de4d quic: reject closed stream writer writes with a TypeError jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/c39de4d7fb3ef0bf797b9cdc4e0db50b6e201a61
378514a stream: fix fromSync() async input error messages jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/378514a53e298af92351471a2a55d22c50e2bbf0
af13c1d doc: document stream/iter behaviors and Node.js extensions jasnell Oct 3, 2026 https://github.com/nodejs/node/pull/66483/commits/af13c1d27a50b2fee4706cf448af2cce27fe52b8
7989e49 stream: do not fail the writer when pipeToSync() cannot close it jasnell Oct 4, 2026 https://github.com/nodejs/node/pull/66483/commits/7989e49958ca806f86d0fcb37f3572ab9eaf5b7b
89a35d9 stream: add pipeToSync() failOnIncompleteClose option jasnell Oct 4, 2026 https://github.com/nodejs/node/pull/66483/commits/89a35d9fd3962332d952cb9cf13d33f30240d4fb
Clear filters https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649
Please reload this pagehttps://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649
Please reload this pagehttps://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649
promises.js https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
test-fs-promises-file-handle-pull.js https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-f0f479e07fb7e28ff83d6d077c7ec88498d5940db86bd32d8f45cd5ec6d217f0
test-fs-promises-file-handle-pullsync.js https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-b11bd5b0e6a0aa7ced883f5eb2761ae64e0a261daa79cb7704ecad31ee7be8b7
Prev https://github.com/nodejs/node/pull/66483/commits/ab994d64f53abb1bc9ef722ec7f52227aea429ba
Next https://github.com/nodejs/node/pull/66483/commits/2d29ae03bb24c26ca8a751f0d04a6b0829904d3e
Please reload this pagehttps://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649
https://github.com/jasnell
jasnellhttps://github.com/nodejs/node/commits?author=jasnell
lib/internal/fs/promises.jshttps://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
View file https://github.com/jasnell/node/blob/2947476bce074556077acfa074a8b229d4534649/lib/internal/fs/promises.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66483/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
test/parallel/test-fs-promises-file-handle-pull.jshttps://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-f0f479e07fb7e28ff83d6d077c7ec88498d5940db86bd32d8f45cd5ec6d217f0
View file https://github.com/jasnell/node/blob/2947476bce074556077acfa074a8b229d4534649/test/parallel/test-fs-promises-file-handle-pull.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66483/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-f0f479e07fb7e28ff83d6d077c7ec88498d5940db86bd32d8f45cd5ec6d217f0
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-f0f479e07fb7e28ff83d6d077c7ec88498d5940db86bd32d8f45cd5ec6d217f0
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-f0f479e07fb7e28ff83d6d077c7ec88498d5940db86bd32d8f45cd5ec6d217f0
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-f0f479e07fb7e28ff83d6d077c7ec88498d5940db86bd32d8f45cd5ec6d217f0
test/parallel/test-fs-promises-file-handle-pullsync.jshttps://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-b11bd5b0e6a0aa7ced883f5eb2761ae64e0a261daa79cb7704ecad31ee7be8b7
View file https://github.com/jasnell/node/blob/2947476bce074556077acfa074a8b229d4534649/test/parallel/test-fs-promises-file-handle-pullsync.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66483/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-b11bd5b0e6a0aa7ced883f5eb2761ae64e0a261daa79cb7704ecad31ee7be8b7
https://github.com/nodejs/node/pull/66483/commits/2947476bce074556077acfa074a8b229d4534649#diff-b11bd5b0e6a0aa7ced883f5eb2761ae64e0a261daa79cb7704ecad31ee7be8b7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.