René's URL Explorer Experiment


Title: fs: normalize paths with dot segments in rm and rmSync by RohithPariki · Pull Request #66472 · nodejs/node · GitHub

Open Graph Title: fs: normalize paths with dot segments in rm and rmSync by RohithPariki · Pull Request #66472 · nodejs/node

X Title: fs: normalize paths with dot segments in rm and rmSync by RohithPariki · Pull Request #66472 · nodejs/node

Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Affected core subsystem(s) fs Description of change When paths containing relative components (such as . or ..) are passed to fs.rm(), fs.rmSync(), or fs.promises.rm(), the different underlying implementations (binding.rmSync via std::filesystem::remove_all vs JS rimraf) produce divergent results: In rimraf, child paths are constructed by concatenating onto the unresolved path. When recursion removes intermediate directory components, subsequent calls fail with ENOENT, which rimraf treats as "already deleted," causing silent partial removals. rmSync throws an error without a .code property on paths with trailing /.. This PR normalizes dot segments before reaching the underlying removal routines: Introduces normalizePathForRm() in lib/fs.js and lib/internal/fs/promises.js. Correctly handles both string and Buffer inputs: for Buffer paths, binary byte content is preserved 1:1 using latin1 round-tripping before and after normalization to prevent data corruption on non-UTF-8 paths. WHATWG URL inputs are converted to strings via getValidatedPath() before normalization. Tests Added regression tests in test/parallel/test-fs-rm.js covering: The full relative path matrix (a/b/../., a/b/.., a/., a/b/c/., a/b/c/../.., a/b/c/d/../../.., a/b/.././b, ./a) across fs.rmSync, fs.rm (callback), and fs.promises.rm. Buffer paths across sync and promises implementations. Non-UTF-8 binary Buffer paths to ensure byte preservation. Fixes: #61958

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Affected core...

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Affected core...

Opengraph URL: https://github.com/nodejs/node/pull/66472

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6b9664ba-5ec6-1ecd-d87f-9f44993c2711
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD158:2AB5E3:10540E8:155D10F:6AED60A9
html-safe-nonceb5df5651d37f77ac7d2fd039b1d7563898581c8b0611ed140ac6da6856d54920
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTU4OjJBQjVFMzoxMDU0MEU4OjE1NUQxMEY6NkFFRDYwQTkiLCJ2aXNpdG9yX2lkIjoiNjcxNDk2MjA4MDk0NDcwOTgwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca6757c8d7b93dc02fa57b79162f4b2d701cfe1f52a39d23d45200cc3515a1feb
hovercard-subject-tagpull_request:4723150532
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/66472/files
twitter:imagehttps://avatars.githubusercontent.com/u/159949499?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/159949499?s=400&v=4
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Affected core...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66472/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66472%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66472%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66472/files
Reloadhttps://github.com/nodejs/node/pull/66472/files
Reloadhttps://github.com/nodejs/node/pull/66472/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
RohithParikihttps://github.com/RohithPariki
nodejs:mainhttps://github.com/nodejs/node/tree/main
RohithPariki:fix/fs-rm-normalize-dotdot-pathshttps://github.com/RohithPariki/node/tree/fix/fs-rm-normalize-dotdot-paths
Conversation 4 https://github.com/nodejs/node/pull/66472
Commits 1 https://github.com/nodejs/node/pull/66472/commits
Checks 1 https://github.com/nodejs/node/pull/66472/checks
Files changed 3 https://github.com/nodejs/node/pull/66472/files
fs: normalize paths with dot segments in rm and rmSync https://github.com/nodejs/node/pull/66472/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/66472/files
0dc372c fs: normalize dot segments in rm and rmSync RohithPariki Oct 3, 2026 https://github.com/nodejs/node/pull/66472/commits/0dc372cc702c622cb5626844c4e4246103a483d5
Clear filters https://github.com/nodejs/node/pull/66472/files
Please reload this pagehttps://github.com/nodejs/node/pull/66472/files
Please reload this pagehttps://github.com/nodejs/node/pull/66472/files
fs.js https://github.com/nodejs/node/pull/66472/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
promises.js https://github.com/nodejs/node/pull/66472/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
test-fs-rm.js https://github.com/nodejs/node/pull/66472/files#diff-596c3dc1f2c2b0c3dc8f6c087b9e0f1910188ff28eaee22800367acc0e9a4f43
lib/fs.jshttps://github.com/nodejs/node/pull/66472/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
View file https://github.com/RohithPariki/node/blob/0dc372cc702c622cb5626844c4e4246103a483d5/lib/fs.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66472/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66472/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
https://github.com/nodejs/node/pull/66472/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
https://github.com/nodejs/node/pull/66472/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
https://github.com/nodejs/node/pull/66472/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
lib/internal/fs/promises.jshttps://github.com/nodejs/node/pull/66472/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
View file https://github.com/RohithPariki/node/blob/0dc372cc702c622cb5626844c4e4246103a483d5/lib/internal/fs/promises.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66472/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66472/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/66472/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
test/parallel/test-fs-rm.jshttps://github.com/nodejs/node/pull/66472/files#diff-596c3dc1f2c2b0c3dc8f6c087b9e0f1910188ff28eaee22800367acc0e9a4f43
View file https://github.com/RohithPariki/node/blob/0dc372cc702c622cb5626844c4e4246103a483d5/test/parallel/test-fs-rm.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66472/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66472/files#diff-596c3dc1f2c2b0c3dc8f6c087b9e0f1910188ff28eaee22800367acc0e9a4f43
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.