René's URL Explorer Experiment


Title: ffi: fix exportArrayBuffer type check by trivikr · Pull Request #66455 · nodejs/node · GitHub

Open Graph Title: ffi: fix exportArrayBuffer type check by trivikr · Pull Request #66455 · nodejs/node

X Title: ffi: fix exportArrayBuffer type check by trivikr · Pull Request #66455 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #66454 Use isArrayBuffer() instead of comparing Object.prototype.toString() output. The old check depended on Symbol.toStringTag, so a real ArrayBuffer with a custom tag was rejected, and a ...

X Description: Fixes: #66454 Use isArrayBuffer() instead of comparing Object.prototype.toString() output. The old check depended on Symbol.toStringTag, so a real ArrayBuffer with a custom tag was rejected, and a ...

Opengraph URL: https://github.com/nodejs/node/pull/66455

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:57d5d745-ae41-19fd-452d-872f3b832f40
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBFA:2FF8F1:25FC58:31628D:6AED194A
html-safe-nonce88d9194bcc86fa8a540878f52e72c160706d3321a05b3b27d9d8cfaf9f2651ca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkZBOjJGRjhGMToyNUZDNTg6MzE2MjhEOjZBRUQxOTRBIiwidmlzaXRvcl9pZCI6IjQ0NjgyNjE2NDIyNDA3MjAxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6b5ad9f0f0845e61e90971db242116c6f742d6810029fbb579dbf7714f125b6b
hovercard-subject-tagpull_request:4712449335
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66455/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a3626fe6049b7b15b46a83e31d83c50288c18a27e47f1438bcc1ba9825541cb2/nodejs/node/pull/66455
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a3626fe6049b7b15b46a83e31d83c50288c18a27e47f1438bcc1ba9825541cb2/nodejs/node/pull/66455
og:image:altFixes: #66454 Use isArrayBuffer() instead of comparing Object.prototype.toString() output. The old check depended on Symbol.toStringTag, so a real ArrayBuffer with a custom tag was rejected, and a ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66455#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66455
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66455
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66455
Reloadhttps://github.com/nodejs/node/pull/66455
Reloadhttps://github.com/nodejs/node/pull/66455
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-exportarraybuffer-type-checkhttps://github.com/trivikr/node/tree/ffi-exportarraybuffer-type-check
Conversationhttps://github.com/nodejs/node/pull/66455
Commits1 (1)https://github.com/nodejs/node/pull/66455/commits
Checkshttps://github.com/nodejs/node/pull/66455/checks
Files changedhttps://github.com/nodejs/node/pull/66455/files
ffi: fix exportArrayBuffer type checkhttps://github.com/nodejs/node/pull/66455#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-exportarraybuffer-type-checkhttps://github.com/trivikr/node/tree/ffi-exportarraybuffer-type-check
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 2, 2026https://github.com/nodejs/node/pull/66455#issue-5672591011
#66454https://github.com/nodejs/node/issues/66454
Please reload this pagehttps://github.com/nodejs/node/pull/66455
https://github.com/trivikr
ffi: fix exportArrayBuffer type checkhttps://github.com/nodejs/node/pull/66455/commits/e6bf923186a38c672b0c8326cdbe8932a19a42f3
e6bf923https://github.com/nodejs/node/pull/66455/commits/e6bf923186a38c672b0c8326cdbe8932a19a42f3
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 2, 2026https://github.com/nodejs/node/pull/66455#issuecomment-5945244026
Please reload this pagehttps://github.com/nodejs/node/pull/66455
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 2, 2026https://github.com/nodejs/node/pull/66455#event-32307449822
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Oct 2, 2026 https://github.com/nodejs/node/pull/66455#pullrequestreview-5388189363
View reviewed changes https://github.com/nodejs/node/pull/66455/files/e6bf923186a38c672b0c8326cdbe8932a19a42f3
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 2, 2026https://github.com/nodejs/node/pull/66455#event-32309235308
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 2, 2026https://github.com/nodejs/node/pull/66455#event-32309540873
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 2, 2026https://github.com/nodejs/node/pull/66455#issuecomment-5945750798
https://ci.nodejs.org/job/node-test-pull-request/78132/https://ci.nodejs.org/job/node-test-pull-request/78132/
Please reload this pagehttps://github.com/nodejs/node/pull/66455
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 2, 2026https://github.com/nodejs/node/pull/66455#issuecomment-5946270624
Please reload this pagehttps://github.com/nodejs/node/pull/66455
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66455?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
a7a9784https://app.codecov.io/gh/nodejs/node/commit/a7a978415cc690fc1f751800a2a8052d4d02f289?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e6bf923https://app.codecov.io/gh/nodejs/node/commit/e6bf923186a38c672b0c8326cdbe8932a19a42f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66455?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/ffi.jshttps://app.codecov.io/gh/nodejs/node/pull/66455?src=pr&el=tree&filepath=lib%2Fffi.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ZmaS5qcw==
499 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66455/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66455
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Oct 2, 2026 https://github.com/nodejs/node/pull/66455#pullrequestreview-5389024502
View reviewed changes https://github.com/nodejs/node/pull/66455/files/e6bf923186a38c672b0c8326cdbe8932a19a42f3
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 2, 2026 https://github.com/nodejs/node/pull/66455#pullrequestreview-5390988618
View reviewed changes https://github.com/nodejs/node/pull/66455/files/e6bf923186a38c672b0c8326cdbe8932a19a42f3
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 2, 2026https://github.com/nodejs/node/pull/66455#event-32328112363
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 2, 2026https://github.com/nodejs/node/pull/66455#event-32329162066
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 2, 2026https://github.com/nodejs/node/pull/66455#issuecomment-5951161387
View workflow runhttps://github.com/nodejs/node/actions/runs/37000090903
Please reload this pagehttps://github.com/nodejs/node/pull/66455
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
Oct 2, 2026https://github.com/nodejs/node/pull/66455#event-32332271919
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
04904ebhttps://github.com/nodejs/node/commit/04904eb4ca488300816cc260cf794598c16a65ab
Oct 4, 2026https://github.com/nodejs/node/pull/66455#event-32427245571
Please reload this pagehttps://github.com/nodejs/node/pull/66455
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 4, 2026https://github.com/nodejs/node/pull/66455#issuecomment-5976330757
04904ebhttps://github.com/nodejs/node/commit/04904eb4ca488300816cc260cf794598c16a65ab
Please reload this pagehttps://github.com/nodejs/node/pull/66455
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 4, 2026https://github.com/nodejs/node/pull/66455#event-32427247169
richardlauhttps://github.com/richardlau
Oct 12, 2026 https://github.com/nodejs/node/pull/66455#ref-commit-c1073f3
https://github.com/trivikr
https://github.com/richardlau
ffi: fix exportArrayBuffer type checkhttps://github.com/nodejs/node/commit/c1073f31ded6b902bf102641f4b3220cff56091c
c1073f3https://github.com/nodejs/node/commit/c1073f31ded6b902bf102641f4b3220cff56091c
#66455https://github.com/nodejs/node/pull/66455
#66454https://github.com/nodejs/node/issues/66454
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 12, 2026 https://github.com/nodejs/node/pull/66455#ref-pullrequest-5817131496
2026-10-14, Version 26.12.0 (Current) #66684 https://github.com/nodejs/node/pull/66684
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/66455#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
markhardinghttps://github.com/markharding
Nov 5, 2026 https://github.com/nodejs/node/pull/66455#ref-commit-609f23e
https://github.com/markharding
Update Node.js to v26 (#2168)https://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
609f23ehttps://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66455
https://github.com/ShogunPanda
ShogunPanda https://github.com/ShogunPanda
https://github.com/nodejs/node/pull/66455/files/e6bf923186a38c672b0c8326cdbe8932a19a42f3
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/66455/files/e6bf923186a38c672b0c8326cdbe8932a19a42f3
https://github.com/Renegade334
Renegade334 https://github.com/Renegade334
https://github.com/nodejs/node/pull/66455/files/e6bf923186a38c672b0c8326cdbe8932a19a42f3
Please reload this pagehttps://github.com/nodejs/node/pull/66455
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
ffi: exportArrayBuffer type check is fooled by Symbol.toStringTag https://github.com/nodejs/node/issues/66454
Please reload this pagehttps://github.com/nodejs/node/pull/66455
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/ShogunPanda
https://github.com/addaleax
https://github.com/Renegade334
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.