René's URL Explorer Experiment


Title: lib: fix benchmark record acknowledgement race by panva · Pull Request #66430 · nodejs/node · GitHub

Open Graph Title: lib: fix benchmark record acknowledgement race by panva · Pull Request #66430 · nodejs/node

X Title: lib: fix benchmark record acknowledgement race by panva · Pull Request #66430 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The child can receive an acknowledgement and send its next record before the parent's send callback runs. Clear recordPending before sending the acknowledgement to avoid rejecting that record a...

X Description: The child can receive an acknowledgement and send its next record before the parent's send callback runs. Clear recordPending before sending the acknowledgement to avoid rejecting that reco...

Opengraph URL: https://github.com/nodejs/node/pull/66430

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:61ca2f7f-0d3c-bcf1-2971-0329f839b4ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAAC2:17D884:3FC8C6:52F4DC:6AED21E3
html-safe-noncee5fc439e9e349eb82dd4841e6a7ca7b278481094e9058911d51a0e7f243fbcdc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUMyOjE3RDg4NDozRkM4QzY6NTJGNERDOjZBRUQyMUUzIiwidmlzaXRvcl9pZCI6IjkwODczMTMxOTk5MDI4MjY5NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac82f997b3439f8dcde9e528ef88d11c54e61a5faa3d0cd7124fc3bb9d3c280930
hovercard-subject-tagpull_request:4701971434
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66430/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9559bbb6e7c912252005c9695c6fff8bcfb91c8bf0a3d73663feda8e6e987af1/nodejs/node/pull/66430
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9559bbb6e7c912252005c9695c6fff8bcfb91c8bf0a3d73663feda8e6e987af1/nodejs/node/pull/66430
og:image:altThe child can receive an acknowledgement and send its next record before the parent's send callback runs. Clear recordPending before sending the acknowledgement to avoid rejecting that record a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepanva
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66430#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66430
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66430
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66430
Reloadhttps://github.com/nodejs/node/pull/66430
Reloadhttps://github.com/nodejs/node/pull/66430
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
panva:bench-ack-racehttps://github.com/panva/node/tree/bench-ack-race
Conversationhttps://github.com/nodejs/node/pull/66430
Commits1 (1)https://github.com/nodejs/node/pull/66430/commits
Checkshttps://github.com/nodejs/node/pull/66430/checks
Files changedhttps://github.com/nodejs/node/pull/66430/files
lib: fix benchmark record acknowledgement racehttps://github.com/nodejs/node/pull/66430#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
panva:bench-ack-racehttps://github.com/panva/node/tree/bench-ack-race
https://github.com/panva
panvahttps://github.com/panva
Oct 1, 2026https://github.com/nodejs/node/pull/66430#issue-5660159072
https://ci.nodejs.org/job/node-test-binary-windows-js-suites/43703/RUN_SUBSET=0,nodes=win2022-COMPILED_BY-vs2022_clang/testReport/junit/(root)/parallel/test_bench_cli_backpressure/https://ci.nodejs.org/job/node-test-binary-windows-js-suites/43703/RUN_SUBSET=0,nodes=win2022-COMPILED_BY-vs2022_clang/testReport/junit/(root)/parallel/test_bench_cli_backpressure/
Please reload this pagehttps://github.com/nodejs/node/pull/66430
https://github.com/panva
lib: fix benchmark record acknowledgement racehttps://github.com/nodejs/node/pull/66430/commits/1becba6284bdb3edb6bb7af8e2efbcaca69455e4
1becba6https://github.com/nodejs/node/pull/66430/commits/1becba6284bdb3edb6bb7af8e2efbcaca69455e4
https://github.com/panva
panvahttps://github.com/panva
jasnellhttps://github.com/jasnell
October 1, 2026 09:41https://github.com/nodejs/node/pull/66430#event-32239650583
https://github.com/panva
panvahttps://github.com/panva
flaky-test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test
Oct 1, 2026https://github.com/nodejs/node/pull/66430#event-32239651689
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 1, 2026https://github.com/nodejs/node/pull/66430#event-32239663382
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 1, 2026https://github.com/nodejs/node/pull/66430#issuecomment-5930534014
Please reload this pagehttps://github.com/nodejs/node/pull/66430
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66430?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
cede7e6https://app.codecov.io/gh/nodejs/node/commit/cede7e674070b1a2d9f91802fa17d8721c597b93?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
1becba6https://app.codecov.io/gh/nodejs/node/commit/1becba6284bdb3edb6bb7af8e2efbcaca69455e4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66430?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/bench_runner/cli.jshttps://app.codecov.io/gh/nodejs/node/pull/66430?src=pr&el=tree&filepath=lib%2Finternal%2Fbench_runner%2Fcli.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2JlbmNoX3J1bm5lci9jbGkuanM=
36 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66430/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66430
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 3, 2026 https://github.com/nodejs/node/pull/66430#pullrequestreview-5398624648
View reviewed changes https://github.com/nodejs/node/pull/66430/files/1becba6284bdb3edb6bb7af8e2efbcaca69455e4
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 3, 2026https://github.com/nodejs/node/pull/66430#event-32386662022
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 3, 2026https://github.com/nodejs/node/pull/66430#event-32387289920
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 3, 2026https://github.com/nodejs/node/pull/66430#issuecomment-5966966830
https://ci.nodejs.org/job/node-test-pull-request/78149/https://ci.nodejs.org/job/node-test-pull-request/78149/
Please reload this pagehttps://github.com/nodejs/node/pull/66430
https://github.com/panva
panvahttps://github.com/panva
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 3, 2026https://github.com/nodejs/node/pull/66430#event-32390508477
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Oct 3, 2026https://github.com/nodejs/node/pull/66430#event-32390760864
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
f9defa6https://github.com/nodejs/node/commit/f9defa61fa95bcce4fa2e04b1204ca703d6604a2
Oct 8, 2026https://github.com/nodejs/node/pull/66430#event-32772220515
Please reload this pagehttps://github.com/nodejs/node/pull/66430
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 8, 2026https://github.com/nodejs/node/pull/66430#issuecomment-6057374026
f9defa6https://github.com/nodejs/node/commit/f9defa61fa95bcce4fa2e04b1204ca703d6604a2
Please reload this pagehttps://github.com/nodejs/node/pull/66430
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Oct 8, 2026https://github.com/nodejs/node/pull/66430#event-32772225271
https://github.com/panva
panvahttps://github.com/panva
October 8, 2026 10:44https://github.com/nodejs/node/pull/66430#event-32776433789
richardlauhttps://github.com/richardlau
Oct 12, 2026 https://github.com/nodejs/node/pull/66430#ref-commit-062ece7
https://github.com/panva
https://github.com/richardlau
lib: fix benchmark record acknowledgement racehttps://github.com/nodejs/node/commit/062ece77fc0a694287f7cd9e3734f9851ddafb51
062ece7https://github.com/nodejs/node/commit/062ece77fc0a694287f7cd9e3734f9851ddafb51
#66430https://github.com/nodejs/node/pull/66430
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 12, 2026 https://github.com/nodejs/node/pull/66430#ref-pullrequest-5817131496
2026-10-14, Version 26.12.0 (Current) #66684 https://github.com/nodejs/node/pull/66684
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/66430#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
markhardinghttps://github.com/markharding
Nov 5, 2026 https://github.com/nodejs/node/pull/66430#ref-commit-609f23e
https://github.com/markharding
Update Node.js to v26 (#2168)https://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
609f23ehttps://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66430
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/66430/files/1becba6284bdb3edb6bb7af8e2efbcaca69455e4
Please reload this pagehttps://github.com/nodejs/node/pull/66430
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
flaky-test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/66430
https://github.com/panva
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.