René's URL Explorer Experiment


Title: ffi: remove permission checks from dlclose and dlsym by trivikr · Pull Request #66426 · nodejs/node · GitHub

Open Graph Title: ffi: remove permission checks from dlclose and dlsym by trivikr · Pull Request #66426 · nodejs/node

X Title: ffi: remove permission checks from dlclose and dlsym by trivikr · Pull Request #66426 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #66425 The docs describe ffi.dlclose(handle) and ffi.dlsym(handle, symbol) as equivalent to handle.close() and handle.getSymbol(symbol), but only the functions called checkFFIPermission(). A...

X Description: Fixes: #66425 The docs describe ffi.dlclose(handle) and ffi.dlsym(handle, symbol) as equivalent to handle.close() and handle.getSymbol(symbol), but only the functions called checkFFIPermission(). A...

Opengraph URL: https://github.com/nodejs/node/pull/66426

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a534a338-5e13-acf9-0e94-065820c8dc38
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDFDC:261346:74D5B:9CB73:6AED00AA
html-safe-noncee4344f799bdf3f2786c8657d02a14db76eff4c09c4c95b3ae937eecfc448f93f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkRDOjI2MTM0Njo3NEQ1Qjo5Q0I3Mzo2QUVEMDBBQSIsInZpc2l0b3JfaWQiOiI1NjI1MTY0MTQ0NDc4ODQ3MTQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacda0bf49ace6559dd6b5253b9be2dbaa0ee7d09f00756622d2bb4d7c808953f65
hovercard-subject-tagpull_request:4699679141
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66426/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/17c4197fa1dbea1c2fc75f1083b365f9cc1d4e4b54bb6b077534a1d1a9672023/nodejs/node/pull/66426
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/17c4197fa1dbea1c2fc75f1083b365f9cc1d4e4b54bb6b077534a1d1a9672023/nodejs/node/pull/66426
og:image:altFixes: #66425 The docs describe ffi.dlclose(handle) and ffi.dlsym(handle, symbol) as equivalent to handle.close() and handle.getSymbol(symbol), but only the functions called checkFFIPermission(). A...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66426#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66426
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66426
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66426
Reloadhttps://github.com/nodejs/node/pull/66426
Reloadhttps://github.com/nodejs/node/pull/66426
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests668 (668)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-permissions-close-symhttps://github.com/trivikr/node/tree/ffi-permissions-close-sym
Conversationhttps://github.com/nodejs/node/pull/66426
Commits1 (1)https://github.com/nodejs/node/pull/66426/commits
Checkshttps://github.com/nodejs/node/pull/66426/checks
Files changedhttps://github.com/nodejs/node/pull/66426/files
ffi: remove permission checks from dlclose and dlsymhttps://github.com/nodejs/node/pull/66426#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-permissions-close-symhttps://github.com/trivikr/node/tree/ffi-permissions-close-sym
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 1, 2026https://github.com/nodejs/node/pull/66426#issue-5657408184
#66425https://github.com/nodejs/node/issues/66425
Please reload this pagehttps://github.com/nodejs/node/pull/66426
https://github.com/trivikr
ffi: remove permission checks from dlclose and dlsymhttps://github.com/nodejs/node/pull/66426/commits/b83b2af2c0f881e54e900bbc768fb79cf392a530
b83b2afhttps://github.com/nodejs/node/pull/66426/commits/b83b2af2c0f881e54e900bbc768fb79cf392a530
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 1, 2026https://github.com/nodejs/node/pull/66426#issuecomment-5925296748
Please reload this pagehttps://github.com/nodejs/node/pull/66426
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 1, 2026https://github.com/nodejs/node/pull/66426#event-32224376622
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 1, 2026https://github.com/nodejs/node/pull/66426#event-32224425609
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 1, 2026https://github.com/nodejs/node/pull/66426#issuecomment-5926409790
Please reload this pagehttps://github.com/nodejs/node/pull/66426
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66426?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
d7ea02dhttps://app.codecov.io/gh/nodejs/node/commit/d7ea02dd5dc6dd7eda3997bc986e4c55ec0b610a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
b83b2afhttps://app.codecov.io/gh/nodejs/node/commit/b83b2af2c0f881e54e900bbc768fb79cf392a530?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66426?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/ffi.jshttps://app.codecov.io/gh/nodejs/node/pull/66426?src=pr&el=tree&filepath=lib%2Fffi.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ZmaS5qcw==
13 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66426/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66426
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Oct 1, 2026 https://github.com/nodejs/node/pull/66426#pullrequestreview-5376309679
View reviewed changes https://github.com/nodejs/node/pull/66426/files/b83b2af2c0f881e54e900bbc768fb79cf392a530
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 1, 2026https://github.com/nodejs/node/pull/66426#event-32232315340
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 1, 2026https://github.com/nodejs/node/pull/66426#issuecomment-5927203135
https://ci.nodejs.org/job/node-test-pull-request/78120/https://ci.nodejs.org/job/node-test-pull-request/78120/
Please reload this pagehttps://github.com/nodejs/node/pull/66426
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 1, 2026 https://github.com/nodejs/node/pull/66426#pullrequestreview-5376508943
View reviewed changes https://github.com/nodejs/node/pull/66426/files/b83b2af2c0f881e54e900bbc768fb79cf392a530
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 1, 2026https://github.com/nodejs/node/pull/66426#event-32232558009
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 1, 2026https://github.com/nodejs/node/pull/66426#event-32232836158
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66426
https://github.com/panva
panvahttps://github.com/panva
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
Oct 1, 2026https://github.com/nodejs/node/pull/66426#event-32233282651
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 1, 2026https://github.com/nodejs/node/pull/66426#event-32256914800
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
2bcc5ddhttps://github.com/nodejs/node/commit/2bcc5dd2eec2ed895212a81679242eef14be3e4a
Oct 3, 2026https://github.com/nodejs/node/pull/66426#event-32383217239
Please reload this pagehttps://github.com/nodejs/node/pull/66426
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 3, 2026https://github.com/nodejs/node/pull/66426#issuecomment-5965961896
2bcc5ddhttps://github.com/nodejs/node/commit/2bcc5dd2eec2ed895212a81679242eef14be3e4a
Please reload this pagehttps://github.com/nodejs/node/pull/66426
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 3, 2026https://github.com/nodejs/node/pull/66426#event-32383218999
aduh95https://github.com/aduh95
Oct 3, 2026 https://github.com/nodejs/node/pull/66426#ref-commit-241e8e3
https://github.com/trivikr
https://github.com/aduh95
ffi: remove permission checks from dlclose and dlsymhttps://github.com/nodejs/node/commit/241e8e3d047b221a266d43db8b47b2a8a96c3662
241e8e3https://github.com/nodejs/node/commit/241e8e3d047b221a266d43db8b47b2a8a96c3662
#66426https://github.com/nodejs/node/pull/66426
#66425https://github.com/nodejs/node/issues/66425
aduh95https://github.com/aduh95
Oct 3, 2026 https://github.com/nodejs/node/pull/66426#ref-commit-53fd8e7
https://github.com/trivikr
https://github.com/aduh95
ffi: remove permission checks from dlclose and dlsymhttps://github.com/nodejs/node/commit/53fd8e7ebbc42fc4b698f1e125c3e7cbd053b2fa
53fd8e7https://github.com/nodejs/node/commit/53fd8e7ebbc42fc4b698f1e125c3e7cbd053b2fa
#66426https://github.com/nodejs/node/pull/66426
#66425https://github.com/nodejs/node/issues/66425
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 5, 2026 https://github.com/nodejs/node/pull/66426#ref-pullrequest-5720654094
2026-10-07, Version 26.11.0 (Current) #66546 https://github.com/nodejs/node/pull/66546
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/66426#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
markhardinghttps://github.com/markharding
Nov 5, 2026 https://github.com/nodejs/node/pull/66426#ref-commit-609f23e
https://github.com/markharding
Update Node.js to v26 (#2168)https://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
609f23ehttps://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66426
https://github.com/ShogunPanda
ShogunPanda https://github.com/ShogunPanda
https://github.com/nodejs/node/pull/66426/files/b83b2af2c0f881e54e900bbc768fb79cf392a530
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/66426/files/b83b2af2c0f881e54e900bbc768fb79cf392a530
Please reload this pagehttps://github.com/nodejs/node/pull/66426
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
ffi: dlclose()/dlsym() check permissions that handle.close()/handle.getSymbol() don't https://github.com/nodejs/node/issues/66425
Please reload this pagehttps://github.com/nodejs/node/pull/66426
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/ShogunPanda
https://github.com/addaleax
https://github.com/panva
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.