René's URL Explorer Experiment


Title: ffi: do not abort when a Worker stops in a callback by trivikr · Pull Request #66389 · nodejs/node · GitHub

Open Graph Title: ffi: do not abort when a Worker stops in a callback by trivikr · Pull Request #66389 · nodejs/node

X Title: ffi: do not abort when a Worker stops in a callback by trivikr · Pull Request #66389 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #66388 Stopping a Worker while it is running an FFI callback aborted the whole process with "Callbacks cannot throw an exception". This happened on worker.terminate(), on process.e...

X Description: Fixes: #66388 Stopping a Worker while it is running an FFI callback aborted the whole process with "Callbacks cannot throw an exception". This happened on worker.terminate(), on p...

Opengraph URL: https://github.com/nodejs/node/pull/66389

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1f2ba241-03b0-169d-8637-1aa13dc56b30
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2D0:96FF6:775F5:A04C7:6AED00B0
html-safe-nonce4fb6390cfba5f0d7252f1019efd6fa0b85f0d3c2ada3b05ec9430856862bf80f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkQwOjk2RkY2Ojc3NUY1OkEwNEM3OjZBRUQwMEIwIiwidmlzaXRvcl9pZCI6IjcwMDM2NjgyOTY1MjMxMjA4MTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6a39074f6ce32e509903dcf8022852474937f186dab470d400460b4bae7cce65
hovercard-subject-tagpull_request:4673052372
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66389/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/19e168adfb4958e5140fe556ab8485fb61553b8bd4e8545ab7b5becc3de43e9c/nodejs/node/pull/66389
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/19e168adfb4958e5140fe556ab8485fb61553b8bd4e8545ab7b5becc3de43e9c/nodejs/node/pull/66389
og:image:altFixes: #66388 Stopping a Worker while it is running an FFI callback aborted the whole process with "Callbacks cannot throw an exception". This happened on worker.terminate(), on process.e...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66389#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66389
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66389
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66389
Reloadhttps://github.com/nodejs/node/pull/66389
Reloadhttps://github.com/nodejs/node/pull/66389
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests668 (668)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-stopping-worker-in-callbackhttps://github.com/trivikr/node/tree/ffi-stopping-worker-in-callback
Conversationhttps://github.com/nodejs/node/pull/66389
Commits2 (2)https://github.com/nodejs/node/pull/66389/commits
Checkshttps://github.com/nodejs/node/pull/66389/checks
Files changedhttps://github.com/nodejs/node/pull/66389/files
ffi: do not abort when a Worker stops in a callbackhttps://github.com/nodejs/node/pull/66389#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-stopping-worker-in-callbackhttps://github.com/trivikr/node/tree/ffi-stopping-worker-in-callback
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 29, 2026https://github.com/nodejs/node/pull/66389#issue-5625718672
#66388https://github.com/nodejs/node/issues/66388
Please reload this pagehttps://github.com/nodejs/node/pull/66389
https://github.com/trivikr
ffi: do not abort when a Worker stops in a callbackhttps://github.com/nodejs/node/pull/66389/commits/48e261d8233db212687d48a57ab267feff820a15
48e261dhttps://github.com/nodejs/node/pull/66389/commits/48e261d8233db212687d48a57ab267feff820a15
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 29, 2026https://github.com/nodejs/node/pull/66389#issuecomment-5884386076
Please reload this pagehttps://github.com/nodejs/node/pull/66389
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 29, 2026https://github.com/nodejs/node/pull/66389#event-32052712286
https://github.com/trivikr
trivikrhttps://github.com/trivikr
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 29, 2026https://github.com/nodejs/node/pull/66389#event-32052720975
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 29, 2026https://github.com/nodejs/node/pull/66389#issuecomment-5885575158
Please reload this pagehttps://github.com/nodejs/node/pull/66389
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66389?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
296584bhttps://app.codecov.io/gh/nodejs/node/commit/296584b7af70b99f016a115958be3608d3506cd2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
41e4125https://app.codecov.io/gh/nodejs/node/commit/41e41258318991500d522e29b34b6bd955bd7781?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66389?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_ffi.cchttps://app.codecov.io/gh/nodejs/node/pull/66389?src=pr&el=tree&filepath=src%2Fnode_ffi.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmZpLmNj
0 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/66389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66389?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_ffi.cchttps://app.codecov.io/gh/nodejs/node/pull/66389?src=pr&el=tree&filepath=src%2Fnode_ffi.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmZpLmNj
36 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66389/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66389
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
Sep 30, 2026 https://github.com/nodejs/node/pull/66389#pullrequestreview-5360051320
View reviewed changes https://github.com/nodejs/node/pull/66389/files/48e261d8233db212687d48a57ab267feff820a15
src/node_ffi.cchttps://github.com/nodejs/node/pull/66389/files/48e261d8233db212687d48a57ab267feff820a15#diff-d585ac37af7068d4e6273cf96dd79d886d8a1a24a280e837541693a74293e74b
Please reload this pagehttps://github.com/nodejs/node/pull/66389
https://github.com/trivikr
fixup! ffi: do not abort when a Worker stops in a callbackhttps://github.com/nodejs/node/pull/66389/commits/41e41258318991500d522e29b34b6bd955bd7781
41e4125https://github.com/nodejs/node/pull/66389/commits/41e41258318991500d522e29b34b6bd955bd7781
https://github.com/trivikr
trivikrhttps://github.com/trivikr
daeyeonhttps://github.com/daeyeon
September 30, 2026 04:25https://github.com/nodejs/node/pull/66389#event-32134668387
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
Sep 30, 2026 https://github.com/nodejs/node/pull/66389#pullrequestreview-5362038049
View reviewed changes https://github.com/nodejs/node/pull/66389/files/41e41258318991500d522e29b34b6bd955bd7781
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Sep 30, 2026https://github.com/nodejs/node/pull/66389#event-32138822847
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 30, 2026https://github.com/nodejs/node/pull/66389#event-32140928918
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 30, 2026https://github.com/nodejs/node/pull/66389#issuecomment-5905617090
https://ci.nodejs.org/job/node-test-pull-request/78088/https://ci.nodejs.org/job/node-test-pull-request/78088/
Please reload this pagehttps://github.com/nodejs/node/pull/66389
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 30, 2026https://github.com/nodejs/node/pull/66389#event-32147571751
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 30, 2026 https://github.com/nodejs/node/pull/66389#pullrequestreview-5363640152
View reviewed changes https://github.com/nodejs/node/pull/66389/files/41e41258318991500d522e29b34b6bd955bd7781
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 30, 2026 https://github.com/nodejs/node/pull/66389#pullrequestreview-5366032169
View reviewed changes https://github.com/nodejs/node/pull/66389/files/41e41258318991500d522e29b34b6bd955bd7781
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/66389#pullrequestreview-5366032169
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66389
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
cede7e6https://github.com/nodejs/node/commit/cede7e674070b1a2d9f91802fa17d8721c597b93
Oct 1, 2026https://github.com/nodejs/node/pull/66389#event-32225775651
Please reload this pagehttps://github.com/nodejs/node/pull/66389
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 1, 2026https://github.com/nodejs/node/pull/66389#issuecomment-5925609320
cede7e6https://github.com/nodejs/node/commit/cede7e674070b1a2d9f91802fa17d8721c597b93
Please reload this pagehttps://github.com/nodejs/node/pull/66389
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 1, 2026https://github.com/nodejs/node/pull/66389#event-32225778351
aduh95https://github.com/aduh95
Oct 3, 2026 https://github.com/nodejs/node/pull/66389#ref-commit-9f31826
https://github.com/trivikr
https://github.com/aduh95
ffi: do not abort when a Worker stops in a callbackhttps://github.com/nodejs/node/commit/9f318266569d57ee0591bd41d3c12d1cc7a0779f
9f31826https://github.com/nodejs/node/commit/9f318266569d57ee0591bd41d3c12d1cc7a0779f
#66389https://github.com/nodejs/node/pull/66389
#66388https://github.com/nodejs/node/issues/66388
aduh95https://github.com/aduh95
Oct 3, 2026 https://github.com/nodejs/node/pull/66389#ref-commit-c65a333
https://github.com/trivikr
https://github.com/aduh95
ffi: do not abort when a Worker stops in a callbackhttps://github.com/nodejs/node/commit/c65a33364822eca4915c66dea488a45f125bd86a
c65a333https://github.com/nodejs/node/commit/c65a33364822eca4915c66dea488a45f125bd86a
#66389https://github.com/nodejs/node/pull/66389
#66388https://github.com/nodejs/node/issues/66388
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 5, 2026 https://github.com/nodejs/node/pull/66389#ref-pullrequest-5720654094
2026-10-07, Version 26.11.0 (Current) #66546 https://github.com/nodejs/node/pull/66546
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/66389#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
markhardinghttps://github.com/markharding
Nov 5, 2026 https://github.com/nodejs/node/pull/66389#ref-commit-609f23e
https://github.com/markharding
Update Node.js to v26 (#2168)https://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
609f23ehttps://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66389
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/66389/files/41e41258318991500d522e29b34b6bd955bd7781
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/66389/files/41e41258318991500d522e29b34b6bd955bd7781
https://github.com/daeyeon
daeyeon https://github.com/daeyeon
https://github.com/nodejs/node/pull/66389/files/41e41258318991500d522e29b34b6bd955bd7781
Please reload this pagehttps://github.com/nodejs/node/pull/66389
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
ffi: stopping a Worker while it is in a callback aborts the process https://github.com/nodejs/node/issues/66388
Please reload this pagehttps://github.com/nodejs/node/pull/66389
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/addaleax
https://github.com/daeyeon
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.