René's URL Explorer Experiment


Title: deps: V8: backport wasm wrapper lifetime fix by ThatKJ · Pull Request #66376 · nodejs/node · GitHub

Open Graph Title: deps: V8: backport wasm wrapper lifetime fix by ThatKJ · Pull Request #66376 · nodejs/node

X Title: deps: V8: backport wasm wrapper lifetime fix by ThatKJ · Pull Request #66376 · nodejs/node

Description: Backports the V8 fixes for the wasm import wrapper lifetime issue reported in #66366. This includes: V8 68210d500a — adds wrapper refcount checks V8 9b8ca54d5a — fixes lookup of wrappers already marked as is_dying The latter prevents a dying wrapper from being added to the current WasmCodeRefScope, avoiding the race that can lead to the jit_page_->allocations_.erase(addr) == 1 CHECK / crash. Both commits applied cleanly to v24.x-staging, and the v8_embedder_string was incremented for each backport. Local Node build completed successfully. Refs: #66366

Open Graph Description: Backports the V8 fixes for the wasm import wrapper lifetime issue reported in #66366. This includes: V8 68210d500a — adds wrapper refcount checks V8 9b8ca54d5a — fixes lookup of wrappers already m...

X Description: Backports the V8 fixes for the wasm import wrapper lifetime issue reported in #66366. This includes: V8 68210d500a — adds wrapper refcount checks V8 9b8ca54d5a — fixes lookup of wrappers already m...

Opengraph URL: https://github.com/nodejs/node/pull/66376

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:61168969-2224-2689-4672-6968346b580a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC494:7CA5D:76D323:9E0193:6AEDC4D0
html-safe-nonce1ec67d28ee72a751647aed26e9cccf3e3d07f0c0ebe3013038b709373676f82e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDk0OjdDQTVEOjc2RDMyMzo5RTAxOTM6NkFFREM0RDAiLCJ2aXNpdG9yX2lkIjoiMzMyNDQ3OTM2OTUxMjg2MjkyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9d73d321db44b41a75e5a095638f6600d6cb6007e71c641feefbfaf6470080fc
hovercard-subject-tagpull_request:4661723578
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f
twitter:imagehttps://avatars.githubusercontent.com/u/94427416?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/94427416?s=400&v=4
og:image:altBackports the V8 fixes for the wasm import wrapper lifetime issue reported in #66366. This includes: V8 68210d500a — adds wrapper refcount checks V8 9b8ca54d5a — fixes lookup of wrappers already m...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec7d2f3ac4f4f560c56267b765892ba5b093e8a5fb2c0ed937edd8947746942e9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0cac2d0cb993b0ad48c49b076135ac558c742c30
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66376%2Fcommits%2F0385bee44f3d7c31a1523394d5a324f101bd7b7f
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66376%2Fcommits%2F0385bee44f3d7c31a1523394d5a324f101bd7b7f
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f
Reloadhttps://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f
Reloadhttps://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests663 (663)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
ThatKJhttps://github.com/ThatKJ
nodejs:v24.x-staginghttps://github.com/nodejs/node/tree/v24.x-staging
ThatKJ:fix-v24-wasm-wrapperhttps://github.com/ThatKJ/node/tree/fix-v24-wasm-wrapper
Conversation 4 https://github.com/nodejs/node/pull/66376
Commits 2 https://github.com/nodejs/node/pull/66376/commits
Checks 17 https://github.com/nodejs/node/pull/66376/checks
Files changed 5 https://github.com/nodejs/node/pull/66376/files
deps: V8: backport wasm wrapper lifetime fix https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#top
Show all changes 2 commits https://github.com/nodejs/node/pull/66376/files
8750f45 deps: V8: cherry-pick 68210d500a ThatKJ Sep 28, 2026 https://github.com/nodejs/node/pull/66376/commits/8750f45fe7f69c8d87cef9589a2bb0bbddc921d3
0385bee deps: V8: cherry-pick 9b8ca54d5a ThatKJ Sep 28, 2026 https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f
Clear filters https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f
Please reload this pagehttps://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f
Please reload this pagehttps://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f
common.gypi https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
wasm-code-manager.cc https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-bfc9ca386ed271edf339f2551b18c6201cdb5cb7324bf22904e7809504760e6c
wasm-code-manager.h https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
wasm-import-wrapper-cache.cc https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-0573461ae073992237c25491e2880c1558e786900bfcac78391cef14fb22465e
Prev https://github.com/nodejs/node/pull/66376/commits/8750f45fe7f69c8d87cef9589a2bb0bbddc921d3
https://chromium-review.googlesource.com/c/v8/v8/+/6450127https://chromium-review.googlesource.com/c/v8/v8/+/6450127
v8/v8@9b8ca54https://github.com/v8/v8/commit/9b8ca54d5a6b6c615eb7ad6d9e2bdca7f8cb1a81
Please reload this pagehttps://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f
https://github.com/ThatKJ
ThatKJhttps://github.com/nodejs/node/commits?author=ThatKJ
common.gypihttps://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
View file https://github.com/nodejs/node/blob/0385bee44f3d7c31a1523394d5a324f101bd7b7f/common.gypi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66376/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
deps/v8/src/wasm/wasm-code-manager.cchttps://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-bfc9ca386ed271edf339f2551b18c6201cdb5cb7324bf22904e7809504760e6c
View file https://github.com/nodejs/node/blob/0385bee44f3d7c31a1523394d5a324f101bd7b7f/deps/v8/src/wasm/wasm-code-manager.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66376/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-bfc9ca386ed271edf339f2551b18c6201cdb5cb7324bf22904e7809504760e6c
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-bfc9ca386ed271edf339f2551b18c6201cdb5cb7324bf22904e7809504760e6c
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-bfc9ca386ed271edf339f2551b18c6201cdb5cb7324bf22904e7809504760e6c
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-bfc9ca386ed271edf339f2551b18c6201cdb5cb7324bf22904e7809504760e6c
deps/v8/src/wasm/wasm-code-manager.hhttps://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
View file https://github.com/nodejs/node/blob/0385bee44f3d7c31a1523394d5a324f101bd7b7f/deps/v8/src/wasm/wasm-code-manager.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66376/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-9a2e11ca06b0b8d2e8af888bb4a151173ab53da9a2c1912191083de18b5c1b3b
deps/v8/src/wasm/wasm-import-wrapper-cache.cchttps://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-0573461ae073992237c25491e2880c1558e786900bfcac78391cef14fb22465e
View file https://github.com/nodejs/node/blob/0385bee44f3d7c31a1523394d5a324f101bd7b7f/deps/v8/src/wasm/wasm-import-wrapper-cache.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66376/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-0573461ae073992237c25491e2880c1558e786900bfcac78391cef14fb22465e
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-0573461ae073992237c25491e2880c1558e786900bfcac78391cef14fb22465e
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-0573461ae073992237c25491e2880c1558e786900bfcac78391cef14fb22465e
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-0573461ae073992237c25491e2880c1558e786900bfcac78391cef14fb22465e
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-0573461ae073992237c25491e2880c1558e786900bfcac78391cef14fb22465e
https://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f#diff-0573461ae073992237c25491e2880c1558e786900bfcac78391cef14fb22465e
Please reload this pagehttps://github.com/nodejs/node/pull/66376/commits/0385bee44f3d7c31a1523394d5a324f101bd7b7f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.