René's URL Explorer Experiment


Title: zlib: fix abort with decodeStrings: false by Cherry · Pull Request #66359 · nodejs/node · GitHub

Open Graph Title: zlib: fix abort with decodeStrings: false by Cherry · Pull Request #66359 · nodejs/node

X Title: zlib: fix abort with decodeStrings: false by Cherry · Pull Request #66359 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Passing decodeStrings: false to a zlib stream or async convenience method aborts the process as soon as a string is written: require('node:zlib').createGzip({ decodeStrings: false }).end(&#...

X Description: Passing decodeStrings: false to a zlib stream or async convenience method aborts the process as soon as a string is written: require('node:zlib').createGzip({ decodeStrings: false }...

Opengraph URL: https://github.com/nodejs/node/pull/66359

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e45c110c-2f1a-368f-d4f2-d49e4fdbc7c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEAEC:1463F:495C60:5F0538:6AED243B
html-safe-nonce8c9e155c90d40108120e9dc1f9f8bc59cb891c0dc88c08a9ce354556d92b6a00
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUVDOjE0NjNGOjQ5NUM2MDo1RjA1Mzg6NkFFRDI0M0IiLCJ2aXNpdG9yX2lkIjoiNzQ4NTc4NTQyNzgzNTQyOTk0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbc69d2765c906ed62922fdbd9d386e54666a4381eb30c32444370bfc69630351
hovercard-subject-tagpull_request:4656918307
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66359/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/49f7efcb492d2113fb04baaa31332756fb958e19a3497a7372d0bdeeced8d8d4/nodejs/node/pull/66359
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/49f7efcb492d2113fb04baaa31332756fb958e19a3497a7372d0bdeeced8d8d4/nodejs/node/pull/66359
og:image:altPassing decodeStrings: false to a zlib stream or async convenience method aborts the process as soon as a string is written: require('node:zlib').createGzip({ decodeStrings: false }).end(&#...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCherry
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66359#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66359
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66359
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66359
Reloadhttps://github.com/nodejs/node/pull/66359
Reloadhttps://github.com/nodejs/node/pull/66359
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
Cherry:zlib-force-decode-stringshttps://github.com/Cherry/node/tree/zlib-force-decode-strings
Conversationhttps://github.com/nodejs/node/pull/66359
Commits1 (1)https://github.com/nodejs/node/pull/66359/commits
Checkshttps://github.com/nodejs/node/pull/66359/checks
Files changedhttps://github.com/nodejs/node/pull/66359/files
zlib: fix abort with decodeStrings: falsehttps://github.com/nodejs/node/pull/66359#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
Cherry:zlib-force-decode-stringshttps://github.com/Cherry/node/tree/zlib-force-decode-strings
https://github.com/Cherry
Cherryhttps://github.com/Cherry
Sep 27, 2026https://github.com/nodejs/node/pull/66359#issue-5606469910
#66358https://github.com/nodejs/node/pull/66358
Please reload this pagehttps://github.com/nodejs/node/pull/66359
https://github.com/Cherry
zlib: fix abort with decodeStrings: falsehttps://github.com/nodejs/node/pull/66359/commits/eb735f8979c579c85d5ca8fd9450cbf3f6c68739
eb735f8https://github.com/nodejs/node/pull/66359/commits/eb735f8979c579c85d5ca8fd9450cbf3f6c68739
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
zlib https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib
Sep 27, 2026https://github.com/nodejs/node/pull/66359#event-31948449831
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 27, 2026https://github.com/nodejs/node/pull/66359#issuecomment-5860755848
Please reload this pagehttps://github.com/nodejs/node/pull/66359
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66359?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
37d5c80https://app.codecov.io/gh/nodejs/node/commit/37d5c80f97cd8104b5dafc35f6e1646cc8d39673?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
eb735f8https://app.codecov.io/gh/nodejs/node/commit/eb735f8979c579c85d5ca8fd9450cbf3f6c68739?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66359?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/zlib.jshttps://app.codecov.io/gh/nodejs/node/pull/66359?src=pr&el=tree&filepath=lib%2Fzlib.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL3psaWIuanM=
28 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66359/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66359
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 28, 2026 https://github.com/nodejs/node/pull/66359#pullrequestreview-5335668169
View reviewed changes https://github.com/nodejs/node/pull/66359/files/eb735f8979c579c85d5ca8fd9450cbf3f6c68739
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 28, 2026https://github.com/nodejs/node/pull/66359#event-31974273259
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 28, 2026https://github.com/nodejs/node/pull/66359#event-31976002868
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 28, 2026https://github.com/nodejs/node/pull/66359#issuecomment-5866427984
https://ci.nodejs.org/job/node-test-pull-request/78028/https://ci.nodejs.org/job/node-test-pull-request/78028/
Please reload this pagehttps://github.com/nodejs/node/pull/66359
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 28, 2026 https://github.com/nodejs/node/pull/66359#pullrequestreview-5343670915
View reviewed changes https://github.com/nodejs/node/pull/66359/files/eb735f8979c579c85d5ca8fd9450cbf3f6c68739
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 29, 2026https://github.com/nodejs/node/pull/66359#issuecomment-5882565762
https://ci.nodejs.org/job/node-test-pull-request/78068/https://ci.nodejs.org/job/node-test-pull-request/78068/
Please reload this pagehttps://github.com/nodejs/node/pull/66359
https://github.com/H4ad
H4adhttps://github.com/H4ad
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 29, 2026https://github.com/nodejs/node/pull/66359#event-32113335320
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
b42c0cchttps://github.com/nodejs/node/commit/b42c0ccfa3bfd8800c432080a166b49c5c166206
Sep 29, 2026https://github.com/nodejs/node/pull/66359#event-32117006801
Please reload this pagehttps://github.com/nodejs/node/pull/66359
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 29, 2026https://github.com/nodejs/node/pull/66359#issuecomment-5899635903
b42c0cchttps://github.com/nodejs/node/commit/b42c0ccfa3bfd8800c432080a166b49c5c166206
Please reload this pagehttps://github.com/nodejs/node/pull/66359
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 29, 2026https://github.com/nodejs/node/pull/66359#event-32117010625
https://github.com/robobun
robobunhttps://github.com/robobun
Sep 30, 2026 https://github.com/nodejs/node/pull/66359#ref-pullrequest-5641682034
node:zlib: zstdCompress keeps an explicit pledgedSrcSize and pledges only an exact input size oven-sh/bun#44283 https://github.com/oven-sh/bun/pull/44283
aduh95https://github.com/aduh95
Oct 3, 2026 https://github.com/nodejs/node/pull/66359#ref-commit-bb3d33e
https://github.com/Cherry
https://github.com/aduh95
zlib: fix abort with decodeStrings: falsehttps://github.com/nodejs/node/commit/bb3d33e610861dd0cb917f97da6b2d3b799bb5c1
bb3d33ehttps://github.com/nodejs/node/commit/bb3d33e610861dd0cb917f97da6b2d3b799bb5c1
#66359https://github.com/nodejs/node/pull/66359
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 5, 2026 https://github.com/nodejs/node/pull/66359#ref-pullrequest-5720654094
2026-10-07, Version 26.11.0 (Current) #66546 https://github.com/nodejs/node/pull/66546
aduh95https://github.com/aduh95
Oct 23, 2026 https://github.com/nodejs/node/pull/66359#ref-commit-d084008
https://github.com/Cherry
https://github.com/aduh95
zlib: fix abort with decodeStrings: falsehttps://github.com/nodejs/node/commit/d0840085a8951964640c344a3b5a027cbc4e1c3c
d084008https://github.com/nodejs/node/commit/d0840085a8951964640c344a3b5a027cbc4e1c3c
#66359https://github.com/nodejs/node/pull/66359
node:zlib: zstd pledgedSrcSize and dictionary follow Node v26.12.1 oven-sh/bun#47027 https://github.com/oven-sh/bun/pull/47027
node:zlib: force decodeStrings back to true in ZlibBase oven-sh/bun#47140 https://github.com/oven-sh/bun/pull/47140
aduh95https://github.com/aduh95
Oct 28, 2026 https://github.com/nodejs/node/pull/66359#ref-commit-90747d4
https://github.com/Cherry
https://github.com/aduh95
zlib: fix abort with decodeStrings: falsehttps://github.com/nodejs/node/commit/90747d4a7aa6429d1078dfdd4aac56fb369b7586
90747d4https://github.com/nodejs/node/commit/90747d4a7aa6429d1078dfdd4aac56fb369b7586
#66359https://github.com/nodejs/node/pull/66359
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/66359#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66359
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/66359/files/eb735f8979c579c85d5ca8fd9450cbf3f6c68739
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/66359/files/eb735f8979c579c85d5ca8fd9450cbf3f6c68739
Please reload this pagehttps://github.com/nodejs/node/pull/66359
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
zlib https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib
Please reload this pagehttps://github.com/nodejs/node/pull/66359
https://github.com/Cherry
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/lpinca
https://github.com/H4ad
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.