René's URL Explorer Experiment


Title: vfs: keep open memory handles in sync with file by trivikr · Pull Request #66356 · nodejs/node · GitHub

Open Graph Title: vfs: keep open memory handles in sync with file by trivikr · Pull Request #66356 · nodejs/node

X Title: vfs: keep open memory handles in sync with file by trivikr · Pull Request #66356 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #66355 A MemoryFileHandle snapshotted the file's buffer at open and never checked the entry again. After the file changed through the provider or another handle, an open handle served st...

X Description: Fixes: #66355 A MemoryFileHandle snapshotted the file's buffer at open and never checked the entry again. After the file changed through the provider or another handle, an open handle serve...

Opengraph URL: https://github.com/nodejs/node/pull/66356

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:459f330a-fbbd-839b-4886-97e095b3ff01
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC096:26B7E0:6783A:83036:6B03357C
html-safe-nonce5ab9bc4e14aaedd2756382abddce887630368c581b1007a187b09e47a4708ad4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDk2OjI2QjdFMDo2NzgzQTo4MzAzNjo2QjAzMzU3QyIsInZpc2l0b3JfaWQiOiI3MjU3ODY5NTY1MTg1NzAxMjQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacaa6dc00e8cee4e24838bb3dbea346add5cd8c8426e9acaccbebe9424a8587d99
hovercard-subject-tagpull_request:4655733453
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66356/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d213ee44c5138f4658687482c2f2b5cbaff1838a5fdc2596f758f7dbf9c6c224/nodejs/node/pull/66356
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d213ee44c5138f4658687482c2f2b5cbaff1838a5fdc2596f758f7dbf9c6c224/nodejs/node/pull/66356
og:image:altFixes: #66355 A MemoryFileHandle snapshotted the file's buffer at open and never checked the entry again. After the file changed through the provider or another handle, an open handle served st...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66356#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66356
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66356
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66356
Reloadhttps://github.com/nodejs/node/pull/66356
Reloadhttps://github.com/nodejs/node/pull/66356
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests669 (669)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:vfs-stale-content-open-handleshttps://github.com/trivikr/node/tree/vfs-stale-content-open-handles
Conversationhttps://github.com/nodejs/node/pull/66356
Commits1 (1)https://github.com/nodejs/node/pull/66356/commits
Checkshttps://github.com/nodejs/node/pull/66356/checks
Files changedhttps://github.com/nodejs/node/pull/66356/files
vfs: keep open memory handles in sync with filehttps://github.com/nodejs/node/pull/66356#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:vfs-stale-content-open-handleshttps://github.com/trivikr/node/tree/vfs-stale-content-open-handles
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 27, 2026https://github.com/nodejs/node/pull/66356#issue-5604999080
#66355https://github.com/nodejs/node/issues/66355
Please reload this pagehttps://github.com/nodejs/node/pull/66356
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vfs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avfs
Sep 27, 2026https://github.com/nodejs/node/pull/66356#event-31941455536
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 27, 2026https://github.com/nodejs/node/pull/66356#issuecomment-5859230435
Please reload this pagehttps://github.com/nodejs/node/pull/66356
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66356?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
06550c7https://app.codecov.io/gh/nodejs/node/commit/06550c777f950aca2d53550fbf120fe94be846d1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
6dcd3dfhttps://app.codecov.io/gh/nodejs/node/commit/6dcd3df67f532d9dec4716a9a062d0b786daf427?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66356?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/vfs/file_handle.jshttps://app.codecov.io/gh/nodejs/node/pull/66356?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Ffile_handle.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy9maWxlX2hhbmRsZS5qcw==
26 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66356/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66356
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66356
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66356
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66356
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 28, 2026https://github.com/nodejs/node/pull/66356#issuecomment-5864436329
https://ci.nodejs.org/job/node-test-pull-request/78018/https://ci.nodejs.org/job/node-test-pull-request/78018/
Please reload this pagehttps://github.com/nodejs/node/pull/66356
https://github.com/trivikr
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66356
https://github.com/trivikr
trivikrhttps://github.com/trivikr
September 29, 2026 16:58https://github.com/nodejs/node/pull/66356#event-32098444427
https://github.com/pipobscure
pipobscurehttps://github.com/pipobscure
Oct 16, 2026https://github.com/nodejs/node/pull/66356#issuecomment-6223587994
#66318https://github.com/nodejs/node/pull/66318
Please reload this pagehttps://github.com/nodejs/node/pull/66356
https://github.com/pipobscure
pipobscurehttps://github.com/pipobscure
Oct 16, 2026 https://github.com/nodejs/node/pull/66356#pullrequestreview-5553018135
View reviewed changes https://github.com/nodejs/node/pull/66356/files
pipobscurehttps://github.com/pipobscure
https://github.com/nodejs/node/pull/66356#pullrequestreview-5553018135
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66356
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/c37b2119b5a4fee5ae82f4e974dc5add07008e70..8dae54c3fca85c5d1d48237dce2b66a5b2bde956
c37b211https://github.com/nodejs/node/commit/c37b2119b5a4fee5ae82f4e974dc5add07008e70
8dae54chttps://github.com/nodejs/node/commit/8dae54c3fca85c5d1d48237dce2b66a5b2bde956
Compare https://github.com/nodejs/node/compare/c37b2119b5a4fee5ae82f4e974dc5add07008e70..8dae54c3fca85c5d1d48237dce2b66a5b2bde956
October 18, 2026 23:20https://github.com/nodejs/node/pull/66356#event-33597572171
https://github.com/trivikr
trivikrhttps://github.com/trivikr
October 18, 2026 23:20https://github.com/nodejs/node/pull/66356#event-33597577527
https://github.com/trivikr
trivikrhttps://github.com/trivikr
mcollinahttps://github.com/mcollina
October 19, 2026 01:15https://github.com/nodejs/node/pull/66356#event-33602021637
https://github.com/trivikr
vfs: keep open memory handles in sync with filehttps://github.com/nodejs/node/pull/66356/commits/6dcd3df67f532d9dec4716a9a062d0b786daf427
6dcd3dfhttps://github.com/nodejs/node/pull/66356/commits/6dcd3df67f532d9dec4716a9a062d0b786daf427
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/8dae54c3fca85c5d1d48237dce2b66a5b2bde956..6dcd3df67f532d9dec4716a9a062d0b786daf427
8dae54chttps://github.com/nodejs/node/commit/8dae54c3fca85c5d1d48237dce2b66a5b2bde956
6dcd3dfhttps://github.com/nodejs/node/commit/6dcd3df67f532d9dec4716a9a062d0b786daf427
Compare https://github.com/nodejs/node/compare/8dae54c3fca85c5d1d48237dce2b66a5b2bde956..6dcd3df67f532d9dec4716a9a062d0b786daf427
October 19, 2026 02:21https://github.com/nodejs/node/pull/66356#event-33604813626
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 20, 2026https://github.com/nodejs/node/pull/66356#issuecomment-6281077362
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/66356
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 22, 2026 https://github.com/nodejs/node/pull/66356#pullrequestreview-5607896036
View reviewed changes https://github.com/nodejs/node/pull/66356/files/6dcd3df67f532d9dec4716a9a062d0b786daf427
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/66356#pullrequestreview-5607896036
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66356
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 22, 2026https://github.com/nodejs/node/pull/66356#event-33903605974
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 22, 2026https://github.com/nodejs/node/pull/66356#event-33904990465
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66356
https://github.com/trivikr
trivikrhttps://github.com/trivikr
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Oct 22, 2026https://github.com/nodejs/node/pull/66356#event-33910307684
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Oct 22, 2026https://github.com/nodejs/node/pull/66356#event-33910855645
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 22, 2026https://github.com/nodejs/node/pull/66356#issuecomment-6331900289
https://ci.nodejs.org/job/node-test-pull-request/78560/https://ci.nodejs.org/job/node-test-pull-request/78560/
Please reload this pagehttps://github.com/nodejs/node/pull/66356
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 22, 2026https://github.com/nodejs/node/pull/66356#event-33996055150
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
44d5d57https://github.com/nodejs/node/commit/44d5d57ad261f63eae6c4b1bd9b0c23edc231c9d
Oct 22, 2026https://github.com/nodejs/node/pull/66356#event-33996923564
Please reload this pagehttps://github.com/nodejs/node/pull/66356
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 22, 2026https://github.com/nodejs/node/pull/66356#issuecomment-6352071384
44d5d57https://github.com/nodejs/node/commit/44d5d57ad261f63eae6c4b1bd9b0c23edc231c9d
Please reload this pagehttps://github.com/nodejs/node/pull/66356
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 22, 2026https://github.com/nodejs/node/pull/66356#event-33996927684
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 27, 2026 https://github.com/nodejs/node/pull/66356#ref-pullrequest-6061836167
2026-10-28, Version 27.0.0-alpha.0.0.0 (Alpha) #67062 https://github.com/nodejs/node/pull/67062
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66356#ref-commit-fc5d0b3
https://github.com/trivikr
https://github.com/aduh95
vfs: keep open memory handles in sync with filehttps://github.com/nodejs/node/commit/fc5d0b3aeceff423fdd2601478e162c0bb4df1df
fc5d0b3https://github.com/nodejs/node/commit/fc5d0b3aeceff423fdd2601478e162c0bb4df1df
#66356https://github.com/nodejs/node/pull/66356
#66355https://github.com/nodejs/node/issues/66355
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 20, 2026 https://github.com/nodejs/node/pull/66356#ref-pullrequest-6515931870
2026-11-30, Version 26.14.0 'Lithium' (LTS) #67664 https://github.com/nodejs/node/pull/67664
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66356
https://github.com/pipobscure
pipobscure https://github.com/pipobscure
https://github.com/nodejs/node/pull/66356/files/e1adb4c782da463f0c725bb198098c98443e2786
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/66356/files/6dcd3df67f532d9dec4716a9a062d0b786daf427
Please reload this pagehttps://github.com/nodejs/node/pull/66356
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vfs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avfs
vfs: memory provider serves stale content and size to already-open handles https://github.com/nodejs/node/issues/66355
Please reload this pagehttps://github.com/nodejs/node/pull/66356
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/pipobscure
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.