René's URL Explorer Experiment


Title: vfs: fix readlink, realpath and mkdtemp encoding by christianaurichzm · Pull Request #66352 · nodejs/node · GitHub

Open Graph Title: vfs: fix readlink, realpath and mkdtemp encoding by christianaurichzm · Pull Request #66352 · nodejs/node

X Title: vfs: fix readlink, realpath and mkdtemp encoding by christianaurichzm · Pull Request #66352 · nodejs/node

Description: On a mounted VFS, readlink(), realpath() and mkdtemp() only honor { encoding: 'buffer' }. The string form 'buffer' and other encodings like 'hex' are ignored, and so is a Buffer mkdtemp() prefix: const fs = require('node:fs'); const path = require('node:path'); const vfs = require('node:vfs'); const myVfs = vfs.create(); myVfs.writeFileSync('/file.txt', 'x'); myVfs.symlinkSync('file.txt', '/link'); const link = path.join(myVfs.mount(), 'link'); fs.readlinkSync(link, 'buffer'); // 'file.txt' instead of a Buffer fs.readlinkSync(link, 'hex'); // 'file.txt' instead of '66696c652e747874' With RealFSProvider the options are passed on to the host fs, so readlink() with 'buffer' throws ERR_INVALID_ARG_TYPE and myVfs.realpathSync(p, 'hex') fails with EACCES. The VirtualFileSystem readlink and realpath methods now get a string from the provider and apply the encoding with getOptions() and encodeRealpathResult(), as fs does. The helper moves from lib/fs.js to internal/fs/utils. The mkdtemp hooks do the same, which replaces the per-hook Buffer conversions for these methods in setup.js. Since the VFS works with string paths, a RealFSProvider link target that isn't valid UTF-8 won't keep its bytes with 'buffer'. readdir() has a similar gap, which I'll leave for a separate PR. The new test covers the sync, callback and promise variants on a memory and a real mount, and fails on main. The test-vfs-* tests and the fs realpath/readlink/mkdtemp tests pass on x64 Linux.

Open Graph Description: On a mounted VFS, readlink(), realpath() and mkdtemp() only honor { encoding: 'buffer' }. The string form 'buffer' and other encodings like 'hex' are ignored, and so is a Bu...

X Description: On a mounted VFS, readlink(), realpath() and mkdtemp() only honor { encoding: 'buffer' }. The string form 'buffer' and other encodings like 'hex' are...

Opengraph URL: https://github.com/nodejs/node/pull/66352

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:37056e68-fdcd-81af-0d4a-d58433088c28
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC83C:2526B:182799:1E8297:6B033A98
html-safe-nonce4b45ae2d65405ecaa016f13404aba77aac1e1dba4e715e649e309074825a6cb1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODNDOjI1MjZCOjE4Mjc5OToxRTgyOTc6NkIwMzNBOTgiLCJ2aXNpdG9yX2lkIjoiMjQ0NjAzMDQ5ODczNzM3MTgwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb6759c06e2d35e69efc5e884776924ad8eeeb988868319e25b231def532bd5c7
hovercard-subject-tagpull_request:4655180556
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/66352/files
twitter:imagehttps://avatars.githubusercontent.com/u/36874062?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/36874062?s=400&v=4
og:image:altOn a mounted VFS, readlink(), realpath() and mkdtemp() only honor { encoding: 'buffer' }. The string form 'buffer' and other encodings like 'hex' are ignored, and so is a Bu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66352/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66352%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66352%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66352/files
Reloadhttps://github.com/nodejs/node/pull/66352/files
Reloadhttps://github.com/nodejs/node/pull/66352/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
christianaurichzm:vfs-path-encodinghttps://github.com/christianaurichzm/node/tree/vfs-path-encoding
Conversation 8 https://github.com/nodejs/node/pull/66352
Commits 1 https://github.com/nodejs/node/pull/66352/commits
Checks 43 https://github.com/nodejs/node/pull/66352/checks
Files changed https://github.com/nodejs/node/pull/66352/files
Please reload this pagehttps://github.com/nodejs/node/pull/66352/files
vfs: fix readlink, realpath and mkdtemp encoding https://github.com/nodejs/node/pull/66352/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/66352/files
5b7bfe0 vfs: fix readlink, realpath and mkdtemp encoding christianaurichzm Sep 27, 2026 https://github.com/nodejs/node/pull/66352/commits/5b7bfe0d89cdab3c84e216898b9ca0d3e27cd28d
Clear filters https://github.com/nodejs/node/pull/66352/files
Please reload this pagehttps://github.com/nodejs/node/pull/66352/files
Please reload this pagehttps://github.com/nodejs/node/pull/66352/files
fs.js https://github.com/nodejs/node/pull/66352/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
utils.js https://github.com/nodejs/node/pull/66352/files#diff-5cd422a9a64bc2c1275d70ba5dcafbc5ea55274432fffc5e4159126007dc4894
file_system.js https://github.com/nodejs/node/pull/66352/files#diff-3ba5ef10cbcba7ede0214d14e30bdfcc197823db418719edddbe2ad70bf6c1d2
setup.js https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
test-vfs-path-encoding.js https://github.com/nodejs/node/pull/66352/files#diff-2a57e16fcb14ab5f84143da45bcd2dff45748909ee69bbad0c26ac92c8839440
lib/fs.jshttps://github.com/nodejs/node/pull/66352/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
View file https://github.com/christianaurichzm/node/blob/5b7bfe0d89cdab3c84e216898b9ca0d3e27cd28d/lib/fs.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66352/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66352/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
https://github.com/nodejs/node/pull/66352/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
https://github.com/nodejs/node/pull/66352/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
https://github.com/nodejs/node/pull/66352/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
lib/internal/fs/utils.jshttps://github.com/nodejs/node/pull/66352/files#diff-5cd422a9a64bc2c1275d70ba5dcafbc5ea55274432fffc5e4159126007dc4894
View file https://github.com/christianaurichzm/node/blob/5b7bfe0d89cdab3c84e216898b9ca0d3e27cd28d/lib/internal/fs/utils.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66352/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66352/files#diff-5cd422a9a64bc2c1275d70ba5dcafbc5ea55274432fffc5e4159126007dc4894
https://github.com/nodejs/node/pull/66352/files#diff-5cd422a9a64bc2c1275d70ba5dcafbc5ea55274432fffc5e4159126007dc4894
https://github.com/nodejs/node/pull/66352/files#diff-5cd422a9a64bc2c1275d70ba5dcafbc5ea55274432fffc5e4159126007dc4894
https://github.com/nodejs/node/pull/66352/files#diff-5cd422a9a64bc2c1275d70ba5dcafbc5ea55274432fffc5e4159126007dc4894
lib/internal/vfs/file_system.jshttps://github.com/nodejs/node/pull/66352/files#diff-3ba5ef10cbcba7ede0214d14e30bdfcc197823db418719edddbe2ad70bf6c1d2
View file https://github.com/christianaurichzm/node/blob/5b7bfe0d89cdab3c84e216898b9ca0d3e27cd28d/lib/internal/vfs/file_system.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66352/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66352/files#diff-3ba5ef10cbcba7ede0214d14e30bdfcc197823db418719edddbe2ad70bf6c1d2
https://github.com/nodejs/node/pull/66352/files#diff-3ba5ef10cbcba7ede0214d14e30bdfcc197823db418719edddbe2ad70bf6c1d2
https://github.com/nodejs/node/pull/66352/files#diff-3ba5ef10cbcba7ede0214d14e30bdfcc197823db418719edddbe2ad70bf6c1d2
https://github.com/nodejs/node/pull/66352/files#diff-3ba5ef10cbcba7ede0214d14e30bdfcc197823db418719edddbe2ad70bf6c1d2
https://github.com/nodejs/node/pull/66352/files#diff-3ba5ef10cbcba7ede0214d14e30bdfcc197823db418719edddbe2ad70bf6c1d2
https://github.com/nodejs/node/pull/66352/files#diff-3ba5ef10cbcba7ede0214d14e30bdfcc197823db418719edddbe2ad70bf6c1d2
https://github.com/nodejs/node/pull/66352/files#diff-3ba5ef10cbcba7ede0214d14e30bdfcc197823db418719edddbe2ad70bf6c1d2
https://github.com/nodejs/node/pull/66352/files#diff-3ba5ef10cbcba7ede0214d14e30bdfcc197823db418719edddbe2ad70bf6c1d2
lib/internal/vfs/setup.jshttps://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
View file https://github.com/christianaurichzm/node/blob/5b7bfe0d89cdab3c84e216898b9ca0d3e27cd28d/lib/internal/vfs/setup.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66352/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
https://github.com/nodejs/node/pull/66352/files#diff-bc3544906ec444604ce87d73671d8f666180e64f634707d210317601b75c184f
test/parallel/test-vfs-path-encoding.jshttps://github.com/nodejs/node/pull/66352/files#diff-2a57e16fcb14ab5f84143da45bcd2dff45748909ee69bbad0c26ac92c8839440
View file https://github.com/christianaurichzm/node/blob/5b7bfe0d89cdab3c84e216898b9ca0d3e27cd28d/test/parallel/test-vfs-path-encoding.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66352/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/66352/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.