René's URL Explorer Experiment


Title: src: do not shrink async resources on every pop by nigrosimone · Pull Request #66344 · nodejs/node · GitHub

Open Graph Title: src: do not shrink async resources on every pop by nigrosimone · Pull Request #66344 · nodejs/node

X Title: src: do not shrink async resources on every pop by nigrosimone · Pull Request #66344 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: AsyncHooks::pop_async_context() calls shrink_to_fit() on native_execution_async_resources_ after every pop. With the MSVC and libc++ standard libraries, shrink_to_fit() on an empty std::deque frees...

X Description: AsyncHooks::pop_async_context() calls shrink_to_fit() on native_execution_async_resources_ after every pop. With the MSVC and libc++ standard libraries, shrink_to_fit() on an empty std::deque frees...

Opengraph URL: https://github.com/nodejs/node/pull/66344

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2b857a53-2bb4-40a4-7e42-da84d91833dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB0D6:20C6D9:4DCFFD:67CD3B:6AED1864
html-safe-nonceed9cee172c25856fcea9fbf33b6fcd5ed64920cf41169865c28ba6f6c684baa9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEQ2OjIwQzZEOTo0RENGRkQ6NjdDRDNCOjZBRUQxODY0IiwidmlzaXRvcl9pZCI6IjI1ODM2MTE0NDM4MjY3MjcwMTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc0272d49dc4149fa3422b685b7c340ce9044f1f995d93d4bbd46edb8c5d1b410
hovercard-subject-tagpull_request:4652698875
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66344/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5e5ab0ba2f5d7a73721accc0b4360601cc07b369fefc16a0b0a0ac44f829d4e5/nodejs/node/pull/66344
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5e5ab0ba2f5d7a73721accc0b4360601cc07b369fefc16a0b0a0ac44f829d4e5/nodejs/node/pull/66344
og:image:altAsyncHooks::pop_async_context() calls shrink_to_fit() on native_execution_async_resources_ after every pop. With the MSVC and libc++ standard libraries, shrink_to_fit() on an empty std::deque frees...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenigrosimone
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66344#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66344
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66344
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66344
Reloadhttps://github.com/nodejs/node/pull/66344
Reloadhttps://github.com/nodejs/node/pull/66344
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nigrosimonehttps://github.com/nigrosimone
nodejs:mainhttps://github.com/nodejs/node/tree/main
nigrosimone:async-resources-no-shrinkhttps://github.com/nigrosimone/node/tree/async-resources-no-shrink
Conversationhttps://github.com/nodejs/node/pull/66344
Commits1 (1)https://github.com/nodejs/node/pull/66344/commits
Checkshttps://github.com/nodejs/node/pull/66344/checks
Files changedhttps://github.com/nodejs/node/pull/66344/files
src: do not shrink async resources on every pophttps://github.com/nodejs/node/pull/66344#top
nigrosimonehttps://github.com/nigrosimone
nodejs:mainhttps://github.com/nodejs/node/tree/main
nigrosimone:async-resources-no-shrinkhttps://github.com/nigrosimone/node/tree/async-resources-no-shrink
https://github.com/nigrosimone
nigrosimonehttps://github.com/nigrosimone
Sep 27, 2026https://github.com/nodejs/node/pull/66344#issue-5601177894
Please reload this pagehttps://github.com/nodejs/node/pull/66344
#56457https://github.com/nodejs/node/pull/56457
#66316https://github.com/nodejs/node/pull/66316
nodejs/performance#24https://github.com/nodejs/performance/issues/24
Please reload this pagehttps://github.com/nodejs/node/pull/66344
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 27, 2026https://github.com/nodejs/node/pull/66344#event-31924096855
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 27, 2026https://github.com/nodejs/node/pull/66344#issuecomment-5854272620
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
contribution and automation policieshttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
pull request guidehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
Code of Conducthttps://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
signed offhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#step-4-commit
Please reload this pagehttps://github.com/nodejs/node/pull/66344
https://github.com/nigrosimone
nigrosimonehttps://github.com/nigrosimone
September 29, 2026 07:06https://github.com/nodejs/node/pull/66344#event-32057393030
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 29, 2026https://github.com/nodejs/node/pull/66344#issuecomment-5886947371
Please reload this pagehttps://github.com/nodejs/node/pull/66344
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66344?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
3e5c8afhttps://app.codecov.io/gh/nodejs/node/commit/3e5c8afba6dcff91d46b8204276d62e3843b23b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
a979326https://app.codecov.io/gh/nodejs/node/commit/a979326cadfd873d879a331a972f858fa76a4222?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66344?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/env.cchttps://app.codecov.io/gh/nodejs/node/pull/66344?src=pr&el=tree&filepath=src%2Fenv.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2Vudi5jYw==
501 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66344/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66344
https://github.com/nigrosimone
nigrosimonehttps://github.com/nigrosimone
Sep 29, 2026 https://github.com/nodejs/node/pull/66344#ref-issue-1457032793
MakeCallback is very slow nodejs/performance#24 https://github.com/nodejs/performance/issues/24
https://github.com/anonrig
anonrighttps://github.com/anonrig
Oct 4, 2026 https://github.com/nodejs/node/pull/66344#pullrequestreview-5406819940
View reviewed changes https://github.com/nodejs/node/pull/66344/files
https://github.com/anonrig
anonrighttps://github.com/anonrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 4, 2026https://github.com/nodejs/node/pull/66344#event-32448853509
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 4, 2026https://github.com/nodejs/node/pull/66344#event-32452322938
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 4, 2026https://github.com/nodejs/node/pull/66344#issuecomment-5982216213
https://ci.nodejs.org/job/node-test-pull-request/78166/https://ci.nodejs.org/job/node-test-pull-request/78166/
Please reload this pagehttps://github.com/nodejs/node/pull/66344
https://github.com/panva
panvahttps://github.com/panva
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Oct 5, 2026https://github.com/nodejs/node/pull/66344#event-32503942444
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Oct 5, 2026https://github.com/nodejs/node/pull/66344#event-32508955152
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 5, 2026https://github.com/nodejs/node/pull/66344#issuecomment-5994820426
https://ci.nodejs.org/job/node-test-pull-request/78180/https://ci.nodejs.org/job/node-test-pull-request/78180/
Please reload this pagehttps://github.com/nodejs/node/pull/66344
https://github.com/nigrosimone
nigrosimonehttps://github.com/nigrosimone
Oct 11, 2026 https://github.com/nodejs/node/pull/66344#ref-pullrequest-5596157690
src: keep ALS store in AsyncResource::MakeCallback #66326 https://github.com/nodejs/node/pull/66326
https://github.com/nigrosimone
nigrosimonehttps://github.com/nigrosimone
Oct 13, 2026https://github.com/nodejs/node/pull/66344#issuecomment-6151618468
@anonrighttps://github.com/anonrig
Please reload this pagehttps://github.com/nodejs/node/pull/66344
https://github.com/gurgunday
gurgundayhttps://github.com/gurgunday
Oct 16, 2026 https://github.com/nodejs/node/pull/66344#pullrequestreview-5551217676
View reviewed changes https://github.com/nodejs/node/pull/66344/files
gurgundayhttps://github.com/gurgunday
Please reload this pagehttps://github.com/nodejs/node/pull/66344
https://github.com/nodejs/node/pull/66344#pullrequestreview-5551217676
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66344
https://github.com/nigrosimone
src: do not shrink async resources on every pophttps://github.com/nodejs/node/pull/66344/commits/a979326cadfd873d879a331a972f858fa76a4222
a979326https://github.com/nodejs/node/pull/66344/commits/a979326cadfd873d879a331a972f858fa76a4222
nodejs/performance#24https://github.com/nodejs/performance/issues/24
https://github.com/nigrosimone
nigrosimonehttps://github.com/nigrosimone
force-pushedhttps://github.com/nodejs/node/compare/a3a1b3c024caff6b3d738fa04f47888ed863b181..a979326cadfd873d879a331a972f858fa76a4222
a3a1b3chttps://github.com/nodejs/node/commit/a3a1b3c024caff6b3d738fa04f47888ed863b181
a979326https://github.com/nodejs/node/commit/a979326cadfd873d879a331a972f858fa76a4222
Compare https://github.com/nodejs/node/compare/a3a1b3c024caff6b3d738fa04f47888ed863b181..a979326cadfd873d879a331a972f858fa76a4222
October 20, 2026 17:54https://github.com/nodejs/node/pull/66344#event-33769609424
https://github.com/nigrosimone
nigrosimonehttps://github.com/nigrosimone
Oct 20, 2026https://github.com/nodejs/node/pull/66344#issuecomment-6297999302
#66395https://github.com/nodejs/node/pull/66395
@anonrighttps://github.com/anonrig
@gurgundayhttps://github.com/gurgunday
Please reload this pagehttps://github.com/nodejs/node/pull/66344
https://github.com/inoway46
inoway46https://github.com/inoway46
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 2, 2026https://github.com/nodejs/node/pull/66344#event-34903518163
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66344
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/66344/files/a3a1b3c024caff6b3d738fa04f47888ed863b181
https://github.com/gurgunday
gurgunday https://github.com/gurgunday
https://github.com/nodejs/node/pull/66344/files/a3a1b3c024caff6b3d738fa04f47888ed863b181
Please reload this pagehttps://github.com/nodejs/node/pull/66344
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Please reload this pagehttps://github.com/nodejs/node/pull/66344
https://github.com/nigrosimone
https://github.com/nodejs-github-bot
https://github.com/anonrig
https://github.com/gurgunday
https://github.com/panva
https://github.com/inoway46
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.