René's URL Explorer Experiment


Title: fs: do not swallow exceptions thrown by completion callbacks by marcopiraccini · Pull Request #66308 · nodejs/node · GitHub

Open Graph Title: fs: do not swallow exceptions thrown by completion callbacks by marcopiraccini · Pull Request #66308 · nodejs/node

X Title: fs: do not swallow exceptions thrown by completion callbacks by marcopiraccini · Pull Request #66308 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Since #57706 the completion callbacks of fs.mkdtemp, fs.realpath.native, fs.readlink, fs.mkdir({ recursive }), fs.readdir({ recursive }) and dir.read() call into JS while the TryCatch meant for Str...

X Description: Since #57706 the completion callbacks of fs.mkdtemp, fs.realpath.native, fs.readlink, fs.mkdir({ recursive }), fs.readdir({ recursive }) and dir.read() call into JS while the TryCatch meant for Str...

Opengraph URL: https://github.com/nodejs/node/pull/66308

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ee0173b6-b258-a880-decb-f6366c6a7ce6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA6A:1A8D69:1E0A18:277455:6AED0CFF
html-safe-nonce092010911dced737ff045e420b1f5bc793ee015cb84d7bdc79411b77f287990f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTZBOjFBOEQ2OToxRTBBMTg6Mjc3NDU1OjZBRUQwQ0ZGIiwidmlzaXRvcl9pZCI6IjkwNDEzNjg1NDMxNjgxMDU3MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac57f34483c65bf20c797d56a44c851cb92e002d7a893dd9e4f141cf6080cbd2a3
hovercard-subject-tagpull_request:4644768079
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66308/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e62701e21ae044e5a0a091af20e3482417834d67d0e974f9c5f19e5981c193e8/nodejs/node/pull/66308
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e62701e21ae044e5a0a091af20e3482417834d67d0e974f9c5f19e5981c193e8/nodejs/node/pull/66308
og:image:altSince #57706 the completion callbacks of fs.mkdtemp, fs.realpath.native, fs.readlink, fs.mkdir({ recursive }), fs.readdir({ recursive }) and dir.read() call into JS while the TryCatch meant for Str...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemarcopiraccini
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66308#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66308
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66308
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66308
Reloadhttps://github.com/nodejs/node/pull/66308
Reloadhttps://github.com/nodejs/node/pull/66308
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
marcopiraccini:fs-trycatch-scopehttps://github.com/marcopiraccini/node/tree/fs-trycatch-scope
Conversationhttps://github.com/nodejs/node/pull/66308
Commits2 (2)https://github.com/nodejs/node/pull/66308/commits
Checkshttps://github.com/nodejs/node/pull/66308/checks
Files changedhttps://github.com/nodejs/node/pull/66308/files
fs: do not swallow exceptions thrown by completion callbackshttps://github.com/nodejs/node/pull/66308#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
marcopiraccini:fs-trycatch-scopehttps://github.com/marcopiraccini/node/tree/fs-trycatch-scope
https://github.com/marcopiraccini
marcopiraccinihttps://github.com/marcopiraccini
Sep 26, 2026https://github.com/nodejs/node/pull/66308#issue-5591111177
Please reload this pagehttps://github.com/nodejs/node/pull/66308
#57706https://github.com/nodejs/node/pull/57706
#65667https://github.com/nodejs/node/issues/65667
Please reload this pagehttps://github.com/nodejs/node/pull/66308
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 26, 2026https://github.com/nodejs/node/pull/66308#event-31877822786
https://github.com/marcopiraccini
marcopiraccinihttps://github.com/marcopiraccini
September 26, 2026 03:53https://github.com/nodejs/node/pull/66308#event-31878045738
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 26, 2026https://github.com/nodejs/node/pull/66308#issuecomment-5843689220
Please reload this pagehttps://github.com/nodejs/node/pull/66308
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66308?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
d630b5dhttps://app.codecov.io/gh/nodejs/node/commit/d630b5d88bc19c10443b3d83b723b7b052fa0c7f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
4e3d6b8https://app.codecov.io/gh/nodejs/node/commit/4e3d6b8ed6ca705a7a6ba7f12432d467d4a8e87c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66308?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_file-inl.hhttps://app.codecov.io/gh/nodejs/node/pull/66308?src=pr&el=tree&filepath=src%2Fnode_file-inl.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmlsZS1pbmwuaA==
0 Missing and 3 partials ⚠️ https://app.codecov.io/gh/nodejs/node/pull/66308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66308?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_dir.cchttps://app.codecov.io/gh/nodejs/node/pull/66308?src=pr&el=tree&filepath=src%2Fnode_dir.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZGlyLmNj
src/node_file.cchttps://app.codecov.io/gh/nodejs/node/pull/66308?src=pr&el=tree&filepath=src%2Fnode_file.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmlsZS5jYw==
src/node_file-inl.hhttps://app.codecov.io/gh/nodejs/node/pull/66308?src=pr&el=tree&filepath=src%2Fnode_file-inl.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmlsZS1pbmwuaA==
35 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66308/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66308
https://github.com/marcopiraccini
marcopiraccinihttps://github.com/marcopiraccini
force-pushedhttps://github.com/nodejs/node/compare/57b5139f04e17cfb87863e689b06844966841ab6..84f74cee954aa02164b74748ee26c5f0f70af016
57b5139https://github.com/nodejs/node/commit/57b5139f04e17cfb87863e689b06844966841ab6
84f74cehttps://github.com/nodejs/node/commit/84f74cee954aa02164b74748ee26c5f0f70af016
Compare https://github.com/nodejs/node/compare/57b5139f04e17cfb87863e689b06844966841ab6..84f74cee954aa02164b74748ee26c5f0f70af016
September 26, 2026 11:56https://github.com/nodejs/node/pull/66308#event-31890091202
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Sep 29, 2026 https://github.com/nodejs/node/pull/66308#pullrequestreview-5352537609
View reviewed changes https://github.com/nodejs/node/pull/66308/files
marcopiraccinihttps://github.com/marcopiraccini
October 26, 2026 12:41https://github.com/nodejs/node/pull/66308#commits-pushed-cd266d2
https://github.com/marcopiraccini
fs: do not swallow exceptions thrown by completion callbackshttps://github.com/nodejs/node/pull/66308/commits/cd266d27dd8083a66b623616ad4e5c8a75347404
cd266d2https://github.com/nodejs/node/pull/66308/commits/cd266d27dd8083a66b623616ad4e5c8a75347404
93644d5https://github.com/marcopiraccini/node/commit/93644d512694fd9f4a3b25f50c918fff455e42fd
nodejs#65667https://github.com/nodejs/node/issues/65667
nodejs#57706https://github.com/nodejs/node/pull/57706
https://github.com/marcopiraccini
fixup: test coveragehttps://github.com/nodejs/node/pull/66308/commits/4e3d6b8ed6ca705a7a6ba7f12432d467d4a8e87c
4e3d6b8https://github.com/nodejs/node/pull/66308/commits/4e3d6b8ed6ca705a7a6ba7f12432d467d4a8e87c
https://github.com/marcopiraccini
marcopiraccinihttps://github.com/marcopiraccini
force-pushedhttps://github.com/nodejs/node/compare/b1076883da8ced2118e66ece996d299d469ad412..4e3d6b8ed6ca705a7a6ba7f12432d467d4a8e87c
b107688https://github.com/nodejs/node/commit/b1076883da8ced2118e66ece996d299d469ad412
4e3d6b8https://github.com/nodejs/node/commit/4e3d6b8ed6ca705a7a6ba7f12432d467d4a8e87c
Compare https://github.com/nodejs/node/compare/b1076883da8ced2118e66ece996d299d469ad412..4e3d6b8ed6ca705a7a6ba7f12432d467d4a8e87c
October 26, 2026 11:51https://github.com/nodejs/node/pull/66308#event-34254668663
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Oct 26, 2026 https://github.com/nodejs/node/pull/66308#pullrequestreview-5653715048
View reviewed changes https://github.com/nodejs/node/pull/66308/files/4e3d6b8ed6ca705a7a6ba7f12432d467d4a8e87c
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 26, 2026https://github.com/nodejs/node/pull/66308#event-34269591024
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 26, 2026https://github.com/nodejs/node/pull/66308#event-34276909253
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 26, 2026https://github.com/nodejs/node/pull/66308#issuecomment-6420358568
https://ci.nodejs.org/job/node-test-pull-request/78668/https://ci.nodejs.org/job/node-test-pull-request/78668/
Please reload this pagehttps://github.com/nodejs/node/pull/66308
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Oct 29, 2026https://github.com/nodejs/node/pull/66308#event-34564795381
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c9f1d2dhttps://github.com/nodejs/node/commit/c9f1d2d31976eb04c69606074127724502abb4e9
Oct 29, 2026https://github.com/nodejs/node/pull/66308#event-34565342334
Please reload this pagehttps://github.com/nodejs/node/pull/66308
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 29, 2026https://github.com/nodejs/node/pull/66308#issuecomment-6492329097
c9f1d2dhttps://github.com/nodejs/node/commit/c9f1d2d31976eb04c69606074127724502abb4e9
Please reload this pagehttps://github.com/nodejs/node/pull/66308
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 29, 2026https://github.com/nodejs/node/pull/66308#event-34565348387
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66308
https://github.com/ShogunPanda
ShogunPanda https://github.com/ShogunPanda
https://github.com/nodejs/node/pull/66308/files/4e3d6b8ed6ca705a7a6ba7f12432d467d4a8e87c
Please reload this pagehttps://github.com/nodejs/node/pull/66308
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
node:test aborts in InternalCallbackScope::Close after listen EPERM https://github.com/nodejs/node/issues/65667
Please reload this pagehttps://github.com/nodejs/node/pull/66308
https://github.com/marcopiraccini
https://github.com/nodejs-github-bot
https://github.com/ShogunPanda
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.