| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:32ad20d3-ba1f-5c2c-78c4-8f35a0e2b980 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 938A:23A9CB:43FB00:5BFDCC:6AFBED66 |
| html-safe-nonce | abfe7b54da4645b7013fc7189f4faca329accb165cc8e6aad41bf6eaea143e4d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzhBOjIzQTlDQjo0M0ZCMDA6NUJGRENDOjZBRkJFRDY2IiwidmlzaXRvcl9pZCI6IjE3MTIwNTY0ODA4OTIxODU5NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 99f273e6ef8f6e2d1b225fd193adde4274bb85f66959ed7a732e74e48e131dbb |
| hovercard-subject-tag | pull_request:4620777824 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66254/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e962bb7d85be2f2d8514df7bedca5c39c4a7dfcf4863723f1e3d383b84d678e0/nodejs/node/pull/66254 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e962bb7d85be2f2d8514df7bedca5c39c4a7dfcf4863723f1e3d383b84d678e0/nodejs/node/pull/66254 |
| og:image:alt | Fixes: #66253
fs.promises.watch() over a virtual mount resolved the first next() with { done: true } when the signal was already aborted, while native fs.promises.watch() rejects with ABORT_ERR.
Bu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | trivikr |
| hostname | github.com |
| expected-hostname | github.com |
| None | fa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b3b5633a74535d9c23385512d534c66c8fde1907 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/66254#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66254 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66254 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/66254 |
| Reload | https://github.com/nodejs/node/pull/66254 |
| Reload | https://github.com/nodejs/node/pull/66254 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues644 (644) | https://github.com/nodejs/node/issues |
| Pull requests679 (679) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| trivikr:vfs-watch-reject-preaborted-signal | https://github.com/trivikr/node/tree/vfs-watch-reject-preaborted-signal |
| Conversation | https://github.com/nodejs/node/pull/66254 |
| Commits1 (1) | https://github.com/nodejs/node/pull/66254/commits |
| Checks | https://github.com/nodejs/node/pull/66254/checks |
| Files changed | https://github.com/nodejs/node/pull/66254/files |
| vfs: fix promises.watch() with an already-aborted signal | https://github.com/nodejs/node/pull/66254#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| trivikr:vfs-watch-reject-preaborted-signal | https://github.com/trivikr/node/tree/vfs-watch-reject-preaborted-signal |
|
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Sep 24, 2026 | https://github.com/nodejs/node/pull/66254#issue-5562094916 |
| #66253 | https://github.com/nodejs/node/issues/66253 |
| Please reload this page | https://github.com/nodejs/node/pull/66254 |
|
| https://github.com/trivikr |
| vfs: fix promises.watch() with an already-aborted signal | https://github.com/nodejs/node/pull/66254/commits/ebc1f19526310c93a2536c674b97780d36602d97 |
| ebc1f19 | https://github.com/nodejs/node/pull/66254/commits/ebc1f19526310c93a2536c674b97780d36602d97 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
vfs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avfs |
| Sep 24, 2026 | https://github.com/nodejs/node/pull/66254#event-31723633846 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 24, 2026 | https://github.com/nodejs/node/pull/66254#event-31724042072 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Sep 24, 2026 | https://github.com/nodejs/node/pull/66254#issuecomment-5807290426 |
| Please reload this page | https://github.com/nodejs/node/pull/66254 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/66254?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| a2c8da5 | https://app.codecov.io/gh/nodejs/node/commit/a2c8da59f2e319860985ff1275d66a6d16d611b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| ebc1f19 | https://app.codecov.io/gh/nodejs/node/commit/ebc1f19526310c93a2536c674b97780d36602d97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/66254?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/internal/vfs/watcher.js | https://app.codecov.io/gh/nodejs/node/pull/66254?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Fwatcher.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy93YXRjaGVyLmpz |
| 4 Missing ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/66254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/66254?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/internal/vfs/watcher.js | https://app.codecov.io/gh/nodejs/node/pull/66254?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Fwatcher.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy93YXRjaGVyLmpz |
| 25 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/66254/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/nodejs/node/pull/66254 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 27, 2026 | https://github.com/nodejs/node/pull/66254#event-31914679785 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 27, 2026 | https://github.com/nodejs/node/pull/66254#issuecomment-5851823718 |
| https://ci.nodejs.org/job/node-test-pull-request/77987/ | https://ci.nodejs.org/job/node-test-pull-request/77987/ |
| Please reload this page | https://github.com/nodejs/node/pull/66254 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| mcollina | https://github.com/mcollina |
| October 19, 2026 02:22 | https://github.com/nodejs/node/pull/66254#event-33604843391 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Oct 22, 2026 | https://github.com/nodejs/node/pull/66254#issuecomment-6352336473 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/66254 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Oct 22, 2026
| https://github.com/nodejs/node/pull/66254#pullrequestreview-5621482432 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/66254/files/ebc1f19526310c93a2536c674b97780d36602d97 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/66254#pullrequestreview-5621482432 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/66254 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Oct 22, 2026 | https://github.com/nodejs/node/pull/66254#event-33998318060 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 22, 2026 | https://github.com/nodejs/node/pull/66254#event-33998606337 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| fcb1aa8 | https://github.com/nodejs/node/commit/fcb1aa83f642290dd29f2876ceca0bc52bf90782 |
| Oct 22, 2026 | https://github.com/nodejs/node/pull/66254#event-33999417875 |
| Please reload this page | https://github.com/nodejs/node/pull/66254 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 22, 2026 | https://github.com/nodejs/node/pull/66254#issuecomment-6352690097 |
| fcb1aa8 | https://github.com/nodejs/node/commit/fcb1aa83f642290dd29f2876ceca0bc52bf90782 |
| Please reload this page | https://github.com/nodejs/node/pull/66254 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Oct 22, 2026 | https://github.com/nodejs/node/pull/66254#event-33999421538 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Oct 27, 2026
| https://github.com/nodejs/node/pull/66254#ref-pullrequest-6061836167 |
|
2026-10-28, Version 27.0.0-alpha.0.0.0 (Alpha)
#67062
| https://github.com/nodejs/node/pull/67062 |
| https://github.com/LiviaMedeiros |
| LiviaMedeiros | https://github.com/LiviaMedeiros |
|
Nov 3, 2026
| https://github.com/nodejs/node/pull/66254#ref-pullrequest-6192459906 |
|
vfs: place value before done in iterator result
#67231
| https://github.com/nodejs/node/pull/67231 |
| aduh95 | https://github.com/aduh95 |
|
Nov 12, 2026
| https://github.com/nodejs/node/pull/66254#ref-commit-4956a1f |
|
| https://github.com/trivikr |
|
| https://github.com/aduh95 |
| vfs: fix promises.watch() with an already-aborted signal | https://github.com/nodejs/node/commit/4956a1f05392a98d900936f1aa69fd045a112057 |
| 4956a1f | https://github.com/nodejs/node/commit/4956a1f05392a98d900936f1aa69fd045a112057 |
| #66254 | https://github.com/nodejs/node/pull/66254 |
| #66253 | https://github.com/nodejs/node/issues/66253 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66254 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/66254/files/ebc1f19526310c93a2536c674b97780d36602d97 |
| Please reload this page | https://github.com/nodejs/node/pull/66254 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
vfs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avfs |
|
vfs: promises.watch() resolves { done: true } instead of rejecting with a pre-aborted signal
| https://github.com/nodejs/node/issues/66253 |
| Please reload this page | https://github.com/nodejs/node/pull/66254 |
|
| https://github.com/trivikr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |