René's URL Explorer Experiment


Title: stream: do not error on Duplex.from early return by kethinov · Pull Request #66243 · nodejs/node · GitHub

Open Graph Title: stream: do not error on Duplex.from early return by kethinov · Pull Request #66243 · nodejs/node

X Title: stream: do not error on Duplex.from early return by kethinov · Pull Request #66243 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: 0bf9e9f833 (#65963) introduced a regression. It destroys the duplex when an async function body resolves without consuming its input, so that pipeline() propagates destruction upstream. It destroys...

X Description: 0bf9e9f833 (#65963) introduced a regression. It destroys the duplex when an async function body resolves without consuming its input, so that pipeline() propagates destruction upstream. It destroys...

Opengraph URL: https://github.com/nodejs/node/pull/66243

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d41541dc-7368-67bb-0733-891fb246f28e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA97A:2B4280:81B2F:B04BA:6AED3279
html-safe-nonce67178cc8b6f6214b7fe1a337ea0f17294c69a44daaa8affc8ca36c027ee3a1be
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTdBOjJCNDI4MDo4MUIyRjpCMDRCQTo2QUVEMzI3OSIsInZpc2l0b3JfaWQiOiI0MTE4ODIyNzAwMzQ1Nzk5Mjg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacede80f49470203f54a01c8c0fcdbb88e336445a36d158c70cd440f38e81b1c84
hovercard-subject-tagpull_request:4614444098
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66243/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f756c9989a21dbfe2df7a0d4e69c054ec483327920b074c1c098b1b4d2cf87e4/nodejs/node/pull/66243
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f756c9989a21dbfe2df7a0d4e69c054ec483327920b074c1c098b1b4d2cf87e4/nodejs/node/pull/66243
og:image:alt0bf9e9f833 (#65963) introduced a regression. It destroys the duplex when an async function body resolves without consuming its input, so that pipeline() propagates destruction upstream. It destroys...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekethinov
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66243#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66243
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66243
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66243
Reloadhttps://github.com/nodejs/node/pull/66243
Reloadhttps://github.com/nodejs/node/pull/66243
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
kethinovhttps://github.com/kethinov
nodejs:mainhttps://github.com/nodejs/node/tree/main
kethinov:duplex-form-fixhttps://github.com/kethinov/node/tree/duplex-form-fix
Conversationhttps://github.com/nodejs/node/pull/66243
Commits1 (1)https://github.com/nodejs/node/pull/66243/commits
Checkshttps://github.com/nodejs/node/pull/66243/checks
Files changedhttps://github.com/nodejs/node/pull/66243/files
stream: do not error on Duplex.from early returnhttps://github.com/nodejs/node/pull/66243#top
kethinovhttps://github.com/kethinov
nodejs:mainhttps://github.com/nodejs/node/tree/main
kethinov:duplex-form-fixhttps://github.com/kethinov/node/tree/duplex-form-fix
https://github.com/kethinov
kethinovhttps://github.com/kethinov
Sep 23, 2026https://github.com/nodejs/node/pull/66243#issue-5554467232
#65963https://github.com/nodejs/node/pull/65963
Please reload this pagehttps://github.com/nodejs/node/pull/66243
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 23, 2026https://github.com/nodejs/node/pull/66243#issuecomment-5796139725
Please reload this pagehttps://github.com/nodejs/node/pull/66243
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Sep 23, 2026https://github.com/nodejs/node/pull/66243#event-31681227021
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 23, 2026https://github.com/nodejs/node/pull/66243#issuecomment-5796147771
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
contribution and automation policieshttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
pull request guidehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
Code of Conducthttps://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
signed offhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#step-4-commit
Please reload this pagehttps://github.com/nodejs/node/pull/66243
https://github.com/kethinov
stream: do not error on Duplex.from early returnhttps://github.com/nodejs/node/pull/66243/commits/3dc56c02cc3765dce053bb378fb89ea19d35d1b1
3dc56c0https://github.com/nodejs/node/pull/66243/commits/3dc56c02cc3765dce053bb378fb89ea19d35d1b1
nodejs#65963https://github.com/nodejs/node/pull/65963
nodejs#65963https://github.com/nodejs/node/pull/65963
https://github.com/kethinov
kethinovhttps://github.com/kethinov
force-pushedhttps://github.com/nodejs/node/compare/d3fd92eb376168b8741020e0cc7de31c87d8058f..3dc56c02cc3765dce053bb378fb89ea19d35d1b1
d3fd92ehttps://github.com/nodejs/node/commit/d3fd92eb376168b8741020e0cc7de31c87d8058f
3dc56c0https://github.com/nodejs/node/commit/3dc56c02cc3765dce053bb378fb89ea19d35d1b1
Compare https://github.com/nodejs/node/compare/d3fd92eb376168b8741020e0cc7de31c87d8058f..3dc56c02cc3765dce053bb378fb89ea19d35d1b1
September 23, 2026 14:02https://github.com/nodejs/node/pull/66243#event-31681696676
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 23, 2026https://github.com/nodejs/node/pull/66243#issuecomment-5798714799
Please reload this pagehttps://github.com/nodejs/node/pull/66243
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66243?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
305cfcdhttps://app.codecov.io/gh/nodejs/node/commit/305cfcd729843977b92d1d84753c0e2d8bea99ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
3dc56c0https://app.codecov.io/gh/nodejs/node/commit/3dc56c02cc3765dce053bb378fb89ea19d35d1b1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66243?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/duplexify.jshttps://app.codecov.io/gh/nodejs/node/pull/66243?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fduplexify.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvZHVwbGV4aWZ5Lmpz
31 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66243/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66243
https://github.com/kethinov
kethinovhttps://github.com/kethinov
Sep 27, 2026 https://github.com/nodejs/node/pull/66243#ref-issue-5602998998
stream: Duplex.from errors when async function body resolves without consuming its input #66349 https://github.com/nodejs/node/issues/66349
https://github.com/inoway46
inoway46https://github.com/inoway46
Sep 27, 2026 https://github.com/nodejs/node/pull/66243#pullrequestreview-5331334662
View reviewed changes https://github.com/nodejs/node/pull/66243/files/3dc56c02cc3765dce053bb378fb89ea19d35d1b1
inoway46https://github.com/inoway46
https://github.com/nodejs/node/pull/66243#pullrequestreview-5331334662
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66243
https://github.com/kethinov
kethinovhttps://github.com/kethinov
Oct 2, 2026https://github.com/nodejs/node/pull/66243#issuecomment-5953465663
@meixghttps://github.com/meixg
@jasnellhttps://github.com/jasnell
nodejs/node#65963https://github.com/nodejs/node/pull/65963
Please reload this pagehttps://github.com/nodejs/node/pull/66243
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
Oct 6, 2026 https://github.com/nodejs/node/pull/66243#pullrequestreview-5435070407
View reviewed changes https://github.com/nodejs/node/pull/66243/files/3dc56c02cc3765dce053bb378fb89ea19d35d1b1
bitpshrhttps://github.com/bitpshr
https://github.com/nodejs/node/pull/66243#pullrequestreview-5435070407
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#55077https://github.com/nodejs/node/issues/55077
#55077https://github.com/nodejs/node/issues/55077
Please reload this pagehttps://github.com/nodejs/node/pull/66243
https://github.com/inoway46
inoway46https://github.com/inoway46
Oct 23, 2026 https://github.com/nodejs/node/pull/66243#ref-pullrequest-5998317919
stream: prevent AbortError when Duplex.from resolves without consuming input (#66349) #66958 https://github.com/nodejs/node/pull/66958
https://github.com/robobun
robobunhttps://github.com/robobun
Oct 29, 2026 https://github.com/nodejs/node/pull/66243#ref-pullrequest-6096955564
node:stream: destroy Duplex.from(async function) when the function returns before final() oven-sh/bun#47349 https://github.com/oven-sh/bun/pull/47349
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66243
https://github.com/bitpshr
bitpshr https://github.com/bitpshr
https://github.com/nodejs/node/pull/66243/files/3dc56c02cc3765dce053bb378fb89ea19d35d1b1
https://github.com/inoway46
inoway46 https://github.com/inoway46
https://github.com/nodejs/node/pull/66243/files/3dc56c02cc3765dce053bb378fb89ea19d35d1b1
Please reload this pagehttps://github.com/nodejs/node/pull/66243
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/66243
https://github.com/kethinov
https://github.com/nodejs-github-bot
https://github.com/bitpshr
https://github.com/inoway46
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.