René's URL Explorer Experiment


Title: http: align empty proxy env var handling with fetch() by barathraj048 · Pull Request #66210 · nodejs/node · GitHub

Open Graph Title: http: align empty proxy env var handling with fetch() by barathraj048 · Pull Request #66210 · nodejs/node

X Title: http: align empty proxy env var handling with fetch() by barathraj048 · Pull Request #66210 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refs: #66202 Status: Closed. The intended behavior is still being decided in #66202, and @christianaurichzm has a fix prepared there. This PR changed lib/internal/http.js to use ?? instead of || wh...

X Description: Refs: #66202 Status: Closed. The intended behavior is still being decided in #66202, and @christianaurichzm has a fix prepared there. This PR changed lib/internal/http.js to use ?? instead of || wh...

Opengraph URL: https://github.com/nodejs/node/pull/66210

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c6781a57-9b94-0aef-10df-44886cf13e07
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB5C:169E62:92DB8:C02A9:6AED1122
html-safe-nonce6ec5688f3e607757158b9026e8b673d121cc773acc4e0af5ad20cddda6148165
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjVDOjE2OUU2Mjo5MkRCODpDMDJBOTo2QUVEMTEyMiIsInZpc2l0b3JfaWQiOiIyNjAzODk5MDE3MTY3NTQ3MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3f7daa192fe2dce1a4706ccb9155403febf46bc03dac9ae5a500aabe4760a99b
hovercard-subject-tagpull_request:4604684754
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66210/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/90c8aabc04012258fae7f1735c034d76b92151bd394d71c8f717dc884f461c73/nodejs/node/pull/66210
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/90c8aabc04012258fae7f1735c034d76b92151bd394d71c8f717dc884f461c73/nodejs/node/pull/66210
og:image:altRefs: #66202 Status: Closed. The intended behavior is still being decided in #66202, and @christianaurichzm has a fix prepared there. This PR changed lib/internal/http.js to use ?? instead of || wh...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebarathraj048
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66210#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66210
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66210
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66210
Reloadhttps://github.com/nodejs/node/pull/66210
Reloadhttps://github.com/nodejs/node/pull/66210
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
barathraj048https://github.com/barathraj048
nodejs:mainhttps://github.com/nodejs/node/tree/main
barathraj048:fix/http-proxy-env-empty-valuehttps://github.com/barathraj048/node-js/tree/fix/http-proxy-env-empty-value
Conversationhttps://github.com/nodejs/node/pull/66210
Commits1 (1)https://github.com/nodejs/node/pull/66210/commits
Checkshttps://github.com/nodejs/node/pull/66210/checks
Files changedhttps://github.com/nodejs/node/pull/66210/files
http: align empty proxy env var handling with fetch()https://github.com/nodejs/node/pull/66210#top
barathraj048https://github.com/barathraj048
nodejs:mainhttps://github.com/nodejs/node/tree/main
barathraj048:fix/http-proxy-env-empty-valuehttps://github.com/barathraj048/node-js/tree/fix/http-proxy-env-empty-value
https://github.com/barathraj048
barathraj048https://github.com/barathraj048
Sep 22, 2026https://github.com/nodejs/node/pull/66210#issue-5542649393
Please reload this pagehttps://github.com/nodejs/node/pull/66210
#66202https://github.com/nodejs/node/issues/66202
#66202https://github.com/nodejs/node/issues/66202
@christianaurichzmhttps://github.com/christianaurichzm
Please reload this pagehttps://github.com/nodejs/node/pull/66210
https://github.com/barathraj048
http: align empty proxy env var handling with fetch()https://github.com/nodejs/node/pull/66210/commits/371a26a772ba62d4e9bb07c7994aba62245fb0c5
371a26ahttps://github.com/nodejs/node/pull/66210/commits/371a26a772ba62d4e9bb07c7994aba62245fb0c5
nodejs#66202https://github.com/nodejs/node/issues/66202
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 22, 2026https://github.com/nodejs/node/pull/66210#issuecomment-5780577168
Please reload this pagehttps://github.com/nodejs/node/pull/66210
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 22, 2026https://github.com/nodejs/node/pull/66210#event-31616932652
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 22, 2026https://github.com/nodejs/node/pull/66210#issuecomment-5781940362
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66210?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
36dd044https://app.codecov.io/gh/nodejs/node/commit/36dd044cfdb20487951a83b75a3341af3025ca17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
371a26ahttps://app.codecov.io/gh/nodejs/node/commit/371a26a772ba62d4e9bb07c7994aba62245fb0c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66210?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/http.jshttps://app.codecov.io/gh/nodejs/node/pull/66210?src=pr&el=tree&filepath=lib%2Finternal%2Fhttp.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2h0dHAuanM=
40 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66210/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66210
https://github.com/MikeMcC399
MikeMcC399https://github.com/MikeMcC399
Sep 22, 2026https://github.com/nodejs/node/pull/66210#issuecomment-5784156813
Please reload this pagehttps://github.com/nodejs/node/pull/66210
@barathraj048https://github.com/barathraj048
#66202https://github.com/nodejs/node/issues/66202
#66202https://github.com/nodejs/node/issues/66202
@christianaurichzmhttps://github.com/christianaurichzm
Developer Certificate of Originhttps://github.com/nodejs/node/blob/main/CONTRIBUTING.md#developers-certificate-of-origin-11
Please reload this pagehttps://github.com/nodejs/node/pull/66210
https://github.com/MikeMcC399
MikeMcC399https://github.com/MikeMcC399
Sep 22, 2026 https://github.com/nodejs/node/pull/66210#ref-issue-5538297472
fetch() and http.request() disagree when a lower-cased proxy env var is empty #66202 https://github.com/nodejs/node/issues/66202
https://github.com/christianaurichzm
christianaurichzmhttps://github.com/christianaurichzm
Sep 22, 2026 https://github.com/nodejs/node/pull/66210#pullrequestreview-5284612593
View reviewed changes https://github.com/nodejs/node/pull/66210/files/371a26a772ba62d4e9bb07c7994aba62245fb0c5
christianaurichzmhttps://github.com/christianaurichzm
https://github.com/nodejs/node/pull/66210#pullrequestreview-5284612593
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#66202https://github.com/nodejs/node/issues/66202
Please reload this pagehttps://github.com/nodejs/node/pull/66210
lib/internal/http.jshttps://github.com/nodejs/node/pull/66210/files/371a26a772ba62d4e9bb07c7994aba62245fb0c5#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
christianaurichzmhttps://github.com/christianaurichzm
Sep 22, 2026https://github.com/nodejs/node/pull/66210#discussion_r4077191323
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/barathraj048/node-js/blob/371a26a772ba62d4e9bb07c7994aba62245fb0c5/doc/api/http.md?plain=1#L221https://github.com/barathraj048/node-js/blob/371a26a772ba62d4e9bb07c7994aba62245fb0c5/doc/api/http.md?plain=1#L221
Please reload this pagehttps://github.com/nodejs/node/pull/66210
test/parallel/test-http-proxy-env-empty-value.jshttps://github.com/nodejs/node/pull/66210/files/371a26a772ba62d4e9bb07c7994aba62245fb0c5#diff-de108e00f6593f183f9c5cc6bee7a293988d04170ece11ed73981f881eb2f963
christianaurichzmhttps://github.com/christianaurichzm
Sep 22, 2026https://github.com/nodejs/node/pull/66210#discussion_r4077230309
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66210
test/parallel/test-http-proxy-env-empty-value.jshttps://github.com/nodejs/node/pull/66210/files/371a26a772ba62d4e9bb07c7994aba62245fb0c5#diff-de108e00f6593f183f9c5cc6bee7a293988d04170ece11ed73981f881eb2f963
christianaurichzmhttps://github.com/christianaurichzm
Sep 22, 2026https://github.com/nodejs/node/pull/66210#discussion_r4077231966
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66210
test/parallel/test-http-proxy-env-empty-value.jshttps://github.com/nodejs/node/pull/66210/files/371a26a772ba62d4e9bb07c7994aba62245fb0c5#diff-de108e00f6593f183f9c5cc6bee7a293988d04170ece11ed73981f881eb2f963
christianaurichzmhttps://github.com/christianaurichzm
Sep 22, 2026https://github.com/nodejs/node/pull/66210#discussion_r4077246421
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66210
https://github.com/barathraj048
barathraj048https://github.com/barathraj048
Sep 23, 2026https://github.com/nodejs/node/pull/66210#issuecomment-5787609561
@MikeMcC399https://github.com/MikeMcC399
@christianaurichzmhttps://github.com/christianaurichzm
#66202https://github.com/nodejs/node/issues/66202
@christianaurichzmhttps://github.com/christianaurichzm
@christianaurichzmhttps://github.com/christianaurichzm
Please reload this pagehttps://github.com/nodejs/node/pull/66210
https://github.com/barathraj048
barathraj048https://github.com/barathraj048
Sep 23, 2026https://github.com/nodejs/node/pull/66210#event-31644258782
https://github.com/MikeMcC399
MikeMcC399https://github.com/MikeMcC399
Sep 23, 2026https://github.com/nodejs/node/pull/66210#issuecomment-5799433418
#65952https://github.com/nodejs/node/pull/65952
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
contribution and automation policieshttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
pull request guidehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
Code of Conducthttps://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
Please reload this pagehttps://github.com/nodejs/node/pull/66210
https://github.com/barathraj048
barathraj048https://github.com/barathraj048
Sep 24, 2026https://github.com/nodejs/node/pull/66210#issuecomment-5806519199
Please reload this pagehttps://github.com/nodejs/node/pull/66210
https://github.com/barathraj048
barathraj048https://github.com/barathraj048
Sep 24, 2026https://github.com/nodejs/node/pull/66210#issuecomment-5806596521
@MikeMcC399https://github.com/MikeMcC399
Please reload this pagehttps://github.com/nodejs/node/pull/66210
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66210
https://github.com/christianaurichzm
christianaurichzm https://github.com/christianaurichzm
https://github.com/nodejs/node/pull/66210/files/371a26a772ba62d4e9bb07c7994aba62245fb0c5
Please reload this pagehttps://github.com/nodejs/node/pull/66210
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/66210
https://github.com/barathraj048
https://github.com/nodejs-github-bot
https://github.com/MikeMcC399
https://github.com/christianaurichzm
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.