René's URL Explorer Experiment


Title: sqlite: run generator return() on cursor refilter by trivikr · Pull Request #66195 · nodejs/node · GitHub

Open Graph Title: sqlite: run generator return() on cursor refilter by trivikr · Pull Request #66195 · nodejs/node

X Title: sqlite: run generator return() on cursor refilter by trivikr · Pull Request #66195 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #66193 SQLite re-invokes xFilter on a cursor it already used, as it does for the inner table of a correlated subquery or join, abandoning the previous iterator mid-loop. Call its return() me...

X Description: Fixes: #66193 SQLite re-invokes xFilter on a cursor it already used, as it does for the inner table of a correlated subquery or join, abandoning the previous iterator mid-loop. Call its return() me...

Opengraph URL: https://github.com/nodejs/node/pull/66195

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:222cbfd7-4820-5bfd-b3a7-21d4a862c9cb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D1A:E530F:A851EE:DF749C:6AED33E2
html-safe-noncee7efcbfc7b3c9c67d781fcf011b304f29a53d6dbcefa966b1668e06d172a8b2a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDFBOkU1MzBGOkE4NTFFRTpERjc0OUM6NkFFRDMzRTIiLCJ2aXNpdG9yX2lkIjoiNDY0MzIxNjQ0ODg4MzA3ODExNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7c31fd03c6507f9340910aa56a90b950ff3ee06c5f6c91a46154c9bfe9552320
hovercard-subject-tagpull_request:4598911567
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66195/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e8570246c174a72e8b28171402910a0c5b1727e61a0fa5153e2a218a7da95c06/nodejs/node/pull/66195
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e8570246c174a72e8b28171402910a0c5b1727e61a0fa5153e2a218a7da95c06/nodejs/node/pull/66195
og:image:altFixes: #66193 SQLite re-invokes xFilter on a cursor it already used, as it does for the inner table of a correlated subquery or join, abandoning the previous iterator mid-loop. Call its return() me...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66195#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66195
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66195
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66195
Reloadhttps://github.com/nodejs/node/pull/66195
Reloadhttps://github.com/nodejs/node/pull/66195
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
trivikrhttps://github.com/trivikr
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:sqlite-virtual-table-cursor-2https://github.com/trivikr/node/tree/sqlite-virtual-table-cursor-2
Conversationhttps://github.com/nodejs/node/pull/66195
Commits1 (1)https://github.com/nodejs/node/pull/66195/commits
Checkshttps://github.com/nodejs/node/pull/66195/checks
Files changedhttps://github.com/nodejs/node/pull/66195/files
sqlite: run generator return() on cursor refilterhttps://github.com/nodejs/node/pull/66195#top
trivikrhttps://github.com/trivikr
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:sqlite-virtual-table-cursor-2https://github.com/trivikr/node/tree/sqlite-virtual-table-cursor-2
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 22, 2026https://github.com/nodejs/node/pull/66195#issue-5535824058
Please reload this pagehttps://github.com/nodejs/node/pull/66195
#66193https://github.com/nodejs/node/issues/66193
Please reload this pagehttps://github.com/nodejs/node/pull/66195
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 22, 2026https://github.com/nodejs/node/pull/66195#issuecomment-5771860026
Please reload this pagehttps://github.com/nodejs/node/pull/66195
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
sqlite https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asqlite
Sep 22, 2026https://github.com/nodejs/node/pull/66195#event-31578069549
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66195
https://github.com/trivikr
sqlite: run generator return() on cursor refilterhttps://github.com/nodejs/node/pull/66195/commits/cefe77fdaaa3b9658feaed266c7eba5eb4ec7614
cefe77fhttps://github.com/nodejs/node/pull/66195/commits/cefe77fdaaa3b9658feaed266c7eba5eb4ec7614
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/9b01002b455aa371dfc0b840b61efad43a7f3f60..cefe77fdaaa3b9658feaed266c7eba5eb4ec7614
9b01002https://github.com/nodejs/node/commit/9b01002b455aa371dfc0b840b61efad43a7f3f60
cefe77fhttps://github.com/nodejs/node/commit/cefe77fdaaa3b9658feaed266c7eba5eb4ec7614
Compare https://github.com/nodejs/node/compare/9b01002b455aa371dfc0b840b61efad43a7f3f60..cefe77fdaaa3b9658feaed266c7eba5eb4ec7614
September 22, 2026 05:59https://github.com/nodejs/node/pull/66195#event-31578190310
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66195
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 22, 2026https://github.com/nodejs/node/pull/66195#issuecomment-5772910489
Please reload this pagehttps://github.com/nodejs/node/pull/66195
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66195?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
dd9f4dahttps://app.codecov.io/gh/nodejs/node/commit/dd9f4dac3296640327d0151912dcc3de90ab385a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
cefe77fhttps://app.codecov.io/gh/nodejs/node/commit/cefe77fdaaa3b9658feaed266c7eba5eb4ec7614?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66195?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/66195?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
1 Missing and 2 partials ⚠️ https://app.codecov.io/gh/nodejs/node/pull/66195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66195?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sqlite.hhttps://app.codecov.io/gh/nodejs/node/pull/66195?src=pr&el=tree&filepath=src%2Fnode_sqlite.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmg=
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/66195?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
26 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66195/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66195
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66195
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 22, 2026https://github.com/nodejs/node/pull/66195#issuecomment-5777692314
https://ci.nodejs.org/job/node-test-pull-request/77751/https://ci.nodejs.org/job/node-test-pull-request/77751/
Please reload this pagehttps://github.com/nodejs/node/pull/66195
https://github.com/trivikr
trivikrhttps://github.com/trivikr
araujoguihttps://github.com/araujogui
September 22, 2026 13:48https://github.com/nodejs/node/pull/66195#event-31604329842
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 22, 2026https://github.com/nodejs/node/pull/66195#issuecomment-5783852112
https://ci.nodejs.org/job/node-test-pull-request/77751/https://ci.nodejs.org/job/node-test-pull-request/77751/
Please reload this pagehttps://github.com/nodejs/node/pull/66195
https://github.com/araujogui
araujoguihttps://github.com/araujogui
Sep 23, 2026 https://github.com/nodejs/node/pull/66195#pullrequestreview-5289981029
View reviewed changes https://github.com/nodejs/node/pull/66195/files/cefe77fdaaa3b9658feaed266c7eba5eb4ec7614
araujoguihttps://github.com/araujogui
https://github.com/nodejs/node/pull/66195#pullrequestreview-5289981029
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66195
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 23, 2026https://github.com/nodejs/node/pull/66195#event-31681350033
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Renegade334https://github.com/Renegade334
September 23, 2026 15:01https://github.com/nodejs/node/pull/66195#event-31686106939
https://github.com/panva
panvahttps://github.com/panva
Sep 25, 2026 https://github.com/nodejs/node/pull/66195#pullrequestreview-5321419864
View reviewed changes https://github.com/nodejs/node/pull/66195/files/cefe77fdaaa3b9658feaed266c7eba5eb4ec7614
panvahttps://github.com/panva
Sep 25, 2026 https://github.com/nodejs/node/pull/66195#ref-commit-8bf65d4
https://github.com/trivikr
https://github.com/panva
sqlite: run generator return() on cursor refilterhttps://github.com/nodejs/node/commit/8bf65d4beb45b871e01210d59153173f33d45891
8bf65d4https://github.com/nodejs/node/commit/8bf65d4beb45b871e01210d59153173f33d45891
#66195https://github.com/nodejs/node/pull/66195
#66193https://github.com/nodejs/node/issues/66193
https://github.com/panva
panvahttps://github.com/panva
Sep 25, 2026https://github.com/nodejs/node/pull/66195#issuecomment-5837710410
8bf65d4https://github.com/nodejs/node/commit/8bf65d4beb45b871e01210d59153173f33d45891
Please reload this pagehttps://github.com/nodejs/node/pull/66195
https://github.com/panva
panvahttps://github.com/panva
Sep 25, 2026https://github.com/nodejs/node/pull/66195#event-31857695427
aduh95https://github.com/aduh95
Sep 27, 2026 https://github.com/nodejs/node/pull/66195#ref-commit-708fadc
https://github.com/trivikr
https://github.com/aduh95
sqlite: run generator return() on cursor refilterhttps://github.com/nodejs/node/commit/708fadccf6f3c3f0fba91a47e8a6f1b32aa4f0a8
708fadchttps://github.com/nodejs/node/commit/708fadccf6f3c3f0fba91a47e8a6f1b32aa4f0a8
#66195https://github.com/nodejs/node/pull/66195
#66193https://github.com/nodejs/node/issues/66193
HoonDongKanghttps://github.com/HoonDongKang
Sep 28, 2026 https://github.com/nodejs/node/pull/66195#ref-commit-ab22226
https://github.com/trivikr
https://github.com/HoonDongKang
sqlite: run generator return() on cursor refilterhttps://github.com/HoonDongKang/node/commit/ab2222637c69840e12a7d951e8a4c869158ed01c
ab22226https://github.com/HoonDongKang/node/commit/ab2222637c69840e12a7d951e8a4c869158ed01c
nodejs#66195https://github.com/nodejs/node/pull/66195
nodejs#66193https://github.com/nodejs/node/issues/66193
aduh95https://github.com/aduh95
Sep 28, 2026 https://github.com/nodejs/node/pull/66195#ref-commit-583ee1c
https://github.com/trivikr
https://github.com/aduh95
sqlite: run generator return() on cursor refilterhttps://github.com/nodejs/node/commit/583ee1ce64215ca3c330a4d8267c354bbb39f97a
583ee1chttps://github.com/nodejs/node/commit/583ee1ce64215ca3c330a4d8267c354bbb39f97a
#66195https://github.com/nodejs/node/pull/66195
#66193https://github.com/nodejs/node/issues/66193
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 5, 2026 https://github.com/nodejs/node/pull/66195#ref-pullrequest-5720654094
2026-10-07, Version 26.11.0 (Current) #66546 https://github.com/nodejs/node/pull/66546
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/66195#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66195
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/66195/files/cefe77fdaaa3b9658feaed266c7eba5eb4ec7614
https://github.com/araujogui
araujogui https://github.com/araujogui
https://github.com/nodejs/node/pull/66195/files/cefe77fdaaa3b9658feaed266c7eba5eb4ec7614
https://github.com/Renegade334
Renegade334 https://github.com/Renegade334
Please reload this pagehttps://github.com/nodejs/node/pull/66195
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
sqlite https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asqlite
sqlite: re-filtering a virtual-table cursor skips generator cleanup https://github.com/nodejs/node/issues/66193
Please reload this pagehttps://github.com/nodejs/node/pull/66195
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/araujogui
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.