René's URL Explorer Experiment


Title: zlib: reject reset after gzip emitted incomplete output by xia-chao · Pull Request #66179 · nodejs/node · GitHub

Open Graph Title: zlib: reject reset after gzip emitted incomplete output by xia-chao · Pull Request #66179 · nodejs/node

X Title: zlib: reject reset after gzip emitted incomplete output by xia-chao · Pull Request #66179 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: gzip writes a header on the first write. Calling reset after that starts a new member while that header is already in the output, so gunzip fails. Same idea as the zstd incomplete-frame case in #66...

X Description: gzip writes a header on the first write. Calling reset after that starts a new member while that header is already in the output, so gunzip fails. Same idea as the zstd incomplete-frame case in #66...

Opengraph URL: https://github.com/nodejs/node/pull/66179

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0ac17424-e2ea-098f-ddcf-3ca513df036f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE45E:3C34F7:20EE3F:2B36F7:6AED1859
html-safe-noncefed24774ba3c3860f5b4192e86a0789fe69a3bafba443b5a1072d01552d0c15a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDVFOjNDMzRGNzoyMEVFM0Y6MkIzNkY3OjZBRUQxODU5IiwidmlzaXRvcl9pZCI6IjY3ODQxMDU1MDk2MDc1MTIxNTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd8edb599911ff5dcd836ace2e08d87045246883abd37e3875a1208dd20c27082
hovercard-subject-tagpull_request:4591251402
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66179/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/576150252c61cd70f2d4c71bb792d0e4eab9ad954deb89cbf46980075875d1c7/nodejs/node/pull/66179
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/576150252c61cd70f2d4c71bb792d0e4eab9ad954deb89cbf46980075875d1c7/nodejs/node/pull/66179
og:image:altgzip writes a header on the first write. Calling reset after that starts a new member while that header is already in the output, so gunzip fails. Same idea as the zstd incomplete-frame case in #66...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamexia-chao
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66179#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66179
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66179
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66179
Reloadhttps://github.com/nodejs/node/pull/66179
Reloadhttps://github.com/nodejs/node/pull/66179
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
xia-chao:zlib-reject-reset-incomplete-outputhttps://github.com/xia-chao/node/tree/zlib-reject-reset-incomplete-output
Conversationhttps://github.com/nodejs/node/pull/66179
Commits2 (2)https://github.com/nodejs/node/pull/66179/commits
Checkshttps://github.com/nodejs/node/pull/66179/checks
Files changedhttps://github.com/nodejs/node/pull/66179/files
zlib: reject reset after gzip emitted incomplete outputhttps://github.com/nodejs/node/pull/66179#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
xia-chao:zlib-reject-reset-incomplete-outputhttps://github.com/xia-chao/node/tree/zlib-reject-reset-incomplete-output
https://github.com/xia-chao
xia-chaohttps://github.com/xia-chao
Sep 21, 2026https://github.com/nodejs/node/pull/66179#issue-5526703504
Please reload this pagehttps://github.com/nodejs/node/pull/66179
#66088https://github.com/nodejs/node/pull/66088
Please reload this pagehttps://github.com/nodejs/node/pull/66179
https://github.com/xia-chao
zlib: reject reset after gzip/deflate emitted incomplete outputhttps://github.com/nodejs/node/pull/66179/commits/5e511b4d114748b17818ff605e0ad325edf408e5
5e511b4https://github.com/nodejs/node/pull/66179/commits/5e511b4d114748b17818ff605e0ad325edf408e5
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
zlib https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib
Sep 21, 2026https://github.com/nodejs/node/pull/66179#event-31526070657
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 21, 2026 https://github.com/nodejs/node/pull/66179#pullrequestreview-5266400837
View reviewed changes https://github.com/nodejs/node/pull/66179/files/5e511b4d114748b17818ff605e0ad325edf408e5
https://github.com/xia-chao
zlib: refuse incomplete-member reset only for gziphttps://github.com/nodejs/node/pull/66179/commits/96593b0f7bcc30155298eea3d6f81d3c407dabdd
96593b0https://github.com/nodejs/node/pull/66179/commits/96593b0f7bcc30155298eea3d6f81d3c407dabdd
https://github.com/xia-chao
xia-chaohttps://github.com/xia-chao
Sep 21, 2026https://github.com/nodejs/node/pull/66179#event-31528835239
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 21, 2026https://github.com/nodejs/node/pull/66179#issuecomment-5762150033
Please reload this pagehttps://github.com/nodejs/node/pull/66179
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66179?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
513981dhttps://app.codecov.io/gh/nodejs/node/commit/513981d1d5fa705ec6a0d2b98ef8313a8c02d234?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
96593b0https://app.codecov.io/gh/nodejs/node/commit/96593b0f7bcc30155298eea3d6f81d3c407dabdd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66179?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_zlib.cchttps://app.codecov.io/gh/nodejs/node/pull/66179?src=pr&el=tree&filepath=src%2Fnode_zlib.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfemxpYi5jYw==
0 Missing and 2 partials ⚠️ https://app.codecov.io/gh/nodejs/node/pull/66179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66179?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_zlib.cchttps://app.codecov.io/gh/nodejs/node/pull/66179?src=pr&el=tree&filepath=src%2Fnode_zlib.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfemxpYi5jYw==
27 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66179/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66179
https://github.com/xia-chao
xia-chaohttps://github.com/xia-chao
Sep 22, 2026https://github.com/nodejs/node/pull/66179#issuecomment-5776616287
Please reload this pagehttps://github.com/nodejs/node/pull/66179
Please reload this pagehttps://github.com/nodejs/node/pull/66179
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 22, 2026 https://github.com/nodejs/node/pull/66179#pullrequestreview-5284113284
View reviewed changes https://github.com/nodejs/node/pull/66179/files/96593b0f7bcc30155298eea3d6f81d3c407dabdd
https://github.com/jasnell
jasnellhttps://github.com/jasnell
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 22, 2026https://github.com/nodejs/node/pull/66179#event-31633589929
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 22, 2026https://github.com/nodejs/node/pull/66179#event-31633716844
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 22, 2026https://github.com/nodejs/node/pull/66179#issuecomment-5784686352
https://ci.nodejs.org/job/node-test-pull-request/77769/https://ci.nodejs.org/job/node-test-pull-request/77769/
Please reload this pagehttps://github.com/nodejs/node/pull/66179
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Sep 25, 2026https://github.com/nodejs/node/pull/66179#event-31824813274
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Sep 25, 2026https://github.com/nodejs/node/pull/66179#event-31839640275
https://github.com/panva
panvahttps://github.com/panva
Sep 26, 2026 https://github.com/nodejs/node/pull/66179#pullrequestreview-5326871719
View reviewed changes https://github.com/nodejs/node/pull/66179/files/96593b0f7bcc30155298eea3d6f81d3c407dabdd
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
ca0810fhttps://github.com/nodejs/node/commit/ca0810fd80e11e494585c641158e57982cd7329c
Sep 26, 2026https://github.com/nodejs/node/pull/66179#event-31901709404
Please reload this pagehttps://github.com/nodejs/node/pull/66179
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2026https://github.com/nodejs/node/pull/66179#issuecomment-5848745804
ca0810fhttps://github.com/nodejs/node/commit/ca0810fd80e11e494585c641158e57982cd7329c
Please reload this pagehttps://github.com/nodejs/node/pull/66179
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Sep 26, 2026https://github.com/nodejs/node/pull/66179#event-31901711004
aduh95https://github.com/aduh95
Sep 27, 2026 https://github.com/nodejs/node/pull/66179#ref-commit-dd109d2
https://github.com/xia-chao
https://github.com/aduh95
zlib: reject reset after gzip/deflate emitted incomplete outputhttps://github.com/nodejs/node/commit/dd109d24912fc1f66f2e835c3242f6afb442b7b3
dd109d2https://github.com/nodejs/node/commit/dd109d24912fc1f66f2e835c3242f6afb442b7b3
#66179https://github.com/nodejs/node/pull/66179
HoonDongKanghttps://github.com/HoonDongKang
Sep 28, 2026 https://github.com/nodejs/node/pull/66179#ref-commit-a884264
https://github.com/xia-chao
https://github.com/HoonDongKang
zlib: reject reset after gzip/deflate emitted incomplete outputhttps://github.com/HoonDongKang/node/commit/a8842648eee2674b94205f7dc3d85f9048a1a064
a884264https://github.com/HoonDongKang/node/commit/a8842648eee2674b94205f7dc3d85f9048a1a064
nodejs#66179https://github.com/nodejs/node/pull/66179
aduh95https://github.com/aduh95
Sep 28, 2026 https://github.com/nodejs/node/pull/66179#ref-commit-54e9330
https://github.com/xia-chao
https://github.com/aduh95
zlib: reject reset after gzip/deflate emitted incomplete outputhttps://github.com/nodejs/node/commit/54e93301a1003c05df9bd1fd2a6f28aefbff969c
54e9330https://github.com/nodejs/node/commit/54e93301a1003c05df9bd1fd2a6f28aefbff969c
#66179https://github.com/nodejs/node/pull/66179
https://github.com/robobun
robobunhttps://github.com/robobun
Sep 30, 2026 https://github.com/nodejs/node/pull/66179#ref-pullrequest-5639121020
node:zlib: reset a zstd stream in place, keep its dictionary and parameters oven-sh/bun#44261 https://github.com/oven-sh/bun/pull/44261
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 5, 2026 https://github.com/nodejs/node/pull/66179#ref-pullrequest-5720654094
2026-10-07, Version 26.11.0 (Current) #66546 https://github.com/nodejs/node/pull/66546
aduh95https://github.com/aduh95
Oct 23, 2026 https://github.com/nodejs/node/pull/66179#ref-commit-c55978e
https://github.com/xia-chao
https://github.com/aduh95
zlib: reject reset after gzip/deflate emitted incomplete outputhttps://github.com/nodejs/node/commit/c55978ef81ec7b69fdbca31cd72714166b0725d4
c55978ehttps://github.com/nodejs/node/commit/c55978ef81ec7b69fdbca31cd72714166b0725d4
#66179https://github.com/nodejs/node/pull/66179
aduh95https://github.com/aduh95
Oct 28, 2026 https://github.com/nodejs/node/pull/66179#ref-commit-22a86a4
https://github.com/xia-chao
https://github.com/aduh95
zlib: reject reset after gzip/deflate emitted incomplete outputhttps://github.com/nodejs/node/commit/22a86a4c6669a91cfbb56fc034a4d5fb108d2975
22a86a4https://github.com/nodejs/node/commit/22a86a4c6669a91cfbb56fc034a4d5fb108d2975
#66179https://github.com/nodejs/node/pull/66179
https://github.com/robobun
robobunhttps://github.com/robobun
Oct 29, 2026 https://github.com/nodejs/node/pull/66179#ref-pullrequest-6098826238
node:zlib: refuse reset() of a gzip member that is open and has given output oven-sh/bun#47364 https://github.com/oven-sh/bun/pull/47364
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/66179#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66179
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/66179/files/96593b0f7bcc30155298eea3d6f81d3c407dabdd
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/66179/files/96593b0f7bcc30155298eea3d6f81d3c407dabdd
Please reload this pagehttps://github.com/nodejs/node/pull/66179
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
zlib https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib
Please reload this pagehttps://github.com/nodejs/node/pull/66179
https://github.com/xia-chao
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.