René's URL Explorer Experiment


Title: ffi: allocate string argument storage lazily by soulee-dev · Pull Request #66178 · nodejs/node · GitHub

Open Graph Title: ffi: allocate string argument storage lazily by soulee-dev · Pull Request #66178 · nodejs/node

X Title: ffi: allocate string argument storage lazily by soulee-dev · Pull Request #66178 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: InvokeFunction reserves a temporary std::vector<std::string> on every call with arguments, even when none of the arguments are strings. Defer that reservation until the first string argument ...

X Description: InvokeFunction reserves a temporary std::vector&lt;std::string&gt; on every call with arguments, even when none of the arguments are strings. Defer that reservation until the first string a...

Opengraph URL: https://github.com/nodejs/node/pull/66178

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1b7c7087-11ee-a4ad-3560-f5777df3301d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD54:32386D:47CE81:5CF251:6AED2274
html-safe-nonced267db93e015336e0e572eb52d7d1a2c3967f671931673fe6effd04fe807f91a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDU0OjMyMzg2RDo0N0NFODE6NUNGMjUxOjZBRUQyMjc0IiwidmlzaXRvcl9pZCI6IjUzNTM0Mjg2ODkwMTE2Nzk4NjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac06fe4a99c3dd9f90bbf2238e072f7b5b5f5632e92e267e0ad0ccba24e2dda48b
hovercard-subject-tagpull_request:4591172744
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66178/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0fe2d0e6620f8157467ef91bff238dfd41f1ba6f6ddb44f3411c95a0d9949ae0/nodejs/node/pull/66178
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0fe2d0e6620f8157467ef91bff238dfd41f1ba6f6ddb44f3411c95a0d9949ae0/nodejs/node/pull/66178
og:image:altInvokeFunction reserves a temporary std::vector<std::string> on every call with arguments, even when none of the arguments are strings. Defer that reservation until the first string argument ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesoulee-dev
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66178#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66178
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66178
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66178
Reloadhttps://github.com/nodejs/node/pull/66178
Reloadhttps://github.com/nodejs/node/pull/66178
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
soulee-dev:ffi-lazy-string-storagehttps://github.com/soulee-dev/node/tree/ffi-lazy-string-storage
Conversationhttps://github.com/nodejs/node/pull/66178
Commits1 (1)https://github.com/nodejs/node/pull/66178/commits
Checkshttps://github.com/nodejs/node/pull/66178/checks
Files changedhttps://github.com/nodejs/node/pull/66178/files
ffi: allocate string argument storage lazilyhttps://github.com/nodejs/node/pull/66178#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
soulee-dev:ffi-lazy-string-storagehttps://github.com/soulee-dev/node/tree/ffi-lazy-string-storage
https://github.com/soulee-dev
soulee-devhttps://github.com/soulee-dev
Sep 21, 2026https://github.com/nodejs/node/pull/66178#issue-5526602013
Please reload this pagehttps://github.com/nodejs/node/pull/66178
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 21, 2026https://github.com/nodejs/node/pull/66178#issuecomment-5760056532
Please reload this pagehttps://github.com/nodejs/node/pull/66178
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 21, 2026https://github.com/nodejs/node/pull/66178#event-31525507312
https://github.com/soulee-dev
ffi: allocate string argument storage lazilyhttps://github.com/nodejs/node/pull/66178/commits/aa0c8b55d4c6c74ab2d12e4f30c8366a439dd535
aa0c8b5https://github.com/nodejs/node/pull/66178/commits/aa0c8b55d4c6c74ab2d12e4f30c8366a439dd535
https://github.com/soulee-dev
soulee-devhttps://github.com/soulee-dev
force-pushedhttps://github.com/nodejs/node/compare/c85110befa2c6e14d32f90b418602b96b443186a..aa0c8b55d4c6c74ab2d12e4f30c8366a439dd535
c85110bhttps://github.com/nodejs/node/commit/c85110befa2c6e14d32f90b418602b96b443186a
aa0c8b5https://github.com/nodejs/node/commit/aa0c8b55d4c6c74ab2d12e4f30c8366a439dd535
Compare https://github.com/nodejs/node/compare/c85110befa2c6e14d32f90b418602b96b443186a..aa0c8b55d4c6c74ab2d12e4f30c8366a439dd535
September 21, 2026 11:57https://github.com/nodejs/node/pull/66178#event-31525710650
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 21, 2026https://github.com/nodejs/node/pull/66178#issuecomment-5761855208
Please reload this pagehttps://github.com/nodejs/node/pull/66178
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66178?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
97af3d7https://app.codecov.io/gh/nodejs/node/commit/97af3d7da562406b75d1baeecb79ef8105d4b92a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
aa0c8b5https://app.codecov.io/gh/nodejs/node/commit/aa0c8b55d4c6c74ab2d12e4f30c8366a439dd535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66178?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_ffi.cchttps://app.codecov.io/gh/nodejs/node/pull/66178?src=pr&el=tree&filepath=src%2Fnode_ffi.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmZpLmNj
53 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66178/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66178
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
Sep 22, 2026https://github.com/nodejs/node/pull/66178#event-31597780874
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
Sep 24, 2026 https://github.com/nodejs/node/pull/66178#pullrequestreview-5303934100
View reviewed changes https://github.com/nodejs/node/pull/66178/files/aa0c8b55d4c6c74ab2d12e4f30c8366a439dd535
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 24, 2026https://github.com/nodejs/node/pull/66178#event-31752572739
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 24, 2026https://github.com/nodejs/node/pull/66178#event-31769283130
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 24, 2026https://github.com/nodejs/node/pull/66178#issuecomment-5817162643
https://ci.nodejs.org/job/node-test-pull-request/77832/https://ci.nodejs.org/job/node-test-pull-request/77832/
Please reload this pagehttps://github.com/nodejs/node/pull/66178
https://github.com/panva
panvahttps://github.com/panva
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Sep 24, 2026https://github.com/nodejs/node/pull/66178#event-31784355786
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Sep 24, 2026https://github.com/nodejs/node/pull/66178#event-31784759674
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 24, 2026https://github.com/nodejs/node/pull/66178#issuecomment-5820788562
https://ci.nodejs.org/job/node-test-pull-request/77859/https://ci.nodejs.org/job/node-test-pull-request/77859/
Please reload this pagehttps://github.com/nodejs/node/pull/66178
https://github.com/panva
panvahttps://github.com/panva
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 25, 2026https://github.com/nodejs/node/pull/66178#event-31839255500
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Sep 25, 2026https://github.com/nodejs/node/pull/66178#event-31839642868
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 25, 2026 https://github.com/nodejs/node/pull/66178#pullrequestreview-5320606161
View reviewed changes https://github.com/nodejs/node/pull/66178/files/aa0c8b55d4c6c74ab2d12e4f30c8366a439dd535
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
6c59f35https://github.com/nodejs/node/commit/6c59f3595735d7c666e9d70edab8db3d61aa791b
Sep 25, 2026https://github.com/nodejs/node/pull/66178#event-31853636835
Please reload this pagehttps://github.com/nodejs/node/pull/66178
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 25, 2026https://github.com/nodejs/node/pull/66178#issuecomment-5836713757
6c59f35https://github.com/nodejs/node/commit/6c59f3595735d7c666e9d70edab8db3d61aa791b
Please reload this pagehttps://github.com/nodejs/node/pull/66178
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Sep 25, 2026https://github.com/nodejs/node/pull/66178#event-31853640154
aduh95https://github.com/aduh95
Sep 27, 2026 https://github.com/nodejs/node/pull/66178#ref-commit-4e71236
https://github.com/soulee-dev
https://github.com/aduh95
ffi: allocate string argument storage lazilyhttps://github.com/nodejs/node/commit/4e71236264f55a18144be504975b3f30cf8688c1
4e71236https://github.com/nodejs/node/commit/4e71236264f55a18144be504975b3f30cf8688c1
#66178https://github.com/nodejs/node/pull/66178
HoonDongKanghttps://github.com/HoonDongKang
Sep 28, 2026 https://github.com/nodejs/node/pull/66178#ref-commit-00b379f
https://github.com/soulee-dev
https://github.com/HoonDongKang
ffi: allocate string argument storage lazilyhttps://github.com/HoonDongKang/node/commit/00b379fa9e4be158bbca9b74fda6ab774e217a4a
00b379fhttps://github.com/HoonDongKang/node/commit/00b379fa9e4be158bbca9b74fda6ab774e217a4a
nodejs#66178https://github.com/nodejs/node/pull/66178
aduh95https://github.com/aduh95
Sep 28, 2026 https://github.com/nodejs/node/pull/66178#ref-commit-0f6cdce
https://github.com/soulee-dev
https://github.com/aduh95
ffi: allocate string argument storage lazilyhttps://github.com/nodejs/node/commit/0f6cdce998627d4ad7b8f88a98e4886e83e734fb
0f6cdcehttps://github.com/nodejs/node/commit/0f6cdce998627d4ad7b8f88a98e4886e83e734fb
#66178https://github.com/nodejs/node/pull/66178
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 5, 2026 https://github.com/nodejs/node/pull/66178#ref-pullrequest-5720654094
2026-10-07, Version 26.11.0 (Current) #66546 https://github.com/nodejs/node/pull/66546
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/66178#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
markhardinghttps://github.com/markharding
Nov 5, 2026 https://github.com/nodejs/node/pull/66178#ref-commit-609f23e
https://github.com/markharding
Update Node.js to v26 (#2168)https://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
609f23ehttps://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66178
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/66178/files/aa0c8b55d4c6c74ab2d12e4f30c8366a439dd535
https://github.com/daeyeon
daeyeon https://github.com/daeyeon
https://github.com/nodejs/node/pull/66178/files/aa0c8b55d4c6c74ab2d12e4f30c8366a439dd535
Please reload this pagehttps://github.com/nodejs/node/pull/66178
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/66178
https://github.com/soulee-dev
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/daeyeon
https://github.com/panva
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.