René's URL Explorer Experiment


Title: fs: validate falsy openAsBlob type option by christianaurichzm · Pull Request #66125 · nodejs/node · GitHub

Open Graph Title: fs: validate falsy openAsBlob type option by christianaurichzm · Pull Request #66125 · nodejs/node

X Title: fs: validate falsy openAsBlob type option by christianaurichzm · Pull Request #66125 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: openAsBlob() and openAsBlobSync() use options.type || '' before validating the option. This causes falsy non-string values such as null, false, 0, and NaN to be silently replaced with the d...

X Description: openAsBlob() and openAsBlobSync() use options.type || '' before validating the option. This causes falsy non-string values such as null, false, 0, and NaN to be silently replaced wi...

Opengraph URL: https://github.com/nodejs/node/pull/66125

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c32a32ad-916b-c4a4-f76b-04ecd2821a48
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id87A4:2FF8F1:7CB9D6:A1DF6D:6AED33D7
html-safe-nonce261a0512beca1037f0077dd6438829da58ecf09478cfb0ce89260b58cdaa2d91
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0E0OjJGRjhGMTo3Q0I5RDY6QTFERjZEOjZBRUQzM0Q3IiwidmlzaXRvcl9pZCI6Ijg5NDUxNzkxOTQzNDEyNzQ1ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac625e6c63cf30a1f142b9d462034731a7e9eec7314f5d0a9b08be4ab9bce4f45c
hovercard-subject-tagpull_request:4576034966
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66125/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9be095e820e1f739e613962812c74df6454b55f0b949c0ba0f2ce032742446b7/nodejs/node/pull/66125
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9be095e820e1f739e613962812c74df6454b55f0b949c0ba0f2ce032742446b7/nodejs/node/pull/66125
og:image:altopenAsBlob() and openAsBlobSync() use options.type || '' before validating the option. This causes falsy non-string values such as null, false, 0, and NaN to be silently replaced with the d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechristianaurichzm
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66125#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66125
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66125
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66125
Reloadhttps://github.com/nodejs/node/pull/66125
Reloadhttps://github.com/nodejs/node/pull/66125
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
christianaurichzm:fs-openasblob-type-validationhttps://github.com/christianaurichzm/node/tree/fs-openasblob-type-validation
Conversationhttps://github.com/nodejs/node/pull/66125
Commits1 (1)https://github.com/nodejs/node/pull/66125/commits
Checkshttps://github.com/nodejs/node/pull/66125/checks
Files changedhttps://github.com/nodejs/node/pull/66125/files
fs: validate falsy openAsBlob type optionhttps://github.com/nodejs/node/pull/66125#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
christianaurichzm:fs-openasblob-type-validationhttps://github.com/christianaurichzm/node/tree/fs-openasblob-type-validation
https://github.com/christianaurichzm
christianaurichzmhttps://github.com/christianaurichzm
Sep 19, 2026https://github.com/nodejs/node/pull/66125#issue-5508126935
Please reload this pagehttps://github.com/nodejs/node/pull/66125
https://github.com/christianaurichzm
fs: validate falsy openAsBlob type optionhttps://github.com/nodejs/node/pull/66125/commits/05453392a4490dbe96edff0b38969cac874f18da
0545339https://github.com/nodejs/node/pull/66125/commits/05453392a4490dbe96edff0b38969cac874f18da
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 19, 2026https://github.com/nodejs/node/pull/66125#event-31435133906
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 19, 2026https://github.com/nodejs/node/pull/66125#issuecomment-5740184576
Please reload this pagehttps://github.com/nodejs/node/pull/66125
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66125?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
b125121https://app.codecov.io/gh/nodejs/node/commit/b1251217f2d28070fac7497fd600e805faa607dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
0545339https://app.codecov.io/gh/nodejs/node/commit/05453392a4490dbe96edff0b38969cac874f18da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66125?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/fs.jshttps://app.codecov.io/gh/nodejs/node/pull/66125?src=pr&el=tree&filepath=lib%2Ffs.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ZzLmpz
27 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66125/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66125
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 19, 2026 https://github.com/nodejs/node/pull/66125#pullrequestreview-5256127331
View reviewed changes https://github.com/nodejs/node/pull/66125/files/05453392a4490dbe96edff0b38969cac874f18da
https://github.com/inoway46
inoway46https://github.com/inoway46
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 21, 2026https://github.com/nodejs/node/pull/66125#event-31501494806
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 21, 2026https://github.com/nodejs/node/pull/66125#event-31502309759
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 21, 2026https://github.com/nodejs/node/pull/66125#issuecomment-5755003841
https://ci.nodejs.org/job/node-test-pull-request/77699/https://ci.nodejs.org/job/node-test-pull-request/77699/
Please reload this pagehttps://github.com/nodejs/node/pull/66125
https://github.com/christianaurichzm
christianaurichzmhttps://github.com/christianaurichzm
Sep 22, 2026https://github.com/nodejs/node/pull/66125#issuecomment-5773943036
Please reload this pagehttps://github.com/nodejs/node/pull/66125
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 22, 2026https://github.com/nodejs/node/pull/66125#issuecomment-5784619667
https://ci.nodejs.org/job/node-test-pull-request/77768/https://ci.nodejs.org/job/node-test-pull-request/77768/
Please reload this pagehttps://github.com/nodejs/node/pull/66125
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 25, 2026https://github.com/nodejs/node/pull/66125#event-31824679545
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Sep 25, 2026https://github.com/nodejs/node/pull/66125#event-31839651184
https://github.com/panva
panvahttps://github.com/panva
Sep 25, 2026 https://github.com/nodejs/node/pull/66125#pullrequestreview-5321931842
View reviewed changes https://github.com/nodejs/node/pull/66125/files/05453392a4490dbe96edff0b38969cac874f18da
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
cc610f1https://github.com/nodejs/node/commit/cc610f1cfbf44f86be0eada4a225b7e64a7f8b65
Sep 25, 2026https://github.com/nodejs/node/pull/66125#event-31861109563
Please reload this pagehttps://github.com/nodejs/node/pull/66125
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 25, 2026https://github.com/nodejs/node/pull/66125#issuecomment-5838536818
cc610f1https://github.com/nodejs/node/commit/cc610f1cfbf44f86be0eada4a225b7e64a7f8b65
Please reload this pagehttps://github.com/nodejs/node/pull/66125
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Sep 25, 2026https://github.com/nodejs/node/pull/66125#event-31861113810
aduh95https://github.com/aduh95
Sep 27, 2026 https://github.com/nodejs/node/pull/66125#ref-commit-7aa7886
https://github.com/christianaurichzm
https://github.com/aduh95
fs: validate falsy openAsBlob type optionhttps://github.com/nodejs/node/commit/7aa7886b1115b80bc532f301fce7ec4383714cb1
7aa7886https://github.com/nodejs/node/commit/7aa7886b1115b80bc532f301fce7ec4383714cb1
#66125https://github.com/nodejs/node/pull/66125
HoonDongKanghttps://github.com/HoonDongKang
Sep 28, 2026 https://github.com/nodejs/node/pull/66125#ref-commit-2e72f59
https://github.com/christianaurichzm
https://github.com/HoonDongKang
fs: validate falsy openAsBlob type optionhttps://github.com/HoonDongKang/node/commit/2e72f597c3672118c8e90fba90e217158efb58f4
2e72f59https://github.com/HoonDongKang/node/commit/2e72f597c3672118c8e90fba90e217158efb58f4
nodejs#66125https://github.com/nodejs/node/pull/66125
aduh95https://github.com/aduh95
Sep 28, 2026 https://github.com/nodejs/node/pull/66125#ref-commit-8b24247
https://github.com/christianaurichzm
https://github.com/aduh95
fs: validate falsy openAsBlob type optionhttps://github.com/nodejs/node/commit/8b24247be100f800c4ec2d4ef7fb1942725cdfe6
8b24247https://github.com/nodejs/node/commit/8b24247be100f800c4ec2d4ef7fb1942725cdfe6
#66125https://github.com/nodejs/node/pull/66125
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 5, 2026 https://github.com/nodejs/node/pull/66125#ref-pullrequest-5720654094
2026-10-07, Version 26.11.0 (Current) #66546 https://github.com/nodejs/node/pull/66546
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/66125#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
markhardinghttps://github.com/markharding
Nov 5, 2026 https://github.com/nodejs/node/pull/66125#ref-commit-609f23e
https://github.com/markharding
Update Node.js to v26 (#2168)https://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
609f23ehttps://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66125
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/66125/files/05453392a4490dbe96edff0b38969cac874f18da
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/66125/files/05453392a4490dbe96edff0b38969cac874f18da
Please reload this pagehttps://github.com/nodejs/node/pull/66125
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/66125
https://github.com/christianaurichzm
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/jasnell
https://github.com/inoway46
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.