Title: Revert "deps: V8: override `depot_tools` version" by richardlau · Pull Request #66110 · nodejs/node · GitHub
Open Graph Title: Revert "deps: V8: override `depot_tools` version" by richardlau · Pull Request #66110 · nodejs/node
X Title: Revert "deps: V8: override `depot_tools` version" by richardlau · Pull Request #66110 · nodejs/node
Description: This reverts commit abff716. No longer required as the override points to the same commit sha of depot_tools as deps/v8/DEPS. This change only affects node-test-commit-v8-linux or make test-v8. For context. we needed to roll to a newer version of depot_tools on older Node.js release lines for Python 3.12 compatibility in #62344. I noted at the time: cc @nodejs/v8-update This will need to be cherry-picked onto all release lines that we want to run the V8 CI on as it is necessary to run on Ubuntu 24.04 where the default Python 3 is 3.12. We should also undo it with/after #61898 (or newer V8) as that will set a new enough version of depot_tools to be Python 3.12 compatible. All of these point to depot_tools@284c5ccb591c3de4e9f71be4a4beb5d1916d5383 so the override is not needed on main and v26.x-staging: main: node/tools/v8/fetch_deps.py Lines 27 to 28 in afbfccc # Update depot_tools for compatibility with Python 3.12. "v8/third_party/depot_tools" : "https://chromium.googlesource.com/chromium/tools/depot_tools.git@284c5ccb591c3de4e9f71be4a4beb5d1916d5383", node/deps/v8/DEPS Lines 228 to 229 in afbfccc 'third_party/depot_tools': Var('chromium_url') + '/chromium/tools/depot_tools.git' + '@' + '284c5ccb591c3de4e9f71be4a4beb5d1916d5383', v26.x-staging: node/deps/v8/DEPS Lines 228 to 229 in da341e2 'third_party/depot_tools': Var('chromium_url') + '/chromium/tools/depot_tools.git' + '@' + '284c5ccb591c3de4e9f71be4a4beb5d1916d5383', Even worse, leaving the override would result in an older version of depot_tools than in deps/v8/DEPS from newer versions of V8 (e.g. #65161).
Open Graph Description: This reverts commit abff716. No longer required as the override points to the same commit sha of depot_tools as deps/v8/DEPS. This change only affects node-test-commit-v8-linux or make test-v8. Fo...
X Description: This reverts commit abff716. No longer required as the override points to the same commit sha of depot_tools as deps/v8/DEPS. This change only affects node-test-commit-v8-linux or make test-v8. Fo...
Opengraph URL: https://github.com/nodejs/node/pull/66110
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:30483765-2b9f-f111-1873-ef60c1894200 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C21A:2B6F5F:4FA1C8D:6F3E510:6AEDCB1B |
| html-safe-nonce | 982ecdabdf052be3859745a30c34c197080b2b6e0798f8036f5cfe5caa6ea634 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjFBOjJCNkY1Rjo0RkExQzhEOjZGM0U1MTA6NkFFRENCMUIiLCJ2aXNpdG9yX2lkIjoiNjI1MDQ3NDI3NDI1OTA2MTUzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | efe169d14e1a6701fa856826517fef60d958c542629b4f8881ba50ce0ad51a8f |
| hovercard-subject-tag | pull_request:4570192832 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/66110/commits/fd6677922f4abaf55b0530a3c0a81b1c47eaa46a |
| twitter:image | https://avatars.githubusercontent.com/u/5445507?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5445507?s=400&v=4 |
| og:image:alt | This reverts commit abff716. No longer required as the override points to the same commit sha of depot_tools as deps/v8/DEPS. This change only affects node-test-commit-v8-linux or make test-v8. Fo... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f60373873bb1ef795e8511ea1f2a76997e9c649d72b02942aedf2def3423a0ce |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0f55cfa61438c7dc93d1024a1e5e5182b36830e2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width