René's URL Explorer Experiment


Title: worker: remove messageerror listeners on exit by dayun6530 · Pull Request #66075 · nodejs/node · GitHub

Open Graph Title: worker: remove messageerror listeners on exit by dayun6530 · Pull Request #66075 · nodejs/node

X Title: worker: remove messageerror listeners on exit by dayun6530 · Pull Request #66075 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes a typo in the worker exit cleanup so messageerror listeners are removed before the exit event is emitted. Adds a regression test covering the listener cleanup behavior. Tests: python3 tools/...

X Description: Fixes a typo in the worker exit cleanup so messageerror listeners are removed before the exit event is emitted. Adds a regression test covering the listener cleanup behavior. Tests: python3 tools/...

Opengraph URL: https://github.com/nodejs/node/pull/66075

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d342541a-bba1-83e9-3313-deeef4f5fb17
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC34:254A2:73BB3:9D982:6AED0437
html-safe-nonce5686ca945121b9e4756c07df2acbfe5884f61c42765f44b5804d7a49255e3a45
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzM0OjI1NEEyOjczQkIzOjlEOTgyOjZBRUQwNDM3IiwidmlzaXRvcl9pZCI6IjQ4MTAyMTA2MjI4MDIwMzU3NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac16b39b99dffdb9b31f330cbcef8d95131d95efa2c94fb859116f7f0273fb15eb
hovercard-subject-tagpull_request:4553756634
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66075/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d000032ff99a018e186363bc331ca591efc5c2cfd32fc97f7a5f2a9b65c6dbce/nodejs/node/pull/66075
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d000032ff99a018e186363bc331ca591efc5c2cfd32fc97f7a5f2a9b65c6dbce/nodejs/node/pull/66075
og:image:altFixes a typo in the worker exit cleanup so messageerror listeners are removed before the exit event is emitted. Adds a regression test covering the listener cleanup behavior. Tests: python3 tools/...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedayun6530
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66075#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66075
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66075
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66075
Reloadhttps://github.com/nodejs/node/pull/66075
Reloadhttps://github.com/nodejs/node/pull/66075
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
dayun6530:fix/worker-messageerror-listener-cleanuphttps://github.com/dayun6530/node/tree/fix/worker-messageerror-listener-cleanup
Conversationhttps://github.com/nodejs/node/pull/66075
Commits1 (1)https://github.com/nodejs/node/pull/66075/commits
Checkshttps://github.com/nodejs/node/pull/66075/checks
Files changedhttps://github.com/nodejs/node/pull/66075/files
worker: remove messageerror listeners on exithttps://github.com/nodejs/node/pull/66075#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
dayun6530:fix/worker-messageerror-listener-cleanuphttps://github.com/dayun6530/node/tree/fix/worker-messageerror-listener-cleanup
https://github.com/dayun6530
dayun6530https://github.com/dayun6530
Sep 17, 2026https://github.com/nodejs/node/pull/66075#issue-5481819059
#65782https://github.com/nodejs/node/issues/65782
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/dayun6530
worker: remove messageerror listeners on exithttps://github.com/nodejs/node/pull/66075/commits/734c24d90cfc0e6cfac5bdc7816aaa94145e7519
734c24dhttps://github.com/nodejs/node/pull/66075/commits/734c24d90cfc0e6cfac5bdc7816aaa94145e7519
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Sep 17, 2026https://github.com/nodejs/node/pull/66075#event-31287173985
https://github.com/dayun6530
dayun6530https://github.com/dayun6530
September 17, 2026 01:54https://github.com/nodejs/node/pull/66075#event-31287420382
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 17, 2026https://github.com/nodejs/node/pull/66075#issuecomment-5707972913
Please reload this pagehttps://github.com/nodejs/node/pull/66075
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66075?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
c081d10https://app.codecov.io/gh/nodejs/node/commit/c081d10d7e436f3c99d0c1f4dd2097207cb011ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
734c24dhttps://app.codecov.io/gh/nodejs/node/commit/734c24d90cfc0e6cfac5bdc7816aaa94145e7519?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66075?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/worker.jshttps://app.codecov.io/gh/nodejs/node/pull/66075?src=pr&el=tree&filepath=lib%2Finternal%2Fworker.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3dvcmtlci5qcw==
71 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66075/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/dayun6530
dayun6530https://github.com/dayun6530
Sep 22, 2026https://github.com/nodejs/node/pull/66075#issuecomment-5771504405
#65782https://github.com/nodejs/node/issues/65782
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 22, 2026 https://github.com/nodejs/node/pull/66075#pullrequestreview-5284087722
View reviewed changes https://github.com/nodejs/node/pull/66075/files/734c24d90cfc0e6cfac5bdc7816aaa94145e7519
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 23, 2026https://github.com/nodejs/node/pull/66075#event-31664813970
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 23, 2026https://github.com/nodejs/node/pull/66075#event-31665205372
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 23, 2026https://github.com/nodejs/node/pull/66075#issuecomment-5792512195
https://ci.nodejs.org/job/node-test-pull-request/77779/https://ci.nodejs.org/job/node-test-pull-request/77779/
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Sep 25, 2026https://github.com/nodejs/node/pull/66075#event-31825126323
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Sep 25, 2026https://github.com/nodejs/node/pull/66075#event-31825831584
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 25, 2026https://github.com/nodejs/node/pull/66075#issuecomment-5830332701
https://ci.nodejs.org/job/node-test-pull-request/77885/https://ci.nodejs.org/job/node-test-pull-request/77885/
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Sep 25, 2026https://github.com/nodejs/node/pull/66075#event-31847707205
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Sep 25, 2026https://github.com/nodejs/node/pull/66075#event-31847974372
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 25, 2026https://github.com/nodejs/node/pull/66075#issuecomment-5835361899
https://ci.nodejs.org/job/node-test-pull-request/77907/https://ci.nodejs.org/job/node-test-pull-request/77907/
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2026https://github.com/nodejs/node/pull/66075#issuecomment-5843911674
https://ci.nodejs.org/job/node-test-pull-request/77932/https://ci.nodejs.org/job/node-test-pull-request/77932/
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2026https://github.com/nodejs/node/pull/66075#issuecomment-5844104638
https://ci.nodejs.org/job/node-test-pull-request/77943/https://ci.nodejs.org/job/node-test-pull-request/77943/
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2026https://github.com/nodejs/node/pull/66075#issuecomment-5844860111
https://ci.nodejs.org/job/node-test-pull-request/77949/https://ci.nodejs.org/job/node-test-pull-request/77949/
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2026https://github.com/nodejs/node/pull/66075#issuecomment-5848586085
https://ci.nodejs.org/job/node-test-pull-request/77969/https://ci.nodejs.org/job/node-test-pull-request/77969/
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/panva
panvahttps://github.com/panva
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 26, 2026https://github.com/nodejs/node/pull/66075#event-31903700473
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
d9208cchttps://github.com/nodejs/node/commit/d9208ccdccb1c6cd5bd0011df0775e860c5d2d1e
Sep 26, 2026https://github.com/nodejs/node/pull/66075#event-31903911448
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2026https://github.com/nodejs/node/pull/66075#issuecomment-5849292740
d9208cchttps://github.com/nodejs/node/commit/d9208ccdccb1c6cd5bd0011df0775e860c5d2d1e
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 26, 2026https://github.com/nodejs/node/pull/66075#event-31903913278
aduh95https://github.com/aduh95
Sep 27, 2026 https://github.com/nodejs/node/pull/66075#ref-commit-c692b9e
https://github.com/dayun6530
https://github.com/aduh95
worker: remove messageerror listeners on exithttps://github.com/nodejs/node/commit/c692b9ebbfe943c207540457455a08532d10549e
c692b9ehttps://github.com/nodejs/node/commit/c692b9ebbfe943c207540457455a08532d10549e
#66075https://github.com/nodejs/node/pull/66075
#65782https://github.com/nodejs/node/issues/65782
HoonDongKanghttps://github.com/HoonDongKang
Sep 28, 2026 https://github.com/nodejs/node/pull/66075#ref-commit-0629da1
https://github.com/dayun6530
https://github.com/HoonDongKang
worker: remove messageerror listeners on exithttps://github.com/HoonDongKang/node/commit/0629da1d79d28b00f189673aee1bfe02ee706e52
0629da1https://github.com/HoonDongKang/node/commit/0629da1d79d28b00f189673aee1bfe02ee706e52
nodejs#66075https://github.com/nodejs/node/pull/66075
nodejs#65782https://github.com/nodejs/node/issues/65782
aduh95https://github.com/aduh95
Sep 28, 2026 https://github.com/nodejs/node/pull/66075#ref-commit-b896580
https://github.com/dayun6530
https://github.com/aduh95
worker: remove messageerror listeners on exithttps://github.com/nodejs/node/commit/b896580c4724d98bcedbbf638c90923507f092c2
b896580https://github.com/nodejs/node/commit/b896580c4724d98bcedbbf638c90923507f092c2
#66075https://github.com/nodejs/node/pull/66075
#65782https://github.com/nodejs/node/issues/65782
docs: add contribution note for #66075 ossca-node/board#25 https://github.com/ossca-node/board/pull/25
docs: add contribution note for #66075 ossca-node/board#26 https://github.com/ossca-node/board/pull/26
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 5, 2026 https://github.com/nodejs/node/pull/66075#ref-pullrequest-5720654094
2026-10-07, Version 26.11.0 (Current) #66546 https://github.com/nodejs/node/pull/66546
aduh95https://github.com/aduh95
Oct 23, 2026 https://github.com/nodejs/node/pull/66075#ref-commit-06ce26d
https://github.com/dayun6530
https://github.com/aduh95
worker: remove messageerror listeners on exithttps://github.com/nodejs/node/commit/06ce26dec5d2b35509b69960c2846f72dc946475
06ce26dhttps://github.com/nodejs/node/commit/06ce26dec5d2b35509b69960c2846f72dc946475
#66075https://github.com/nodejs/node/pull/66075
#65782https://github.com/nodejs/node/issues/65782
aduh95https://github.com/aduh95
Oct 28, 2026 https://github.com/nodejs/node/pull/66075#ref-commit-761c3d5
https://github.com/dayun6530
https://github.com/aduh95
worker: remove messageerror listeners on exithttps://github.com/nodejs/node/commit/761c3d54607e2d06ca2620cd07c933b13b6f26ff
761c3d5https://github.com/nodejs/node/commit/761c3d54607e2d06ca2620cd07c933b13b6f26ff
#66075https://github.com/nodejs/node/pull/66075
#65782https://github.com/nodejs/node/issues/65782
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/66075#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66075
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/66075/files/734c24d90cfc0e6cfac5bdc7816aaa94145e7519
Please reload this pagehttps://github.com/nodejs/node/pull/66075
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
worker: messageerror listeners remain during exit https://github.com/nodejs/node/issues/65782
Please reload this pagehttps://github.com/nodejs/node/pull/66075
https://github.com/dayun6530
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/panva
https://github.com/daeyeon
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.