René's URL Explorer Experiment


Title: stream: destroy half-open sockets after iteration by mcollina · Pull Request #65986 · nodejs/node · GitHub

Open Graph Title: stream: destroy half-open sockets after iteration by mcollina · Pull Request #65986 · nodejs/node

X Title: stream: destroy half-open sockets after iteration by mcollina · Pull Request #65986 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Async iteration left the writable side of allowHalfOpen duplexes open after clean EOF. For net.Socket instances, this retained a live handle after the peer disconnected. Restore default iterator de...

X Description: Async iteration left the writable side of allowHalfOpen duplexes open after clean EOF. For net.Socket instances, this retained a live handle after the peer disconnected. Restore default iterator de...

Opengraph URL: https://github.com/nodejs/node/pull/65986

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:60f0b8f0-b133-c416-cc12-2ecccf0d5f0d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC26:1258EF:AC5BB6:E0FDE0:6AED4439
html-safe-nonceea72dfdcceee796a3ab57dda0223eb1129a89cff0ad88bba1923e92ad6b7aa49
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzI2OjEyNThFRjpBQzVCQjY6RTBGREUwOjZBRUQ0NDM5IiwidmlzaXRvcl9pZCI6IjQ5MzIzMDc1MTkzMDEwNDMyNTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac90e70834df4ff88e1d7bad05224f7e95eb2a19461302bfef0067045fa8ea46d9
hovercard-subject-tagpull_request:4507393712
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65986/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7064e20379b773d78c569743215b9e5214e2994a96604c7634701885b1039f89/nodejs/node/pull/65986
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7064e20379b773d78c569743215b9e5214e2994a96604c7634701885b1039f89/nodejs/node/pull/65986
og:image:altAsync iteration left the writable side of allowHalfOpen duplexes open after clean EOF. For net.Socket instances, this retained a live handle after the peer disconnected. Restore default iterator de...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcollina
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65986#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65986
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65986
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65986
Reloadhttps://github.com/nodejs/node/pull/65986
Reloadhttps://github.com/nodejs/node/pull/65986
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests663 (663)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
mcollina:fix-stream-async-iterator-socket-leakhttps://github.com/mcollina/node/tree/fix-stream-async-iterator-socket-leak
Conversationhttps://github.com/nodejs/node/pull/65986
Commits1 (1)https://github.com/nodejs/node/pull/65986/commits
Checkshttps://github.com/nodejs/node/pull/65986/checks
Files changedhttps://github.com/nodejs/node/pull/65986/files
stream: destroy half-open sockets after iterationhttps://github.com/nodejs/node/pull/65986#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
mcollina:fix-stream-async-iterator-socket-leakhttps://github.com/mcollina/node/tree/fix-stream-async-iterator-socket-leak
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 11, 2026https://github.com/nodejs/node/pull/65986#issue-5426167085
#65110https://github.com/nodejs/node/issues/65110
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/mcollina
stream: destroy half-open sockets after iterationhttps://github.com/nodejs/node/pull/65986/commits/0539c7f10507b7abef9782d2cc2c2b80a0b3d3d4
0539c7fhttps://github.com/nodejs/node/pull/65986/commits/0539c7f10507b7abef9782d2cc2c2b80a0b3d3d4
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 11, 2026https://github.com/nodejs/node/pull/65986#issuecomment-5636874557
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 11, 2026https://github.com/nodejs/node/pull/65986#event-30982346212
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Sep 11, 2026https://github.com/nodejs/node/pull/65986#event-30982352602
https://github.com/mcollina
mcollinahttps://github.com/mcollina
ronaghttps://github.com/ronag
ronaghttps://github.com/ronag
September 11, 2026 15:37https://github.com/nodejs/node/pull/65986#event-30982365853
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 11, 2026https://github.com/nodejs/node/pull/65986#event-30982392839
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 11, 2026 https://github.com/nodejs/node/pull/65986#pullrequestreview-5180847706
View reviewed changes https://github.com/nodejs/node/pull/65986/files/0539c7f10507b7abef9782d2cc2c2b80a0b3d3d4
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 11, 2026https://github.com/nodejs/node/pull/65986#issuecomment-5637631608
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Sep 11, 2026https://github.com/nodejs/node/pull/65986#issuecomment-5637727827
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 11, 2026https://github.com/nodejs/node/pull/65986#issuecomment-5638296556
Please reload this pagehttps://github.com/nodejs/node/pull/65986
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65986?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
c909c63https://app.codecov.io/gh/nodejs/node/commit/c909c63be392b4c9ffdc2108e64371b9fa83e472?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
0539c7fhttps://app.codecov.io/gh/nodejs/node/commit/0539c7f10507b7abef9782d2cc2c2b80a0b3d3d4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65986?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/readable.jshttps://app.codecov.io/gh/nodejs/node/pull/65986?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Freadable.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvcmVhZGFibGUuanM=
29 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65986/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 11, 2026 https://github.com/nodejs/node/pull/65986#pullrequestreview-5182241473
View reviewed changes https://github.com/nodejs/node/pull/65986/files/0539c7f10507b7abef9782d2cc2c2b80a0b3d3d4
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 13, 2026https://github.com/nodejs/node/pull/65986#event-31061725487
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 13, 2026https://github.com/nodejs/node/pull/65986#event-31061927161
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 13, 2026https://github.com/nodejs/node/pull/65986#issuecomment-5655495723
https://ci.nodejs.org/job/node-test-pull-request/77434/https://ci.nodejs.org/job/node-test-pull-request/77434/
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 14, 2026https://github.com/nodejs/node/pull/65986#event-31082318301
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 14, 2026https://github.com/nodejs/node/pull/65986#issuecomment-5661254965
https://ci.nodejs.org/job/node-test-pull-request/77459/https://ci.nodejs.org/job/node-test-pull-request/77459/
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 15, 2026https://github.com/nodejs/node/pull/65986#event-31148252685
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 15, 2026https://github.com/nodejs/node/pull/65986#event-31148883468
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 15, 2026https://github.com/nodejs/node/pull/65986#issuecomment-5675171907
https://github.com/nodejs/node/actions/runs/34932314346https://github.com/nodejs/node/actions/runs/34932314346
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 15, 2026https://github.com/nodejs/node/pull/65986#event-31149578899
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 15, 2026https://github.com/nodejs/node/pull/65986#event-31149853245
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 15, 2026https://github.com/nodejs/node/pull/65986#issuecomment-5675376501
https://github.com/nodejs/node/actions/runs/34933997571https://github.com/nodejs/node/actions/runs/34933997571
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
Sep 17, 2026https://github.com/nodejs/node/pull/65986#event-31295611670
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 17, 2026https://github.com/nodejs/node/pull/65986#event-31295761287
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 17, 2026https://github.com/nodejs/node/pull/65986#issuecomment-5709313944
https://github.com/nodejs/node/actions/runs/35185994844https://github.com/nodejs/node/actions/runs/35185994844
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 17, 2026 https://github.com/nodejs/node/pull/65986#ref-pullrequest-5484950225
fix: start CI when the duplicate check cannot query Jenkins nodejs/node-core-utils#1195 https://github.com/nodejs/node-core-utils/pull/1195
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 17, 2026https://github.com/nodejs/node/pull/65986#issuecomment-5716377030
https://ci.nodejs.org/job/node-test-pull-request/77569/https://ci.nodejs.org/job/node-test-pull-request/77569/
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/mcollina
mcollinahttps://github.com/mcollina
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
Sep 18, 2026https://github.com/nodejs/node/pull/65986#event-31369401102
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
795585ehttps://github.com/nodejs/node/commit/795585e87e1ad20720ac2ccf610a1f4de73ac504
Sep 18, 2026https://github.com/nodejs/node/pull/65986#event-31369684084
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 18, 2026https://github.com/nodejs/node/pull/65986#issuecomment-5725680415
795585ehttps://github.com/nodejs/node/commit/795585e87e1ad20720ac2ccf610a1f4de73ac504
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 18, 2026https://github.com/nodejs/node/pull/65986#event-31369686075
aduh95https://github.com/aduh95
Sep 18, 2026 https://github.com/nodejs/node/pull/65986#ref-commit-e5d2a33
https://github.com/mcollina
https://github.com/aduh95
stream: destroy half-open sockets after iterationhttps://github.com/nodejs/node/commit/e5d2a336bdae6f6d728508bf8f27d04016986002
e5d2a33https://github.com/nodejs/node/commit/e5d2a336bdae6f6d728508bf8f27d04016986002
#65986https://github.com/nodejs/node/pull/65986
#65110https://github.com/nodejs/node/issues/65110
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 20, 2026 https://github.com/nodejs/node/pull/65986#ref-pullrequest-5520639298
2026-09-22, Version 26.10.0 (Current) #66163 https://github.com/nodejs/node/pull/66163
https://github.com/hy0ug0
hy0ug0https://github.com/hy0ug0
Oct 9, 2026 https://github.com/nodejs/node/pull/65986#ref-pullrequest-5784668293
Add per-reviewer response time hy0ug0/pr-reviews-analysis#32 https://github.com/hy0ug0/pr-reviews-analysis/pull/32
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65986
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65986/files/0539c7f10507b7abef9782d2cc2c2b80a0b3d3d4
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/65986/files/0539c7f10507b7abef9782d2cc2c2b80a0b3d3d4
Please reload this pagehttps://github.com/nodejs/node/pull/65986
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Multiple independent reports of out-of-memory crash after updating 24.18.1->24.19.0 https://github.com/nodejs/node/issues/65110
Please reload this pagehttps://github.com/nodejs/node/pull/65986
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com/trevnorris
https://github.com/jasnell
https://github.com/ronag
https://github.com/panva
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.