René's URL Explorer Experiment


Title: deps: read unaligned two byte data in nbytes search by bitpshr · Pull Request #65968 · nodejs/node · GitHub

Open Graph Title: deps: read unaligned two byte data in nbytes search by bitpshr · Pull Request #65968 · nodejs/node

X Title: deps: read unaligned two byte data in nbytes search by bitpshr · Pull Request #65968 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #65959 A Buffer can be a view starting at an odd byte offset, so the data the UCS2 search runs over is not necessarily aligned for uint16_t. The string search read it through a uint16_t poin...

X Description: Fixes: #65959 A Buffer can be a view starting at an odd byte offset, so the data the UCS2 search runs over is not necessarily aligned for uint16_t. The string search read it through a uint16_t poin...

Opengraph URL: https://github.com/nodejs/node/pull/65968

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2d24cdac-e743-ae24-6731-46aeb6cb73c9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED04:204D3A:50C94F:6E0D97:6AED1EB3
html-safe-noncec425d669ab8459b2701f69193245462f275de5238fc0373b56d9f910592a5e04
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDA0OjIwNEQzQTo1MEM5NEY6NkUwRDk3OjZBRUQxRUIzIiwidmlzaXRvcl9pZCI6IjEyNzcxODE5Nzk3OTAyMjA5NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb2bb9fe986147e998b2c1bf9f1fc03104401ab7a856cedb1fbc288ce39f5a76d
hovercard-subject-tagpull_request:4500188158
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65968/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a1b4970e0222bb9ae3e59593c1eb8ecee199bcb1b07484ea393ae87e51305e52/nodejs/node/pull/65968
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a1b4970e0222bb9ae3e59593c1eb8ecee199bcb1b07484ea393ae87e51305e52/nodejs/node/pull/65968
og:image:altFixes: #65959 A Buffer can be a view starting at an odd byte offset, so the data the UCS2 search runs over is not necessarily aligned for uint16_t. The string search read it through a uint16_t poin...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebitpshr
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65968#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65968
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65968
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65968
Reloadhttps://github.com/nodejs/node/pull/65968
Reloadhttps://github.com/nodejs/node/pull/65968
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
bitpshrhttps://github.com/bitpshr
nodejs:mainhttps://github.com/nodejs/node/tree/main
bitpshr:buffer/ucs2-unaligned-indexofhttps://github.com/bitpshr/node/tree/buffer/ucs2-unaligned-indexof
Conversationhttps://github.com/nodejs/node/pull/65968
Commits1 (1)https://github.com/nodejs/node/pull/65968/commits
Checkshttps://github.com/nodejs/node/pull/65968/checks
Files changedhttps://github.com/nodejs/node/pull/65968/files
deps: read unaligned two byte data in nbytes searchhttps://github.com/nodejs/node/pull/65968#top
bitpshrhttps://github.com/bitpshr
nodejs:mainhttps://github.com/nodejs/node/tree/main
bitpshr:buffer/ucs2-unaligned-indexofhttps://github.com/bitpshr/node/tree/buffer/ucs2-unaligned-indexof
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
Sep 10, 2026https://github.com/nodejs/node/pull/65968#issue-5417536655
Please reload this pagehttps://github.com/nodejs/node/pull/65968
#65959https://github.com/nodejs/node/issues/65959
@bnoordhuishttps://github.com/bnoordhuis
#65960https://github.com/nodejs/node/pull/65960
@inoway46https://github.com/inoway46
Please reload this pagehttps://github.com/nodejs/node/pull/65968
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
Sep 10, 2026 https://github.com/nodejs/node/pull/65968#ref-issue-5411811927
buffer: UTF-16LE indexOf can hang on unaligned Buffer views #65959 https://github.com/nodejs/node/issues/65959
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 10, 2026https://github.com/nodejs/node/pull/65968#event-30932865726
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 10, 2026https://github.com/nodejs/node/pull/65968#issuecomment-5626941468
Please reload this pagehttps://github.com/nodejs/node/pull/65968
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65968?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
97af3d7https://app.codecov.io/gh/nodejs/node/commit/97af3d7da562406b75d1baeecb79ef8105d4b92a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
f360789https://app.codecov.io/gh/nodejs/node/commit/f3607899e081bff3049c59002532d735ebd8d6b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
see 34 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65968/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65968
https://github.com/inoway46
inoway46https://github.com/inoway46
Sep 12, 2026 https://github.com/nodejs/node/pull/65968#pullrequestreview-5185742313
View reviewed changes https://github.com/nodejs/node/pull/65968/files
inoway46https://github.com/inoway46
Please reload this pagehttps://github.com/nodejs/node/pull/65968
https://github.com/nodejs/node/pull/65968#pullrequestreview-5185742313
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#65960https://github.com/nodejs/node/pull/65960
@inoway46https://github.com/inoway46
#65960https://github.com/nodejs/node/pull/65960
Please reload this pagehttps://github.com/nodejs/node/pull/65968
src/node_buffer.cchttps://github.com/nodejs/node/pull/65968/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
inoway46https://github.com/inoway46
Sep 12, 2026https://github.com/nodejs/node/pull/65968#discussion_r3995529763
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65968
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 15, 2026 https://github.com/nodejs/node/pull/65968#pullrequestreview-5212867140
View reviewed changes https://github.com/nodejs/node/pull/65968/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/65968#pullrequestreview-5212867140
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65968
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
force-pushedhttps://github.com/nodejs/node/compare/7b53d526f61f28440e058b11edef137f5d67ad92..f3607899e081bff3049c59002532d735ebd8d6b6
7b53d52https://github.com/nodejs/node/commit/7b53d526f61f28440e058b11edef137f5d67ad92
f360789https://github.com/nodejs/node/commit/f3607899e081bff3049c59002532d735ebd8d6b6
Compare https://github.com/nodejs/node/compare/7b53d526f61f28440e058b11edef137f5d67ad92..f3607899e081bff3049c59002532d735ebd8d6b6
September 19, 2026 22:11https://github.com/nodejs/node/pull/65968#event-31461774799
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
Sep 19, 2026https://github.com/nodejs/node/pull/65968#issuecomment-5745668717
Please reload this pagehttps://github.com/nodejs/node/pull/65968
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
Sep 19, 2026https://github.com/nodejs/node/pull/65968#event-31461787886
https://github.com/inoway46
inoway46https://github.com/inoway46
Sep 20, 2026https://github.com/nodejs/node/pull/65968#issuecomment-5748015434
@bitpshrhttps://github.com/bitpshr
Please reload this pagehttps://github.com/nodejs/node/pull/65968
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
September 30, 2026 20:00https://github.com/nodejs/node/pull/65968#event-32197024322
https://github.com/bitpshr
deps: fix nbytes two byte search on unaligned datahttps://github.com/nodejs/node/pull/65968/commits/72df60f8aa21bbb30a6b3622aaacdf9e0be803f6
72df60fhttps://github.com/nodejs/node/pull/65968/commits/72df60f8aa21bbb30a6b3622aaacdf9e0be803f6
nodejs#65959https://github.com/nodejs/node/issues/65959
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
force-pushedhttps://github.com/nodejs/node/compare/f3607899e081bff3049c59002532d735ebd8d6b6..72df60f8aa21bbb30a6b3622aaacdf9e0be803f6
f360789https://github.com/nodejs/node/commit/f3607899e081bff3049c59002532d735ebd8d6b6
72df60fhttps://github.com/nodejs/node/commit/72df60f8aa21bbb30a6b3622aaacdf9e0be803f6
Compare https://github.com/nodejs/node/compare/f3607899e081bff3049c59002532d735ebd8d6b6..72df60f8aa21bbb30a6b3622aaacdf9e0be803f6
October 6, 2026 03:05https://github.com/nodejs/node/pull/65968#event-32563881643
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
Oct 6, 2026https://github.com/nodejs/node/pull/65968#issuecomment-6008492144
@inoway46https://github.com/inoway46
Please reload this pagehttps://github.com/nodejs/node/pull/65968
https://github.com/inoway46
inoway46https://github.com/inoway46
Oct 6, 2026https://github.com/nodejs/node/pull/65968#issuecomment-6017963826
Please reload this pagehttps://github.com/nodejs/node/pull/65968
https://github.com/inoway46
inoway46https://github.com/inoway46
Nov 2, 2026https://github.com/nodejs/node/pull/65968#issuecomment-6575234216
@bitpshrhttps://github.com/bitpshr
Please reload this pagehttps://github.com/nodejs/node/pull/65968
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65968
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/65968/files/7b53d526f61f28440e058b11edef137f5d67ad92
https://github.com/inoway46
inoway46 https://github.com/inoway46
https://github.com/nodejs/node/pull/65968/files/7b53d526f61f28440e058b11edef137f5d67ad92
Please reload this pagehttps://github.com/nodejs/node/pull/65968
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
buffer: UTF-16LE indexOf can hang on unaligned Buffer views https://github.com/nodejs/node/issues/65959
Please reload this pagehttps://github.com/nodejs/node/pull/65968
https://github.com/bitpshr
https://github.com/inoway46
https://github.com/bnoordhuis
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.