René's URL Explorer Experiment


Title: http: don't destroy socket after request completes by barathraj048 · Pull Request #65952 · nodejs/node · GitHub

Open Graph Title: http: don't destroy socket after request completes by barathraj048 · Pull Request #65952 · nodejs/node

X Title: http: don't destroy socket after request completes by barathraj048 · Pull Request #65952 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Aborting a ClientRequest after the request has finished sending and the response has fully arrived has nothing left to cancel. destroy() still called socket.destroy(err), but the resulting 'err...

X Description: Aborting a ClientRequest after the request has finished sending and the response has fully arrived has nothing left to cancel. destroy() still called socket.destroy(err), but the resulting &#39...

Opengraph URL: https://github.com/nodejs/node/pull/65952

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:48180220-1f37-d5f9-3c2b-ef3bea50587d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC308:D1DAA:C7192:1136EB:6AED0622
html-safe-nonceafb85386f56c1e4185e1b702cfccf80e6ccc72aa5e3964eed1cd409b6b7d3bd2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzA4OkQxREFBOkM3MTkyOjExMzZFQjo2QUVEMDYyMiIsInZpc2l0b3JfaWQiOiI0ODIzMjMxMjQ1NjU2NTg5ODU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbe34b84617d0098cb3ca5184ca01012de209f00caef167c7355f944ea2699681
hovercard-subject-tagpull_request:4492626608
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65952/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1083e69378bad7d5f7eebfddd636eaa69e814edfefaf52d832e67cc3dcd6cfe7/nodejs/node/pull/65952
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1083e69378bad7d5f7eebfddd636eaa69e814edfefaf52d832e67cc3dcd6cfe7/nodejs/node/pull/65952
og:image:altAborting a ClientRequest after the request has finished sending and the response has fully arrived has nothing left to cancel. destroy() still called socket.destroy(err), but the resulting 'err...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebarathraj048
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65952#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65952
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65952
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65952
Reloadhttps://github.com/nodejs/node/pull/65952
Reloadhttps://github.com/nodejs/node/pull/65952
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
barathraj048:http-no-abort-after-response-completehttps://github.com/barathraj048/node-js/tree/http-no-abort-after-response-complete
Conversationhttps://github.com/nodejs/node/pull/65952
Commits1 (1)https://github.com/nodejs/node/pull/65952/commits
Checkshttps://github.com/nodejs/node/pull/65952/checks
Files changedhttps://github.com/nodejs/node/pull/65952/files
http: don't destroy socket after request completeshttps://github.com/nodejs/node/pull/65952#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
barathraj048:http-no-abort-after-response-completehttps://github.com/barathraj048/node-js/tree/http-no-abort-after-response-complete
https://github.com/barathraj048
barathraj048https://github.com/barathraj048
Sep 10, 2026https://github.com/nodejs/node/pull/65952#issue-5408604478
Please reload this pagehttps://github.com/nodejs/node/pull/65952
#65938https://github.com/nodejs/node/issues/65938
Please reload this pagehttps://github.com/nodejs/node/pull/65952
https://github.com/barathraj048
http: don't destroy socket after request completeshttps://github.com/nodejs/node/pull/65952/commits/170744a22c08572aaaa1311b0810714d006c47a7
170744ahttps://github.com/nodejs/node/pull/65952/commits/170744a22c08572aaaa1311b0810714d006c47a7
nodejs#65938https://github.com/nodejs/node/issues/65938
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 10, 2026https://github.com/nodejs/node/pull/65952#issuecomment-5614148874
Please reload this pagehttps://github.com/nodejs/node/pull/65952
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 10, 2026https://github.com/nodejs/node/pull/65952#event-30880567784
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 10, 2026https://github.com/nodejs/node/pull/65952#issuecomment-5614156488
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
contribution and automation policieshttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
pull request guidehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
Code of Conducthttps://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
signed offhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#step-4-commit
Please reload this pagehttps://github.com/nodejs/node/pull/65952
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 10, 2026https://github.com/nodejs/node/pull/65952#issuecomment-5615560903
Please reload this pagehttps://github.com/nodejs/node/pull/65952
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65952?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
b3fb344https://app.codecov.io/gh/nodejs/node/commit/b3fb3440ae64fb56261876cc6cb90770bc0ea843?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
170744ahttps://app.codecov.io/gh/nodejs/node/commit/170744a22c08572aaaa1311b0810714d006c47a7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65952?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/_http_client.jshttps://app.codecov.io/gh/nodejs/node/pull/65952?src=pr&el=tree&filepath=lib%2F_http_client.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL19odHRwX2NsaWVudC5qcw==
33 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65952/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65952
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 13, 2026 https://github.com/nodejs/node/pull/65952#pullrequestreview-5191984839
View reviewed changes https://github.com/nodejs/node/pull/65952/files/170744a22c08572aaaa1311b0810714d006c47a7
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/65952#pullrequestreview-5191984839
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65952
https://github.com/bjohansebas
bjohansebashttps://github.com/bjohansebas
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 13, 2026https://github.com/nodejs/node/pull/65952#event-31063353892
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 13, 2026https://github.com/nodejs/node/pull/65952#event-31063511680
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 13, 2026https://github.com/nodejs/node/pull/65952#issuecomment-5655862747
https://ci.nodejs.org/job/node-test-pull-request/77439/https://ci.nodejs.org/job/node-test-pull-request/77439/
Please reload this pagehttps://github.com/nodejs/node/pull/65952
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 14, 2026https://github.com/nodejs/node/pull/65952#event-31082289102
https://github.com/barathraj048
barathraj048https://github.com/barathraj048
Sep 15, 2026https://github.com/nodejs/node/pull/65952#issuecomment-5674555693
@bjohansebashttps://github.com/bjohansebas
Please reload this pagehttps://github.com/nodejs/node/pull/65952
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 15, 2026 https://github.com/nodejs/node/pull/65952#pullrequestreview-5205395415
View reviewed changes https://github.com/nodejs/node/pull/65952/files/170744a22c08572aaaa1311b0810714d006c47a7
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 15, 2026https://github.com/nodejs/node/pull/65952#issuecomment-5674698780
https://ci.nodejs.org/job/node-test-pull-request/77499/https://ci.nodejs.org/job/node-test-pull-request/77499/
Please reload this pagehttps://github.com/nodejs/node/pull/65952
https://github.com/barathraj048
barathraj048https://github.com/barathraj048
Sep 16, 2026https://github.com/nodejs/node/pull/65952#issuecomment-5696471630
@mcollinahttps://github.com/mcollina
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/65952
https://github.com/inoway46
inoway46https://github.com/inoway46
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 16, 2026https://github.com/nodejs/node/pull/65952#event-31241180109
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
67e66b8https://github.com/nodejs/node/commit/67e66b8e054a842a68fa3d1ea71709953141172a
Sep 16, 2026https://github.com/nodejs/node/pull/65952#event-31242048985
Please reload this pagehttps://github.com/nodejs/node/pull/65952
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 16, 2026https://github.com/nodejs/node/pull/65952#issuecomment-5696916206
67e66b8https://github.com/nodejs/node/commit/67e66b8e054a842a68fa3d1ea71709953141172a
Please reload this pagehttps://github.com/nodejs/node/pull/65952
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 16, 2026https://github.com/nodejs/node/pull/65952#event-31242052441
aduh95https://github.com/aduh95
Sep 16, 2026 https://github.com/nodejs/node/pull/65952#ref-commit-77d8f17
https://github.com/barathraj048
https://github.com/aduh95
http: don't destroy socket after request completeshttps://github.com/nodejs/node/commit/77d8f17ab1617c109f0839088a2125d05a3ebe60
77d8f17https://github.com/nodejs/node/commit/77d8f17ab1617c109f0839088a2125d05a3ebe60
#65938https://github.com/nodejs/node/issues/65938
#65952https://github.com/nodejs/node/pull/65952
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 20, 2026 https://github.com/nodejs/node/pull/65952#ref-pullrequest-5520639298
2026-09-22, Version 26.10.0 (Current) #66163 https://github.com/nodejs/node/pull/66163
aduh95https://github.com/aduh95
Sep 22, 2026 https://github.com/nodejs/node/pull/65952#ref-commit-019b71b
https://github.com/barathraj048
https://github.com/aduh95
http: don't destroy socket after request completeshttps://github.com/nodejs/node/commit/019b71b76b006526d933636eb1e20427d3f68372
019b71bhttps://github.com/nodejs/node/commit/019b71b76b006526d933636eb1e20427d3f68372
#65938https://github.com/nodejs/node/issues/65938
#65952https://github.com/nodejs/node/pull/65952
https://github.com/MikeMcC399
MikeMcC399https://github.com/MikeMcC399
Sep 23, 2026 https://github.com/nodejs/node/pull/65952#ref-pullrequest-5542649393
http: align empty proxy env var handling with fetch() #66210 https://github.com/nodejs/node/pull/66210
aduh95https://github.com/aduh95
Sep 25, 2026 https://github.com/nodejs/node/pull/65952#ref-commit-53b4700
https://github.com/barathraj048
https://github.com/aduh95
http: don't destroy socket after request completeshttps://github.com/nodejs/node/commit/53b47008929027074dee674bb900bdd7596e2626
53b4700https://github.com/nodejs/node/commit/53b47008929027074dee674bb900bdd7596e2626
#65938https://github.com/nodejs/node/issues/65938
#65952https://github.com/nodejs/node/pull/65952
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 11, 2026 https://github.com/nodejs/node/pull/65952#ref-pullrequest-5805806867
2026-10-14, Version 24.22.0 'Krypton' (LTS) #66667 https://github.com/nodejs/node/pull/66667
markhardinghttps://github.com/markharding
Oct 19, 2026 https://github.com/nodejs/node/pull/65952#ref-commit-7e9c1d2
https://github.com/markharding
Update Node.js to v24.22.0 (#1833)https://github.com/futo-org/Harbor/commit/7e9c1d2fd346da653b5f5b3cbdadc19494c1516f
7e9c1d2https://github.com/futo-org/Harbor/commit/7e9c1d2fd346da653b5f5b3cbdadc19494c1516f
https://github.com/robertobandini
robertobandinihttps://github.com/robertobandini
Oct 26, 2026 https://github.com/nodejs/node/pull/65952#ref-pullrequest-6039888362
Close the socket of a download when it ends, whatever the runtime does with its request freelensapp/freelens-velero-extension#100 https://github.com/freelensapp/freelens-velero-extension/pull/100
robertobandinihttps://github.com/robertobandini
Oct 26, 2026 https://github.com/nodejs/node/pull/65952#ref-commit-ad3c81e
https://github.com/robertobandini
https://github.com/claude
Close the socket of a download when it ends, whatever the runtime doe…https://github.com/freelensapp/freelens-velero-extension/commit/ad3c81ea033f325d0ffe16004970937e151535bb
ad3c81ehttps://github.com/freelensapp/freelens-velero-extension/commit/ad3c81ea033f325d0ffe16004970937e151535bb
nodejs/node#65952https://github.com/nodejs/node/pull/65952
paultibbettshttps://github.com/paultibbetts
Oct 27, 2026 https://github.com/nodejs/node/pull/65952#ref-commit-1cd6b6e
https://github.com/renovate-bot
https://github.com/paultibbetts
chore(deps): update node.js to v24.22.1 (#12)https://github.com/paultibbetts/indiekit.paultibbetts.uk/commit/1cd6b6eb5f00d6f9cbd77687d68df169241003ad
1cd6b6ehttps://github.com/paultibbetts/indiekit.paultibbetts.uk/commit/1cd6b6eb5f00d6f9cbd77687d68df169241003ad
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65952
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/65952/files/170744a22c08572aaaa1311b0810714d006c47a7
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65952/files/170744a22c08572aaaa1311b0810714d006c47a7
Please reload this pagehttps://github.com/nodejs/node/pull/65952
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
http: aborting a keep-alive response during async iteration emits an unhandled Socket error https://github.com/nodejs/node/issues/65938
Please reload this pagehttps://github.com/nodejs/node/pull/65952
https://github.com/barathraj048
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/jasnell
https://github.com/panva
https://github.com/inoway46
https://github.com/bjohansebas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.