René's URL Explorer Experiment


Title: quic: improve stream cleanup & lookup by pimterry · Pull Request #65944 · nodejs/node · GitHub

Open Graph Title: quic: improve stream cleanup & lookup by pimterry · Pull Request #65944 · nodejs/node

X Title: quic: improve stream cleanup & lookup by pimterry · Pull Request #65944 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Extracted from #63995, but with a few further improvements en route. The core change here is to stop querying for our Stream instance by id in every on_read_data, on_acked_stream_data and on_receiv...

X Description: Extracted from #63995, but with a few further improvements en route. The core change here is to stop querying for our Stream instance by id in every on_read_data, on_acked_stream_data and on_receiv...

Opengraph URL: https://github.com/nodejs/node/pull/65944

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:183e867e-06c2-b411-d2c3-ac08cf61ac42
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB12A:1AAFBE:23690C:301D68:6AED469E
html-safe-noncef9a566c3c5d999ce69e487f9ad32e5b32a819e82036fb4408d5519bf9575d99a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTJBOjFBQUZCRToyMzY5MEM6MzAxRDY4OjZBRUQ0NjlFIiwidmlzaXRvcl9pZCI6IjIxMjcwMzEzNTkxMjc3NjY2ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac77d8e20f39918e9c12bc69841108977cde3a5651f0a2c1b90304b046640d7cd0
hovercard-subject-tagpull_request:4487432924
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65944/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/75a0bddba81fd2266d9c55b1dba478e016d7a4612d1c448fa63c15439d1fb923/nodejs/node/pull/65944
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/75a0bddba81fd2266d9c55b1dba478e016d7a4612d1c448fa63c15439d1fb923/nodejs/node/pull/65944
og:image:altExtracted from #63995, but with a few further improvements en route. The core change here is to stop querying for our Stream instance by id in every on_read_data, on_acked_stream_data and on_receiv...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepimterry
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65944#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65944
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65944
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65944
Reloadhttps://github.com/nodejs/node/pull/65944
Reloadhttps://github.com/nodejs/node/pull/65944
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests663 (663)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
pimterryhttps://github.com/pimterry
nodejs:mainhttps://github.com/nodejs/node/tree/main
pimterry:nghttp3-stream-cachinghttps://github.com/pimterry/node/tree/nghttp3-stream-caching
Conversationhttps://github.com/nodejs/node/pull/65944
Commits2 (2)https://github.com/nodejs/node/pull/65944/commits
Checkshttps://github.com/nodejs/node/pull/65944/checks
Files changedhttps://github.com/nodejs/node/pull/65944/files
quic: improve stream cleanup & lookuphttps://github.com/nodejs/node/pull/65944#top
pimterryhttps://github.com/pimterry
nodejs:mainhttps://github.com/nodejs/node/tree/main
pimterry:nghttp3-stream-cachinghttps://github.com/pimterry/node/tree/nghttp3-stream-caching
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Sep 9, 2026https://github.com/nodejs/node/pull/65944#issue-5402429574
#63995https://github.com/nodejs/node/pull/63995
Please reload this pagehttps://github.com/nodejs/node/pull/65944
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 9, 2026https://github.com/nodejs/node/pull/65944#issuecomment-5605690769
Please reload this pagehttps://github.com/nodejs/node/pull/65944
https://github.com/pimterry
quic: improve stream cleanup & lookuphttps://github.com/nodejs/node/pull/65944/commits/28daf5924f60c14110e12a412ddde009191338d2
28daf59https://github.com/nodejs/node/pull/65944/commits/28daf5924f60c14110e12a412ddde009191338d2
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 9, 2026https://github.com/nodejs/node/pull/65944#event-30845801147
https://github.com/jasnell
jasnellhttps://github.com/jasnell
QUIC Teamhttps://github.com/orgs/nodejs/projects/17
Sep 9, 2026https://github.com/nodejs/node/pull/65944#event-30845994273
https://github.com/jasnell
jasnellhttps://github.com/jasnell
QUIC Teamhttps://github.com/orgs/nodejs/projects/17
Sep 9, 2026https://github.com/nodejs/node/pull/65944#event-30845929514
https://github.com/pimterry
pimterryhttps://github.com/pimterry
force-pushedhttps://github.com/nodejs/node/compare/6d51d4e9e0e058c8707172a057e9d72bb9e489c5..28daf5924f60c14110e12a412ddde009191338d2
6d51d4ehttps://github.com/nodejs/node/commit/6d51d4e9e0e058c8707172a057e9d72bb9e489c5
28daf59https://github.com/nodejs/node/commit/28daf5924f60c14110e12a412ddde009191338d2
Compare https://github.com/nodejs/node/compare/6d51d4e9e0e058c8707172a057e9d72bb9e489c5..28daf5924f60c14110e12a412ddde009191338d2
September 9, 2026 17:10https://github.com/nodejs/node/pull/65944#event-30846180521
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 9, 2026https://github.com/nodejs/node/pull/65944#issuecomment-5606953850
Please reload this pagehttps://github.com/nodejs/node/pull/65944
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65944?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
b3fb344https://app.codecov.io/gh/nodejs/node/commit/b3fb3440ae64fb56261876cc6cb90770bc0ea843?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
7df3a19https://app.codecov.io/gh/nodejs/node/commit/7df3a19fd3f49a29440a46027a3e8de8138ab73a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
see 169 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65944/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65944
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 9, 2026 https://github.com/nodejs/node/pull/65944#pullrequestreview-5159910720
View reviewed changes https://github.com/nodejs/node/pull/65944/files/28daf5924f60c14110e12a412ddde009191338d2
src/quic/application.cchttps://github.com/nodejs/node/pull/65944/files/28daf5924f60c14110e12a412ddde009191338d2#diff-a010523fa8894660b54049d865ba731f77fb22839124ad7c39f43d77c9302182
Please reload this pagehttps://github.com/nodejs/node/pull/65944
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 9, 2026 https://github.com/nodejs/node/pull/65944#pullrequestreview-5159917073
View reviewed changes https://github.com/nodejs/node/pull/65944/files/28daf5924f60c14110e12a412ddde009191338d2
src/quic/session.cchttps://github.com/nodejs/node/pull/65944/files/28daf5924f60c14110e12a412ddde009191338d2#diff-90b56372b92188ce4cd4994c1361530afbb3cd177ef3f8b9de8b625e472e1030
Please reload this pagehttps://github.com/nodejs/node/pull/65944
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 9, 2026 https://github.com/nodejs/node/pull/65944#pullrequestreview-5159925108
View reviewed changes https://github.com/nodejs/node/pull/65944/files/28daf5924f60c14110e12a412ddde009191338d2
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/65944#pullrequestreview-5159925108
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65944
https://github.com/jasnell
jasnellhttps://github.com/jasnell
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 15, 2026https://github.com/nodejs/node/pull/65944#event-31146572707
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 15, 2026https://github.com/nodejs/node/pull/65944#event-31147026897
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 15, 2026https://github.com/nodejs/node/pull/65944#issuecomment-5674785851
https://ci.nodejs.org/job/node-test-pull-request/77501/https://ci.nodejs.org/job/node-test-pull-request/77501/
Please reload this pagehttps://github.com/nodejs/node/pull/65944
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 16, 2026https://github.com/nodejs/node/pull/65944#issuecomment-5698780882
https://ci.nodejs.org/job/node-test-pull-request/77549/https://ci.nodejs.org/job/node-test-pull-request/77549/
Please reload this pagehttps://github.com/nodejs/node/pull/65944
https://github.com/pimterry
Comment stream cleanup more to resolve nitshttps://github.com/nodejs/node/pull/65944/commits/7df3a19fd3f49a29440a46027a3e8de8138ab73a
7df3a19https://github.com/nodejs/node/pull/65944/commits/7df3a19fd3f49a29440a46027a3e8de8138ab73a
https://github.com/pimterry
pimterryhttps://github.com/pimterry
force-pushedhttps://github.com/nodejs/node/compare/e9ab5c919618a525f631e372b0e99f626a2d82c4..7df3a19fd3f49a29440a46027a3e8de8138ab73a
e9ab5c9https://github.com/nodejs/node/commit/e9ab5c919618a525f631e372b0e99f626a2d82c4
7df3a19https://github.com/nodejs/node/commit/7df3a19fd3f49a29440a46027a3e8de8138ab73a
Compare https://github.com/nodejs/node/compare/e9ab5c919618a525f631e372b0e99f626a2d82c4..7df3a19fd3f49a29440a46027a3e8de8138ab73a
September 17, 2026 07:32https://github.com/nodejs/node/pull/65944#event-31301701028
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 17, 2026https://github.com/nodejs/node/pull/65944#issuecomment-5712007964
https://ci.nodejs.org/job/node-test-pull-request/77563/https://ci.nodejs.org/job/node-test-pull-request/77563/
Please reload this pagehttps://github.com/nodejs/node/pull/65944
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 17, 2026https://github.com/nodejs/node/pull/65944#issuecomment-5715843042
https://ci.nodejs.org/job/node-test-pull-request/77568/https://ci.nodejs.org/job/node-test-pull-request/77568/
Please reload this pagehttps://github.com/nodejs/node/pull/65944
pimterryhttps://github.com/pimterry
Sep 17, 2026 https://github.com/nodejs/node/pull/65944#ref-commit-c2ddf93
https://github.com/pimterry
quic: improve stream cleanup & lookuphttps://github.com/nodejs/node/commit/c2ddf939c0c01a8f612ed67b99bdb44e730823f4
c2ddf93https://github.com/nodejs/node/commit/c2ddf939c0c01a8f612ed67b99bdb44e730823f4
#65944https://github.com/nodejs/node/pull/65944
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Sep 17, 2026https://github.com/nodejs/node/pull/65944#issuecomment-5717772680
c2ddf93https://github.com/nodejs/node/commit/c2ddf939c0c01a8f612ed67b99bdb44e730823f4
Please reload this pagehttps://github.com/nodejs/node/pull/65944
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Sep 17, 2026https://github.com/nodejs/node/pull/65944#event-31334630933
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
QUIC Teamhttps://github.com/orgs/nodejs/projects/17
Sep 17, 2026https://github.com/nodejs/node/pull/65944#event-31356462689
aduh95https://github.com/aduh95
Sep 18, 2026 https://github.com/nodejs/node/pull/65944#ref-commit-0df54fb
https://github.com/pimterry
https://github.com/aduh95
quic: improve stream cleanup & lookuphttps://github.com/nodejs/node/commit/0df54fb38f49befc29c3e133ed60b2f43af0d801
0df54fbhttps://github.com/nodejs/node/commit/0df54fb38f49befc29c3e133ed60b2f43af0d801
#65944https://github.com/nodejs/node/pull/65944
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 20, 2026 https://github.com/nodejs/node/pull/65944#ref-pullrequest-5520639298
2026-09-22, Version 26.10.0 (Current) #66163 https://github.com/nodejs/node/pull/66163
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65944
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65944/files/28daf5924f60c14110e12a412ddde009191338d2
Please reload this pagehttps://github.com/nodejs/node/pull/65944
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
QUIC Team https://github.com/orgs/nodejs/projects/17
Please reload this pagehttps://github.com/nodejs/node/pull/65944
https://github.com/pimterry
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.