René's URL Explorer Experiment


Title: src: avoid union type-punning in trace values by XadillaX · Pull Request #65933 · nodejs/node · GitHub

Open Graph Title: src: avoid union type-punning in trace values by XadillaX · Pull Request #65933 · nodejs/node

X Title: src: avoid union type-punning in trace values by XadillaX · Pull Request #65933 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Replace TraceValueUnion with memcpy-based object representation copying to avoid reading inactive union members. Generalize integral values to support all integral and enum types. This follows the ...

X Description: Replace TraceValueUnion with memcpy-based object representation copying to avoid reading inactive union members. Generalize integral values to support all integral and enum types. This follows the ...

Opengraph URL: https://github.com/nodejs/node/pull/65933

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:862f4cb7-d213-6af7-7935-6822e669daa3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9B6:2F339D:D9A1B6:122B734:6AED4442
html-safe-nonce5251cc06d1a8e37429a1d90fbed535c7ecfd1aa82edd709aad16a77ca85f6748
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUI2OjJGMzM5RDpEOUExQjY6MTIyQjczNDo2QUVENDQ0MiIsInZpc2l0b3JfaWQiOiIxNjU4MDYwOTIwODQ1MDU5MTM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd0cfbb3213b10b3ed45ea6e79ebf1932a9653babecc082ccc27c09b8f396fdb6
hovercard-subject-tagpull_request:4483538123
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65933/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e33c9f7bf1851815aad8e2223b2465bd67b0c9aaf1ebd8c9744a731a946f576c/nodejs/node/pull/65933
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e33c9f7bf1851815aad8e2223b2465bd67b0c9aaf1ebd8c9744a731a946f576c/nodejs/node/pull/65933
og:image:altReplace TraceValueUnion with memcpy-based object representation copying to avoid reading inactive union members. Generalize integral values to support all integral and enum types. This follows the ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameXadillaX
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65933#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65933
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65933
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65933
Reloadhttps://github.com/nodejs/node/pull/65933
Reloadhttps://github.com/nodejs/node/pull/65933
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests663 (663)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
XadillaX:fix-trace-value-union-ubhttps://github.com/XadillaX/node/tree/fix-trace-value-union-ub
Conversationhttps://github.com/nodejs/node/pull/65933
Commits1 (1)https://github.com/nodejs/node/pull/65933/commits
Checkshttps://github.com/nodejs/node/pull/65933/checks
Files changedhttps://github.com/nodejs/node/pull/65933/files
src: avoid union type-punning in trace valueshttps://github.com/nodejs/node/pull/65933#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
XadillaX:fix-trace-value-union-ubhttps://github.com/XadillaX/node/tree/fix-trace-value-union-ub
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Sep 9, 2026https://github.com/nodejs/node/pull/65933#issue-5397834924
https://chromium-review.googlesource.com/c/v8/v8/+/1886918https://chromium-review.googlesource.com/c/v8/v8/+/1886918
#57033https://github.com/nodejs/node/issues/57033
Please reload this pagehttps://github.com/nodejs/node/pull/65933
https://github.com/XadillaX
src: avoid union type-punning in trace valueshttps://github.com/nodejs/node/pull/65933/commits/3c837ec5b76acc43ccf064f5c2e299bd31689f01
3c837echttps://github.com/nodejs/node/pull/65933/commits/3c837ec5b76acc43ccf064f5c2e299bd31689f01
https://chromium-review.googlesource.com/c/v8/v8/+/1886918https://chromium-review.googlesource.com/c/v8/v8/+/1886918
nodejs#57033https://github.com/nodejs/node/issues/57033
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 9, 2026https://github.com/nodejs/node/pull/65933#event-30818878980
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 9, 2026https://github.com/nodejs/node/pull/65933#issuecomment-5601250322
Please reload this pagehttps://github.com/nodejs/node/pull/65933
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65933?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
b3fb344https://app.codecov.io/gh/nodejs/node/commit/b3fb3440ae64fb56261876cc6cb90770bc0ea843?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
3c837echttps://app.codecov.io/gh/nodejs/node/commit/3c837ec5b76acc43ccf064f5c2e299bd31689f01?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65933?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/tracing/trace_event_legacy_inl.hhttps://app.codecov.io/gh/nodejs/node/pull/65933?src=pr&el=tree&filepath=src%2Ftracing%2Ftrace_event_legacy_inl.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3RyYWNpbmcvdHJhY2VfZXZlbnRfbGVnYWN5X2lubC5o
27 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65933/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65933
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Sep 10, 2026https://github.com/nodejs/node/pull/65933#issuecomment-5613259050
@legendecashttps://github.com/legendecas
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/65933
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Sep 10, 2026 https://github.com/nodejs/node/pull/65933#ref-issue-5411799275
Request to restore active collaborator status nodejs/TSC#1892 https://github.com/nodejs/TSC/issues/1892
https://github.com/legendecas
legendecashttps://github.com/legendecas
Sep 10, 2026 https://github.com/nodejs/node/pull/65933#pullrequestreview-5168270873
View reviewed changes https://github.com/nodejs/node/pull/65933/files/3c837ec5b76acc43ccf064f5c2e299bd31689f01
legendecashttps://github.com/legendecas
https://github.com/nodejs/node/pull/65933#pullrequestreview-5168270873
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://chromium-review.googlesource.com/c/v8/v8/+/1896835https://chromium-review.googlesource.com/c/v8/v8/+/1896835
Please reload this pagehttps://github.com/nodejs/node/pull/65933
https://github.com/legendecas
legendecashttps://github.com/legendecas
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 10, 2026https://github.com/nodejs/node/pull/65933#event-30933296168
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 10, 2026https://github.com/nodejs/node/pull/65933#event-30935395089
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 10, 2026https://github.com/nodejs/node/pull/65933#event-30935780836
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 10, 2026https://github.com/nodejs/node/pull/65933#issuecomment-5626413487
https://ci.nodejs.org/job/node-test-pull-request/77325/https://ci.nodejs.org/job/node-test-pull-request/77325/
Please reload this pagehttps://github.com/nodejs/node/pull/65933
https://github.com/legendecas
legendecashttps://github.com/legendecas
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
trace_events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atrace_events
Sep 17, 2026https://github.com/nodejs/node/pull/65933#event-31323350326
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
99f0ddehttps://github.com/nodejs/node/commit/99f0ddef2ecfaf21f61a4a2b8643944f6ddab538
Sep 17, 2026https://github.com/nodejs/node/pull/65933#event-31323825075
Please reload this pagehttps://github.com/nodejs/node/pull/65933
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 17, 2026https://github.com/nodejs/node/pull/65933#issuecomment-5715381654
99f0ddehttps://github.com/nodejs/node/commit/99f0ddef2ecfaf21f61a4a2b8643944f6ddab538
Please reload this pagehttps://github.com/nodejs/node/pull/65933
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 17, 2026https://github.com/nodejs/node/pull/65933#event-31323829601
https://github.com/safocl
safoclhttps://github.com/safocl
Sep 17, 2026 https://github.com/nodejs/node/pull/65933#pullrequestreview-5237443389
View reviewed changes https://github.com/nodejs/node/pull/65933/files/3c837ec5b76acc43ccf064f5c2e299bd31689f01
src/tracing/trace_event_legacy_inl.hhttps://github.com/nodejs/node/pull/65933/files/3c837ec5b76acc43ccf064f5c2e299bd31689f01#diff-7acb4ef2b308d02ebb61bdc49d11dd50da79b6235fbc3f76483c952ff8e46b73
safoclhttps://github.com/safocl
Sep 17, 2026https://github.com/nodejs/node/pull/65933#discussion_r4038240868
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
[basic.types.trivial#3]https://eel.is/c++draft/basic.types.trivial#3
3https://eel.is/c++draft/basic.types.trivial#3
[intro.memory]https://eel.is/c++draft/intro.memory
[cstddef.syn]https://eel.is/c++draft/cstddef.syn
.https://eel.is/c++draft/basic.types.trivial#3.sentence-1
²³https://eel.is/c++draft/basic.types.trivial#footnote-23
.https://eel.is/c++draft/basic.types.trivial#3.sentence-2
1https://eel.is/c++draft/basic.types.trivial#example-1
Please reload this pagehttps://github.com/nodejs/node/pull/65933
aduh95https://github.com/aduh95
Sep 18, 2026 https://github.com/nodejs/node/pull/65933#ref-commit-410093d
https://github.com/XadillaX
https://github.com/aduh95
src: avoid union type-punning in trace valueshttps://github.com/nodejs/node/commit/410093dbf7fa3a5d05effabb65618d70946964ba
410093dhttps://github.com/nodejs/node/commit/410093dbf7fa3a5d05effabb65618d70946964ba
https://chromium-review.googlesource.com/c/v8/v8/+/1886918https://chromium-review.googlesource.com/c/v8/v8/+/1886918
#57033https://github.com/nodejs/node/issues/57033
#65933https://github.com/nodejs/node/pull/65933
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 20, 2026 https://github.com/nodejs/node/pull/65933#ref-pullrequest-5520639298
2026-09-22, Version 26.10.0 (Current) #66163 https://github.com/nodejs/node/pull/66163
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65933
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node/pull/65933/files/3c837ec5b76acc43ccf064f5c2e299bd31689f01
https://github.com/safocl
safocl https://github.com/safocl
https://github.com/nodejs/node/pull/65933/files/3c837ec5b76acc43ccf064f5c2e299bd31689f01
Please reload this pagehttps://github.com/nodejs/node/pull/65933
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
trace_events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atrace_events
Undefined behavior when accessing inactive union members https://github.com/nodejs/node/issues/57033
Please reload this pagehttps://github.com/nodejs/node/pull/65933
https://github.com/XadillaX
https://github.com/nodejs-github-bot
https://github.com/legendecas
https://github.com/safocl
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.