René's URL Explorer Experiment


Title: vfs: resolve symlinks when checking rename descendants by trivikr · Pull Request #65904 · nodejs/node · GitHub

Open Graph Title: vfs: resolve symlinks when checking rename descendants by trivikr · Pull Request #65904 · nodejs/node

X Title: vfs: resolve symlinks when checking rename descendants by trivikr · Pull Request #65904 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #65903 Check resolved source and destination parent paths before renaming a directory to prevent moving it into its own subtree through a symlink. Assisted-by: codex

X Description: Fixes: #65903 Check resolved source and destination parent paths before renaming a directory to prevent moving it into its own subtree through a symlink. Assisted-by: codex

Opengraph URL: https://github.com/nodejs/node/pull/65904

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:d23acafd-99c0-d56f-baff-523f0785f369
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-id8BD6:236B69:63DEAF:882EDF:6AED6062
html-safe-noncefafff2d2db4cb05d475a862d6af3e12644299a8c53a59a4602587b68b7837ac9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkQ2OjIzNkI2OTo2M0RFQUY6ODgyRURGOjZBRUQ2MDYyIiwidmlzaXRvcl9pZCI6IjEwNzc1MjM5Njk2OTk4MzE5MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacece8dcd61d2034af4a9e36ca5dde126add3041eb2e265e3bd7fd57f6b383667a
hovercard-subject-tagpull_request:4470475162
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/65904/checks
twitter:imagehttps://opengraph.githubassets.com/5fe7cdc005309d33e6309e88d394c723ff7c49f280cc3761206d41e59d680875/nodejs/node/pull/65904
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5fe7cdc005309d33e6309e88d394c723ff7c49f280cc3761206d41e59d680875/nodejs/node/pull/65904
og:image:altFixes: #65903 Check resolved source and destination parent paths before renaming a directory to prevent moving it into its own subtree through a symlink. Assisted-by: codex
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65904/checks#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65904%2Fchecks
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65904%2Fchecks
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65904/checks
Reloadhttps://github.com/nodejs/node/pull/65904/checks
Reloadhttps://github.com/nodejs/node/pull/65904/checks
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:vfs-rename-dir-symlinkhttps://github.com/trivikr/node/tree/vfs-rename-dir-symlink
Conversationhttps://github.com/nodejs/node/pull/65904
Commits1 (1)https://github.com/nodejs/node/pull/65904/commits
Checkshttps://github.com/nodejs/node/pull/65904/checks
Files changedhttps://github.com/nodejs/node/pull/65904/files
vfs: resolve symlinks when checking rename descendantshttps://github.com/nodejs/node/pull/65904/checks#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:vfs-rename-dir-symlinkhttps://github.com/trivikr/node/tree/vfs-rename-dir-symlink
Please reload this pagehttps://github.com/nodejs/node/pull/65904/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65904%2Fchecks
First commit message adheres to guidelines on: pull_request_target https://github.com/nodejs/node/actions/runs/34559347138
lint-commit-message https://github.com/nodejs/node/actions/runs/34559347138/job/103138684142?pr=65904
Build from tarball on: pull_request https://github.com/nodejs/node/actions/runs/34559348811
build-tarball https://github.com/nodejs/node/actions/runs/34559348811/job/103138688876?pr=65904
test-tarball-linux https://github.com/nodejs/node/actions/runs/34559348811/job/103139379980?pr=65904
Test Linux on: pull_request https://github.com/nodejs/node/actions/runs/34559348817
test-linux (ubuntu-24.04) https://github.com/nodejs/node/actions/runs/34559348817/job/103138689237?pr=65904
test-linux (ubuntu-24.04-arm) https://github.com/nodejs/node/actions/runs/34559348817/job/103138689058?pr=65904
Test macOS on: pull_request https://github.com/nodejs/node/actions/runs/34559348820
test-macOS https://github.com/nodejs/node/actions/runs/34559348820/job/103138688905?pr=65904
Test and upload documentation to artifacts on: pull_request https://github.com/nodejs/node/actions/runs/34559348826
build-docs https://github.com/nodejs/node/actions/runs/34559348826/job/103138689062?pr=65904
Linters on: pull_request https://github.com/nodejs/node/actions/runs/34559348864
lint-addon-docs https://github.com/nodejs/node/actions/runs/34559348864/job/103138689039?pr=65904
lint-cpp https://github.com/nodejs/node/actions/runs/34559348864/job/103138688912?pr=65904
format-cpp https://github.com/nodejs/node/actions/runs/34559348864/job/103138688950?pr=65904
lint-js-and-md https://github.com/nodejs/node/actions/runs/34559348864/job/103138688792?pr=65904
lint-py https://github.com/nodejs/node/actions/runs/34559348864/job/103138688987?pr=65904
lint-yaml https://github.com/nodejs/node/actions/runs/34559348864/job/103138688943?pr=65904
lint-sh https://github.com/nodejs/node/actions/runs/34559348864/job/103138688945?pr=65904
lint-codeowners https://github.com/nodejs/node/actions/runs/34559348864/job/103138688998?pr=65904
lint-pr-url https://github.com/nodejs/node/actions/runs/34559348864/job/103138688927?pr=65904
lint-readme https://github.com/nodejs/node/actions/runs/34559348864/job/103138689042?pr=65904
Coverage Linux on: pull_request https://github.com/nodejs/node/actions/runs/34559348868
coverage-linux https://github.com/nodejs/node/actions/runs/34559348868/job/103138688869?pr=65904
Coverage Windows on: pull_request https://github.com/nodejs/node/actions/runs/34559348951
coverage-windows https://github.com/nodejs/node/actions/runs/34559348951/job/103138689139?pr=65904
Test Shared libraries on: pull_request https://github.com/nodejs/node/actions/runs/34559349071
Build slim tarball https://github.com/nodejs/node/actions/runs/34559349071/job/103138689679?pr=65904
x86_64-linux: with shared libraries and perfetto / build https://github.com/nodejs/node/actions/runs/34559349071/job/103139060050?pr=65904
x86_64-darwin: with shared libraries / build https://github.com/nodejs/node/actions/runs/34559349071/job/103139060118?pr=65904
aarch64-darwin: with shared libraries / build https://github.com/nodejs/node/actions/runs/34559349071/job/103139060132?pr=65904
aarch64-linux: Cache V8 build https://github.com/nodejs/node/actions/runs/34559349071/job/103139059799?pr=65904
aarch64-linux: with shared boringssl-0.20260803.0 / build https://github.com/nodejs/node/actions/runs/34559349071/job/103139139365?pr=65904
aarch64-linux: with shared openssl-3.5.8 / build https://github.com/nodejs/node/actions/runs/34559349071/job/103139139347?pr=65904
aarch64-linux: with shared openssl-3.0.22 / build https://github.com/nodejs/node/actions/runs/34559349071/job/103139139350?pr=65904
aarch64-linux: with shared openssl-3.6.3 / build https://github.com/nodejs/node/actions/runs/34559349071/job/103139139295?pr=65904
aarch64-linux: with shared openssl-4.0.2 / build https://github.com/nodejs/node/actions/runs/34559349071/job/103139139275?pr=65904
aarch64-linux: with shared openssl-fips-3.5.8 / build https://github.com/nodejs/node/actions/runs/34559349071/job/103139139354?pr=65904
Comment on issues and PRs when labeled on: pull_request_target https://github.com/nodejs/node/actions/runs/34628739974
stale-comment https://github.com/nodejs/node/actions/runs/34628739974/job/103360105073?pr=65904
fast-track https://github.com/nodejs/node/actions/runs/34628739974/job/103360149509?pr=65904
notable-change https://github.com/nodejs/node/actions/runs/34628739974/job/103360104767?pr=65904
Notify on Review Wanted on: pull_request_target https://github.com/nodejs/node/actions/runs/34628740023
Notify on Review Wanted https://github.com/nodejs/node/actions/runs/34628740023/job/103360104741?pr=65904
Comment on issues and PRs when labeled on: pull_request_target https://github.com/nodejs/node/actions/runs/34628747762
stale-comment https://github.com/nodejs/node/actions/runs/34628747762/job/103360129999?pr=65904
fast-track https://github.com/nodejs/node/actions/runs/34628747762/job/103360129536?pr=65904
notable-change https://github.com/nodejs/node/actions/runs/34628747762/job/103360129308?pr=65904
Notify on Review Wanted on: pull_request_target https://github.com/nodejs/node/actions/runs/34628747888
Notify on Review Wanted https://github.com/nodejs/node/actions/runs/34628747888/job/103360130794?pr=65904
Notify on Review Wanted on: pull_request_target https://github.com/nodejs/node/actions/runs/34629046160
Notify on Review Wanted https://github.com/nodejs/node/actions/runs/34629046160/job/103361153218?pr=65904
Comment on issues and PRs when labeled on: pull_request_target https://github.com/nodejs/node/actions/runs/34629046314
stale-comment https://github.com/nodejs/node/actions/runs/34629046314/job/103361109218?pr=65904
fast-track https://github.com/nodejs/node/actions/runs/34629046314/job/103361140069?pr=65904
notable-change https://github.com/nodejs/node/actions/runs/34629046314/job/103361109473?pr=65904
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.