René's URL Explorer Experiment


Title: vfs: resolve symlinks when checking rename descendants by trivikr · Pull Request #65904 · nodejs/node · GitHub

Open Graph Title: vfs: resolve symlinks when checking rename descendants by trivikr · Pull Request #65904 · nodejs/node

X Title: vfs: resolve symlinks when checking rename descendants by trivikr · Pull Request #65904 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #65903 Check resolved source and destination parent paths before renaming a directory to prevent moving it into its own subtree through a symlink. Assisted-by: codex

X Description: Fixes: #65903 Check resolved source and destination parent paths before renaming a directory to prevent moving it into its own subtree through a symlink. Assisted-by: codex

Opengraph URL: https://github.com/nodejs/node/pull/65904

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:75687532-b61a-11d1-eb8a-9c9ae142fffe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6D6:7C3DA:2D19E5:3D60CF:6AED4A84
html-safe-nonceb78ad1ae0446b65fd4b94dc249b977a658bda7251e326a1e69f929f5a7a0eb19
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkQ2OjdDM0RBOjJEMTlFNTozRDYwQ0Y6NkFFRDRBODQiLCJ2aXNpdG9yX2lkIjoiMzIzNjU0NjM3Mzc1ODA0NDgwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac88c03db286df081e50d2267a8ed0090a71b154744ccf1b09ec3b045a9091345b
hovercard-subject-tagpull_request:4470475162
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65904/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5fe7cdc005309d33e6309e88d394c723ff7c49f280cc3761206d41e59d680875/nodejs/node/pull/65904
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5fe7cdc005309d33e6309e88d394c723ff7c49f280cc3761206d41e59d680875/nodejs/node/pull/65904
og:image:altFixes: #65903 Check resolved source and destination parent paths before renaming a directory to prevent moving it into its own subtree through a symlink. Assisted-by: codex
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65904#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65904
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65904
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65904
Reloadhttps://github.com/nodejs/node/pull/65904
Reloadhttps://github.com/nodejs/node/pull/65904
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:vfs-rename-dir-symlinkhttps://github.com/trivikr/node/tree/vfs-rename-dir-symlink
Conversationhttps://github.com/nodejs/node/pull/65904
Commits1 (1)https://github.com/nodejs/node/pull/65904/commits
Checkshttps://github.com/nodejs/node/pull/65904/checks
Files changedhttps://github.com/nodejs/node/pull/65904/files
vfs: resolve symlinks when checking rename descendantshttps://github.com/nodejs/node/pull/65904#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:vfs-rename-dir-symlinkhttps://github.com/trivikr/node/tree/vfs-rename-dir-symlink
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 8, 2026https://github.com/nodejs/node/pull/65904#issue-5382302653
#65903https://github.com/nodejs/node/issues/65903
Please reload this pagehttps://github.com/nodejs/node/pull/65904
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vfs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avfs
Sep 8, 2026https://github.com/nodejs/node/pull/65904#event-30729988134
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 8, 2026https://github.com/nodejs/node/pull/65904#event-30730068822
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 8, 2026https://github.com/nodejs/node/pull/65904#issuecomment-5580594336
Please reload this pagehttps://github.com/nodejs/node/pull/65904
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65904?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
0de4fcchttps://app.codecov.io/gh/nodejs/node/commit/0de4fcceb9372b5974f7bacc315d90f82f456d67?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
7510763https://app.codecov.io/gh/nodejs/node/commit/751076344781ec986283c81df10d765332ed57b9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65904?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/vfs/providers/memory.jshttps://app.codecov.io/gh/nodejs/node/pull/65904?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Fproviders%2Fmemory.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy9wcm92aWRlcnMvbWVtb3J5Lmpz
26 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65904/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65904
https://github.com/trivikr
vfs: resolve symlinks when checking rename descendantshttps://github.com/nodejs/node/pull/65904/commits/751076344781ec986283c81df10d765332ed57b9
7510763https://github.com/nodejs/node/pull/65904/commits/751076344781ec986283c81df10d765332ed57b9
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/648406e88eccfa0ff2c08acf192efa1bcd537a69..751076344781ec986283c81df10d765332ed57b9
648406ehttps://github.com/nodejs/node/commit/648406e88eccfa0ff2c08acf192efa1bcd537a69
7510763https://github.com/nodejs/node/commit/751076344781ec986283c81df10d765332ed57b9
Compare https://github.com/nodejs/node/compare/648406e88eccfa0ff2c08acf192efa1bcd537a69..751076344781ec986283c81df10d765332ed57b9
September 11, 2026 03:40https://github.com/nodejs/node/pull/65904#event-30947326391
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 11, 2026https://github.com/nodejs/node/pull/65904#issuecomment-5629105666
https://ci.nodejs.org/job/node-test-pull-request/77336/https://ci.nodejs.org/job/node-test-pull-request/77336/
Please reload this pagehttps://github.com/nodejs/node/pull/65904
https://github.com/trivikr
trivikrhttps://github.com/trivikr
mcollinahttps://github.com/mcollina
September 11, 2026 16:52https://github.com/nodejs/node/pull/65904#event-30986628332
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 11, 2026 https://github.com/nodejs/node/pull/65904#pullrequestreview-5181661506
View reviewed changes https://github.com/nodejs/node/pull/65904/files/751076344781ec986283c81df10d765332ed57b9
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/65904#pullrequestreview-5181661506
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65904
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 11, 2026https://github.com/nodejs/node/pull/65904#event-30989216261
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65904
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
request-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed
Sep 11, 2026https://github.com/nodejs/node/pull/65904#event-30989254931
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Sep 11, 2026https://github.com/nodejs/node/pull/65904#event-30989459689
https://github.com/aduh95
aduh95https://github.com/aduh95
Sep 12, 2026 https://github.com/nodejs/node/pull/65904#pullrequestreview-5185995647
View reviewed changes https://github.com/nodejs/node/pull/65904/files/751076344781ec986283c81df10d765332ed57b9
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fe52478https://github.com/nodejs/node/commit/fe52478de797c225b604e55513fa48ecbffa81e8
Sep 12, 2026https://github.com/nodejs/node/pull/65904#event-31017036253
Please reload this pagehttps://github.com/nodejs/node/pull/65904
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 12, 2026https://github.com/nodejs/node/pull/65904#issuecomment-5645044175
fe52478https://github.com/nodejs/node/commit/fe52478de797c225b604e55513fa48ecbffa81e8
Please reload this pagehttps://github.com/nodejs/node/pull/65904
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Sep 12, 2026https://github.com/nodejs/node/pull/65904#event-31017037254
aduh95https://github.com/aduh95
Sep 16, 2026 https://github.com/nodejs/node/pull/65904#ref-commit-816790e
https://github.com/trivikr
https://github.com/aduh95
vfs: resolve symlinks when checking rename descendantshttps://github.com/nodejs/node/commit/816790e0e55c9e243c29581ed339f04429a19808
816790ehttps://github.com/nodejs/node/commit/816790e0e55c9e243c29581ed339f04429a19808
#65904https://github.com/nodejs/node/pull/65904
#65903https://github.com/nodejs/node/issues/65903
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 20, 2026 https://github.com/nodejs/node/pull/65904#ref-pullrequest-5520639298
2026-09-22, Version 26.10.0 (Current) #66163 https://github.com/nodejs/node/pull/66163
https://github.com/trivikr
trivikrhttps://github.com/trivikr
September 22, 2026 13:52https://github.com/nodejs/node/pull/65904#event-31604652100
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65904
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/65904/files/751076344781ec986283c81df10d765332ed57b9
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/65904/files/751076344781ec986283c81df10d765332ed57b9
Please reload this pagehttps://github.com/nodejs/node/pull/65904
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vfs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avfs
vfs: renaming a directory through a symlink into its descendant detaches the subtree https://github.com/nodejs/node/issues/65903
Please reload this pagehttps://github.com/nodejs/node/pull/65904
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.