René's URL Explorer Experiment


Title: src: stop leaking a CppHeap in CommonEnvironmentSetup by codebytere · Pull Request #65792 · nodejs/node · GitHub

Open Graph Title: src: stop leaking a CppHeap in CommonEnvironmentSetup by codebytere · Pull Request #65792 · nodejs/node

X Title: src: stop leaking a CppHeap in CommonEnvironmentSetup by codebytere · Pull Request #65792 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Every CommonEnvironmentSetup::Create() and CreateFromSnapshot() leaks one v8::CppHeap: the constructor created a heap for its CreateParams up front, but the non-snapshotting path then calls NewIsol...

X Description: Every CommonEnvironmentSetup::Create() and CreateFromSnapshot() leaks one v8::CppHeap: the constructor created a heap for its CreateParams up front, but the non-snapshotting path then calls NewIsol...

Opengraph URL: https://github.com/nodejs/node/pull/65792

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c21de55a-a3d2-a521-22bf-245cd5e7b2b1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id86D8:36D84F:AE2BD:EBA18:6AED0565
html-safe-noncecf95dfd788a416d553bc9e729d73dd0cb91a82c84d049765bf0b7d8274b65685
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkQ4OjM2RDg0RjpBRTJCRDpFQkExODo2QUVEMDU2NSIsInZpc2l0b3JfaWQiOiI4MjA2OTM2MDk5MjYzNDE1NjUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace37c275db8d2ebd6607afadaa4f98a957288ee7bb8fdda405ecc438f2bd64dde
hovercard-subject-tagpull_request:4443575494
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65792/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/63508e53795300387e510b1cbd5b120183c87d516375cff9ea88f1e0f843c4e0/nodejs/node/pull/65792
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/63508e53795300387e510b1cbd5b120183c87d516375cff9ea88f1e0f843c4e0/nodejs/node/pull/65792
og:image:altEvery CommonEnvironmentSetup::Create() and CreateFromSnapshot() leaks one v8::CppHeap: the constructor created a heap for its CreateParams up front, but the non-snapshotting path then calls NewIsol...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecodebytere
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65792#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65792
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65792
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65792
Reloadhttps://github.com/nodejs/node/pull/65792
Reloadhttps://github.com/nodejs/node/pull/65792
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
codebytere:fix/embedder-setup-cppheap-leakhttps://github.com/codebytere/node/tree/fix/embedder-setup-cppheap-leak
Conversationhttps://github.com/nodejs/node/pull/65792
Commits1 (1)https://github.com/nodejs/node/pull/65792/commits
Checkshttps://github.com/nodejs/node/pull/65792/checks
Files changedhttps://github.com/nodejs/node/pull/65792/files
src: stop leaking a CppHeap in CommonEnvironmentSetuphttps://github.com/nodejs/node/pull/65792#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
codebytere:fix/embedder-setup-cppheap-leakhttps://github.com/codebytere/node/tree/fix/embedder-setup-cppheap-leak
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 4, 2026https://github.com/nodejs/node/pull/65792#issue-5349416249
Please reload this pagehttps://github.com/nodejs/node/pull/65792
#55337https://github.com/nodejs/node/pull/55337
@codebyterehttps://github.com/codebytere
Please reload this pagehttps://github.com/nodejs/node/pull/65792
https://github.com/codebytere
src: stop leaking a CppHeap in CommonEnvironmentSetuphttps://github.com/nodejs/node/pull/65792/commits/455f7260d0b54b3cae7d8b6971a6bfac80867282
455f726https://github.com/nodejs/node/pull/65792/commits/455f7260d0b54b3cae7d8b6971a6bfac80867282
nodejs#55337https://github.com/nodejs/node/pull/55337
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 4, 2026https://github.com/nodejs/node/pull/65792#event-30561047793
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 4, 2026https://github.com/nodejs/node/pull/65792#issuecomment-5542061131
https://ci.nodejs.org/job/node-test-pull-request/76973/https://ci.nodejs.org/job/node-test-pull-request/76973/
Please reload this pagehttps://github.com/nodejs/node/pull/65792
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 4, 2026https://github.com/nodejs/node/pull/65792#issuecomment-5543101899
Please reload this pagehttps://github.com/nodejs/node/pull/65792
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65792?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
2befec5https://app.codecov.io/gh/nodejs/node/commit/2befec51ae74531405257bcd68405427cd6046b1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
455f726https://app.codecov.io/gh/nodejs/node/commit/455f7260d0b54b3cae7d8b6971a6bfac80867282?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65792?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/api/embed_helpers.cchttps://app.codecov.io/gh/nodejs/node/pull/65792?src=pr&el=tree&filepath=src%2Fapi%2Fembed_helpers.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FwaS9lbWJlZF9oZWxwZXJzLmNj
101 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65792/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65792
https://github.com/codebytere
codebyterehttps://github.com/codebytere
addaleaxhttps://github.com/addaleax
joyeecheunghttps://github.com/joyeecheung
legendecashttps://github.com/legendecas
September 4, 2026 16:14https://github.com/nodejs/node/pull/65792#event-30566866228
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 4, 2026 https://github.com/nodejs/node/pull/65792#pullrequestreview-5117918313
View reviewed changes https://github.com/nodejs/node/pull/65792/files/455f7260d0b54b3cae7d8b6971a6bfac80867282
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 5, 2026https://github.com/nodejs/node/pull/65792#issuecomment-5551750833
https://ci.nodejs.org/job/node-test-pull-request/77017/https://ci.nodejs.org/job/node-test-pull-request/77017/
Please reload this pagehttps://github.com/nodejs/node/pull/65792
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 7, 2026 https://github.com/nodejs/node/pull/65792#pullrequestreview-5131590339
View reviewed changes https://github.com/nodejs/node/pull/65792/files/455f7260d0b54b3cae7d8b6971a6bfac80867282
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 7, 2026https://github.com/nodejs/node/pull/65792#event-30690430566
https://github.com/jakecastelli
jakecastellihttps://github.com/jakecastelli
Sep 7, 2026 https://github.com/nodejs/node/pull/65792#pullrequestreview-5131954779
View reviewed changes https://github.com/nodejs/node/pull/65792/files/455f7260d0b54b3cae7d8b6971a6bfac80867282
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
8e4d830https://github.com/nodejs/node/commit/8e4d830a1bb5d0e6621bd672e2a684e2b1c901fc
Sep 7, 2026https://github.com/nodejs/node/pull/65792#event-30691158665
Please reload this pagehttps://github.com/nodejs/node/pull/65792
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 7, 2026https://github.com/nodejs/node/pull/65792#issuecomment-5570709001
8e4d830https://github.com/nodejs/node/commit/8e4d830a1bb5d0e6621bd672e2a684e2b1c901fc
Please reload this pagehttps://github.com/nodejs/node/pull/65792
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 7, 2026https://github.com/nodejs/node/pull/65792#event-30691162395
aduh95https://github.com/aduh95
Sep 16, 2026 https://github.com/nodejs/node/pull/65792#ref-commit-48158fb
https://github.com/codebytere
https://github.com/aduh95
src: stop leaking a CppHeap in CommonEnvironmentSetuphttps://github.com/nodejs/node/commit/48158fba8c51533501816d0ea7f66dcab1a78c47
48158fbhttps://github.com/nodejs/node/commit/48158fba8c51533501816d0ea7f66dcab1a78c47
#55337https://github.com/nodejs/node/pull/55337
#65792https://github.com/nodejs/node/pull/65792
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 20, 2026 https://github.com/nodejs/node/pull/65792#ref-pullrequest-5520639298
2026-09-22, Version 26.10.0 (Current) #66163 https://github.com/nodejs/node/pull/66163
aduh95https://github.com/aduh95
Sep 22, 2026 https://github.com/nodejs/node/pull/65792#ref-commit-7331f5c
https://github.com/codebytere
https://github.com/aduh95
src: stop leaking a CppHeap in CommonEnvironmentSetuphttps://github.com/nodejs/node/commit/7331f5cfcc8b69669f3c2494ffd3435f7ce7ba7b
7331f5chttps://github.com/nodejs/node/commit/7331f5cfcc8b69669f3c2494ffd3435f7ce7ba7b
#55337https://github.com/nodejs/node/pull/55337
#65792https://github.com/nodejs/node/pull/65792
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 11, 2026 https://github.com/nodejs/node/pull/65792#ref-pullrequest-5805806867
2026-10-14, Version 24.22.0 'Krypton' (LTS) #66667 https://github.com/nodejs/node/pull/66667
markhardinghttps://github.com/markharding
Oct 19, 2026 https://github.com/nodejs/node/pull/65792#ref-commit-7e9c1d2
https://github.com/markharding
Update Node.js to v24.22.0 (#1833)https://github.com/futo-org/Harbor/commit/7e9c1d2fd346da653b5f5b3cbdadc19494c1516f
7e9c1d2https://github.com/futo-org/Harbor/commit/7e9c1d2fd346da653b5f5b3cbdadc19494c1516f
paultibbettshttps://github.com/paultibbetts
Oct 27, 2026 https://github.com/nodejs/node/pull/65792#ref-commit-1cd6b6e
https://github.com/renovate-bot
https://github.com/paultibbetts
chore(deps): update node.js to v24.22.1 (#12)https://github.com/paultibbetts/indiekit.paultibbetts.uk/commit/1cd6b6eb5f00d6f9cbd77687d68df169241003ad
1cd6b6ehttps://github.com/paultibbetts/indiekit.paultibbetts.uk/commit/1cd6b6eb5f00d6f9cbd77687d68df169241003ad
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65792
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65792/files/455f7260d0b54b3cae7d8b6971a6bfac80867282
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/65792/files/455f7260d0b54b3cae7d8b6971a6bfac80867282
https://github.com/jakecastelli
jakecastelli https://github.com/jakecastelli
https://github.com/nodejs/node/pull/65792/files/455f7260d0b54b3cae7d8b6971a6bfac80867282
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/legendecas
legendecas https://github.com/legendecas
Please reload this pagehttps://github.com/nodejs/node/pull/65792
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/65792
https://github.com/codebytere
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/joyeecheung
https://github.com/jakecastelli
https://github.com/panva
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.