René's URL Explorer Experiment


Title: test: ensure fsPromises.watch rejects on abort by hanityx · Pull Request #65768 · nodejs/node · GitHub

Open Graph Title: test: ensure fsPromises.watch rejects on abort by hanityx · Pull Request #65768 · nodejs/node

X Title: test: ensure fsPromises.watch rejects on abort by hanityx · Pull Request #65768 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The abort case in test-fs-promises-watch.js only asserts inside a catch block, so if the iterator finishes without throwing the test still passes. Every other rejection in this file uses assert.rej...

X Description: The abort case in test-fs-promises-watch.js only asserts inside a catch block, so if the iterator finishes without throwing the test still passes. Every other rejection in this file uses assert.rej...

Opengraph URL: https://github.com/nodejs/node/pull/65768

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7d6e9956-1d9c-556a-0b48-7ba230c9fa74
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC31C:F547B:11CD9DE:18A57C7:6AED0045
html-safe-nonce40537f74e8c16998d5ddf3e0d4aafb418f7514a3463861722aa2a123935c3db2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzFDOkY1NDdCOjExQ0Q5REU6MThBNTdDNzo2QUVEMDA0NSIsInZpc2l0b3JfaWQiOiI3NTkwMDg0NzI3MTg0MDk3MzQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1ded71ec1fb767259c0f79d9d8295ae648b02919e164a8330e673a56b2683a8a
hovercard-subject-tagpull_request:4435470486
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65768/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5bb9c18b4d5c01dc2ba7d220ad0b1f4fb24092ad6d9ae983a265be3d6979bd12/nodejs/node/pull/65768
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5bb9c18b4d5c01dc2ba7d220ad0b1f4fb24092ad6d9ae983a265be3d6979bd12/nodejs/node/pull/65768
og:image:altThe abort case in test-fs-promises-watch.js only asserts inside a catch block, so if the iterator finishes without throwing the test still passes. Every other rejection in this file uses assert.rej...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehanityx
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65768#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65768
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65768
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65768
Reloadhttps://github.com/nodejs/node/pull/65768
Reloadhttps://github.com/nodejs/node/pull/65768
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests668 (668)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
hanityx:fs-watch-assert-rejectshttps://github.com/hanityx/node/tree/fs-watch-assert-rejects
Conversationhttps://github.com/nodejs/node/pull/65768
Commits1 (1)https://github.com/nodejs/node/pull/65768/commits
Checkshttps://github.com/nodejs/node/pull/65768/checks
Files changedhttps://github.com/nodejs/node/pull/65768/files
test: ensure fsPromises.watch rejects on aborthttps://github.com/nodejs/node/pull/65768#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
hanityx:fs-watch-assert-rejectshttps://github.com/hanityx/node/tree/fs-watch-assert-rejects
https://github.com/hanityx
hanityxhttps://github.com/hanityx
Sep 3, 2026https://github.com/nodejs/node/pull/65768#issue-5339692820
#58490https://github.com/nodejs/node/pull/58490
#58490https://github.com/nodejs/node/pull/58490
Please reload this pagehttps://github.com/nodejs/node/pull/65768
https://github.com/hanityx
test: ensure fsPromises.watch rejects on aborthttps://github.com/nodejs/node/pull/65768/commits/51d4b668d4aee59411c1c48327d2f0cd0af152e6
51d4b66https://github.com/nodejs/node/pull/65768/commits/51d4b668d4aee59411c1c48327d2f0cd0af152e6
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Sep 3, 2026https://github.com/nodejs/node/pull/65768#event-30506087607
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 3, 2026https://github.com/nodejs/node/pull/65768#issuecomment-5531124019
Please reload this pagehttps://github.com/nodejs/node/pull/65768
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65768?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
85e93a1https://app.codecov.io/gh/nodejs/node/commit/85e93a165aa21f7796de4f38e2be7c07a232d0eb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
51d4b66https://app.codecov.io/gh/nodejs/node/commit/51d4b668d4aee59411c1c48327d2f0cd0af152e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
see 97 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65768/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65768
https://github.com/hanityx
hanityxhttps://github.com/hanityx
Sep 19, 2026https://github.com/nodejs/node/pull/65768#issuecomment-5738926844
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/65768
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 19, 2026 https://github.com/nodejs/node/pull/65768#pullrequestreview-5257117884
View reviewed changes https://github.com/nodejs/node/pull/65768/files/51d4b668d4aee59411c1c48327d2f0cd0af152e6
https://github.com/lpinca
lpincahttps://github.com/lpinca
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 19, 2026https://github.com/nodejs/node/pull/65768#event-31456217110
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 19, 2026https://github.com/nodejs/node/pull/65768#event-31456550364
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 19, 2026https://github.com/nodejs/node/pull/65768#issuecomment-5744576651
https://ci.nodejs.org/job/node-test-pull-request/77654/https://ci.nodejs.org/job/node-test-pull-request/77654/
Please reload this pagehttps://github.com/nodejs/node/pull/65768
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Sep 25, 2026https://github.com/nodejs/node/pull/65768#event-31818426566
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Sep 25, 2026https://github.com/nodejs/node/pull/65768#event-31818959254
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 25, 2026https://github.com/nodejs/node/pull/65768#issuecomment-5828819802
https://ci.nodejs.org/job/node-test-pull-request/77871/https://ci.nodejs.org/job/node-test-pull-request/77871/
Please reload this pagehttps://github.com/nodejs/node/pull/65768
https://github.com/panva
panvahttps://github.com/panva
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 25, 2026https://github.com/nodejs/node/pull/65768#event-31839724396
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
30c5a65https://github.com/nodejs/node/commit/30c5a6596f589828a80d0bbdf9a7a625484b337e
Sep 25, 2026https://github.com/nodejs/node/pull/65768#event-31840530548
Please reload this pagehttps://github.com/nodejs/node/pull/65768
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 25, 2026https://github.com/nodejs/node/pull/65768#issuecomment-5833653133
30c5a65https://github.com/nodejs/node/commit/30c5a6596f589828a80d0bbdf9a7a625484b337e
Please reload this pagehttps://github.com/nodejs/node/pull/65768
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 25, 2026https://github.com/nodejs/node/pull/65768#event-31840535023
aduh95https://github.com/aduh95
Sep 27, 2026 https://github.com/nodejs/node/pull/65768#ref-commit-7b02b8c
https://github.com/hanityx
https://github.com/aduh95
test: ensure fsPromises.watch rejects on aborthttps://github.com/nodejs/node/commit/7b02b8c87783ae28779324a3d511acf8780d87aa
7b02b8chttps://github.com/nodejs/node/commit/7b02b8c87783ae28779324a3d511acf8780d87aa
#65768https://github.com/nodejs/node/pull/65768
#58490https://github.com/nodejs/node/pull/58490
HoonDongKanghttps://github.com/HoonDongKang
Sep 28, 2026 https://github.com/nodejs/node/pull/65768#ref-commit-1f8e238
https://github.com/hanityx
https://github.com/HoonDongKang
test: ensure fsPromises.watch rejects on aborthttps://github.com/HoonDongKang/node/commit/1f8e2384a3384ad3df826aa3f92de307c10af134
1f8e238https://github.com/HoonDongKang/node/commit/1f8e2384a3384ad3df826aa3f92de307c10af134
nodejs#65768https://github.com/nodejs/node/pull/65768
nodejs#58490https://github.com/nodejs/node/pull/58490
aduh95https://github.com/aduh95
Sep 28, 2026 https://github.com/nodejs/node/pull/65768#ref-commit-c155248
https://github.com/hanityx
https://github.com/aduh95
test: ensure fsPromises.watch rejects on aborthttps://github.com/nodejs/node/commit/c155248f1bdc3841b4c5256559994d0fc144061c
c155248https://github.com/nodejs/node/commit/c155248f1bdc3841b4c5256559994d0fc144061c
#65768https://github.com/nodejs/node/pull/65768
#58490https://github.com/nodejs/node/pull/58490
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 5, 2026 https://github.com/nodejs/node/pull/65768#ref-pullrequest-5720654094
2026-10-07, Version 26.11.0 (Current) #66546 https://github.com/nodejs/node/pull/66546
aduh95https://github.com/aduh95
Oct 23, 2026 https://github.com/nodejs/node/pull/65768#ref-commit-6d01aec
https://github.com/hanityx
https://github.com/aduh95
test: ensure fsPromises.watch rejects on aborthttps://github.com/nodejs/node/commit/6d01aec6276ad4c45b13268ae3e545aee96e3152
6d01aechttps://github.com/nodejs/node/commit/6d01aec6276ad4c45b13268ae3e545aee96e3152
#65768https://github.com/nodejs/node/pull/65768
#58490https://github.com/nodejs/node/pull/58490
aduh95https://github.com/aduh95
Oct 28, 2026 https://github.com/nodejs/node/pull/65768#ref-commit-7ef78fb
https://github.com/hanityx
https://github.com/aduh95
test: ensure fsPromises.watch rejects on aborthttps://github.com/nodejs/node/commit/7ef78fb95cba969ae6398b4b0a79bff4ab3fa005
7ef78fbhttps://github.com/nodejs/node/commit/7ef78fb95cba969ae6398b4b0a79bff4ab3fa005
#65768https://github.com/nodejs/node/pull/65768
#58490https://github.com/nodejs/node/pull/58490
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/65768#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65768
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/65768/files/51d4b668d4aee59411c1c48327d2f0cd0af152e6
Please reload this pagehttps://github.com/nodejs/node/pull/65768
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/65768
https://github.com/hanityx
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/panva
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.