René's URL Explorer Experiment


Title: stream: reject closed only after sink abort settles by lazerg · Pull Request #65727 · nodejs/node · GitHub

Open Graph Title: stream: reject closed only after sink abort settles by lazerg · Pull Request #65727 · nodejs/node

X Title: stream: reject closed only after sink abort settles by lazerg · Pull Request #65727 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The writer's closed promise is materialized lazily, and the lazy derivation maps a stream in the 'errored' state straight to an already rejected promise. WritableStreamFinishErroring se...

X Description: The writer's closed promise is materialized lazily, and the lazy derivation maps a stream in the 'errored' state straight to an already rejected promise. WritableStreamFinis...

Opengraph URL: https://github.com/nodejs/node/pull/65727

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a4a405c8-2845-ccda-c3b0-e0ca41170796
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB400:E1F91:64BDE:843E3:6AED06C1
html-safe-nonce0d0bed210fc18f9f1a743f85d25a5d8d5675a6d04bf25f26d5892a0fc9fc59f2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDAwOkUxRjkxOjY0QkRFOjg0M0UzOjZBRUQwNkMxIiwidmlzaXRvcl9pZCI6IjI3MTMxNzYyNDQ3NzY0MDQ2NzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacde6c9fd3592ea4a3950f5c5809263d044ba5aba4bd6b4f741064c2150f1ffe19
hovercard-subject-tagpull_request:4415846865
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65727/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/569c6ef14e6840f1f8ed0a67aa31e7836580f90411a19ea1936e16c9eb5d0c56/nodejs/node/pull/65727
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/569c6ef14e6840f1f8ed0a67aa31e7836580f90411a19ea1936e16c9eb5d0c56/nodejs/node/pull/65727
og:image:altThe writer's closed promise is materialized lazily, and the lazy derivation maps a stream in the 'errored' state straight to an already rejected promise. WritableStreamFinishErroring se...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelazerg
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65727#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65727
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65727
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65727
Reloadhttps://github.com/nodejs/node/pull/65727
Reloadhttps://github.com/nodejs/node/pull/65727
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
lazerg:fix/issue-65726https://github.com/lazerg/node/tree/fix/issue-65726
Conversationhttps://github.com/nodejs/node/pull/65727
Commits1 (1)https://github.com/nodejs/node/pull/65727/commits
Checkshttps://github.com/nodejs/node/pull/65727/checks
Files changedhttps://github.com/nodejs/node/pull/65727/files
stream: reject closed only after sink abort settleshttps://github.com/nodejs/node/pull/65727#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
lazerg:fix/issue-65726https://github.com/lazerg/node/tree/fix/issue-65726
https://github.com/lazerg
lazerghttps://github.com/lazerg
Sep 1, 2026https://github.com/nodejs/node/pull/65727#issue-5316270968
#65726https://github.com/nodejs/node/issues/65726
Please reload this pagehttps://github.com/nodejs/node/pull/65727
https://github.com/lazerg
stream: reject closed only after sink abort settleshttps://github.com/nodejs/node/pull/65727/commits/b8020598472daafc66b31312a481de51a390f289
b802059https://github.com/nodejs/node/pull/65727/commits/b8020598472daafc66b31312a481de51a390f289
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
web streams https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22web%20streams%22
Sep 1, 2026https://github.com/nodejs/node/pull/65727#event-30371159254
https://github.com/aduh95
aduh95https://github.com/aduh95
Sep 1, 2026 https://github.com/nodejs/node/pull/65727#pullrequestreview-5083359620
View reviewed changes https://github.com/nodejs/node/pull/65727/files/b8020598472daafc66b31312a481de51a390f289
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 1, 2026https://github.com/nodejs/node/pull/65727#event-30375999218
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 1, 2026https://github.com/nodejs/node/pull/65727#event-30376086469
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 1, 2026https://github.com/nodejs/node/pull/65727#issuecomment-5500869996
Please reload this pagehttps://github.com/nodejs/node/pull/65727
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65727?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
f234fbchttps://app.codecov.io/gh/nodejs/node/commit/f234fbccaec924c39023b59d51447539a14e8126?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
b802059https://app.codecov.io/gh/nodejs/node/commit/b8020598472daafc66b31312a481de51a390f289?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65727?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/webstreams/writablestream.jshttps://app.codecov.io/gh/nodejs/node/pull/65727?src=pr&el=tree&filepath=lib%2Finternal%2Fwebstreams%2Fwritablestream.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3dlYnN0cmVhbXMvd3JpdGFibGVzdHJlYW0uanM=
40 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65727/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65727
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65727
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65727
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 12, 2026https://github.com/nodejs/node/pull/65727#issuecomment-5644616394
https://ci.nodejs.org/job/node-test-pull-request/77394/https://ci.nodejs.org/job/node-test-pull-request/77394/
Please reload this pagehttps://github.com/nodejs/node/pull/65727
https://github.com/panva
panvahttps://github.com/panva
Sep 12, 2026 https://github.com/nodejs/node/pull/65727#pullrequestreview-5186220725
View reviewed changes https://github.com/nodejs/node/pull/65727/files/b8020598472daafc66b31312a481de51a390f289
panvahttps://github.com/panva
https://github.com/nodejs/node/pull/65727#pullrequestreview-5186220725
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65727
https://github.com/panva
panvahttps://github.com/panva
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 12, 2026https://github.com/nodejs/node/pull/65727#event-31018687159
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
50b355ehttps://github.com/nodejs/node/commit/50b355ec044a2d8f45f7b4536fb8fa0e9090bee5
Sep 12, 2026https://github.com/nodejs/node/pull/65727#event-31018757202
Please reload this pagehttps://github.com/nodejs/node/pull/65727
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 12, 2026https://github.com/nodejs/node/pull/65727#issuecomment-5645477095
50b355ehttps://github.com/nodejs/node/commit/50b355ec044a2d8f45f7b4536fb8fa0e9090bee5
Please reload this pagehttps://github.com/nodejs/node/pull/65727
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 12, 2026https://github.com/nodejs/node/pull/65727#event-31018758374
aduh95https://github.com/aduh95
Sep 16, 2026 https://github.com/nodejs/node/pull/65727#ref-commit-898cd55
https://github.com/lazerg
https://github.com/aduh95
stream: reject closed only after sink abort settleshttps://github.com/nodejs/node/commit/898cd55bdfcd6def5500cf3f12aecbcbbab8c298
898cd55https://github.com/nodejs/node/commit/898cd55bdfcd6def5500cf3f12aecbcbbab8c298
#65727https://github.com/nodejs/node/pull/65727
#65726https://github.com/nodejs/node/issues/65726
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 20, 2026 https://github.com/nodejs/node/pull/65727#ref-pullrequest-5520639298
2026-09-22, Version 26.10.0 (Current) #66163 https://github.com/nodejs/node/pull/66163
aduh95https://github.com/aduh95
Sep 22, 2026 https://github.com/nodejs/node/pull/65727#ref-commit-db19499
https://github.com/lazerg
https://github.com/aduh95
stream: reject closed only after sink abort settleshttps://github.com/nodejs/node/commit/db19499b1b15aa5bc808bf412152ffc5683fab54
db19499https://github.com/nodejs/node/commit/db19499b1b15aa5bc808bf412152ffc5683fab54
#65727https://github.com/nodejs/node/pull/65727
#65726https://github.com/nodejs/node/issues/65726
aduh95https://github.com/aduh95
Sep 25, 2026 https://github.com/nodejs/node/pull/65727#ref-commit-70c1415
https://github.com/lazerg
https://github.com/aduh95
stream: reject closed only after sink abort settleshttps://github.com/nodejs/node/commit/70c141568661840773ff243db4feee2038a9a46e
70c1415https://github.com/nodejs/node/commit/70c141568661840773ff243db4feee2038a9a46e
#65727https://github.com/nodejs/node/pull/65727
#65726https://github.com/nodejs/node/issues/65726
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 11, 2026 https://github.com/nodejs/node/pull/65727#ref-pullrequest-5805806867
2026-10-14, Version 24.22.0 'Krypton' (LTS) #66667 https://github.com/nodejs/node/pull/66667
markhardinghttps://github.com/markharding
Oct 19, 2026 https://github.com/nodejs/node/pull/65727#ref-commit-7e9c1d2
https://github.com/markharding
Update Node.js to v24.22.0 (#1833)https://github.com/futo-org/Harbor/commit/7e9c1d2fd346da653b5f5b3cbdadc19494c1516f
7e9c1d2https://github.com/futo-org/Harbor/commit/7e9c1d2fd346da653b5f5b3cbdadc19494c1516f
paultibbettshttps://github.com/paultibbetts
Oct 27, 2026 https://github.com/nodejs/node/pull/65727#ref-commit-1cd6b6e
https://github.com/renovate-bot
https://github.com/paultibbetts
chore(deps): update node.js to v24.22.1 (#12)https://github.com/paultibbetts/indiekit.paultibbetts.uk/commit/1cd6b6eb5f00d6f9cbd77687d68df169241003ad
1cd6b6ehttps://github.com/paultibbetts/indiekit.paultibbetts.uk/commit/1cd6b6eb5f00d6f9cbd77687d68df169241003ad
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65727
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/65727/files/b8020598472daafc66b31312a481de51a390f289
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/65727/files/b8020598472daafc66b31312a481de51a390f289
Please reload this pagehttps://github.com/nodejs/node/pull/65727
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
web streams https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22web%20streams%22
webstreams: writer.closed settles before sink abort() completes when first observed during erroring https://github.com/nodejs/node/issues/65726
Please reload this pagehttps://github.com/nodejs/node/pull/65727
https://github.com/lazerg
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.