René's URL Explorer Experiment


Title: fs: support Buffer paths in cp() and cpSync() by HuzaifaAbdulRehman · Pull Request #65713 · nodejs/node · GitHub

Open Graph Title: fs: support Buffer paths in cp() and cpSync() by HuzaifaAbdulRehman · Pull Request #65713 · nodejs/node

X Title: fs: support Buffer paths in cp() and cpSync() by HuzaifaAbdulRehman · Pull Request #65713 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: What breaks fs.cpSync() with a filter, and fs.promises.cp(), throw ERR_INVALID_ARG_TYPE when src or dest is a Buffer, though Buffer paths are accepted elsewhere in fs (they address non-UTF-8 byte f...

X Description: What breaks fs.cpSync() with a filter, and fs.promises.cp(), throw ERR_INVALID_ARG_TYPE when src or dest is a Buffer, though Buffer paths are accepted elsewhere in fs (they address non-UTF-8 byte f...

Opengraph URL: https://github.com/nodejs/node/pull/65713

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3ecbf338-9b5b-4d5e-de90-6d0fc99829e3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BF4:3B1A19:7F0243:A8BFD3:6AED278D
html-safe-noncec6cb0885c0e1db26e51124f59f750bfab8c695d5c2de1458c4034bc60e2eeff7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkY0OjNCMUExOTo3RjAyNDM6QThCRkQzOjZBRUQyNzhEIiwidmlzaXRvcl9pZCI6IjQ5MDY5MTU4OTU5ODUzODMzMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca74e2c7fa3f6e22d752ec71082d204f73a2f3170ab3f389042fec92ba5466abc
hovercard-subject-tagpull_request:4414761179
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65713/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b5df2c04c00d3dbe5579eafe38964a47565b7f4cc909e909db5370dc84b0ae63/nodejs/node/pull/65713
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b5df2c04c00d3dbe5579eafe38964a47565b7f4cc909e909db5370dc84b0ae63/nodejs/node/pull/65713
og:image:altWhat breaks fs.cpSync() with a filter, and fs.promises.cp(), throw ERR_INVALID_ARG_TYPE when src or dest is a Buffer, though Buffer paths are accepted elsewhere in fs (they address non-UTF-8 byte f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameHuzaifaAbdulRehman
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65713#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65713
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65713
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65713
Reloadhttps://github.com/nodejs/node/pull/65713
Reloadhttps://github.com/nodejs/node/pull/65713
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
HuzaifaAbdulRehmanhttps://github.com/HuzaifaAbdulRehman
nodejs:mainhttps://github.com/nodejs/node/tree/main
HuzaifaAbdulRehman:fix/58634-cp-buffer-paths-filterhttps://github.com/HuzaifaAbdulRehman/node/tree/fix/58634-cp-buffer-paths-filter
Conversationhttps://github.com/nodejs/node/pull/65713
Commits1 (1)https://github.com/nodejs/node/pull/65713/commits
Checkshttps://github.com/nodejs/node/pull/65713/checks
Files changedhttps://github.com/nodejs/node/pull/65713/files
fs: support Buffer paths in cp() and cpSync()https://github.com/nodejs/node/pull/65713#top
HuzaifaAbdulRehmanhttps://github.com/HuzaifaAbdulRehman
nodejs:mainhttps://github.com/nodejs/node/tree/main
HuzaifaAbdulRehman:fix/58634-cp-buffer-paths-filterhttps://github.com/HuzaifaAbdulRehman/node/tree/fix/58634-cp-buffer-paths-filter
https://github.com/HuzaifaAbdulRehman
HuzaifaAbdulRehmanhttps://github.com/HuzaifaAbdulRehman
Sep 1, 2026https://github.com/nodejs/node/pull/65713#issue-5314986179
#58869https://github.com/nodejs/node/issues/58869
#58634https://github.com/nodejs/node/issues/58634
#58634https://github.com/nodejs/node/issues/58634
Please reload this pagehttps://github.com/nodejs/node/pull/65713
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 1, 2026https://github.com/nodejs/node/pull/65713#event-30363727769
https://github.com/MikeMcC399
MikeMcC399https://github.com/MikeMcC399
Sep 1, 2026 https://github.com/nodejs/node/pull/65713#ref-pullrequest-5288713938
tools: retry first-time contributor query #65648 https://github.com/nodejs/node/pull/65648
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 2, 2026https://github.com/nodejs/node/pull/65713#issuecomment-5506217845
Please reload this pagehttps://github.com/nodejs/node/pull/65713
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65713?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e68a93ahttps://app.codecov.io/gh/nodejs/node/commit/e68a93a8e9823e7faa0dce2c0a1521c49246c8b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
004d3c3https://app.codecov.io/gh/nodejs/node/commit/004d3c32fcafad915e4e09ce4d0d528095d7f11f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65713?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/cp/cp.jshttps://app.codecov.io/gh/nodejs/node/pull/65713?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fcp%2Fcp.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL2NwL2NwLmpz
7 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/65713?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65713?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/cp/cp-sync.jshttps://app.codecov.io/gh/nodejs/node/pull/65713?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fcp%2Fcp-sync.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL2NwL2NwLXN5bmMuanM=
lib/internal/fs/cp/cp.jshttps://app.codecov.io/gh/nodejs/node/pull/65713?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fcp%2Fcp.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL2NwL2NwLmpz
56 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65713/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65713
https://github.com/HuzaifaAbdulRehman
HuzaifaAbdulRehmanhttps://github.com/HuzaifaAbdulRehman
force-pushedhttps://github.com/nodejs/node/compare/cb6e436e10ee71e797bf86864654597f9974fb9a..258a798f13b59ca937936c8c079865d099557951
cb6e436https://github.com/nodejs/node/commit/cb6e436e10ee71e797bf86864654597f9974fb9a
258a798https://github.com/nodejs/node/commit/258a798f13b59ca937936c8c079865d099557951
Compare https://github.com/nodejs/node/compare/cb6e436e10ee71e797bf86864654597f9974fb9a..258a798f13b59ca937936c8c079865d099557951
September 2, 2026 09:16https://github.com/nodejs/node/pull/65713#event-30404282396
https://github.com/HuzaifaAbdulRehman
fs: support Buffer paths in cp() and cpSync()https://github.com/nodejs/node/pull/65713/commits/004d3c32fcafad915e4e09ce4d0d528095d7f11f
004d3c3https://github.com/nodejs/node/pull/65713/commits/004d3c32fcafad915e4e09ce4d0d528095d7f11f
nodejs#58634https://github.com/nodejs/node/issues/58634
https://github.com/HuzaifaAbdulRehman
HuzaifaAbdulRehmanhttps://github.com/HuzaifaAbdulRehman
force-pushedhttps://github.com/nodejs/node/compare/258a798f13b59ca937936c8c079865d099557951..004d3c32fcafad915e4e09ce4d0d528095d7f11f
258a798https://github.com/nodejs/node/commit/258a798f13b59ca937936c8c079865d099557951
004d3c3https://github.com/nodejs/node/commit/004d3c32fcafad915e4e09ce4d0d528095d7f11f
Compare https://github.com/nodejs/node/compare/258a798f13b59ca937936c8c079865d099557951..004d3c32fcafad915e4e09ce4d0d528095d7f11f
September 2, 2026 09:17https://github.com/nodejs/node/pull/65713#event-30404341271
https://github.com/HuzaifaAbdulRehman
HuzaifaAbdulRehmanhttps://github.com/HuzaifaAbdulRehman
Sep 23, 2026https://github.com/nodejs/node/pull/65713#issuecomment-5800235636
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/65713
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65713
Please reload this pagehttps://github.com/nodejs/node/pull/65713
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
fs.cpSync / fs.cp / fs.promises.cp fails when src/dest args are Buffer https://github.com/nodejs/node/issues/58634
Please reload this pagehttps://github.com/nodejs/node/pull/65713
https://github.com/HuzaifaAbdulRehman
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.