René's URL Explorer Experiment


Title: test: fix flaky cleanup in http2 test by pimterry · Pull Request #65701 · nodejs/node · GitHub

Open Graph Title: test: fix flaky cleanup in http2 test by pimterry · Pull Request #65701 · nodejs/node

X Title: test: fix flaky cleanup in http2 test by pimterry · Pull Request #65701 · nodejs/node

Description: This new HTTP/2 test just flaked today & yesterday: a ECONNRESET on the server side. Looking at this closely, I think this is very likely a race in the test teardown. The test simply destroyed the client and closed the server: it never ended the request that was in progress, and didn't cleanly close the client session. I think this triggers a race, where the server sends a GOAWAY to shut down the client, gets a ECONNRESET back if the client is always fully gone, and then throws that on the incomplete request. This change now ends the request properly, and closes the client session and server cleanly, so everything should do the proper GOAWAY shutdown dance before anything is closed, guaranteeing no unexpected resets. It's hard to validate (only failing on macos15-x64, and with low frequency, stress-test on main didn't reproduce) but I think doing proper cleanup here is good in any case, and doing clean shutdown throughout the test should make an unexpected reset structurally impossible.

Open Graph Description: This new HTTP/2 test just flaked today & yesterday: a ECONNRESET on the server side. Looking at this closely, I think this is very likely a race in the test teardown. The test simply destroyed ...

X Description: This new HTTP/2 test just flaked today & yesterday: a ECONNRESET on the server side. Looking at this closely, I think this is very likely a race in the test teardown. The test simply destro...

Opengraph URL: https://github.com/nodejs/node/pull/65701

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b483f121-0720-81a1-464f-9ef16963c4de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CF8:C63F3:95D06D:C72456:6AED2E71
html-safe-nonce46d98efb52ba31cae20a35f9fe4b84afbe4289835bdd1813a2dcef0c567dd3c0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0Y4OkM2M0YzOjk1RDA2RDpDNzI0NTY6NkFFRDJFNzEiLCJ2aXNpdG9yX2lkIjoiMjQzMTY4ODc5NTQ4MDczMTI0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac12d3b05cd1a2f953a3a5fa09d6f91595a63202e0a619b7abc6157a37803d3aeb
hovercard-subject-tagpull_request:4410600746
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/65701/files
twitter:imagehttps://avatars.githubusercontent.com/u/1526883?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1526883?s=400&v=4
og:image:altThis new HTTP/2 test just flaked today & yesterday: a ECONNRESET on the server side. Looking at this closely, I think this is very likely a race in the test teardown. The test simply destroyed ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65701/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65701%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65701%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65701/files
Reloadhttps://github.com/nodejs/node/pull/65701/files
Reloadhttps://github.com/nodejs/node/pull/65701/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
pimterry:fix-flaky-h2-deadlock-testhttps://github.com/pimterry/node/tree/fix-flaky-h2-deadlock-test
Conversation 18 https://github.com/nodejs/node/pull/65701
Commits 1 https://github.com/nodejs/node/pull/65701/commits
Checks 59 https://github.com/nodejs/node/pull/65701/checks
Files changed https://github.com/nodejs/node/pull/65701/files
Please reload this pagehttps://github.com/nodejs/node/pull/65701/files
test: fix flaky cleanup in http2 test https://github.com/nodejs/node/pull/65701/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/65701/files
f7fb8fd test: fix flaky cleanup in http2 test pimterry Sep 1, 2026 https://github.com/nodejs/node/pull/65701/commits/f7fb8fdce8afaefcf76ae3b9e68746b1f0ba8717
Clear filters https://github.com/nodejs/node/pull/65701/files
Please reload this pagehttps://github.com/nodejs/node/pull/65701/files
Please reload this pagehttps://github.com/nodejs/node/pull/65701/files
test/parallel/test-http2-bidirectional-write-deadlock.jshttps://github.com/nodejs/node/pull/65701/files#diff-bd9cf6aa3782d4406a839b88f170d297017e03627822d9124f55ebd3d765133c
View file https://github.com/pimterry/node/blob/f7fb8fdce8afaefcf76ae3b9e68746b1f0ba8717/test/parallel/test-http2-bidirectional-write-deadlock.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/65701/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/65701/files#diff-bd9cf6aa3782d4406a839b88f170d297017e03627822d9124f55ebd3d765133c
https://github.com/nodejs/node/pull/65701/files#diff-bd9cf6aa3782d4406a839b88f170d297017e03627822d9124f55ebd3d765133c
https://github.com/nodejs/node/pull/65701/files#diff-bd9cf6aa3782d4406a839b88f170d297017e03627822d9124f55ebd3d765133c
https://github.com/nodejs/node/pull/65701/files#diff-bd9cf6aa3782d4406a839b88f170d297017e03627822d9124f55ebd3d765133c
Please reload this pagehttps://github.com/nodejs/node/pull/65701/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.