René's URL Explorer Experiment


Title: stream: recompute the close error when eos() defers by bitpshr · Pull Request #65689 · nodejs/node · GitHub

Open Graph Title: stream: recompute the close error when eos() defers by bitpshr · Pull Request #65689 · nodejs/node

X Title: stream: recompute the close error when eos() defers by bitpshr · Pull Request #65689 · nodejs/node

Description: Fixes: #65677 Great report, the analysis in the issue is spot on and made this easy to confirm. When eos() runs against a stream that has already closed, it computed the premature close error immediately and then delivered it on the next tick. A closed stream can still be holding its whole body in the readable buffer, so anything that drains that buffer in between, such as async iteration starting up, leaves the callback reporting a state that no longer applies. An HTTP/2 response that was fully buffered before the stream closed normally fails with ERR_STREAM_PREMATURE_CLOSE. This recomputes the result inside the deferred callback instead, which is what the 'close' handler further down the same file already does. Only the already-closed branch is affected. The other branches capture an error that was already emitted, so they cannot go stale, and the synchronous callback path returns before the tick. Verification, since this sits under a lot of streams: The reproduction from the issue goes from ERR_STREAM_PREMATURE_CLOSE to passing, and v22 passes it both ways as a control. The added regression test fails on an unpatched build with exactly ERR_STREAM_PREMATURE_CLOSE, so it is not passing vacuously. Full parallel and sequential runs on patched and unpatched builds produced nearly disjoint failure sets, 9 unique to patched and 14 unique to baseline, with only a local fixture issue common to both. The unpatched run failed more tests than the patched one. A handful of TLS tests appeared in the patched run, so I ran those five six more times against the patched build and they passed every time. Worth flagging that the reporter suspects #62394 / cbee0de as the origin, which matches the version boundary in their table, so v24.x and v26.x are likely to want this too.

Open Graph Description: Fixes: #65677 Great report, the analysis in the issue is spot on and made this easy to confirm. When eos() runs against a stream that has already closed, it computed the premature close error immed...

X Description: Fixes: #65677 Great report, the analysis in the issue is spot on and made this easy to confirm. When eos() runs against a stream that has already closed, it computed the premature close error immed...

Opengraph URL: https://github.com/nodejs/node/pull/65689

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.113.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8151baee-4968-32a6-e1db-39ef710b8ff3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCE2:14E440:B61BB6:E6AF12:6B036DFE
html-safe-noncef8bb74e8d6eaa4d2d896f0c045d06fe620ef08c92841df15508c56750fb5096c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0UyOjE0RTQ0MDpCNjFCQjY6RTZBRjEyOjZCMDM2REZFIiwidmlzaXRvcl9pZCI6IjM2NjYyOTk0Mzk4OTI2MjI4NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf5123e4646644caae01e88b73ff6e32f897bfdee167920db2678189f133f1627
hovercard-subject-tagpull_request:4405511919
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/65689/files
twitter:imagehttps://avatars.githubusercontent.com/u/334586?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/334586?s=400&v=4
og:image:altFixes: #65677 Great report, the analysis in the issue is spot on and made this easy to confirm. When eos() runs against a stream that has already closed, it computed the premature close error immed...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65689/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65689%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65689%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65689/files
Reloadhttps://github.com/nodejs/node/pull/65689/files
Reloadhttps://github.com/nodejs/node/pull/65689/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues639 (639)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
bitpshrhttps://github.com/bitpshr
nodejs:mainhttps://github.com/nodejs/node/tree/main
bitpshr:stream/eos-recompute-close-errorhttps://github.com/bitpshr/node/tree/stream/eos-recompute-close-error
Conversation 6 https://github.com/nodejs/node/pull/65689
Commits 1 https://github.com/nodejs/node/pull/65689/commits
Checks 39 https://github.com/nodejs/node/pull/65689/checks
Files changed https://github.com/nodejs/node/pull/65689/files
Please reload this pagehttps://github.com/nodejs/node/pull/65689/files
stream: recompute the close error when eos() defers https://github.com/nodejs/node/pull/65689/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/65689/files
7f7dc98 stream: recompute the close error when eos() defers bitpshr Aug 31, 2026 https://github.com/nodejs/node/pull/65689/commits/7f7dc980f03bf7319aa643fb83f5ed346826e93e
Clear filters https://github.com/nodejs/node/pull/65689/files
Please reload this pagehttps://github.com/nodejs/node/pull/65689/files
Please reload this pagehttps://github.com/nodejs/node/pull/65689/files
end-of-stream.js https://github.com/nodejs/node/pull/65689/files#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
test-http2-async-iteration-buffered-response.js https://github.com/nodejs/node/pull/65689/files#diff-93ddba4e2f264296ae4717fc950342bf4ad495c00f91f8fecdd42e2bc25589a1
lib/internal/streams/end-of-stream.jshttps://github.com/nodejs/node/pull/65689/files#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
View file https://github.com/bitpshr/node/blob/7f7dc980f03bf7319aa643fb83f5ed346826e93e/lib/internal/streams/end-of-stream.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/65689/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/65689/files#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
https://github.com/nodejs/node/pull/65689/files#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
https://github.com/nodejs/node/pull/65689/files#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
https://github.com/nodejs/node/pull/65689/files#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
test/parallel/test-http2-async-iteration-buffered-response.jshttps://github.com/nodejs/node/pull/65689/files#diff-93ddba4e2f264296ae4717fc950342bf4ad495c00f91f8fecdd42e2bc25589a1
View file https://github.com/bitpshr/node/blob/7f7dc980f03bf7319aa643fb83f5ed346826e93e/test/parallel/test-http2-async-iteration-buffered-response.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/65689/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/65689/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.