René's URL Explorer Experiment


Title: stream: recompute the close error when eos() defers by bitpshr · Pull Request #65689 · nodejs/node · GitHub

Open Graph Title: stream: recompute the close error when eos() defers by bitpshr · Pull Request #65689 · nodejs/node

X Title: stream: recompute the close error when eos() defers by bitpshr · Pull Request #65689 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #65677 Great report, the analysis in the issue is spot on and made this easy to confirm. When eos() runs against a stream that has already closed, it computed the premature close error immed...

X Description: Fixes: #65677 Great report, the analysis in the issue is spot on and made this easy to confirm. When eos() runs against a stream that has already closed, it computed the premature close error immed...

Opengraph URL: https://github.com/nodejs/node/pull/65689

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.112.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7d686773-cfa9-daff-cee7-4dfa41675611
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB80:3BA08A:A4710:D8AA4:6B0369AA
html-safe-nonce36c10f6d5a7416c774784bb3739d9d4e8fe6c5ce7fe4e4653831886e6e455008
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjgwOjNCQTA4QTpBNDcxMDpEOEFBNDo2QjAzNjlBQSIsInZpc2l0b3JfaWQiOiI4OTA4MjMxMjQzMjM2MjUzODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacea8ca6a8476487a4a0bf568106a879fa98254c58f75e330d3db340fbaef131d2
hovercard-subject-tagpull_request:4405511919
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65689/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/38f9a3b0c44013760da5d59adf054f38cfc73de711692432c6ff9e569cd8b3fb/nodejs/node/pull/65689
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/38f9a3b0c44013760da5d59adf054f38cfc73de711692432c6ff9e569cd8b3fb/nodejs/node/pull/65689
og:image:altFixes: #65677 Great report, the analysis in the issue is spot on and made this easy to confirm. When eos() runs against a stream that has already closed, it computed the premature close error immed...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebitpshr
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65689#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65689
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65689
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65689
Reloadhttps://github.com/nodejs/node/pull/65689
Reloadhttps://github.com/nodejs/node/pull/65689
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues639 (639)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
bitpshrhttps://github.com/bitpshr
nodejs:mainhttps://github.com/nodejs/node/tree/main
bitpshr:stream/eos-recompute-close-errorhttps://github.com/bitpshr/node/tree/stream/eos-recompute-close-error
Conversationhttps://github.com/nodejs/node/pull/65689
Commits1 (1)https://github.com/nodejs/node/pull/65689/commits
Checkshttps://github.com/nodejs/node/pull/65689/checks
Files changedhttps://github.com/nodejs/node/pull/65689/files
stream: recompute the close error when eos() defershttps://github.com/nodejs/node/pull/65689#top
bitpshrhttps://github.com/bitpshr
nodejs:mainhttps://github.com/nodejs/node/tree/main
bitpshr:stream/eos-recompute-close-errorhttps://github.com/bitpshr/node/tree/stream/eos-recompute-close-error
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
Aug 31, 2026https://github.com/nodejs/node/pull/65689#issue-5303967514
#65677https://github.com/nodejs/node/issues/65677
#62394https://github.com/nodejs/node/pull/62394
cbee0dehttps://github.com/nodejs/node/commit/cbee0de1cb0cc2947d024bc1228c965ae115a55f
Please reload this pagehttps://github.com/nodejs/node/pull/65689
https://github.com/bitpshr
stream: recompute the close error when eos() defershttps://github.com/nodejs/node/pull/65689/commits/7f7dc980f03bf7319aa643fb83f5ed346826e93e
7f7dc98https://github.com/nodejs/node/pull/65689/commits/7f7dc980f03bf7319aa643fb83f5ed346826e93e
nodejs#65677https://github.com/nodejs/node/issues/65677
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 31, 2026https://github.com/nodejs/node/pull/65689#issuecomment-5483305681
Please reload this pagehttps://github.com/nodejs/node/pull/65689
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Aug 31, 2026https://github.com/nodejs/node/pull/65689#event-30300354794
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
Aug 31, 2026 https://github.com/nodejs/node/pull/65689#ref-issue-5299494957
http2: async iteration reports premature close with buffered responses in v26.3.0+ and v24.20.0 #65677 https://github.com/nodejs/node/issues/65677
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 31, 2026https://github.com/nodejs/node/pull/65689#issuecomment-5484466489
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65689?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
705646fhttps://app.codecov.io/gh/nodejs/node/commit/705646f2f70fd8097d13d85de8347a74b6c443af?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
7f7dc98https://app.codecov.io/gh/nodejs/node/commit/7f7dc980f03bf7319aa643fb83f5ed346826e93e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65689?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/end-of-stream.jshttps://app.codecov.io/gh/nodejs/node/pull/65689?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fend-of-stream.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvZW5kLW9mLXN0cmVhbS5qcw==
28 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65689/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65689
https://github.com/zhming0
zhming0https://github.com/zhming0
Sep 15, 2026 https://github.com/nodejs/node/pull/65689#ref-pullrequest-5461729625
Allow HTTP sandbox egress and note the Node 24.19.0 pin zhming0/dsh-yawn#87 https://github.com/zhming0/dsh-yawn/pull/87
https://github.com/petersutter
petersutterhttps://github.com/petersutter
Sep 25, 2026 https://github.com/nodejs/node/pull/65689#ref-pullrequest-5582835166
fix(request): don't fail requests on HTTP/2 GOAWAY or refused streams gardener/dashboard#3302 https://github.com/gardener/dashboard/pull/3302
https://github.com/bitpshr
bitpshrhttps://github.com/bitpshr
Oct 6, 2026https://github.com/nodejs/node/pull/65689#issuecomment-6027476900
#62394https://github.com/nodejs/node/pull/62394
Please reload this pagehttps://github.com/nodejs/node/pull/65689
https://github.com/jbeda
jbedahttps://github.com/jbeda
Oct 13, 2026 https://github.com/nodejs/node/pull/65689#ref-issue-5823352411
http2: async iterator rejects complete buffered response after NO_ERROR reset with request side open #66693 https://github.com/nodejs/node/issues/66693
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Nov 3, 2026 https://github.com/nodejs/node/pull/65689#pullrequestreview-5759642888
View reviewed changes https://github.com/nodejs/node/pull/65689/files/7f7dc980f03bf7319aa643fb83f5ed346826e93e
pimterryhttps://github.com/pimterry
https://github.com/nodejs/node/pull/65689#pullrequestreview-5759642888
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#66693https://github.com/nodejs/node/issues/66693
Please reload this pagehttps://github.com/nodejs/node/pull/65689
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Nov 10, 2026https://github.com/nodejs/node/pull/65689#issuecomment-6769971168
@bitpshrhttps://github.com/bitpshr
#66693https://github.com/nodejs/node/issues/66693
Please reload this pagehttps://github.com/nodejs/node/pull/65689
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Nov 17, 2026 https://github.com/nodejs/node/pull/65689#ref-pullrequest-6450443682
http2: fix eos() for HTTP/2 streams after clean end & close #67553 https://github.com/nodejs/node/pull/67553
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Nov 17, 2026https://github.com/nodejs/node/pull/65689#issuecomment-6955913992
#67553https://github.com/nodejs/node/pull/67553
@bitpshrhttps://github.com/bitpshr
Please reload this pagehttps://github.com/nodejs/node/pull/65689
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Nov 17, 2026https://github.com/nodejs/node/pull/65689#event-36435966063
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65689
https://github.com/pimterry
pimterry https://github.com/pimterry
https://github.com/nodejs/node/pull/65689/files/7f7dc980f03bf7319aa643fb83f5ed346826e93e
Please reload this pagehttps://github.com/nodejs/node/pull/65689
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
http2: async iteration reports premature close with buffered responses in v26.3.0+ and v24.20.0 https://github.com/nodejs/node/issues/65677
Please reload this pagehttps://github.com/nodejs/node/pull/65689
https://github.com/bitpshr
https://github.com/nodejs-github-bot
https://github.com/pimterry
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.