René's URL Explorer Experiment


Title: src: fix sqlite connection leak in Web Storage by JosephDoUrden · Pull Request #65673 · nodejs/node · GitHub

Open Graph Title: src: fix sqlite connection leak in Web Storage by JosephDoUrden · Pull Request #65673 · nodejs/node

X Title: src: fix sqlite connection leak in Web Storage by JosephDoUrden · Pull Request #65673 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes #64640. Every failed Web Storage initialisation leaks the SQLite connection. Root cause is in the issue thread: sqlite3_open() usually returns a handle even on failure, but Storage::Open() on...

X Description: Fixes #64640. Every failed Web Storage initialisation leaks the SQLite connection. Root cause is in the issue thread: sqlite3_open() usually returns a handle even on failure, but Storage::Open() on...

Opengraph URL: https://github.com/nodejs/node/pull/65673

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d6c81646-7e49-8a80-31f3-1a2f19d100f2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA60C:143C91:1ADACB:24371A:6AED0966
html-safe-nonce819bc3667b8387dcca1a8ddbb8207e59cca2d20a0a8cf1170efc72fd8cc0c9ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjBDOjE0M0M5MToxQURBQ0I6MjQzNzFBOjZBRUQwOTY2IiwidmlzaXRvcl9pZCI6IjEzNDQwNTI1MTE3NTk5OTMxOTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd666a124a568c04549e7f2809ca9fe3837a55beb0076c832cb0e037ff7820656
hovercard-subject-tagpull_request:4396983645
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65673/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a0637522d106311e7bb68c6bec99ccba2f31e612596130779ad11d6e87c42daa/nodejs/node/pull/65673
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a0637522d106311e7bb68c6bec99ccba2f31e612596130779ad11d6e87c42daa/nodejs/node/pull/65673
og:image:altFixes #64640. Every failed Web Storage initialisation leaks the SQLite connection. Root cause is in the issue thread: sqlite3_open() usually returns a handle even on failure, but Storage::Open() on...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJosephDoUrden
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65673#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65673
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65673
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65673
Reloadhttps://github.com/nodejs/node/pull/65673
Reloadhttps://github.com/nodejs/node/pull/65673
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
JosephDoUrdenhttps://github.com/JosephDoUrden
nodejs:mainhttps://github.com/nodejs/node/tree/main
JosephDoUrden:fix/webstorage-connection-leakhttps://github.com/JosephDoUrden/node/tree/fix/webstorage-connection-leak
Conversationhttps://github.com/nodejs/node/pull/65673
Commits1 (1)https://github.com/nodejs/node/pull/65673/commits
Checkshttps://github.com/nodejs/node/pull/65673/checks
Files changedhttps://github.com/nodejs/node/pull/65673/files
src: fix sqlite connection leak in Web Storagehttps://github.com/nodejs/node/pull/65673#top
JosephDoUrdenhttps://github.com/JosephDoUrden
nodejs:mainhttps://github.com/nodejs/node/tree/main
JosephDoUrden:fix/webstorage-connection-leakhttps://github.com/JosephDoUrden/node/tree/fix/webstorage-connection-leak
https://github.com/JosephDoUrden
JosephDoUrdenhttps://github.com/JosephDoUrden
Aug 30, 2026https://github.com/nodejs/node/pull/65673#issue-5293621361
#64640https://github.com/nodejs/node/issues/64640
Please reload this pagehttps://github.com/nodejs/node/pull/65673
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 30, 2026https://github.com/nodejs/node/pull/65673#event-30243152363
https://github.com/MikeMcC399
MikeMcC399https://github.com/MikeMcC399
Aug 30, 2026https://github.com/nodejs/node/pull/65673#issuecomment-5470648934
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
contribution and automation policieshttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
pull request guidehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
Code of Conducthttps://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
#65634https://github.com/nodejs/node/pull/65634
Q: How do I trigger the CI runs?https://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md#q-how-do-i-trigger-the-ci-runs
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-6-testhttps://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-6-test
Please reload this pagehttps://github.com/nodejs/node/pull/65673
https://github.com/JosephDoUrden
src: fix sqlite connection leak in Web Storagehttps://github.com/nodejs/node/pull/65673/commits/ae982987fc8174225eaa1059874ef7a8e2989680
ae98298https://github.com/nodejs/node/pull/65673/commits/ae982987fc8174225eaa1059874ef7a8e2989680
nodejs#64640https://github.com/nodejs/node/issues/64640
https://github.com/JosephDoUrden
JosephDoUrdenhttps://github.com/JosephDoUrden
force-pushedhttps://github.com/nodejs/node/compare/07886650338e4309d9b2efd8f7e4d1fb69f6d493..ae982987fc8174225eaa1059874ef7a8e2989680
0788665https://github.com/nodejs/node/commit/07886650338e4309d9b2efd8f7e4d1fb69f6d493
ae98298https://github.com/nodejs/node/commit/ae982987fc8174225eaa1059874ef7a8e2989680
Compare https://github.com/nodejs/node/compare/07886650338e4309d9b2efd8f7e4d1fb69f6d493..ae982987fc8174225eaa1059874ef7a8e2989680
August 30, 2026 19:18https://github.com/nodejs/node/pull/65673#event-30244500701
https://github.com/JosephDoUrden
JosephDoUrdenhttps://github.com/JosephDoUrden
Aug 30, 2026https://github.com/nodejs/node/pull/65673#issuecomment-5470738378
@MikeMcC399https://github.com/MikeMcC399
#65634https://github.com/nodejs/node/pull/65634
Please reload this pagehttps://github.com/nodejs/node/pull/65673
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 30, 2026https://github.com/nodejs/node/pull/65673#issuecomment-5471226353
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65673?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
01c1300https://app.codecov.io/gh/nodejs/node/commit/01c1300dfc168ddce2b44e719bd50eba5ed22015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
ae98298https://app.codecov.io/gh/nodejs/node/commit/ae982987fc8174225eaa1059874ef7a8e2989680?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65673?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_webstorage.cchttps://app.codecov.io/gh/nodejs/node/pull/65673?src=pr&el=tree&filepath=src%2Fnode_webstorage.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfd2Vic3RvcmFnZS5jYw==
33 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65673/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65673
https://github.com/MikeMcC399
MikeMcC399https://github.com/MikeMcC399
Sep 29, 2026https://github.com/nodejs/node/pull/65673#issuecomment-5887097161
rebasehttps://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase
Pull requestshttps://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#pull-requests
Please reload this pagehttps://github.com/nodejs/node/pull/65673
https://github.com/JosephDoUrden
JosephDoUrdenhttps://github.com/JosephDoUrden
Oct 24, 2026https://github.com/nodejs/node/pull/65673#issuecomment-6383744231
#65879https://github.com/nodejs/node/pull/65879
#65634https://github.com/nodejs/node/pull/65634
Please reload this pagehttps://github.com/nodejs/node/pull/65673
https://github.com/JosephDoUrden
JosephDoUrdenhttps://github.com/JosephDoUrden
Oct 24, 2026https://github.com/nodejs/node/pull/65673#event-34125898069
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65673
Please reload this pagehttps://github.com/nodejs/node/pull/65673
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Web Storage Maybe leaks SQLite connections when database initialization fails https://github.com/nodejs/node/issues/64640
Please reload this pagehttps://github.com/nodejs/node/pull/65673
https://github.com/JosephDoUrden
https://github.com/MikeMcC399
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.