René's URL Explorer Experiment


Title: events: fix addAbortListener for aborted signals by lazerg · Pull Request #65640 · nodejs/node · GitHub

Open Graph Title: events: fix addAbortListener for aborted signals by lazerg · Pull Request #65640 · nodejs/node

X Title: events: fix addAbortListener for aborted signals by lazerg · Pull Request #65640 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When addAbortListener() is given a signal that is already aborted, it queues listener() with no arguments and leaves the returned disposable empty. So the callback gets undefined where every other ...

X Description: When addAbortListener() is given a signal that is already aborted, it queues listener() with no arguments and leaves the returned disposable empty. So the callback gets undefined where every other ...

Opengraph URL: https://github.com/nodejs/node/pull/65640

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:81627308-7d01-1e85-ca2d-ea63955d0b85
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB51A:7DD00:B22F2:F1E95:6AED0603
html-safe-nonced954d61959683f9e7b01de99007542f83d2922e302b89023a77ae9adf0e08d60
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTFBOjdERDAwOkIyMkYyOkYxRTk1OjZBRUQwNjAzIiwidmlzaXRvcl9pZCI6IjE3ODQxNTQ1MjkyMjYwOTgxNzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfe399c09f361c2798a264a86ab0c81212758d129a5dd92d26016b46ab23e2d12
hovercard-subject-tagpull_request:4390747217
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65640/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/00af36f9080320b83128bba1fb9624bf379b1d301f3b8d008539d9a410a8eae7/nodejs/node/pull/65640
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/00af36f9080320b83128bba1fb9624bf379b1d301f3b8d008539d9a410a8eae7/nodejs/node/pull/65640
og:image:altWhen addAbortListener() is given a signal that is already aborted, it queues listener() with no arguments and leaves the returned disposable empty. So the callback gets undefined where every other ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelazerg
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65640#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65640
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65640
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65640
Reloadhttps://github.com/nodejs/node/pull/65640
Reloadhttps://github.com/nodejs/node/pull/65640
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
lazerg:fix/issue-65637-abort-listener-disposalhttps://github.com/lazerg/node/tree/fix/issue-65637-abort-listener-disposal
Conversationhttps://github.com/nodejs/node/pull/65640
Commits1 (1)https://github.com/nodejs/node/pull/65640/commits
Checkshttps://github.com/nodejs/node/pull/65640/checks
Files changedhttps://github.com/nodejs/node/pull/65640/files
events: fix addAbortListener for aborted signalshttps://github.com/nodejs/node/pull/65640#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
lazerg:fix/issue-65637-abort-listener-disposalhttps://github.com/lazerg/node/tree/fix/issue-65637-abort-listener-disposal
https://github.com/lazerg
lazerghttps://github.com/lazerg
Aug 29, 2026https://github.com/nodejs/node/pull/65640#issue-5285524369
Please reload this pagehttps://github.com/nodejs/node/pull/65640
#65637https://github.com/nodejs/node/issues/65637
Please reload this pagehttps://github.com/nodejs/node/pull/65640
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 29, 2026https://github.com/nodejs/node/pull/65640#event-30204699685
https://github.com/lazerg
events: fix addAbortListener for aborted signalshttps://github.com/nodejs/node/pull/65640/commits/eca0fdb3b87710a736a45d1dd6830c53b0a5f23f
eca0fdbhttps://github.com/nodejs/node/pull/65640/commits/eca0fdb3b87710a736a45d1dd6830c53b0a5f23f
https://github.com/lazerg
lazerghttps://github.com/lazerg
force-pushedhttps://github.com/nodejs/node/compare/1830f2a001c849cfa6a2d72a546e300b0d8481f6..eca0fdb3b87710a736a45d1dd6830c53b0a5f23f
1830f2ahttps://github.com/nodejs/node/commit/1830f2a001c849cfa6a2d72a546e300b0d8481f6
eca0fdbhttps://github.com/nodejs/node/commit/eca0fdb3b87710a736a45d1dd6830c53b0a5f23f
Compare https://github.com/nodejs/node/compare/1830f2a001c849cfa6a2d72a546e300b0d8481f6..eca0fdb3b87710a736a45d1dd6830c53b0a5f23f
August 29, 2026 08:47https://github.com/nodejs/node/pull/65640#event-30205000271
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 29, 2026https://github.com/nodejs/node/pull/65640#issuecomment-5461828936
Please reload this pagehttps://github.com/nodejs/node/pull/65640
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65640?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
2f469dfhttps://app.codecov.io/gh/nodejs/node/commit/2f469dfe48359378d05ba080446bcc1b7f489f24?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
eca0fdbhttps://app.codecov.io/gh/nodejs/node/commit/eca0fdb3b87710a736a45d1dd6830c53b0a5f23f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65640?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/event_target.jshttps://app.codecov.io/gh/nodejs/node/pull/65640?src=pr&el=tree&filepath=lib%2Finternal%2Fevent_target.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2V2ZW50X3RhcmdldC5qcw==
lib/internal/events/abort_listener.jshttps://app.codecov.io/gh/nodejs/node/pull/65640?src=pr&el=tree&filepath=lib%2Finternal%2Fevents%2Fabort_listener.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2V2ZW50cy9hYm9ydF9saXN0ZW5lci5qcw==
29 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65640/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65640
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 29, 2026 https://github.com/nodejs/node/pull/65640#pullrequestreview-5058623218
View reviewed changes https://github.com/nodejs/node/pull/65640/files/eca0fdb3b87710a736a45d1dd6830c53b0a5f23f
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 8, 2026 https://github.com/nodejs/node/pull/65640#pullrequestreview-5138169873
View reviewed changes https://github.com/nodejs/node/pull/65640/files/eca0fdb3b87710a736a45d1dd6830c53b0a5f23f
https://github.com/inoway46
inoway46https://github.com/inoway46
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 25, 2026https://github.com/nodejs/node/pull/65640#event-31845583550
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 25, 2026https://github.com/nodejs/node/pull/65640#event-31845960320
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65640
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 25, 2026https://github.com/nodejs/node/pull/65640#event-31846355074
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2026https://github.com/nodejs/node/pull/65640#issuecomment-5843901476
https://ci.nodejs.org/job/node-test-pull-request/77931/https://ci.nodejs.org/job/node-test-pull-request/77931/
Please reload this pagehttps://github.com/nodejs/node/pull/65640
https://github.com/aduh95
aduh95https://github.com/aduh95
Sep 26, 2026https://github.com/nodejs/node/pull/65640#issuecomment-5844017554
Please reload this pagehttps://github.com/nodejs/node/pull/65640
Please reload this pagehttps://github.com/nodejs/node/pull/65640
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2026https://github.com/nodejs/node/pull/65640#issuecomment-5844067017
https://ci.nodejs.org/job/node-test-pull-request/77939/https://ci.nodejs.org/job/node-test-pull-request/77939/
Please reload this pagehttps://github.com/nodejs/node/pull/65640
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2026https://github.com/nodejs/node/pull/65640#issuecomment-5848603159
https://ci.nodejs.org/job/node-test-pull-request/77971/https://ci.nodejs.org/job/node-test-pull-request/77971/
Please reload this pagehttps://github.com/nodejs/node/pull/65640
https://github.com/panva
panvahttps://github.com/panva
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 26, 2026https://github.com/nodejs/node/pull/65640#event-31905702360
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
261c8a1https://github.com/nodejs/node/commit/261c8a196cea84c4ffcb119545520a11fc28318e
Sep 26, 2026https://github.com/nodejs/node/pull/65640#event-31906032385
Please reload this pagehttps://github.com/nodejs/node/pull/65640
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2026https://github.com/nodejs/node/pull/65640#issuecomment-5849804663
261c8a1https://github.com/nodejs/node/commit/261c8a196cea84c4ffcb119545520a11fc28318e
Please reload this pagehttps://github.com/nodejs/node/pull/65640
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 26, 2026https://github.com/nodejs/node/pull/65640#event-31906034246
aduh95https://github.com/aduh95
Sep 27, 2026 https://github.com/nodejs/node/pull/65640#ref-commit-fbc21cd
https://github.com/lazerg
https://github.com/aduh95
events: fix addAbortListener for aborted signalshttps://github.com/nodejs/node/commit/fbc21cd9bc2b52338358fd358861eb503085aaa7
fbc21cdhttps://github.com/nodejs/node/commit/fbc21cd9bc2b52338358fd358861eb503085aaa7
#65640https://github.com/nodejs/node/pull/65640
HoonDongKanghttps://github.com/HoonDongKang
Sep 28, 2026 https://github.com/nodejs/node/pull/65640#ref-commit-e15f203
https://github.com/lazerg
https://github.com/HoonDongKang
events: fix addAbortListener for aborted signalshttps://github.com/HoonDongKang/node/commit/e15f203f9c4fae3347a7fdb7a409b474bef88b7f
e15f203https://github.com/HoonDongKang/node/commit/e15f203f9c4fae3347a7fdb7a409b474bef88b7f
nodejs#65640https://github.com/nodejs/node/pull/65640
aduh95https://github.com/aduh95
Sep 28, 2026 https://github.com/nodejs/node/pull/65640#ref-commit-215639d
https://github.com/lazerg
https://github.com/aduh95
events: fix addAbortListener for aborted signalshttps://github.com/nodejs/node/commit/215639d6cea3749561423c4ffa125e1ac43c2080
215639dhttps://github.com/nodejs/node/commit/215639d6cea3749561423c4ffa125e1ac43c2080
#65640https://github.com/nodejs/node/pull/65640
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 5, 2026 https://github.com/nodejs/node/pull/65640#ref-pullrequest-5720654094
2026-10-07, Version 26.11.0 (Current) #66546 https://github.com/nodejs/node/pull/66546
https://github.com/robobun
robobunhttps://github.com/robobun
Oct 28, 2026 https://github.com/nodejs/node/pull/65640#ref-pullrequest-6088501718
node:events: give the listener of an aborted AbortSignal a trusted abort event, and let dispose() cancel the call oven-sh/bun#47252 https://github.com/oven-sh/bun/pull/47252
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/65640#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
markhardinghttps://github.com/markharding
Nov 5, 2026 https://github.com/nodejs/node/pull/65640#ref-commit-609f23e
https://github.com/markharding
Update Node.js to v26 (#2168)https://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
609f23ehttps://github.com/futo-org/Harbor/commit/609f23e8d0f42eb45a55543b96b55f997f66e2c3
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65640
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65640/files/eca0fdb3b87710a736a45d1dd6830c53b0a5f23f
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/65640/files/eca0fdb3b87710a736a45d1dd6830c53b0a5f23f
Please reload this pagehttps://github.com/nodejs/node/pull/65640
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
events: addAbortListener ignores disposal and passes undefined event when signal is already aborted https://github.com/nodejs/node/issues/65637
Please reload this pagehttps://github.com/nodejs/node/pull/65640
https://github.com/lazerg
https://github.com/nodejs-github-bot
https://github.com/aduh95
https://github.com/jasnell
https://github.com/ronag
https://github.com/panva
https://github.com/inoway46
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.