René's URL Explorer Experiment


Title: fs: fix recursive watch error handling by panva · Pull Request #65635 · nodejs/node · GitHub

Open Graph Title: fs: fix recursive watch error handling by panva · Pull Request #65635 · nodejs/node

X Title: fs: fix recursive watch error handling by panva · Pull Request #65635 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Recursive watch inverted the throwIfNoEntry check during setup, causing the default behavior to suppress ENOENT while the opt-out threw it. Other setup errors were also silently ignored. Suppress o...

X Description: Recursive watch inverted the throwIfNoEntry check during setup, causing the default behavior to suppress ENOENT while the opt-out threw it. Other setup errors were also silently ignored. Suppress o...

Opengraph URL: https://github.com/nodejs/node/pull/65635

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fcd6cdbf-1944-986b-63d8-3a09b6db6acd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA20C:257A3D:163818:1DE176:6AED0841
html-safe-nonce1ac4aeabd79e4d45bb9070fe82600c2be8521ad4123433f2a26a0ab7356ecef8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjBDOjI1N0EzRDoxNjM4MTg6MURFMTc2OjZBRUQwODQxIiwidmlzaXRvcl9pZCI6IjE3MDYwNDk2OTg1NDQ4MTQxNDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7aa77b10848d0cf2be23a262d7db42e6151f3352b2d7a9216a1098366dfe3028
hovercard-subject-tagpull_request:4390407565
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65635/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/caec4bebf429e4464a1f99ee59f5c4266ef0d3efb9eb0728234a4c9c94ab6d9a/nodejs/node/pull/65635
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/caec4bebf429e4464a1f99ee59f5c4266ef0d3efb9eb0728234a4c9c94ab6d9a/nodejs/node/pull/65635
og:image:altRecursive watch inverted the throwIfNoEntry check during setup, causing the default behavior to suppress ENOENT while the opt-out threw it. Other setup errors were also silently ignored. Suppress o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepanva
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65635#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65635
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65635
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65635
Reloadhttps://github.com/nodejs/node/pull/65635
Reloadhttps://github.com/nodejs/node/pull/65635
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
panva:fs-recursive-watch-errorshttps://github.com/panva/node/tree/fs-recursive-watch-errors
Conversationhttps://github.com/nodejs/node/pull/65635
Commits1 (1)https://github.com/nodejs/node/pull/65635/commits
Checkshttps://github.com/nodejs/node/pull/65635/checks
Files changedhttps://github.com/nodejs/node/pull/65635/files
fs: fix recursive watch error handlinghttps://github.com/nodejs/node/pull/65635#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
panva:fs-recursive-watch-errorshttps://github.com/panva/node/tree/fs-recursive-watch-errors
https://github.com/panva
panvahttps://github.com/panva
Aug 29, 2026https://github.com/nodejs/node/pull/65635#issue-5285087281
Please reload this pagehttps://github.com/nodejs/node/pull/65635
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 29, 2026https://github.com/nodejs/node/pull/65635#event-30202611115
https://github.com/panva
panvahttps://github.com/panva
Aug 29, 2026https://github.com/nodejs/node/pull/65635#issuecomment-5460839524
Please reload this pagehttps://github.com/nodejs/node/pull/65635
https://github.com/panva
fs: fix recursive watch error handlinghttps://github.com/nodejs/node/pull/65635/commits/e998475969f581605e7d0c9194b0a4f06c23a744
e998475https://github.com/nodejs/node/pull/65635/commits/e998475969f581605e7d0c9194b0a4f06c23a744
https://github.com/panva
panvahttps://github.com/panva
force-pushedhttps://github.com/nodejs/node/compare/7047f05e3913a52e65129c98d3db69fded1bc7f7..e998475969f581605e7d0c9194b0a4f06c23a744
7047f05https://github.com/nodejs/node/commit/7047f05e3913a52e65129c98d3db69fded1bc7f7
e998475https://github.com/nodejs/node/commit/e998475969f581605e7d0c9194b0a4f06c23a744
Compare https://github.com/nodejs/node/compare/7047f05e3913a52e65129c98d3db69fded1bc7f7..e998475969f581605e7d0c9194b0a4f06c23a744
August 29, 2026 07:55https://github.com/nodejs/node/pull/65635#event-30204035101
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 29, 2026https://github.com/nodejs/node/pull/65635#issuecomment-5461646438
Please reload this pagehttps://github.com/nodejs/node/pull/65635
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65635?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
2f469dfhttps://app.codecov.io/gh/nodejs/node/commit/2f469dfe48359378d05ba080446bcc1b7f489f24?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e998475https://app.codecov.io/gh/nodejs/node/commit/e998475969f581605e7d0c9194b0a4f06c23a744?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65635?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/recursive_watch.jshttps://app.codecov.io/gh/nodejs/node/pull/65635?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Frecursive_watch.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3JlY3Vyc2l2ZV93YXRjaC5qcw==
30 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65635/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65635
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 29, 2026 https://github.com/nodejs/node/pull/65635#pullrequestreview-5058618912
View reviewed changes https://github.com/nodejs/node/pull/65635/files/e998475969f581605e7d0c9194b0a4f06c23a744
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 29, 2026https://github.com/nodejs/node/pull/65635#event-30215220286
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 29, 2026https://github.com/nodejs/node/pull/65635#event-30215260113
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 29, 2026https://github.com/nodejs/node/pull/65635#issuecomment-5463596617
https://ci.nodejs.org/job/node-test-pull-request/76699/https://ci.nodejs.org/job/node-test-pull-request/76699/
Please reload this pagehttps://github.com/nodejs/node/pull/65635
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 29, 2026 https://github.com/nodejs/node/pull/65635#pullrequestreview-5058895242
View reviewed changes https://github.com/nodejs/node/pull/65635/files/e998475969f581605e7d0c9194b0a4f06c23a744
https://github.com/panva
panvahttps://github.com/panva
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 29, 2026https://github.com/nodejs/node/pull/65635#event-30220642307
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
971cc1chttps://github.com/nodejs/node/commit/971cc1c91e88360547c1c4f01bc525c2d0a1976b
Aug 31, 2026https://github.com/nodejs/node/pull/65635#event-30262747204
Please reload this pagehttps://github.com/nodejs/node/pull/65635
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 31, 2026https://github.com/nodejs/node/pull/65635#issuecomment-5474933037
971cc1chttps://github.com/nodejs/node/commit/971cc1c91e88360547c1c4f01bc525c2d0a1976b
Please reload this pagehttps://github.com/nodejs/node/pull/65635
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 31, 2026https://github.com/nodejs/node/pull/65635#event-30262749254
https://github.com/panva
panvahttps://github.com/panva
August 31, 2026 07:08https://github.com/nodejs/node/pull/65635#event-30262892841
https://github.com/panva
panvahttps://github.com/panva
Aug 31, 2026 https://github.com/nodejs/node/pull/65635#ref-pullrequest-5301676347
test: fix recursive fs.watch error fixture #65683 https://github.com/nodejs/node/pull/65683
aduh95https://github.com/aduh95
Sep 3, 2026 https://github.com/nodejs/node/pull/65635#ref-commit-6be311e
https://github.com/panva
https://github.com/aduh95
fs: fix recursive watch error handlinghttps://github.com/nodejs/node/commit/6be311eb6899681c42b5a8ba3871701d2d46d83b
6be311ehttps://github.com/nodejs/node/commit/6be311eb6899681c42b5a8ba3871701d2d46d83b
#65635https://github.com/nodejs/node/pull/65635
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65635#ref-pullrequest-5376777990
Version 26.9.0 (Current) #65881 https://github.com/nodejs/node/pull/65881
aduh95https://github.com/aduh95
Sep 15, 2026 https://github.com/nodejs/node/pull/65635#ref-commit-d418ca1
https://github.com/panva
https://github.com/aduh95
fs: fix recursive watch error handlinghttps://github.com/nodejs/node/commit/d418ca140edb0f253bfd90486f81a0c6efb80718
d418ca1https://github.com/nodejs/node/commit/d418ca140edb0f253bfd90486f81a0c6efb80718
#65635https://github.com/nodejs/node/pull/65635
aduh95https://github.com/aduh95
Sep 19, 2026 https://github.com/nodejs/node/pull/65635#ref-commit-bf707d6
https://github.com/panva
https://github.com/aduh95
fs: fix recursive watch error handlinghttps://github.com/nodejs/node/commit/bf707d6f7138545fae75b85d02e572ab00be077b
bf707d6https://github.com/nodejs/node/commit/bf707d6f7138545fae75b85d02e572ab00be077b
#65635https://github.com/nodejs/node/pull/65635
aduh95https://github.com/aduh95
Sep 19, 2026 https://github.com/nodejs/node/pull/65635#ref-commit-ba5ca5a
https://github.com/panva
https://github.com/aduh95
fs: fix recursive watch error handlinghttps://github.com/nodejs/node/commit/ba5ca5a1a590eadbff0aeb8344fcba67805e82aa
ba5ca5ahttps://github.com/nodejs/node/commit/ba5ca5a1a590eadbff0aeb8344fcba67805e82aa
#65635https://github.com/nodejs/node/pull/65635
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 11, 2026 https://github.com/nodejs/node/pull/65635#ref-pullrequest-5805806867
2026-10-14, Version 24.22.0 'Krypton' (LTS) #66667 https://github.com/nodejs/node/pull/66667
https://github.com/codeNinja62
codeNinja62https://github.com/codeNinja62
Oct 16, 2026 https://github.com/nodejs/node/pull/65635#ref-pullrequest-5885694593
fs: report errors from recursive watch events #66792 https://github.com/nodejs/node/pull/66792
markhardinghttps://github.com/markharding
Oct 19, 2026 https://github.com/nodejs/node/pull/65635#ref-commit-7e9c1d2
https://github.com/markharding
Update Node.js to v24.22.0 (#1833)https://github.com/futo-org/Harbor/commit/7e9c1d2fd346da653b5f5b3cbdadc19494c1516f
7e9c1d2https://github.com/futo-org/Harbor/commit/7e9c1d2fd346da653b5f5b3cbdadc19494c1516f
https://github.com/steipete
steipetehttps://github.com/steipete
Oct 20, 2026 https://github.com/nodejs/node/pull/65635#ref-pullrequest-5936426447
fix: skill folders created after Gateway start go unwatched on Linux with Node 24 openclaw/openclaw#178095 https://github.com/openclaw/openclaw/pull/178095
steipetehttps://github.com/steipete
Oct 20, 2026 https://github.com/nodejs/node/pull/65635#ref-commit-4150931
https://github.com/steipete
fix: skill folders created after Gateway start go unwatched on Linux …https://github.com/openclaw/openclaw/commit/4150931338d8c608a7b7c1680d74d7ebd7760b98
4150931https://github.com/openclaw/openclaw/commit/4150931338d8c608a7b7c1680d74d7ebd7760b98
#178095https://github.com/openclaw/openclaw/pull/178095
nodejs/node#65635https://github.com/nodejs/node/pull/65635
github-actionshttps://github.com/apps/github-actions
Oct 21, 2026 https://github.com/nodejs/node/pull/65635#ref-commit-5912347
https://github.com/steipete
fix: skill folders created after Gateway start go unwatched on Linux …https://github.com/Desicool/openclaw/commit/5912347a7532333aec6aa00cfa9f388d3827ea75
5912347https://github.com/Desicool/openclaw/commit/5912347a7532333aec6aa00cfa9f388d3827ea75
openclaw#178095https://github.com/openclaw/openclaw/pull/178095
nodejs/node#65635https://github.com/nodejs/node/pull/65635
paultibbettshttps://github.com/paultibbetts
Oct 27, 2026 https://github.com/nodejs/node/pull/65635#ref-commit-1cd6b6e
https://github.com/renovate-bot
https://github.com/paultibbetts
chore(deps): update node.js to v24.22.1 (#12)https://github.com/paultibbetts/indiekit.paultibbetts.uk/commit/1cd6b6eb5f00d6f9cbd77687d68df169241003ad
1cd6b6ehttps://github.com/paultibbetts/indiekit.paultibbetts.uk/commit/1cd6b6eb5f00d6f9cbd77687d68df169241003ad
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65635
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65635/files/e998475969f581605e7d0c9194b0a4f06c23a744
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/65635/files/e998475969f581605e7d0c9194b0a4f06c23a744
Please reload this pagehttps://github.com/nodejs/node/pull/65635
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/65635
https://github.com/panva
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.