René's URL Explorer Experiment


Title: stream: fix early drain after Utf8Stream reopen by mcollina · Pull Request #65633 · nodejs/node · GitHub

Open Graph Title: stream: fix early drain after Utf8Stream reopen by mcollina · Pull Request #65633 · nodejs/node

X Title: stream: fix early drain after Utf8Stream reopen by mcollina · Pull Request #65633 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: If a 'ready' listener starts a write after reopen(), the reopen path still emits 'drain' from a nextTick before that write completes, so a listener reading the file on 'drain...

X Description: If a 'ready' listener starts a write after reopen(), the reopen path still emits 'drain' from a nextTick before that write completes, so a listener reading the file ...

Opengraph URL: https://github.com/nodejs/node/pull/65633

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9fd81d16-47ee-c860-9493-d9fb56fea449
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id83A4:1980F6:B1577:E91A5:6AED0814
html-safe-nonce5081a1c409f33732b27fb791d4a38a8eab5539a30efc7ad9d140b60b14d0c45b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0E0OjE5ODBGNjpCMTU3NzpFOTFBNTo2QUVEMDgxNCIsInZpc2l0b3JfaWQiOiI4ODc0ODg5NTIwNTExNTE4NzQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacea7925c31ecac388735a971164106827b17e6863b53679673877ea567143d2d7
hovercard-subject-tagpull_request:4390216345
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65633/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/be6abb21fcc32235f02d2261ed285cce028df3501dba40fb4de6248ffac935a5/nodejs/node/pull/65633
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/be6abb21fcc32235f02d2261ed285cce028df3501dba40fb4de6248ffac935a5/nodejs/node/pull/65633
og:image:altIf a 'ready' listener starts a write after reopen(), the reopen path still emits 'drain' from a nextTick before that write completes, so a listener reading the file on 'drain...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcollina
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65633#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65633
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65633
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65633
Reloadhttps://github.com/nodejs/node/pull/65633
Reloadhttps://github.com/nodejs/node/pull/65633
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
mcollina:fix-utf8stream-reopen-drainhttps://github.com/mcollina/node/tree/fix-utf8stream-reopen-drain
Conversationhttps://github.com/nodejs/node/pull/65633
Commits1 (1)https://github.com/nodejs/node/pull/65633/commits
Checkshttps://github.com/nodejs/node/pull/65633/checks
Files changedhttps://github.com/nodejs/node/pull/65633/files
stream: fix early drain after Utf8Stream reopenhttps://github.com/nodejs/node/pull/65633#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
mcollina:fix-utf8stream-reopen-drainhttps://github.com/mcollina/node/tree/fix-utf8stream-reopen-drain
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 29, 2026https://github.com/nodejs/node/pull/65633#issue-5284846745
2e8a4b1https://github.com/nodejs/node/commit/2e8a4b1a8ce897808b7a774afe8bfdb00f6045a7
pinojs/sonic-boom#255https://github.com/pinojs/sonic-boom/pull/255
Please reload this pagehttps://github.com/nodejs/node/pull/65633
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 29, 2026https://github.com/nodejs/node/pull/65633#issuecomment-5460577648
Please reload this pagehttps://github.com/nodejs/node/pull/65633
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Aug 29, 2026https://github.com/nodejs/node/pull/65633#event-30201431607
https://github.com/mcollina
mcollinahttps://github.com/mcollina
jasnellhttps://github.com/jasnell
August 29, 2026 05:32https://github.com/nodejs/node/pull/65633#event-30201476092
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Aug 29, 2026 https://github.com/nodejs/node/pull/65633#pullrequestreview-5057223624
View reviewed changes https://github.com/nodejs/node/pull/65633/files/90dfd42d97cea025ba50185ece9399f9e43aaf35
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 29, 2026https://github.com/nodejs/node/pull/65633#issuecomment-5460975942
Please reload this pagehttps://github.com/nodejs/node/pull/65633
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65633?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
2f469dfhttps://app.codecov.io/gh/nodejs/node/commit/2f469dfe48359378d05ba080446bcc1b7f489f24?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
90dfd42https://app.codecov.io/gh/nodejs/node/commit/90dfd42d97cea025ba50185ece9399f9e43aaf35?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65633?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/fast-utf8-stream.jshttps://app.codecov.io/gh/nodejs/node/pull/65633?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Ffast-utf8-stream.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvZmFzdC11dGY4LXN0cmVhbS5qcw==
33 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65633/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65633
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 29, 2026 https://github.com/nodejs/node/pull/65633#pullrequestreview-5057251838
View reviewed changes https://github.com/nodejs/node/pull/65633/files/90dfd42d97cea025ba50185ece9399f9e43aaf35
https://github.com/mcollina
stream: fix early drain after Utf8Stream reopenhttps://github.com/nodejs/node/pull/65633/commits/90dfd42d97cea025ba50185ece9399f9e43aaf35
90dfd42https://github.com/nodejs/node/pull/65633/commits/90dfd42d97cea025ba50185ece9399f9e43aaf35
2e8a4b1https://github.com/mcollina/node/commit/2e8a4b1a8ce897808b7a774afe8bfdb00f6045a7
nodejs@2e8a4b1a8cehttps://github.com/nodejs/node/commit/2e8a4b1a8ce
https://github.com/mcollina
mcollinahttps://github.com/mcollina
force-pushedhttps://github.com/nodejs/node/compare/7837e2ffe07d0dd343c951b1adb53ab35e870e12..90dfd42d97cea025ba50185ece9399f9e43aaf35
7837e2fhttps://github.com/nodejs/node/commit/7837e2ffe07d0dd343c951b1adb53ab35e870e12
90dfd42https://github.com/nodejs/node/commit/90dfd42d97cea025ba50185ece9399f9e43aaf35
Compare https://github.com/nodejs/node/compare/7837e2ffe07d0dd343c951b1adb53ab35e870e12..90dfd42d97cea025ba50185ece9399f9e43aaf35
August 29, 2026 08:40https://github.com/nodejs/node/pull/65633#event-30204866217
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 29, 2026 https://github.com/nodejs/node/pull/65633#pullrequestreview-5058617980
View reviewed changes https://github.com/nodejs/node/pull/65633/files/90dfd42d97cea025ba50185ece9399f9e43aaf35
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 29, 2026https://github.com/nodejs/node/pull/65633#event-30221183994
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 29, 2026https://github.com/nodejs/node/pull/65633#event-30221312158
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 29, 2026https://github.com/nodejs/node/pull/65633#issuecomment-5465076604
https://ci.nodejs.org/job/node-test-pull-request/76708/https://ci.nodejs.org/job/node-test-pull-request/76708/
Please reload this pagehttps://github.com/nodejs/node/pull/65633
https://github.com/mcollina
mcollinahttps://github.com/mcollina
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 30, 2026https://github.com/nodejs/node/pull/65633#event-30229192646
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
5947a91https://github.com/nodejs/node/commit/5947a91327fcc0d0b41b3947ebeb3365c34aecd3
Aug 31, 2026https://github.com/nodejs/node/pull/65633#event-30259448620
Please reload this pagehttps://github.com/nodejs/node/pull/65633
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 31, 2026https://github.com/nodejs/node/pull/65633#issuecomment-5474200962
5947a91https://github.com/nodejs/node/commit/5947a91327fcc0d0b41b3947ebeb3365c34aecd3
Please reload this pagehttps://github.com/nodejs/node/pull/65633
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 31, 2026https://github.com/nodejs/node/pull/65633#event-30259450236
aduh95https://github.com/aduh95
Sep 3, 2026 https://github.com/nodejs/node/pull/65633#ref-commit-81abe3b
https://github.com/mcollina
https://github.com/aduh95
stream: fix early drain after Utf8Stream reopenhttps://github.com/nodejs/node/commit/81abe3b61fcfe4681c49672a0ff862d2372566ae
81abe3bhttps://github.com/nodejs/node/commit/81abe3b61fcfe4681c49672a0ff862d2372566ae
2e8a4b1https://github.com/nodejs/node/commit/2e8a4b1a8ce897808b7a774afe8bfdb00f6045a7
2e8a4b1a8cehttps://github.com/nodejs/node/commit/2e8a4b1a8ce
#65633https://github.com/nodejs/node/pull/65633
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65633#ref-pullrequest-5376777990
Version 26.9.0 (Current) #65881 https://github.com/nodejs/node/pull/65881
aduh95https://github.com/aduh95
Sep 15, 2026 https://github.com/nodejs/node/pull/65633#ref-commit-dfe0617
https://github.com/mcollina
https://github.com/aduh95
stream: fix early drain after Utf8Stream reopenhttps://github.com/nodejs/node/commit/dfe0617e71b6482ec6a57db613b1bb40ccd5670a
dfe0617https://github.com/nodejs/node/commit/dfe0617e71b6482ec6a57db613b1bb40ccd5670a
2e8a4b1https://github.com/nodejs/node/commit/2e8a4b1a8ce897808b7a774afe8bfdb00f6045a7
2e8a4b1a8cehttps://github.com/nodejs/node/commit/2e8a4b1a8ce
#65633https://github.com/nodejs/node/pull/65633
aduh95https://github.com/aduh95
Sep 19, 2026 https://github.com/nodejs/node/pull/65633#ref-commit-f0e1096
https://github.com/mcollina
https://github.com/aduh95
stream: fix early drain after Utf8Stream reopenhttps://github.com/nodejs/node/commit/f0e1096ba7e2bedad8a081228a304163888b5ad2
f0e1096https://github.com/nodejs/node/commit/f0e1096ba7e2bedad8a081228a304163888b5ad2
2e8a4b1https://github.com/nodejs/node/commit/2e8a4b1a8ce897808b7a774afe8bfdb00f6045a7
2e8a4b1a8cehttps://github.com/nodejs/node/commit/2e8a4b1a8ce
#65633https://github.com/nodejs/node/pull/65633
aduh95https://github.com/aduh95
Sep 19, 2026 https://github.com/nodejs/node/pull/65633#ref-commit-47b3f6a
https://github.com/mcollina
https://github.com/aduh95
stream: fix early drain after Utf8Stream reopenhttps://github.com/nodejs/node/commit/47b3f6a1fa200fc6f1a1d952bd781ee34e056597
47b3f6ahttps://github.com/nodejs/node/commit/47b3f6a1fa200fc6f1a1d952bd781ee34e056597
2e8a4b1https://github.com/nodejs/node/commit/2e8a4b1a8ce897808b7a774afe8bfdb00f6045a7
2e8a4b1a8cehttps://github.com/nodejs/node/commit/2e8a4b1a8ce
#65633https://github.com/nodejs/node/pull/65633
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 11, 2026 https://github.com/nodejs/node/pull/65633#ref-pullrequest-5805806867
2026-10-14, Version 24.22.0 'Krypton' (LTS) #66667 https://github.com/nodejs/node/pull/66667
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65633
https://github.com/ShogunPanda
ShogunPanda https://github.com/ShogunPanda
https://github.com/nodejs/node/pull/65633/files/90dfd42d97cea025ba50185ece9399f9e43aaf35
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65633/files/90dfd42d97cea025ba50185ece9399f9e43aaf35
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/65633/files/90dfd42d97cea025ba50185ece9399f9e43aaf35
Please reload this pagehttps://github.com/nodejs/node/pull/65633
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/65633
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com/ShogunPanda
https://github.com/jasnell
https://github.com/ronag
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.