René's URL Explorer Experiment


Title: http: match subdomains for plain NO_PROXY entries by dibenkobit · Pull Request #65617 · nodejs/node · GitHub

Open Graph Title: http: match subdomains for plain NO_PROXY entries by dibenkobit · Pull Request #65617 · nodejs/node

X Title: http: match subdomains for plain NO_PROXY entries by dibenkobit · Pull Request #65617 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: NO_PROXY=example.com only exact-matched the hostname in the http/https built-ins, so requests to subdomains still used the proxy. Make plain domain entries match the host and its subdomains, as fet...

X Description: NO_PROXY=example.com only exact-matched the hostname in the http/https built-ins, so requests to subdomains still used the proxy. Make plain domain entries match the host and its subdomains, as fet...

Opengraph URL: https://github.com/nodejs/node/pull/65617

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ca587581-0327-6f43-cf98-ecb7c5e74bfd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB1FA:36D84F:930324:C3B682:6AED2F42
html-safe-nonce6c3324dea004c1e43def5ce64bf1378192fde054bfe2514133d9ae83749b9bff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUZBOjM2RDg0Rjo5MzAzMjQ6QzNCNjgyOjZBRUQyRjQyIiwidmlzaXRvcl9pZCI6IjUyNTM5ODUyMTk1NTgzMjE5ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf7188535193b49a6ed45c3fc153fc7bd2de4973099f7a977b847629c412152cc
hovercard-subject-tagpull_request:4384792436
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65617/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b5df2c04c00d3dbe5579eafe38964a47565b7f4cc909e909db5370dc84b0ae63/nodejs/node/pull/65617
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b5df2c04c00d3dbe5579eafe38964a47565b7f4cc909e909db5370dc84b0ae63/nodejs/node/pull/65617
og:image:altNO_PROXY=example.com only exact-matched the hostname in the http/https built-ins, so requests to subdomains still used the proxy. Make plain domain entries match the host and its subdomains, as fet...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedibenkobit
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65617#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65617
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65617
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65617
Reloadhttps://github.com/nodejs/node/pull/65617
Reloadhttps://github.com/nodejs/node/pull/65617
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
dibenkobithttps://github.com/dibenkobit
nodejs:mainhttps://github.com/nodejs/node/tree/main
dibenkobit:http-no-proxy-suffixhttps://github.com/dibenkobit/node/tree/http-no-proxy-suffix
Conversationhttps://github.com/nodejs/node/pull/65617
Commits5 (5)https://github.com/nodejs/node/pull/65617/commits
Checkshttps://github.com/nodejs/node/pull/65617/checks
Files changedhttps://github.com/nodejs/node/pull/65617/files
http: match subdomains for plain NO_PROXY entrieshttps://github.com/nodejs/node/pull/65617#top
dibenkobithttps://github.com/dibenkobit
nodejs:mainhttps://github.com/nodejs/node/tree/main
dibenkobit:http-no-proxy-suffixhttps://github.com/dibenkobit/node/tree/http-no-proxy-suffix
https://github.com/dibenkobit
dibenkobithttps://github.com/dibenkobit
Aug 28, 2026https://github.com/nodejs/node/pull/65617#issue-5278333983
Please reload this pagehttps://github.com/nodejs/node/pull/65617
#65616https://github.com/nodejs/node/issues/65616
#57872https://github.com/nodejs/node/issues/57872
Please reload this pagehttps://github.com/nodejs/node/pull/65617
https://github.com/dibenkobit
http: match subdomains for plain NO_PROXY entrieshttps://github.com/nodejs/node/pull/65617/commits/b19633ffd74aab9670e929c0f9b5d3e56d3505f5
b19633fhttps://github.com/nodejs/node/pull/65617/commits/b19633ffd74aab9670e929c0f9b5d3e56d3505f5
nodejs#65616https://github.com/nodejs/node/issues/65616
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 28, 2026https://github.com/nodejs/node/pull/65617#issuecomment-5452668929
Please reload this pagehttps://github.com/nodejs/node/pull/65617
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 28, 2026https://github.com/nodejs/node/pull/65617#event-30165231666
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 29, 2026https://github.com/nodejs/node/pull/65617#issuecomment-5464394961
Please reload this pagehttps://github.com/nodejs/node/pull/65617
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65617?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
9f04fcdhttps://app.codecov.io/gh/nodejs/node/commit/9f04fcd70d28ac691f592d3c0c1e00a28998eb51?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
09d37d4https://app.codecov.io/gh/nodejs/node/commit/09d37d4c0cc4300060bd5b44697aa89eaa1fdacf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65617?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/http.jshttps://app.codecov.io/gh/nodejs/node/pull/65617?src=pr&el=tree&filepath=lib%2Finternal%2Fhttp.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2h0dHAuanM=
73 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65617/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65617
https://github.com/inoway46
inoway46https://github.com/inoway46
Aug 30, 2026 https://github.com/nodejs/node/pull/65617#pullrequestreview-5060030956
View reviewed changes https://github.com/nodejs/node/pull/65617/files/b19633ffd74aab9670e929c0f9b5d3e56d3505f5
lib/internal/http.jshttps://github.com/nodejs/node/pull/65617/files/b19633ffd74aab9670e929c0f9b5d3e56d3505f5#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
inoway46https://github.com/inoway46
Aug 30, 2026https://github.com/nodejs/node/pull/65617#discussion_r3888566766
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65617
dibenkobithttps://github.com/dibenkobit
Aug 30, 2026https://github.com/nodejs/node/pull/65617#discussion_r3888616645
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65617
dibenkobithttps://github.com/dibenkobit
Sep 1, 2026https://github.com/nodejs/node/pull/65617#discussion_r3901343019
Please reload this pagehttps://github.com/nodejs/node/pull/65617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65617
https://github.com/inoway46
inoway46https://github.com/inoway46
Aug 30, 2026 https://github.com/nodejs/node/pull/65617#pullrequestreview-5060040729
View reviewed changes https://github.com/nodejs/node/pull/65617/files/b19633ffd74aab9670e929c0f9b5d3e56d3505f5
test/client-proxy/test-http-proxy-request-no-proxy-domain.mjshttps://github.com/nodejs/node/pull/65617/files/b19633ffd74aab9670e929c0f9b5d3e56d3505f5#diff-a579e311fc2304c36b32aa6b8e0512e65b0cffc7aa18775f6bbdb9c2b7435e74
inoway46https://github.com/inoway46
Aug 30, 2026https://github.com/nodejs/node/pull/65617#discussion_r3888574947
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65617
dibenkobithttps://github.com/dibenkobit
Aug 30, 2026https://github.com/nodejs/node/pull/65617#discussion_r3888617761
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65617
dibenkobithttps://github.com/dibenkobit
Sep 1, 2026https://github.com/nodejs/node/pull/65617#discussion_r3901288662
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65617
dibenkobithttps://github.com/dibenkobit
September 1, 2026 11:09https://github.com/nodejs/node/pull/65617#commits-pushed-734e21b
https://github.com/dibenkobit
fixup! http: match subdomains for plain NO_PROXY entrieshttps://github.com/nodejs/node/pull/65617/commits/734e21befa42215be9a91993b56fff773aa4a5e7
734e21bhttps://github.com/nodejs/node/pull/65617/commits/734e21befa42215be9a91993b56fff773aa4a5e7
https://github.com/dibenkobit
fixup! http: match subdomains for plain NO_PROXY entrieshttps://github.com/nodejs/node/pull/65617/commits/4be166252d7b754edf7f8a302ecac9c925d89b5f
4be1662https://github.com/nodejs/node/pull/65617/commits/4be166252d7b754edf7f8a302ecac9c925d89b5f
https://github.com/dibenkobit
fixup! http: match subdomains for plain NO_PROXY entrieshttps://github.com/nodejs/node/pull/65617/commits/15fa39757965a4dddd5487028397e5c3547ccb5e
15fa397https://github.com/nodejs/node/pull/65617/commits/15fa39757965a4dddd5487028397e5c3547ccb5e
https://github.com/dibenkobit
dibenkobithttps://github.com/dibenkobit
September 1, 2026 12:45https://github.com/nodejs/node/pull/65617#event-30346020614
https://github.com/dibenkobit
dibenkobithttps://github.com/dibenkobit
force-pushedhttps://github.com/nodejs/node/compare/af34dc3358d33963b81952d833062b130eb6ae3c..8af581d3687fc3b47ebf27ea0f7b806d4c01323d
af34dc3https://github.com/nodejs/node/commit/af34dc3358d33963b81952d833062b130eb6ae3c
8af581dhttps://github.com/nodejs/node/commit/8af581d3687fc3b47ebf27ea0f7b806d4c01323d
Compare https://github.com/nodejs/node/compare/af34dc3358d33963b81952d833062b130eb6ae3c..8af581d3687fc3b47ebf27ea0f7b806d4c01323d
September 1, 2026 12:57https://github.com/nodejs/node/pull/65617#event-30346759709
https://github.com/dibenkobit
fixup! http: match subdomains for plain NO_PROXY entrieshttps://github.com/nodejs/node/pull/65617/commits/09d37d4c0cc4300060bd5b44697aa89eaa1fdacf
09d37d4https://github.com/nodejs/node/pull/65617/commits/09d37d4c0cc4300060bd5b44697aa89eaa1fdacf
https://github.com/dibenkobit
dibenkobithttps://github.com/dibenkobit
force-pushedhttps://github.com/nodejs/node/compare/8af581d3687fc3b47ebf27ea0f7b806d4c01323d..09d37d4c0cc4300060bd5b44697aa89eaa1fdacf
8af581dhttps://github.com/nodejs/node/commit/8af581d3687fc3b47ebf27ea0f7b806d4c01323d
09d37d4https://github.com/nodejs/node/commit/09d37d4c0cc4300060bd5b44697aa89eaa1fdacf
Compare https://github.com/nodejs/node/compare/8af581d3687fc3b47ebf27ea0f7b806d4c01323d..09d37d4c0cc4300060bd5b44697aa89eaa1fdacf
September 1, 2026 13:44https://github.com/nodejs/node/pull/65617#event-30349620998
https://github.com/dibenkobit
dibenkobithttps://github.com/dibenkobit
September 1, 2026 13:44https://github.com/nodejs/node/pull/65617#event-30349646638
https://github.com/dibenkobit
dibenkobithttps://github.com/dibenkobit
inoway46https://github.com/inoway46
September 1, 2026 13:44https://github.com/nodejs/node/pull/65617#event-30349652782
https://github.com/dibenkobit
dibenkobithttps://github.com/dibenkobit
Sep 1, 2026 https://github.com/nodejs/node/pull/65617#ref-issue-2993213777
Tracking issue: HTTP_PROXY/HTTPS_PROXY/NO_PROXY support in Node.js #57872 https://github.com/nodejs/node/issues/57872
https://github.com/mcollina
mcollinahttps://github.com/mcollina
joyeecheunghttps://github.com/joyeecheung
inoway46https://github.com/inoway46
September 1, 2026 15:17https://github.com/nodejs/node/pull/65617#event-30355518399
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 1, 2026 https://github.com/nodejs/node/pull/65617#pullrequestreview-5079849036
View reviewed changes https://github.com/nodejs/node/pull/65617/files/09d37d4c0cc4300060bd5b44697aa89eaa1fdacf
doc/api/http.mdhttps://github.com/nodejs/node/pull/65617/files/09d37d4c0cc4300060bd5b44697aa89eaa1fdacf#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641
mcollinahttps://github.com/mcollina
Sep 1, 2026https://github.com/nodejs/node/pull/65617#discussion_r3905602629
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65617
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65617
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/65617/files/09d37d4c0cc4300060bd5b44697aa89eaa1fdacf
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/inoway46
inoway46 https://github.com/inoway46
https://github.com/nodejs/node/pull/65617/files/b19633ffd74aab9670e929c0f9b5d3e56d3505f5
Please reload this pagehttps://github.com/nodejs/node/pull/65617
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
NO_PROXY=example.com does not bypass subdomains for http.request(), unlike fetch() https://github.com/nodejs/node/issues/65616
Please reload this pagehttps://github.com/nodejs/node/pull/65617
https://github.com/dibenkobit
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/inoway46
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.