René's URL Explorer Experiment


Title: vfs: fix rename over non-empty directory by christianaurichzm · Pull Request #65613 · nodejs/node · GitHub

Open Graph Title: vfs: fix rename over non-empty directory by christianaurichzm · Pull Request #65613 · nodejs/node

X Title: vfs: fix rename over non-empty directory by christianaurichzm · Pull Request #65613 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: MemoryProvider#renameSync() only rejected a destination whose type differed from the source (EISDIR/ENOTDIR). When both sides were directories it fell through to replacing the destination in its pa...

X Description: MemoryProvider#renameSync() only rejected a destination whose type differed from the source (EISDIR/ENOTDIR). When both sides were directories it fell through to replacing the destination in its pa...

Opengraph URL: https://github.com/nodejs/node/pull/65613

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f65cf720-ad04-c456-80ce-ddab32ba6004
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD2E:143C91:C0F1BE:1009994:6AED3A7A
html-safe-nonce2ce9d5c4dcc3f423e9d1f7b2b3f238b0bcf0120b5c86ea22ea4704f345c6af30
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDJFOjE0M0M5MTpDMEYxQkU6MTAwOTk5NDo2QUVEM0E3QSIsInZpc2l0b3JfaWQiOiIzOTk2NTAzMjgxNTkxMjA0NDc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2a973695b518d3eb53d2492dc7024e4fcc01396487892dc6dea0cfb775cf8c02
hovercard-subject-tagpull_request:4383457330
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65613/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/57b90a923599e4db4b4660439fa0be05ec4c1d86452b1f336491293c5c68871f/nodejs/node/pull/65613
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/57b90a923599e4db4b4660439fa0be05ec4c1d86452b1f336491293c5c68871f/nodejs/node/pull/65613
og:image:altMemoryProvider#renameSync() only rejected a destination whose type differed from the source (EISDIR/ENOTDIR). When both sides were directories it fell through to replacing the destination in its pa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechristianaurichzm
hostnamegithub.com
expected-hostnamegithub.com
None26c92a9388ddfad3fa88d132b5d5f0b4747030233dcc4e5efb05f1cbae152184
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec629ad99c254d306375fc8354d04321c2c362236
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65613#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65613
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65613
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65613
Reloadhttps://github.com/nodejs/node/pull/65613
Reloadhttps://github.com/nodejs/node/pull/65613
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests664 (664)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
christianaurichzmhttps://github.com/christianaurichzm
nodejs:mainhttps://github.com/nodejs/node/tree/main
christianaurichzm:vfs-fix-rename-over-non-empty-directoryhttps://github.com/christianaurichzm/node/tree/vfs-fix-rename-over-non-empty-directory
Conversationhttps://github.com/nodejs/node/pull/65613
Commits2 (2)https://github.com/nodejs/node/pull/65613/commits
Checkshttps://github.com/nodejs/node/pull/65613/checks
Files changedhttps://github.com/nodejs/node/pull/65613/files
vfs: fix rename over non-empty directoryhttps://github.com/nodejs/node/pull/65613#top
christianaurichzmhttps://github.com/christianaurichzm
nodejs:mainhttps://github.com/nodejs/node/tree/main
christianaurichzm:vfs-fix-rename-over-non-empty-directoryhttps://github.com/christianaurichzm/node/tree/vfs-fix-rename-over-non-empty-directory
https://github.com/christianaurichzm
christianaurichzmhttps://github.com/christianaurichzm
Aug 28, 2026https://github.com/nodejs/node/pull/65613#issue-5276745263
Please reload this pagehttps://github.com/nodejs/node/pull/65613
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vfs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avfs
Aug 28, 2026https://github.com/nodejs/node/pull/65613#event-30156422786
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 28, 2026https://github.com/nodejs/node/pull/65613#issuecomment-5451968297
Please reload this pagehttps://github.com/nodejs/node/pull/65613
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65613?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
705646fhttps://app.codecov.io/gh/nodejs/node/commit/705646f2f70fd8097d13d85de8347a74b6c443af?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
7789cf3https://app.codecov.io/gh/nodejs/node/commit/7789cf376f213f7224d41bbc2a7461cd9845b18b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65613?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/vfs/providers/memory.jshttps://app.codecov.io/gh/nodejs/node/pull/65613?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Fproviders%2Fmemory.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy9wcm92aWRlcnMvbWVtb3J5Lmpz
34 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65613/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65613
https://github.com/christianaurichzm
vfs: fix rename over non-empty directoryhttps://github.com/nodejs/node/pull/65613/commits/5eeb333bb15488a98f75c5b1e6daa3948b046847
5eeb333https://github.com/nodejs/node/pull/65613/commits/5eeb333bb15488a98f75c5b1e6daa3948b046847
https://github.com/christianaurichzm
christianaurichzmhttps://github.com/christianaurichzm
force-pushedhttps://github.com/nodejs/node/compare/e9333ce3258684ac1a70ece92baf1ad7cd5ddabd..5eeb333bb15488a98f75c5b1e6daa3948b046847
e9333cehttps://github.com/nodejs/node/commit/e9333ce3258684ac1a70ece92baf1ad7cd5ddabd
5eeb333https://github.com/nodejs/node/commit/5eeb333bb15488a98f75c5b1e6daa3948b046847
Compare https://github.com/nodejs/node/compare/e9333ce3258684ac1a70ece92baf1ad7cd5ddabd..5eeb333bb15488a98f75c5b1e6daa3948b046847
August 31, 2026 20:26https://github.com/nodejs/node/pull/65613#event-30303540671
https://github.com/christianaurichzm
christianaurichzmhttps://github.com/christianaurichzm
Aug 31, 2026https://github.com/nodejs/node/pull/65613#issuecomment-5484128355
@mcollinahttps://github.com/mcollina
4d9cb71https://github.com/nodejs/node/commit/4d9cb71fa290f8f79fcd344bbb52930d547b4c1c
Please reload this pagehttps://github.com/nodejs/node/pull/65613
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 1, 2026 https://github.com/nodejs/node/pull/65613#pullrequestreview-5073912955
View reviewed changes https://github.com/nodejs/node/pull/65613/files/5eeb333bb15488a98f75c5b1e6daa3948b046847
lib/internal/vfs/providers/memory.jshttps://github.com/nodejs/node/pull/65613/files/5eeb333bb15488a98f75c5b1e6daa3948b046847#diff-e954e208a8f73fa7dd4ce5b1eb35b1f5cead8d2a9ce751037e54a65334f40963
Please reload this pagehttps://github.com/nodejs/node/pull/65613
https://github.com/christianaurichzm
vfs: fix rename over a lazy destination directoryhttps://github.com/nodejs/node/pull/65613/commits/7789cf376f213f7224d41bbc2a7461cd9845b18b
7789cf3https://github.com/nodejs/node/pull/65613/commits/7789cf376f213f7224d41bbc2a7461cd9845b18b
https://github.com/christianaurichzm
christianaurichzmhttps://github.com/christianaurichzm
trivikrhttps://github.com/trivikr
September 1, 2026 13:14https://github.com/nodejs/node/pull/65613#event-30347784064
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 1, 2026https://github.com/nodejs/node/pull/65613#event-30349848346
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 1, 2026 https://github.com/nodejs/node/pull/65613#pullrequestreview-5078836873
View reviewed changes https://github.com/nodejs/node/pull/65613/files/7789cf376f213f7224d41bbc2a7461cd9845b18b
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 1, 2026https://github.com/nodejs/node/pull/65613#event-30350075139
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65613
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 1, 2026 https://github.com/nodejs/node/pull/65613#pullrequestreview-5079765304
View reviewed changes https://github.com/nodejs/node/pull/65613/files/7789cf376f213f7224d41bbc2a7461cd9845b18b
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/65613#pullrequestreview-5079765304
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65613
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 1, 2026https://github.com/nodejs/node/pull/65613#event-30355640041
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 1, 2026https://github.com/nodejs/node/pull/65613#issuecomment-5500626014
https://ci.nodejs.org/job/node-test-pull-request/76856/https://ci.nodejs.org/job/node-test-pull-request/76856/
Please reload this pagehttps://github.com/nodejs/node/pull/65613
https://github.com/christianaurichzm
christianaurichzmhttps://github.com/christianaurichzm
Sep 3, 2026https://github.com/nodejs/node/pull/65613#issuecomment-5519917702
nodejs/build#4387https://github.com/nodejs/build/issues/4387
Please reload this pagehttps://github.com/nodejs/node/pull/65613
trivikrhttps://github.com/trivikr
Sep 3, 2026 https://github.com/nodejs/node/pull/65613#ref-commit-b53ddc0
https://github.com/christianaurichzm
https://github.com/trivikr
vfs: fix rename over non-empty directoryhttps://github.com/nodejs/node/commit/b53ddc0daabba17604e7100726c1e233a5f7f15b
b53ddc0https://github.com/nodejs/node/commit/b53ddc0daabba17604e7100726c1e233a5f7f15b
#65613https://github.com/nodejs/node/pull/65613
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 3, 2026https://github.com/nodejs/node/pull/65613#issuecomment-5520542896
b53ddc0https://github.com/nodejs/node/commit/b53ddc0daabba17604e7100726c1e233a5f7f15b
Please reload this pagehttps://github.com/nodejs/node/pull/65613
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 3, 2026https://github.com/nodejs/node/pull/65613#event-30463480362
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 3, 2026https://github.com/nodejs/node/pull/65613#issuecomment-5520553392
Please reload this pagehttps://github.com/nodejs/node/pull/65613
aduh95https://github.com/aduh95
Sep 3, 2026 https://github.com/nodejs/node/pull/65613#ref-commit-5c86964
https://github.com/christianaurichzm
https://github.com/aduh95
vfs: fix rename over non-empty directoryhttps://github.com/nodejs/node/commit/5c869646be23c9b851c42440d8c26690a652b672
5c86964https://github.com/nodejs/node/commit/5c869646be23c9b851c42440d8c26690a652b672
#65613https://github.com/nodejs/node/pull/65613
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65613#ref-pullrequest-5376777990
Version 26.9.0 (Current) #65881 https://github.com/nodejs/node/pull/65881
aduh95https://github.com/aduh95
Sep 15, 2026 https://github.com/nodejs/node/pull/65613#ref-commit-ea6f70b
https://github.com/christianaurichzm
https://github.com/aduh95
vfs: fix rename over non-empty directoryhttps://github.com/nodejs/node/commit/ea6f70ba412dfc5a6fc5d3a62bda6cdde31b19c1
ea6f70bhttps://github.com/nodejs/node/commit/ea6f70ba412dfc5a6fc5d3a62bda6cdde31b19c1
#65613https://github.com/nodejs/node/pull/65613
https://github.com/dibenkobit
dibenkobithttps://github.com/dibenkobit
Nov 3, 2026 https://github.com/nodejs/node/pull/65613#ref-pullrequest-5178725059
vfs: reject rename onto a non-empty directory #65373 https://github.com/nodejs/node/pull/65373
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65613
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/65613/files/7789cf376f213f7224d41bbc2a7461cd9845b18b
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/65613/files/7789cf376f213f7224d41bbc2a7461cd9845b18b
Please reload this pagehttps://github.com/nodejs/node/pull/65613
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vfs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avfs
Please reload this pagehttps://github.com/nodejs/node/pull/65613
https://github.com/christianaurichzm
https://github.com/nodejs-github-bot
https://github.com/trivikr
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.