René's URL Explorer Experiment

Title: buffer: pad aligned allocations by a multiple of 8 by lazerg · Pull Request #65605 · nodejs/node · GitHub

Open Graph Title: buffer: pad aligned allocations by a multiple of 8 by lazerg · Pull Request #65605 · nodejs/node

X Title: buffer: pad aligned allocations by a multiple of 8 by lazerg · Pull Request #65605 · nodejs/node

Description: Reaching an aligned start only needs alignment - 1 extra bytes, but padding by exactly that much leaves the Buffer.allocUnsafe() pool sitting in a 65599 byte ArrayBuffer, so a pooled buffer no longer ends on an element boundary of it. new Uint32Array(buf.buffer, buf.byteOffset) has thrown a RangeError since v26.8.0 as a result. Pad by a multiple of 8 instead. Backing store addresses are 8 byte aligned too, so what is left after the buffer stays a whole number of elements, as it was before v26.8.0. The accepted size drops by one byte for alignments above 8, since that much more is now allocated. Fixes: #65601

Open Graph Description: Reaching an aligned start only needs alignment - 1 extra bytes, but padding by exactly that much leaves the Buffer.allocUnsafe() pool sitting in a 65599 byte ArrayBuffer, so a pooled buffer no long...

X Description: Reaching an aligned start only needs alignment - 1 extra bytes, but padding by exactly that much leaves the Buffer.allocUnsafe() pool sitting in a 65599 byte ArrayBuffer, so a pooled buffer no long...

Opengraph URL: https://github.com/nodejs/node/pull/65605

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width