René's URL Explorer Experiment


Title: fs: coerce FileHandle.read length like fs.read by xia-chao · Pull Request #65521 · nodejs/node · GitHub

Open Graph Title: fs: coerce FileHandle.read length like fs.read by xia-chao · Pull Request #65521 · nodejs/node

X Title: fs: coerce FileHandle.read length like fs.read by xia-chao · Pull Request #65521 · nodejs/node

Description: Summary fs.promises.FileHandle.read() forwarded a non-number length (for example "5") into binding.read. node::fs::Read requires args[3]->IsInt32() and aborts the process on a debug/CHECK failure. fs.read / fs.readSync already coerce with length |= 0 after defaulting. This applies the same step on the promises path so a bad length cannot reach C++. Test plan ./node test/parallel/test-fs-promises-file-handle-read.js Existing FileHandle.read cases (empty length, options object, null/undefined length) still pass on CI const fh = await fs.promises.open(file, 'r'); await fh.read(Buffer.alloc(20), 0, '5', 0); // must not abort; bytesRead === 5

Open Graph Description: Summary fs.promises.FileHandle.read() forwarded a non-number length (for example "5") into binding.read. node::fs::Read requires args[3]->IsInt32() and aborts the process on a debug/CH...

X Description: Summary fs.promises.FileHandle.read() forwarded a non-number length (for example "5") into binding.read. node::fs::Read requires args[3]->IsInt32() and aborts the process o...

Opengraph URL: https://github.com/nodejs/node/pull/65521

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f8663cb5-8691-c692-6de4-0c51bfb2a655
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7CE:1463F:2D783A:3B2EE7:6AED1BC9
html-safe-nonce0346988d005dd7fdbca5a5839e529eb5f2135dd17e4ee9fc5ff22ba8bbaac13d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0NFOjE0NjNGOjJENzgzQTozQjJFRTc6NkFFRDFCQzkiLCJ2aXNpdG9yX2lkIjoiNDQzNjU2NjQyMTAxMzMzOTA4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdd9f81497feeb847816f9a8c5193ca77139b075557f79939c7e2e3e92bee295f
hovercard-subject-tagpull_request:4350987036
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/65521/files
twitter:imagehttps://avatars.githubusercontent.com/u/236466140?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/236466140?s=400&v=4
og:image:altSummary fs.promises.FileHandle.read() forwarded a non-number length (for example "5") into binding.read. node::fs::Read requires args[3]->IsInt32() and aborts the process on a debug/CH...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65521/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65521%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65521%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65521/files
Reloadhttps://github.com/nodejs/node/pull/65521/files
Reloadhttps://github.com/nodejs/node/pull/65521/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
xia-chao:fs-coerce-filehandle-read-lengthhttps://github.com/xia-chao/node/tree/fs-coerce-filehandle-read-length
Conversation 9 https://github.com/nodejs/node/pull/65521
Commits 1 https://github.com/nodejs/node/pull/65521/commits
Checks 59 https://github.com/nodejs/node/pull/65521/checks
Files changed 2 https://github.com/nodejs/node/pull/65521/files
fs: coerce FileHandle.read length like fs.read https://github.com/nodejs/node/pull/65521/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/65521/files
dcefcbc fs: coerce FileHandle.read length like fs.read xia-chao Aug 24, 2026 https://github.com/nodejs/node/pull/65521/commits/dcefcbcce97021cac243f984d0b1b8da1245e268
Clear filters https://github.com/nodejs/node/pull/65521/files
Please reload this pagehttps://github.com/nodejs/node/pull/65521/files
Please reload this pagehttps://github.com/nodejs/node/pull/65521/files
promises.js https://github.com/nodejs/node/pull/65521/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
test-fs-promises-file-handle-read.js https://github.com/nodejs/node/pull/65521/files#diff-3d8f9f8a83e54edd6ab427f50690127f167980c02e6a27f08d72d055aa8a11a0
lib/internal/fs/promises.jshttps://github.com/nodejs/node/pull/65521/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
View file https://github.com/xia-chao/node/blob/dcefcbcce97021cac243f984d0b1b8da1245e268/lib/internal/fs/promises.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/65521/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/65521/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
https://github.com/nodejs/node/pull/65521/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
test/parallel/test-fs-promises-file-handle-read.jshttps://github.com/nodejs/node/pull/65521/files#diff-3d8f9f8a83e54edd6ab427f50690127f167980c02e6a27f08d72d055aa8a11a0
View file https://github.com/xia-chao/node/blob/dcefcbcce97021cac243f984d0b1b8da1245e268/test/parallel/test-fs-promises-file-handle-read.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/65521/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/65521/files#diff-3d8f9f8a83e54edd6ab427f50690127f167980c02e6a27f08d72d055aa8a11a0
https://github.com/nodejs/node/pull/65521/files#diff-3d8f9f8a83e54edd6ab427f50690127f167980c02e6a27f08d72d055aa8a11a0
https://github.com/nodejs/node/pull/65521/files#diff-3d8f9f8a83e54edd6ab427f50690127f167980c02e6a27f08d72d055aa8a11a0
Please reload this pagehttps://github.com/nodejs/node/pull/65521/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.