René's URL Explorer Experiment


Title: test: cover Readable.from() sync iterator errors by jakecastelli · Pull Request #65515 · nodejs/node · GitHub

Open Graph Title: test: cover Readable.from() sync iterator errors by jakecastelli · Pull Request #65515 · nodejs/node

X Title: test: cover Readable.from() sync iterator errors by jakecastelli · Pull Request #65515 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Adds regression coverage for Readable.from() when consuming synchronous iterators across null-value and promise-rejection paths which we don't have coverage atm.

X Description: Adds regression coverage for Readable.from() when consuming synchronous iterators across null-value and promise-rejection paths which we don't have coverage atm.

Opengraph URL: https://github.com/nodejs/node/pull/65515

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d801ee05-b407-8c28-342b-3a8e5a2500b0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD39A:32386D:56685:6F5AC:6AED0FE3
html-safe-nonce1c479ff365ea7c466a062480b058707a8d97139d1438858c92e14666e20fb9b6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzlBOjMyMzg2RDo1NjY4NTo2RjVBQzo2QUVEMEZFMyIsInZpc2l0b3JfaWQiOiIzNDA5MDM0MzYwNjA0Mzk3NTM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace54647dfb52ce56169aec5e7a27b02000d6e73bdc308d5db761c63db01b02f91
hovercard-subject-tagpull_request:4348531602
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65515/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/628b9ad25c10813f17f0a1ccae64c50bd14b96bfb06549cbedd818f817b4f58f/nodejs/node/pull/65515
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/628b9ad25c10813f17f0a1ccae64c50bd14b96bfb06549cbedd818f817b4f58f/nodejs/node/pull/65515
og:image:altAdds regression coverage for Readable.from() when consuming synchronous iterators across null-value and promise-rejection paths which we don't have coverage atm.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejakecastelli
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65515#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65515
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65515
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65515
Reloadhttps://github.com/nodejs/node/pull/65515
Reloadhttps://github.com/nodejs/node/pull/65515
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
jakecastelli:test/readable-from-sync-iterator-cleanuphttps://github.com/jakecastelli/node/tree/test/readable-from-sync-iterator-cleanup
Conversationhttps://github.com/nodejs/node/pull/65515
Commits1 (1)https://github.com/nodejs/node/pull/65515/commits
Checkshttps://github.com/nodejs/node/pull/65515/checks
Files changedhttps://github.com/nodejs/node/pull/65515/files
test: cover Readable.from() sync iterator errorshttps://github.com/nodejs/node/pull/65515#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
jakecastelli:test/readable-from-sync-iterator-cleanuphttps://github.com/jakecastelli/node/tree/test/readable-from-sync-iterator-cleanup
https://github.com/jakecastelli
jakecastellihttps://github.com/jakecastelli
Aug 24, 2026https://github.com/nodejs/node/pull/65515#issue-5234859741
Please reload this pagehttps://github.com/nodejs/node/pull/65515
Please reload this pagehttps://github.com/nodejs/node/pull/65515
https://github.com/jakecastelli
test: cover Readable.from() sync iterator errorshttps://github.com/nodejs/node/pull/65515/commits/e1ce5bd4ad1f44e6e740fd44c2d90434cba5cc34
e1ce5bdhttps://github.com/nodejs/node/pull/65515/commits/e1ce5bd4ad1f44e6e740fd44c2d90434cba5cc34
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Aug 24, 2026https://github.com/nodejs/node/pull/65515#event-29913025319
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 24, 2026https://github.com/nodejs/node/pull/65515#issuecomment-5396655904
Please reload this pagehttps://github.com/nodejs/node/pull/65515
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65515?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
82babeehttps://app.codecov.io/gh/nodejs/node/commit/82babee3e6bfcb57b542418b2c5efe87ef075f9c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e1ce5bdhttps://app.codecov.io/gh/nodejs/node/commit/e1ce5bd4ad1f44e6e740fd44c2d90434cba5cc34?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
see 67 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65515/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65515
https://github.com/jazelly
jazellyhttps://github.com/jazelly
Aug 25, 2026 https://github.com/nodejs/node/pull/65515#pullrequestreview-5025369648
View reviewed changes https://github.com/nodejs/node/pull/65515/files/e1ce5bd4ad1f44e6e740fd44c2d90434cba5cc34
jazellyhttps://github.com/jazelly
https://github.com/nodejs/node/pull/65515#pullrequestreview-5025369648
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65515
https://github.com/jakecastelli
jakecastellihttps://github.com/jakecastelli
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 26, 2026https://github.com/nodejs/node/pull/65515#event-30017909148
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 26, 2026https://github.com/nodejs/node/pull/65515#event-30018231296
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 26, 2026https://github.com/nodejs/node/pull/65515#issuecomment-5419915884
https://ci.nodejs.org/job/node-test-pull-request/76498/https://ci.nodejs.org/job/node-test-pull-request/76498/
Please reload this pagehttps://github.com/nodejs/node/pull/65515
https://github.com/jakecastelli
jakecastellihttps://github.com/jakecastelli
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 26, 2026https://github.com/nodejs/node/pull/65515#event-30041663501
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
Aug 26, 2026 https://github.com/nodejs/node/pull/65515#pullrequestreview-5031047498
View reviewed changes https://github.com/nodejs/node/pull/65515/files/e1ce5bd4ad1f44e6e740fd44c2d90434cba5cc34
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 26, 2026https://github.com/nodejs/node/pull/65515#event-30045992387
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
8813291https://github.com/nodejs/node/commit/8813291ec2a3d27afd16915e8e959802578b95a8
Aug 26, 2026https://github.com/nodejs/node/pull/65515#event-30047917263
Please reload this pagehttps://github.com/nodejs/node/pull/65515
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 26, 2026https://github.com/nodejs/node/pull/65515#issuecomment-5426526530
8813291https://github.com/nodejs/node/commit/8813291ec2a3d27afd16915e8e959802578b95a8
Please reload this pagehttps://github.com/nodejs/node/pull/65515
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 26, 2026https://github.com/nodejs/node/pull/65515#event-30047920453
aduh95https://github.com/aduh95
Aug 29, 2026 https://github.com/nodejs/node/pull/65515#ref-commit-e775071
https://github.com/jakecastelli
https://github.com/aduh95
test: cover Readable.from() sync iterator errorshttps://github.com/nodejs/node/commit/e77507174890257088615163d40a3e660885c7f0
e775071https://github.com/nodejs/node/commit/e77507174890257088615163d40a3e660885c7f0
#65515https://github.com/nodejs/node/pull/65515
aduh95https://github.com/aduh95
Sep 3, 2026 https://github.com/nodejs/node/pull/65515#ref-commit-566f819
https://github.com/jakecastelli
https://github.com/aduh95
test: cover Readable.from() sync iterator errorshttps://github.com/nodejs/node/commit/566f819f8bfd9a30992edf55c818aa9531010fbf
566f819https://github.com/nodejs/node/commit/566f819f8bfd9a30992edf55c818aa9531010fbf
#65515https://github.com/nodejs/node/pull/65515
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65515#ref-pullrequest-5376777990
Version 26.9.0 (Current) #65881 https://github.com/nodejs/node/pull/65881
aduh95https://github.com/aduh95
Sep 15, 2026 https://github.com/nodejs/node/pull/65515#ref-commit-2342b2b
https://github.com/jakecastelli
https://github.com/aduh95
test: cover Readable.from() sync iterator errorshttps://github.com/nodejs/node/commit/2342b2bf30accbbd7530a1bab98ecf7d7a44fa95
2342b2bhttps://github.com/nodejs/node/commit/2342b2bf30accbbd7530a1bab98ecf7d7a44fa95
#65515https://github.com/nodejs/node/pull/65515
aduh95https://github.com/aduh95
Sep 19, 2026 https://github.com/nodejs/node/pull/65515#ref-commit-7b5896c
https://github.com/jakecastelli
https://github.com/aduh95
test: cover Readable.from() sync iterator errorshttps://github.com/nodejs/node/commit/7b5896c136bc0fd9ea99acaaa34749416cd98d7c
7b5896chttps://github.com/nodejs/node/commit/7b5896c136bc0fd9ea99acaaa34749416cd98d7c
#65515https://github.com/nodejs/node/pull/65515
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 11, 2026 https://github.com/nodejs/node/pull/65515#ref-pullrequest-5805806867
2026-10-14, Version 24.22.0 'Krypton' (LTS) #66667 https://github.com/nodejs/node/pull/66667
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65515
https://github.com/daeyeon
daeyeon https://github.com/daeyeon
https://github.com/nodejs/node/pull/65515/files/e1ce5bd4ad1f44e6e740fd44c2d90434cba5cc34
https://github.com/jazelly
jazelly https://github.com/jazelly
https://github.com/nodejs/node/pull/65515/files/e1ce5bd4ad1f44e6e740fd44c2d90434cba5cc34
Please reload this pagehttps://github.com/nodejs/node/pull/65515
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/65515
https://github.com/jakecastelli
https://github.com/nodejs-github-bot
https://github.com/daeyeon
https://github.com/jazelly
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.